2018-07-25 09:30:33 +00:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2018-03-06 19:09:01 +00:00
|
|
|
# An InternalId is a strictly monotone sequence of integers
|
2018-03-12 15:51:38 +00:00
|
|
|
# generated for a given scope and usage.
|
2018-03-06 19:09:01 +00:00
|
|
|
#
|
2018-08-01 09:03:14 +00:00
|
|
|
# The monotone sequence may be broken if an ID is explicitly provided
|
|
|
|
# to `.track_greatest_and_save!` or `#track_greatest`.
|
|
|
|
#
|
2018-03-12 15:51:38 +00:00
|
|
|
# For example, issues use their project to scope internal ids:
|
|
|
|
# In that sense, scope is "project" and usage is "issues".
|
|
|
|
# Generated internal ids for an issue are unique per project.
|
|
|
|
#
|
|
|
|
# See InternalId#usage enum for available usages.
|
|
|
|
#
|
|
|
|
# In order to leverage InternalId for other usages, the idea is to
|
|
|
|
# * Add `usage` value to enum
|
|
|
|
# * (Optionally) add columns to `internal_ids` if needed for scope.
|
2019-03-28 13:17:42 +00:00
|
|
|
class InternalId < ApplicationRecord
|
2019-09-20 15:06:12 +00:00
|
|
|
include Gitlab::Utils::StrongMemoize
|
|
|
|
|
2018-03-06 19:09:01 +00:00
|
|
|
belongs_to :project
|
2018-04-20 14:00:15 +00:00
|
|
|
belongs_to :namespace
|
2018-03-06 19:09:01 +00:00
|
|
|
|
2020-03-05 18:08:19 +00:00
|
|
|
enum usage: ::InternalIdEnums.usage_resources
|
2018-03-06 19:09:01 +00:00
|
|
|
|
|
|
|
validates :usage, presence: true
|
|
|
|
|
|
|
|
# Increments #last_value and saves the record
|
|
|
|
#
|
2018-03-12 15:51:38 +00:00
|
|
|
# The operation locks the record and gathers a `ROW SHARE` lock (in PostgreSQL).
|
|
|
|
# As such, the increment is atomic and safe to be called concurrently.
|
2018-05-28 10:44:07 +00:00
|
|
|
def increment_and_save!
|
2018-08-01 09:03:14 +00:00
|
|
|
update_and_save { self.last_value = (last_value || 0) + 1 }
|
|
|
|
end
|
|
|
|
|
|
|
|
# Increments #last_value with new_value if it is greater than the current,
|
|
|
|
# and saves the record
|
|
|
|
#
|
|
|
|
# The operation locks the record and gathers a `ROW SHARE` lock (in PostgreSQL).
|
|
|
|
# As such, the increment is atomic and safe to be called concurrently.
|
|
|
|
def track_greatest_and_save!(new_value)
|
|
|
|
update_and_save { self.last_value = [last_value || 0, new_value].max }
|
|
|
|
end
|
|
|
|
|
|
|
|
private
|
|
|
|
|
|
|
|
def update_and_save(&block)
|
2018-03-06 19:09:01 +00:00
|
|
|
lock!
|
2018-08-01 09:03:14 +00:00
|
|
|
yield
|
2019-09-20 15:06:12 +00:00
|
|
|
update_and_save_counter.increment(usage: usage, changed: last_value_changed?)
|
2018-03-06 19:09:01 +00:00
|
|
|
save!
|
|
|
|
last_value
|
|
|
|
end
|
|
|
|
|
2019-10-15 21:06:25 +00:00
|
|
|
# Instrumentation to track for-update locks
|
2019-09-20 15:06:12 +00:00
|
|
|
def update_and_save_counter
|
|
|
|
strong_memoize(:update_and_save_counter) do
|
|
|
|
Gitlab::Metrics.counter(:gitlab_internal_id_for_update_lock, 'Number of ROW SHARE (FOR UPDATE) locks on individual records from internal_ids')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-03-06 19:09:01 +00:00
|
|
|
class << self
|
2018-08-01 09:03:14 +00:00
|
|
|
def track_greatest(subject, scope, usage, new_value, init)
|
2019-03-22 15:51:15 +00:00
|
|
|
InternalIdGenerator.new(subject, scope, usage)
|
|
|
|
.track_greatest(init, new_value)
|
2018-08-01 09:03:14 +00:00
|
|
|
end
|
|
|
|
|
2018-03-12 15:51:38 +00:00
|
|
|
def generate_next(subject, scope, usage, init)
|
2019-03-22 15:51:15 +00:00
|
|
|
InternalIdGenerator.new(subject, scope, usage)
|
|
|
|
.generate(init)
|
|
|
|
end
|
|
|
|
|
|
|
|
def reset(subject, scope, usage, value)
|
|
|
|
InternalIdGenerator.new(subject, scope, usage)
|
|
|
|
.reset(value)
|
2018-03-12 15:51:38 +00:00
|
|
|
end
|
2018-03-13 15:53:55 +00:00
|
|
|
|
2019-01-02 15:50:37 +00:00
|
|
|
# Flushing records is generally safe in a sense that those
|
|
|
|
# records are going to be re-created when needed.
|
|
|
|
#
|
|
|
|
# A filter condition has to be provided to not accidentally flush
|
|
|
|
# records for all projects.
|
|
|
|
def flush_records!(filter)
|
|
|
|
raise ArgumentError, "filter cannot be empty" if filter.blank?
|
|
|
|
|
|
|
|
where(filter).delete_all
|
|
|
|
end
|
2018-03-12 15:51:38 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
class InternalIdGenerator
|
|
|
|
# Generate next internal id for a given scope and usage.
|
2018-03-06 19:09:01 +00:00
|
|
|
#
|
|
|
|
# For currently supported usages, see #usage enum.
|
|
|
|
#
|
|
|
|
# The method implements a locking scheme that has the following properties:
|
2018-03-12 15:51:38 +00:00
|
|
|
# 1) Generated sequence of internal ids is unique per (scope and usage)
|
2018-03-06 19:09:01 +00:00
|
|
|
# 2) The method is thread-safe and may be used in concurrent threads/processes.
|
|
|
|
# 3) The generated sequence is gapless.
|
|
|
|
# 4) In the absence of a record in the internal_ids table, one will be created
|
|
|
|
# and last_value will be calculated on the fly.
|
2018-03-12 15:51:38 +00:00
|
|
|
#
|
|
|
|
# subject: The instance we're generating an internal id for. Gets passed to init if called.
|
|
|
|
# scope: Attributes that define the scope for id generation.
|
|
|
|
# usage: Symbol to define the usage of the internal id, see InternalId.usages
|
2019-03-22 15:51:15 +00:00
|
|
|
attr_reader :subject, :scope, :scope_attrs, :usage
|
2018-03-14 12:42:03 +00:00
|
|
|
|
2019-03-22 15:51:15 +00:00
|
|
|
def initialize(subject, scope, usage)
|
2018-03-12 15:51:38 +00:00
|
|
|
@subject = subject
|
|
|
|
@scope = scope
|
|
|
|
@usage = usage
|
2018-03-12 14:38:56 +00:00
|
|
|
|
2018-03-16 12:34:08 +00:00
|
|
|
raise ArgumentError, 'Scope is not well-defined, need at least one column for scope (given: 0)' if scope.empty?
|
2018-03-12 14:38:56 +00:00
|
|
|
|
2018-03-16 12:34:08 +00:00
|
|
|
unless InternalId.usages.has_key?(usage.to_s)
|
2018-03-14 12:42:03 +00:00
|
|
|
raise ArgumentError, "Usage '#{usage}' is unknown. Supported values are #{InternalId.usages.keys} from InternalId.usages"
|
2018-03-12 14:38:56 +00:00
|
|
|
end
|
2018-03-12 15:51:38 +00:00
|
|
|
end
|
2018-03-06 19:09:01 +00:00
|
|
|
|
2018-03-12 15:51:38 +00:00
|
|
|
# Generates next internal id and returns it
|
2019-03-22 15:51:15 +00:00
|
|
|
# init: Block that gets called to initialize InternalId record if not present
|
|
|
|
# Make sure to not throw exceptions in the absence of records (if this is expected).
|
|
|
|
def generate(init)
|
2019-01-02 15:05:40 +00:00
|
|
|
subject.transaction do
|
2018-03-06 19:09:01 +00:00
|
|
|
# Create a record in internal_ids if one does not yet exist
|
2018-03-16 12:34:08 +00:00
|
|
|
# and increment its last value
|
2018-03-12 15:51:38 +00:00
|
|
|
#
|
|
|
|
# Note this will acquire a ROW SHARE lock on the InternalId record
|
2019-03-22 15:51:15 +00:00
|
|
|
(lookup || create_record(init)).increment_and_save!
|
2018-03-06 19:09:01 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-03-22 15:51:15 +00:00
|
|
|
# Reset tries to rewind to `value-1`. This will only succeed,
|
|
|
|
# if `value` stored in database is equal to `last_value`.
|
|
|
|
# value: The expected last_value to decrement
|
|
|
|
def reset(value)
|
|
|
|
return false unless value
|
|
|
|
|
|
|
|
updated =
|
|
|
|
InternalId
|
|
|
|
.where(**scope, usage: usage_value)
|
|
|
|
.where(last_value: value)
|
|
|
|
.update_all('last_value = last_value - 1')
|
|
|
|
|
|
|
|
updated > 0
|
|
|
|
end
|
|
|
|
|
2018-08-01 09:03:14 +00:00
|
|
|
# Create a record in internal_ids if one does not yet exist
|
|
|
|
# and set its new_value if it is higher than the current last_value
|
|
|
|
#
|
|
|
|
# Note this will acquire a ROW SHARE lock on the InternalId record
|
2019-03-22 15:51:15 +00:00
|
|
|
def track_greatest(init, new_value)
|
2019-01-02 15:05:40 +00:00
|
|
|
subject.transaction do
|
2019-03-22 15:51:15 +00:00
|
|
|
(lookup || create_record(init)).track_greatest_and_save!(new_value)
|
2018-08-01 09:03:14 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-03-06 19:09:01 +00:00
|
|
|
private
|
|
|
|
|
|
|
|
# Retrieve InternalId record for (project, usage) combination, if it exists
|
2018-03-12 15:51:38 +00:00
|
|
|
def lookup
|
|
|
|
InternalId.find_by(**scope, usage: usage_value)
|
|
|
|
end
|
|
|
|
|
|
|
|
def usage_value
|
|
|
|
@usage_value ||= InternalId.usages[usage.to_s]
|
2018-03-06 19:09:01 +00:00
|
|
|
end
|
|
|
|
|
2018-03-12 15:51:38 +00:00
|
|
|
# Create InternalId record for (scope, usage) combination, if it doesn't exist
|
2018-03-06 19:09:01 +00:00
|
|
|
#
|
2018-03-12 15:51:38 +00:00
|
|
|
# We blindly insert without synchronization. If another process
|
2018-03-06 19:09:01 +00:00
|
|
|
# was faster in doing this, we'll realize once we hit the unique key constraint
|
|
|
|
# violation. We can safely roll-back the nested transaction and perform
|
|
|
|
# a lookup instead to retrieve the record.
|
2019-03-22 15:51:15 +00:00
|
|
|
def create_record(init)
|
2019-01-02 15:05:40 +00:00
|
|
|
subject.transaction(requires_new: true) do
|
2018-03-12 15:51:38 +00:00
|
|
|
InternalId.create!(
|
|
|
|
**scope,
|
|
|
|
usage: usage_value,
|
2018-05-28 10:44:07 +00:00
|
|
|
last_value: init.call(subject) || 0
|
2018-03-12 15:51:38 +00:00
|
|
|
)
|
2018-03-06 19:09:01 +00:00
|
|
|
end
|
2018-03-12 15:51:38 +00:00
|
|
|
rescue ActiveRecord::RecordNotUnique
|
|
|
|
lookup
|
2018-03-06 19:09:01 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|