gitlab-org--gitlab-foss/spec/controllers/projects/pipeline_schedules_controller_spec.rb

460 lines
15 KiB
Ruby
Raw Normal View History

require 'spec_helper'
describe Projects::PipelineSchedulesController do
2017-06-26 05:25:08 -04:00
include AccessMatchersForController
set(:project) { create(:project, :public, :repository) }
set(:pipeline_schedule) { create(:ci_pipeline_schedule, project: project) }
describe 'GET #index' do
render_views
let(:scope) { nil }
let!(:inactive_pipeline_schedule) do
create(:ci_pipeline_schedule, :inactive, project: project)
end
it 'renders the index view' do
visit_pipelines_schedules
expect(response).to have_gitlab_http_status(:ok)
expect(response).to render_template(:index)
end
2017-06-29 13:22:05 -04:00
it 'avoids N + 1 queries' do
control_count = ActiveRecord::QueryRecorder.new { visit_pipelines_schedules }.count
create_list(:ci_pipeline_schedule, 2, project: project)
expect { visit_pipelines_schedules }.not_to exceed_query_limit(control_count)
end
context 'when the scope is set to active' do
let(:scope) { 'active' }
before do
visit_pipelines_schedules
end
it 'only shows active pipeline schedules' do
expect(response).to have_gitlab_http_status(:ok)
expect(assigns(:schedules)).to include(pipeline_schedule)
expect(assigns(:schedules)).not_to include(inactive_pipeline_schedule)
end
end
def visit_pipelines_schedules
get :index, namespace_id: project.namespace.to_param, project_id: project, scope: scope
end
end
describe 'GET #new' do
2017-07-03 12:51:21 -04:00
set(:user) { create(:user) }
before do
2017-07-03 12:51:21 -04:00
project.add_developer(user)
sign_in(user)
end
it 'initializes a pipeline schedule model' do
get :new, namespace_id: project.namespace.to_param, project_id: project
expect(response).to have_gitlab_http_status(:ok)
expect(assigns(:schedule)).to be_a_new(Ci::PipelineSchedule)
end
end
describe 'POST #create' do
2017-06-26 05:25:08 -04:00
describe 'functionality' do
2017-07-03 12:51:21 -04:00
set(:user) { create(:user) }
2017-06-26 05:25:08 -04:00
before do
2017-07-03 12:51:21 -04:00
project.add_developer(user)
sign_in(user)
end
2017-06-26 05:25:08 -04:00
let(:basic_param) do
2017-07-04 04:45:07 -04:00
attributes_for(:ci_pipeline_schedule)
end
2017-06-26 05:25:08 -04:00
context 'when variables_attributes has one variable' do
let(:schedule) do
basic_param.merge({
2017-06-28 11:03:56 -04:00
variables_attributes: [{ key: 'AAA', value: 'AAA123' }]
2017-06-26 05:25:08 -04:00
})
end
2017-06-26 05:25:08 -04:00
it 'creates a new schedule' do
2017-06-28 11:03:56 -04:00
expect { go }
2017-06-26 05:25:08 -04:00
.to change { Ci::PipelineSchedule.count }.by(1)
.and change { Ci::PipelineScheduleVariable.count }.by(1)
expect(response).to have_gitlab_http_status(:found)
2017-07-04 04:45:07 -04:00
Ci::PipelineScheduleVariable.last.tap do |v|
expect(v.key).to eq("AAA")
expect(v.value).to eq("AAA123")
end
2017-06-26 05:25:08 -04:00
end
end
context 'when variables_attributes has two variables and duplicated' do
let(:schedule) do
basic_param.merge({
variables_attributes: [{ key: 'AAA', value: 'AAA123' }, { key: 'AAA', value: 'BBB123' }]
})
end
it 'returns an error that the keys of variable are duplicated' do
expect { go }
.to change { Ci::PipelineSchedule.count }.by(0)
.and change { Ci::PipelineScheduleVariable.count }.by(0)
2017-07-05 11:45:26 -04:00
expect(assigns(:schedule).errors['variables']).not_to be_empty
end
end
end
2017-06-26 05:25:08 -04:00
describe 'security' do
2017-07-04 04:45:07 -04:00
let(:schedule) { attributes_for(:ci_pipeline_schedule) }
2017-06-29 13:22:05 -04:00
2017-06-28 11:03:56 -04:00
it { expect { go }.to be_allowed_for(:admin) }
it { expect { go }.to be_allowed_for(:owner).of(project) }
it { expect { go }.to be_allowed_for(:master).of(project) }
it { expect { go }.to be_allowed_for(:developer).of(project) }
it { expect { go }.to be_denied_for(:reporter).of(project) }
it { expect { go }.to be_denied_for(:guest).of(project) }
it { expect { go }.to be_denied_for(:user) }
it { expect { go }.to be_denied_for(:external) }
it { expect { go }.to be_denied_for(:visitor) }
2017-06-29 13:22:05 -04:00
end
2017-06-28 11:03:56 -04:00
2017-06-29 13:22:05 -04:00
def go
post :create, namespace_id: project.namespace.to_param, project_id: project, schedule: schedule
2017-06-26 05:25:08 -04:00
end
end
2017-06-26 05:25:08 -04:00
2017-06-26 05:25:08 -04:00
describe 'PUT #update' do
describe 'functionality' do
2017-07-03 12:51:21 -04:00
set(:user) { create(:user) }
2017-06-26 05:25:08 -04:00
let!(:pipeline_schedule) { create(:ci_pipeline_schedule, project: project, owner: user) }
2017-06-26 05:25:08 -04:00
2017-06-26 05:25:08 -04:00
before do
project.add_developer(user)
sign_in(user)
end
2017-06-26 05:25:08 -04:00
2017-06-26 05:25:08 -04:00
context 'when a pipeline schedule has no variables' do
let(:basic_param) do
2017-07-04 04:45:07 -04:00
{ description: 'updated_desc', cron: '0 1 * * *', cron_timezone: 'UTC', ref: 'patch-x', active: true }
2017-06-26 05:25:08 -04:00
end
context 'when params include one variable' do
let(:schedule) do
basic_param.merge({
2017-06-28 11:03:56 -04:00
variables_attributes: [{ key: 'AAA', value: 'AAA123' }]
})
end
2017-06-26 05:25:08 -04:00
it 'inserts new variable to the pipeline schedule' do
2017-06-28 11:03:56 -04:00
expect { go }.to change { Ci::PipelineScheduleVariable.count }.by(1)
2017-06-26 05:25:08 -04:00
pipeline_schedule.reload
expect(response).to have_gitlab_http_status(:found)
expect(pipeline_schedule.variables.last.key).to eq('AAA')
2017-06-26 05:25:08 -04:00
expect(pipeline_schedule.variables.last.value).to eq('AAA123')
end
end
context 'when params include two duplicated variables' do
let(:schedule) do
basic_param.merge({
variables_attributes: [{ key: 'AAA', value: 'AAA123' }, { key: 'AAA', value: 'BBB123' }]
})
end
it 'returns an error that variables are duplciated' do
go
2017-07-05 11:45:26 -04:00
expect(assigns(:schedule).errors['variables']).not_to be_empty
end
end
end
2017-06-26 05:25:08 -04:00
context 'when a pipeline schedule has one variable' do
let(:basic_param) do
2017-07-04 04:45:07 -04:00
{ description: 'updated_desc', cron: '0 1 * * *', cron_timezone: 'UTC', ref: 'patch-x', active: true }
2017-06-26 05:25:08 -04:00
end
2017-06-26 05:25:08 -04:00
2017-06-26 05:25:08 -04:00
let!(:pipeline_schedule_variable) do
2017-06-29 13:22:05 -04:00
create(:ci_pipeline_schedule_variable,
key: 'CCC', pipeline_schedule: pipeline_schedule)
2017-06-26 05:25:08 -04:00
end
2017-06-26 05:25:08 -04:00
context 'when adds a new variable' do
let(:schedule) do
basic_param.merge({
variables_attributes: [{ key: 'AAA', value: 'AAA123' }]
})
end
it 'adds the new variable' do
expect { go }.to change { Ci::PipelineScheduleVariable.count }.by(1)
pipeline_schedule.reload
expect(pipeline_schedule.variables.last.key).to eq('AAA')
end
end
context 'when adds a new duplicated variable' do
let(:schedule) do
basic_param.merge({
variables_attributes: [{ key: 'CCC', value: 'AAA123' }]
})
end
it 'returns an error' do
expect { go }.not_to change { Ci::PipelineScheduleVariable.count }
pipeline_schedule.reload
expect(assigns(:schedule).errors['variables']).not_to be_empty
2017-06-26 05:25:08 -04:00
end
end
2017-06-26 05:25:08 -04:00
context 'when updates a variable' do
let(:schedule) do
basic_param.merge({
variables_attributes: [{ id: pipeline_schedule_variable.id, value: 'new_value' }]
})
end
2017-06-26 05:25:08 -04:00
it 'updates the variable' do
expect { go }.not_to change { Ci::PipelineScheduleVariable.count }
2017-06-26 05:25:08 -04:00
pipeline_schedule_variable.reload
expect(pipeline_schedule_variable.value).to eq('new_value')
2017-06-26 05:25:08 -04:00
end
end
2017-06-26 05:25:08 -04:00
context 'when deletes a variable' do
let(:schedule) do
basic_param.merge({
variables_attributes: [{ id: pipeline_schedule_variable.id, _destroy: true }]
})
end
2017-06-26 05:25:08 -04:00
it 'delete the existsed variable' do
expect { go }.to change { Ci::PipelineScheduleVariable.count }.by(-1)
end
end
context 'when deletes and creates a same key simultaneously' do
let(:schedule) do
basic_param.merge({
variables_attributes: [{ id: pipeline_schedule_variable.id, _destroy: true },
{ key: 'CCC', value: 'CCC123' }]
})
end
it 'updates the variable' do
expect { go }.not_to change { Ci::PipelineScheduleVariable.count }
pipeline_schedule.reload
expect(pipeline_schedule.variables.last.key).to eq('CCC')
expect(pipeline_schedule.variables.last.value).to eq('CCC123')
2017-06-26 05:25:08 -04:00
end
end
end
end
2017-06-26 05:25:08 -04:00
2017-06-26 05:25:08 -04:00
describe 'security' do
2017-06-29 13:22:05 -04:00
let(:schedule) { { description: 'updated_desc' } }
it { expect { go }.to be_allowed_for(:admin) }
it { expect { go }.to be_allowed_for(:owner).of(project) }
it { expect { go }.to be_allowed_for(:master).of(project) }
2017-07-04 04:45:07 -04:00
it { expect { go }.to be_allowed_for(:developer).of(project).own(pipeline_schedule) }
2017-06-29 13:22:05 -04:00
it { expect { go }.to be_denied_for(:reporter).of(project) }
it { expect { go }.to be_denied_for(:guest).of(project) }
it { expect { go }.to be_denied_for(:user) }
it { expect { go }.to be_denied_for(:external) }
it { expect { go }.to be_denied_for(:visitor) }
2017-06-26 05:25:08 -04:00
context 'when a developer created a pipeline schedule' do
let(:developer_1) { create(:user) }
let!(:pipeline_schedule) { create(:ci_pipeline_schedule, project: project, owner: developer_1) }
before do
project.add_developer(developer_1)
end
2017-06-26 05:25:08 -04:00
2017-06-29 13:22:05 -04:00
it { expect { go }.to be_allowed_for(developer_1) }
it { expect { go }.to be_denied_for(:developer).of(project) }
it { expect { go }.to be_allowed_for(:master).of(project) }
end
2017-06-26 05:25:08 -04:00
2017-06-26 05:25:08 -04:00
context 'when a master created a pipeline schedule' do
let(:master_1) { create(:user) }
let!(:pipeline_schedule) { create(:ci_pipeline_schedule, project: project, owner: master_1) }
before do
project.add_master(master_1)
end
2017-06-29 13:22:05 -04:00
it { expect { go }.to be_allowed_for(master_1) }
it { expect { go }.to be_allowed_for(:master).of(project) }
it { expect { go }.to be_denied_for(:developer).of(project) }
end
end
2017-06-28 11:03:56 -04:00
def go
put :update, namespace_id: project.namespace.to_param,
project_id: project, id: pipeline_schedule,
2017-06-29 13:22:05 -04:00
schedule: schedule
2017-06-28 11:03:56 -04:00
end
end
2017-06-29 13:22:05 -04:00
describe 'GET #edit' do
describe 'functionality' do
let(:user) { create(:user) }
2017-06-26 05:25:08 -04:00
2017-06-29 13:22:05 -04:00
before do
project.add_master(user)
sign_in(user)
end
it 'loads the pipeline schedule' do
get :edit, namespace_id: project.namespace.to_param, project_id: project, id: pipeline_schedule.id
expect(response).to have_gitlab_http_status(:ok)
2017-06-29 13:22:05 -04:00
expect(assigns(:schedule)).to eq(pipeline_schedule)
end
end
2017-06-26 05:25:08 -04:00
2017-06-29 13:22:05 -04:00
describe 'security' do
it { expect { go }.to be_allowed_for(:admin) }
it { expect { go }.to be_allowed_for(:owner).of(project) }
it { expect { go }.to be_allowed_for(:master).of(project) }
2017-07-04 04:45:07 -04:00
it { expect { go }.to be_allowed_for(:developer).of(project).own(pipeline_schedule) }
2017-06-29 13:22:05 -04:00
it { expect { go }.to be_denied_for(:reporter).of(project) }
it { expect { go }.to be_denied_for(:guest).of(project) }
it { expect { go }.to be_denied_for(:user) }
it { expect { go }.to be_denied_for(:external) }
it { expect { go }.to be_denied_for(:visitor) }
2017-06-26 05:25:08 -04:00
end
2017-06-29 13:22:05 -04:00
def go
2017-06-26 05:25:08 -04:00
get :edit, namespace_id: project.namespace.to_param, project_id: project, id: pipeline_schedule.id
2017-06-29 13:22:05 -04:00
end
end
2017-06-26 05:25:08 -04:00
2017-06-29 13:22:05 -04:00
describe 'GET #take_ownership' do
describe 'security' do
it { expect { go }.to be_allowed_for(:admin) }
it { expect { go }.to be_allowed_for(:owner).of(project) }
it { expect { go }.to be_allowed_for(:master).of(project) }
2017-07-04 04:45:07 -04:00
it { expect { go }.to be_allowed_for(:developer).of(project).own(pipeline_schedule) }
2017-06-29 13:22:05 -04:00
it { expect { go }.to be_denied_for(:reporter).of(project) }
it { expect { go }.to be_denied_for(:guest).of(project) }
it { expect { go }.to be_denied_for(:user) }
it { expect { go }.to be_denied_for(:external) }
it { expect { go }.to be_denied_for(:visitor) }
end
def go
post :take_ownership, namespace_id: project.namespace.to_param, project_id: project, id: pipeline_schedule.id
2017-06-26 05:25:08 -04:00
end
end
describe 'POST #play', :clean_gitlab_redis_cache do
set(:user) { create(:user) }
let(:ref) { 'master' }
before do
project.add_developer(user)
sign_in(user)
end
context 'when an anonymous user makes the request' do
before do
sign_out(user)
end
it 'does not allow pipeline to be executed' do
expect(RunPipelineScheduleWorker).not_to receive(:perform_async)
post :play, namespace_id: project.namespace.to_param, project_id: project, id: pipeline_schedule.id
expect(response).to have_gitlab_http_status(404)
end
end
context 'when a developer makes the request' do
it 'executes a new pipeline' do
expect(RunPipelineScheduleWorker).to receive(:perform_async).with(pipeline_schedule.id, user.id).and_return('job-123')
post :play, namespace_id: project.namespace.to_param, project_id: project, id: pipeline_schedule.id
expect(flash[:notice]).to start_with 'Successfully scheduled a pipeline to run'
expect(response).to have_gitlab_http_status(302)
end
it 'prevents users from scheduling the same pipeline repeatedly' do
2.times do
post :play, namespace_id: project.namespace.to_param, project_id: project, id: pipeline_schedule.id
end
expect(flash.to_a.size).to eq(2)
expect(flash[:alert]).to eq 'You cannot play this scheduled pipeline at the moment. Please wait a minute.'
expect(response).to have_gitlab_http_status(302)
end
end
context 'when a developer attempts to schedule a protected ref' do
it 'does not allow pipeline to be executed' do
create(:protected_branch, project: project, name: ref)
protected_schedule = create(:ci_pipeline_schedule, project: project, ref: ref)
expect(RunPipelineScheduleWorker).not_to receive(:perform_async)
post :play, namespace_id: project.namespace.to_param, project_id: project, id: protected_schedule.id
expect(response).to have_gitlab_http_status(404)
end
end
end
describe 'DELETE #destroy' do
set(:user) { create(:user) }
2017-06-26 05:25:08 -04:00
context 'when a developer makes the request' do
before do
project.add_developer(user)
sign_in(user)
2017-06-26 05:25:08 -04:00
delete :destroy, namespace_id: project.namespace.to_param, project_id: project, id: pipeline_schedule.id
end
2017-06-28 11:03:56 -04:00
it 'does not delete the pipeline schedule' do
expect(response).to have_gitlab_http_status(:not_found)
end
2017-06-28 11:03:56 -04:00
end
2017-06-26 05:25:08 -04:00
context 'when a master makes the request' do
2017-06-29 13:22:05 -04:00
before do
project.add_master(user)
sign_in(user)
end
it 'destroys the pipeline schedule' do
expect do
delete :destroy, namespace_id: project.namespace.to_param, project_id: project, id: pipeline_schedule.id
end.to change { project.pipeline_schedules.count }.by(-1)
2017-06-29 13:22:05 -04:00
expect(response).to have_gitlab_http_status(302)
2017-06-29 13:22:05 -04:00
end
end
end
end