2011-10-08 17:36:38 -04:00
|
|
|
require 'spec_helper'
|
|
|
|
|
2017-08-02 12:43:51 -04:00
|
|
|
describe Key, :mailer do
|
2011-10-08 17:36:38 -04:00
|
|
|
describe "Associations" do
|
2015-02-12 13:17:35 -05:00
|
|
|
it { is_expected.to belong_to(:user) }
|
2011-10-08 17:36:38 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
describe "Validation" do
|
2015-02-12 13:17:35 -05:00
|
|
|
it { is_expected.to validate_presence_of(:title) }
|
2016-12-02 07:54:57 -05:00
|
|
|
it { is_expected.to validate_length_of(:title).is_at_most(255) }
|
|
|
|
|
2015-02-12 13:17:35 -05:00
|
|
|
it { is_expected.to validate_presence_of(:key) }
|
2016-12-02 07:54:57 -05:00
|
|
|
it { is_expected.to validate_length_of(:key).is_at_most(5000) }
|
|
|
|
it { is_expected.to allow_value('ssh-foo').for(:key) }
|
|
|
|
it { is_expected.to allow_value('ecdsa-foo').for(:key) }
|
|
|
|
it { is_expected.not_to allow_value('foo-bar').for(:key) }
|
2011-10-08 17:36:38 -04:00
|
|
|
end
|
|
|
|
|
2011-10-26 09:46:25 -04:00
|
|
|
describe "Methods" do
|
2016-08-02 01:56:23 -04:00
|
|
|
let(:user) { create(:user) }
|
2015-02-12 13:17:35 -05:00
|
|
|
it { is_expected.to respond_to :projects }
|
2015-06-19 13:17:34 -04:00
|
|
|
it { is_expected.to respond_to :publishable_key }
|
|
|
|
|
|
|
|
describe "#publishable_keys" do
|
2016-08-02 01:56:23 -04:00
|
|
|
it 'replaces SSH key comment with simple identifier of username + hostname' do
|
2016-11-18 07:17:10 -05:00
|
|
|
expect(build(:key, user: user).publishable_key).to include("#{user.name} (#{Gitlab.config.gitlab.host})")
|
2015-06-19 13:17:34 -04:00
|
|
|
end
|
|
|
|
end
|
2016-12-21 09:59:54 -05:00
|
|
|
|
|
|
|
describe "#update_last_used_at" do
|
2017-01-20 05:42:46 -05:00
|
|
|
let(:key) { create(:key) }
|
2016-12-21 09:59:54 -05:00
|
|
|
|
2017-01-20 05:42:46 -05:00
|
|
|
context 'when key was not updated during the last day' do
|
|
|
|
before do
|
2017-06-21 09:48:12 -04:00
|
|
|
allow_any_instance_of(Gitlab::ExclusiveLease).to receive(:try_obtain)
|
|
|
|
.and_return('000000')
|
2017-01-20 05:42:46 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'enqueues a UseKeyWorker job' do
|
|
|
|
expect(UseKeyWorker).to receive(:perform_async).with(key.id)
|
|
|
|
key.update_last_used_at
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when key was updated during the last day' do
|
|
|
|
before do
|
2017-06-21 09:48:12 -04:00
|
|
|
allow_any_instance_of(Gitlab::ExclusiveLease).to receive(:try_obtain)
|
|
|
|
.and_return(false)
|
2017-01-20 05:42:46 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not enqueue a UseKeyWorker job' do
|
|
|
|
expect(UseKeyWorker).not_to receive(:perform_async)
|
|
|
|
key.update_last_used_at
|
|
|
|
end
|
2016-12-21 09:59:54 -05:00
|
|
|
end
|
|
|
|
end
|
2011-10-08 17:36:38 -04:00
|
|
|
end
|
|
|
|
|
2016-06-16 06:53:32 -04:00
|
|
|
context "validation of uniqueness (based on fingerprint uniqueness)" do
|
2013-05-06 08:09:26 -04:00
|
|
|
let(:user) { create(:user) }
|
2012-03-01 10:00:14 -05:00
|
|
|
|
2013-05-06 08:09:26 -04:00
|
|
|
it "accepts the key once" do
|
2015-02-12 13:17:35 -05:00
|
|
|
expect(build(:key, user: user)).to be_valid
|
2012-03-01 10:00:14 -05:00
|
|
|
end
|
|
|
|
|
2013-07-17 09:16:34 -04:00
|
|
|
it "does not accept the exact same key twice" do
|
2017-05-31 09:43:19 -04:00
|
|
|
first_key = create(:key, user: user)
|
|
|
|
|
|
|
|
expect(build(:key, user: user, key: first_key.key)).not_to be_valid
|
2012-03-01 10:00:14 -05:00
|
|
|
end
|
2013-07-17 09:16:34 -04:00
|
|
|
|
|
|
|
it "does not accept a duplicate key with a different comment" do
|
2017-05-31 09:43:19 -04:00
|
|
|
first_key = create(:key, user: user)
|
|
|
|
duplicate = build(:key, user: user, key: first_key.key)
|
2013-07-17 09:16:34 -04:00
|
|
|
duplicate.key << ' extra comment'
|
2017-05-31 09:43:19 -04:00
|
|
|
|
2015-02-12 13:17:35 -05:00
|
|
|
expect(duplicate).not_to be_valid
|
2013-07-17 09:16:34 -04:00
|
|
|
end
|
2012-03-01 10:00:14 -05:00
|
|
|
end
|
2012-09-21 12:22:43 -04:00
|
|
|
|
|
|
|
context "validate it is a fingerprintable key" do
|
|
|
|
it "accepts the fingerprintable key" do
|
2015-02-12 13:17:35 -05:00
|
|
|
expect(build(:key)).to be_valid
|
2012-09-21 12:22:43 -04:00
|
|
|
end
|
|
|
|
|
2015-04-09 17:16:01 -04:00
|
|
|
it 'rejects an unfingerprintable key that contains a space' do
|
|
|
|
key = build(:key)
|
|
|
|
|
|
|
|
# Not always the middle, but close enough
|
2015-07-11 14:18:56 -04:00
|
|
|
key.key = key.key[0..100] + ' ' + key.key[101..-1]
|
2015-04-09 17:16:01 -04:00
|
|
|
|
|
|
|
expect(key).not_to be_valid
|
2012-09-21 12:22:43 -04:00
|
|
|
end
|
2013-02-15 04:31:05 -05:00
|
|
|
|
2017-08-03 12:39:10 -04:00
|
|
|
it 'accepts a key with newline charecters after stripping them' do
|
|
|
|
key = build(:key)
|
|
|
|
key.key = key.key.insert(100, "\n")
|
|
|
|
key.key = key.key.insert(40, "\r\n")
|
|
|
|
expect(key).to be_valid
|
2013-02-15 04:31:05 -05:00
|
|
|
end
|
2015-07-11 14:18:56 -04:00
|
|
|
|
2017-08-03 12:39:10 -04:00
|
|
|
it 'rejects the unfingerprintable key (not a key)' do
|
|
|
|
expect(build(:key, key: 'ssh-rsa an-invalid-key==')).not_to be_valid
|
2015-07-11 14:18:56 -04:00
|
|
|
end
|
2017-08-03 12:39:10 -04:00
|
|
|
|
2012-09-21 12:22:43 -04:00
|
|
|
end
|
2014-04-02 14:13:05 -04:00
|
|
|
|
|
|
|
context 'callbacks' do
|
2016-08-01 11:00:44 -04:00
|
|
|
it 'adds new key to authorized_file' do
|
2016-11-15 14:27:49 -05:00
|
|
|
key = build(:personal_key, id: 7)
|
|
|
|
expect(GitlabShellWorker).to receive(:perform_async).with(:add_key, key.shell_id, key.key)
|
|
|
|
key.save!
|
2014-04-02 14:13:05 -04:00
|
|
|
end
|
|
|
|
|
2016-08-01 11:00:44 -04:00
|
|
|
it 'removes key from authorized_file' do
|
2016-11-15 14:27:49 -05:00
|
|
|
key = create(:personal_key)
|
|
|
|
expect(GitlabShellWorker).to receive(:perform_async).with(:remove_key, key.shell_id, key.key)
|
|
|
|
key.destroy
|
2014-04-02 14:13:05 -04:00
|
|
|
end
|
|
|
|
end
|
2016-11-15 14:16:45 -05:00
|
|
|
|
|
|
|
describe '#key=' do
|
|
|
|
let(:valid_key) do
|
|
|
|
"ssh-rsa AAAAB3NzaC1yc2EAAAABJQAAAIEAiPWx6WM4lhHNedGfBpPJNPpZ7yKu+dnn1SJejgt4596k6YjzGGphH2TUxwKzxcKDKKezwkpfnxPkSMkuEspGRt/aZZ9wa++Oi7Qkr8prgHc4soW6NUlfDzpvZK2H5E7eQaSeP3SAwGmQKUFHCddNaP0L+hM7zhFNzjFvpaMgJw0= dummy@gitlab.com"
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'strips white spaces' do
|
|
|
|
expect(described_class.new(key: " #{valid_key} ").key).to eq(valid_key)
|
|
|
|
end
|
|
|
|
end
|
2016-11-18 06:09:03 -05:00
|
|
|
|
|
|
|
describe 'notification' do
|
|
|
|
let(:user) { create(:user) }
|
|
|
|
|
|
|
|
it 'sends a notification' do
|
|
|
|
perform_enqueued_jobs do
|
|
|
|
create(:key, user: user)
|
|
|
|
end
|
|
|
|
|
|
|
|
should_email(user)
|
|
|
|
end
|
|
|
|
end
|
2011-10-08 17:36:38 -04:00
|
|
|
end
|