gitlab-org--gitlab-foss/spec/features/task_lists_spec.rb

400 lines
12 KiB
Ruby
Raw Normal View History

# frozen_string_literal: true
2015-05-04 23:06:57 -04:00
require 'spec_helper'
RSpec.describe 'Task Lists', :js do
2015-05-04 23:06:57 -04:00
include Warden::Test::Helpers
let_it_be(:project) { create(:project, :public, :repository) }
let_it_be(:user) { create(:user) }
let_it_be(:user2) { create(:user) }
2015-05-04 23:06:57 -04:00
let(:markdown) do
<<-MARKDOWN.strip_heredoc
This is a task list:
- [ ] Incomplete entry 1
- [x] Complete entry 1
- [ ] Incomplete entry 2
- [x] Complete entry 2
- [ ] Incomplete entry 3
- [ ] Incomplete entry 4
MARKDOWN
end
2016-08-27 13:36:08 -04:00
let(:singleIncompleteMarkdown) do
<<-MARKDOWN.strip_heredoc
This is a task list:
- [ ] Incomplete entry 1
MARKDOWN
end
let(:singleCompleteMarkdown) do
<<-MARKDOWN.strip_heredoc
This is a task list:
- [x] Incomplete entry 1
MARKDOWN
end
before_all do
project.add_maintainer(user)
project.add_guest(user2)
end
2015-05-04 23:06:57 -04:00
before do
2015-05-04 23:06:57 -04:00
login_as(user)
end
def visit_issue(project, issue)
visit project_issue_path(project, issue)
2015-05-04 23:06:57 -04:00
end
describe 'for Issues' do
describe 'multiple tasks' do
2016-08-27 13:36:08 -04:00
let!(:issue) { create(:issue, description: markdown, author: user, project: project) }
2015-05-04 23:06:57 -04:00
2016-08-27 13:36:08 -04:00
it 'renders' do
visit_issue(project, issue)
wait_for_requests
2016-08-27 13:36:08 -04:00
expect(page).to have_selector('ul.task-list', count: 1)
expect(page).to have_selector('li.task-list-item', count: 6)
expect(page).to have_selector('ul input[checked]', count: 2)
end
it 'contains the required selectors' do
visit_issue(project, issue)
wait_for_requests
2016-08-27 13:36:08 -04:00
expect(page).to have_selector(".md .task-list .task-list-item .task-list-item-checkbox")
expect(page).to have_selector('.btn-close')
2016-08-27 13:36:08 -04:00
end
2015-05-04 23:06:57 -04:00
2016-08-27 13:36:08 -04:00
it 'is only editable by author' do
visit_issue(project, issue)
wait_for_requests
expect(page).to have_selector(".md .task-list .task-list-item .task-list-item-checkbox")
2015-05-04 23:06:57 -04:00
2016-08-27 13:36:08 -04:00
logout(:user)
login_as(user2)
visit current_path
wait_for_requests
2017-05-03 16:35:54 -04:00
expect(page).to have_selector(".md .task-list .task-list-item .task-list-item-checkbox")
2016-08-27 13:36:08 -04:00
end
it 'provides a summary on Issues#index' do
visit project_issues_path(project)
2016-08-27 13:36:08 -04:00
expect(page).to have_content("2 of 6 tasks completed")
end
2015-05-04 23:06:57 -04:00
end
describe 'single incomplete task' do
2016-08-27 13:36:08 -04:00
let!(:issue) { create(:issue, description: singleIncompleteMarkdown, author: user, project: project) }
2015-05-04 23:06:57 -04:00
2016-08-27 13:36:08 -04:00
it 'renders' do
visit_issue(project, issue)
wait_for_requests
2016-08-27 13:36:08 -04:00
expect(page).to have_selector('ul.task-list', count: 1)
expect(page).to have_selector('li.task-list-item', count: 1)
expect(page).to have_selector('ul input[checked]', count: 0)
end
it 'provides a summary on Issues#index' do
visit project_issues_path(project)
2017-05-03 16:35:54 -04:00
2016-08-27 13:36:08 -04:00
expect(page).to have_content("0 of 1 task completed")
end
2015-05-04 23:06:57 -04:00
end
describe 'single complete task' do
2016-08-27 13:36:08 -04:00
let!(:issue) { create(:issue, description: singleCompleteMarkdown, author: user, project: project) }
it 'renders' do
visit_issue(project, issue)
wait_for_requests
2016-08-27 13:36:08 -04:00
expect(page).to have_selector('ul.task-list', count: 1)
expect(page).to have_selector('li.task-list-item', count: 1)
expect(page).to have_selector('ul input[checked]', count: 1)
end
it 'provides a summary on Issues#index' do
visit project_issues_path(project)
2017-05-03 16:35:54 -04:00
2016-08-27 13:36:08 -04:00
expect(page).to have_content("1 of 1 task completed")
end
2015-05-04 23:06:57 -04:00
end
end
describe 'for Notes' do
let!(:issue) { create(:issue, author: user, project: project) }
2016-08-27 13:36:08 -04:00
describe 'multiple tasks' do
let!(:note) do
create(:note, note: markdown, noteable: issue,
project: project, author: user)
end
it 'renders for note body' do
2016-08-27 13:36:08 -04:00
visit_issue(project, issue)
expect(page).to have_selector('.note ul.task-list', count: 1)
expect(page).to have_selector('.note li.task-list-item', count: 6)
expect(page).to have_selector('.note ul input[checked]', count: 2)
end
it 'contains the required selectors' do
2016-08-27 13:36:08 -04:00
visit_issue(project, issue)
expect(page).to have_selector('.note .js-task-list-container')
expect(page).to have_selector('.note .js-task-list-container .task-list .task-list-item .task-list-item-checkbox')
end
it 'is only editable by author' do
2016-08-27 13:36:08 -04:00
visit_issue(project, issue)
2016-08-27 13:36:08 -04:00
expect(page).to have_selector('.js-task-list-container')
gitlab_sign_out
2016-08-27 13:36:08 -04:00
gitlab_sign_in(user2)
2016-08-27 13:36:08 -04:00
visit current_path
expect(page).not_to have_selector('.js-task-list-container')
end
end
2015-05-04 23:06:57 -04:00
2016-08-27 13:36:08 -04:00
describe 'single incomplete task' do
let!(:note) do
create(:note, note: singleIncompleteMarkdown, noteable: issue,
project: project, author: user)
end
2015-05-04 23:06:57 -04:00
it 'renders for note body' do
2016-08-27 13:36:08 -04:00
visit_issue(project, issue)
2015-05-04 23:06:57 -04:00
2016-08-27 13:36:08 -04:00
expect(page).to have_selector('.note ul.task-list', count: 1)
expect(page).to have_selector('.note li.task-list-item', count: 1)
expect(page).to have_selector('.note ul input[checked]', count: 0)
end
2015-05-04 23:06:57 -04:00
end
2016-08-27 13:36:08 -04:00
describe 'single complete task' do
let!(:note) do
create(:note, note: singleCompleteMarkdown, noteable: issue,
project: project, author: user)
end
2015-05-04 23:06:57 -04:00
it 'renders for note body' do
2016-08-27 13:36:08 -04:00
visit_issue(project, issue)
2015-05-04 23:06:57 -04:00
2016-08-27 13:36:08 -04:00
expect(page).to have_selector('.note ul.task-list', count: 1)
expect(page).to have_selector('.note li.task-list-item', count: 1)
expect(page).to have_selector('.note ul input[checked]', count: 1)
end
2015-05-04 23:06:57 -04:00
end
end
describe 'for Merge Requests' do
def visit_merge_request(project, merge)
visit project_merge_request_path(project, merge)
2015-05-04 23:06:57 -04:00
end
shared_examples 'multiple tasks' do
it 'renders for description' do
2016-08-27 13:36:08 -04:00
visit_merge_request(project, merge)
wait_for_requests
2015-05-04 23:06:57 -04:00
2016-08-27 13:36:08 -04:00
expect(page).to have_selector('ul.task-list', count: 1)
expect(page).to have_selector('li.task-list-item', count: 6)
expect(page).to have_selector('ul input[checked]', count: 2)
end
2015-05-04 23:06:57 -04:00
it 'contains the required selectors' do
2016-08-27 13:36:08 -04:00
visit_merge_request(project, merge)
wait_for_requests
2015-05-04 23:06:57 -04:00
2016-08-27 13:36:08 -04:00
container = '.detail-page-description .description.js-task-list-container'
2015-05-04 23:06:57 -04:00
2016-08-27 13:36:08 -04:00
expect(page).to have_selector(container)
expect(page).to have_selector("#{container} .md .task-list .task-list-item .task-list-item-checkbox")
expect(page).to have_selector("#{container} .js-task-list-field", visible: false)
2016-08-27 13:36:08 -04:00
expect(page).to have_selector('form.js-issuable-update')
end
2015-05-04 23:06:57 -04:00
it 'is only editable by author' do
2016-08-27 13:36:08 -04:00
visit_merge_request(project, merge)
wait_for_requests
2016-08-27 13:36:08 -04:00
expect(page).to have_selector('.js-task-list-container')
expect(page).to have_selector('li.task-list-item.enabled', count: 6)
2015-05-04 23:06:57 -04:00
2016-08-27 13:36:08 -04:00
logout(:user)
login_as(user2)
visit current_path
wait_for_requests
2016-08-27 13:36:08 -04:00
expect(page).not_to have_selector('.js-task-list-container')
expect(page).to have_selector('li.task-list-item.enabled', count: 0)
expect(page).to have_selector('li.task-list-item input[disabled]', count: 6)
2016-08-27 13:36:08 -04:00
end
end
context 'when merge request is open' do
let!(:merge) { create(:merge_request, :simple, description: markdown, author: user, source_project: project) }
it_behaves_like 'multiple tasks'
2016-08-27 13:36:08 -04:00
it 'provides a summary on MergeRequests#index' do
visit project_merge_requests_path(project)
2016-08-27 13:36:08 -04:00
expect(page).to have_content("2 of 6 tasks completed")
end
end
2017-01-18 08:33:13 -05:00
context 'when merge request is closed' do
let!(:merge) { create(:merge_request, :closed, :simple, description: markdown, author: user, source_project: project) }
it_behaves_like 'multiple tasks'
end
2016-08-27 13:36:08 -04:00
describe 'single incomplete task' do
let!(:merge) { create(:merge_request, :simple, description: singleIncompleteMarkdown, author: user, source_project: project) }
it 'renders for description' do
2016-08-27 13:36:08 -04:00
visit_merge_request(project, merge)
wait_for_requests
2016-08-27 13:36:08 -04:00
expect(page).to have_selector('ul.task-list', count: 1)
expect(page).to have_selector('li.task-list-item', count: 1)
expect(page).to have_selector('ul input[checked]', count: 0)
end
it 'provides a summary on MergeRequests#index' do
visit project_merge_requests_path(project)
2016-08-27 13:36:08 -04:00
expect(page).to have_content("0 of 1 task completed")
end
2015-05-04 23:06:57 -04:00
end
2016-08-27 13:36:08 -04:00
describe 'single complete task' do
let!(:merge) { create(:merge_request, :simple, description: singleCompleteMarkdown, author: user, source_project: project) }
it 'renders for description' do
2016-08-27 13:36:08 -04:00
visit_merge_request(project, merge)
wait_for_requests
2016-08-27 13:36:08 -04:00
expect(page).to have_selector('ul.task-list', count: 1)
expect(page).to have_selector('li.task-list-item', count: 1)
expect(page).to have_selector('ul input[checked]', count: 1)
end
it 'provides a summary on MergeRequests#index' do
visit project_merge_requests_path(project)
2016-08-27 13:36:08 -04:00
expect(page).to have_content("1 of 1 task completed")
end
2015-05-04 23:06:57 -04:00
end
end
describe 'markdown task edge cases' do
describe 'commented tasks' do
let(:commented_tasks_markdown) do
<<-EOT.strip_heredoc
<!--
- [ ] a
-->
- [ ] b
EOT
end
let!(:issue) { create(:issue, description: commented_tasks_markdown, author: user, project: project) }
it 'renders' do
visit_issue(project, issue)
wait_for_requests
expect(page).to have_selector('ul.task-list', count: 1)
expect(page).to have_selector('li.task-list-item', count: 1)
expect(page).to have_selector('ul input[checked]', count: 0)
find('.task-list-item-checkbox').click
wait_for_requests
visit_issue(project, issue)
wait_for_requests
expect(page).to have_selector('ul.task-list', count: 1)
expect(page).to have_selector('li.task-list-item', count: 1)
expect(page).to have_selector('ul input[checked]', count: 1)
end
end
describe 'summary with no blank line' do
let(:summary_no_blank_line_markdown) do
<<-EOT.strip_heredoc
<details>
<summary>No blank line after summary element breaks task list</summary>
1. [ ] People Ops: do such and such
</details>
* [ ] Task 1
EOT
end
let!(:issue) { create(:issue, description: summary_no_blank_line_markdown, author: user, project: project) }
it 'renders' do
visit_issue(project, issue)
wait_for_requests
expect(page).to have_selector('ul.task-list', count: 1)
expect(page).to have_selector('li.task-list-item', count: 1)
expect(page).to have_selector('ul input[checked]', count: 0)
find('.task-list-item-checkbox').click
wait_for_requests
visit_issue(project, issue)
wait_for_requests
expect(page).to have_selector('ul.task-list', count: 1)
expect(page).to have_selector('li.task-list-item', count: 1)
expect(page).to have_selector('ul input[checked]', count: 1)
end
end
describe 'markdown starting with new line character' do
let(:markdown_starting_with_new_line) do
<<-EOT.strip_heredoc
- [ ] Task 1
EOT
end
let(:merge_request) { create(:merge_request, description: markdown_starting_with_new_line, author: user, source_project: project) }
it 'allows the task to be checked' do
visit project_merge_request_path(project, merge_request)
wait_for_requests
expect(page).to have_selector('ul input[checked]', count: 0)
find('.task-list-item-checkbox').click
wait_for_requests
visit project_merge_request_path(project, merge_request)
wait_for_requests
expect(page).to have_selector('ul input[checked]', count: 1)
end
end
end
2015-05-04 23:06:57 -04:00
end