2020-10-30 12:08:44 +00:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
require 'spec_helper'
|
|
|
|
|
|
|
|
RSpec.describe API::ContainerRepositories do
|
2022-02-18 12:15:31 +00:00
|
|
|
include_context 'container registry client stubs'
|
|
|
|
|
2020-10-30 12:08:44 +00:00
|
|
|
let_it_be(:project) { create(:project, :private) }
|
|
|
|
let_it_be(:reporter) { create(:user) }
|
|
|
|
let_it_be(:guest) { create(:user) }
|
|
|
|
let_it_be(:repository) { create(:container_repository, project: project) }
|
|
|
|
|
|
|
|
let(:users) do
|
|
|
|
{
|
|
|
|
anonymous: nil,
|
|
|
|
guest: guest,
|
|
|
|
reporter: reporter
|
|
|
|
}
|
|
|
|
end
|
|
|
|
|
|
|
|
let(:api_user) { reporter }
|
|
|
|
|
|
|
|
before do
|
|
|
|
project.add_reporter(reporter)
|
|
|
|
project.add_guest(guest)
|
|
|
|
|
|
|
|
stub_container_registry_config(enabled: true)
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'GET /registry/repositories/:id' do
|
|
|
|
let(:url) { "/registry/repositories/#{repository.id}" }
|
|
|
|
|
|
|
|
subject { get api(url, api_user) }
|
|
|
|
|
|
|
|
it_behaves_like 'rejected container repository access', :guest, :forbidden
|
|
|
|
it_behaves_like 'rejected container repository access', :anonymous, :unauthorized
|
|
|
|
|
|
|
|
context 'for allowed user' do
|
|
|
|
it 'returns a repository' do
|
|
|
|
subject
|
|
|
|
|
|
|
|
expect(json_response['id']).to eq(repository.id)
|
|
|
|
expect(response.body).not_to include('tags')
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns a matching schema' do
|
|
|
|
subject
|
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
|
|
expect(response).to match_response_schema('registry/repository')
|
|
|
|
end
|
|
|
|
|
2021-10-11 18:09:46 +00:00
|
|
|
context 'with a network error' do
|
|
|
|
before do
|
|
|
|
stub_container_registry_network_error(client_method: :repository_tags)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns a matching schema' do
|
|
|
|
subject
|
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
|
|
expect(response).to match_response_schema('registry/repository')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2020-10-30 12:08:44 +00:00
|
|
|
context 'with tags param' do
|
|
|
|
let(:url) { "/registry/repositories/#{repository.id}?tags=true" }
|
|
|
|
|
|
|
|
before do
|
|
|
|
stub_container_registry_tags(repository: repository.path, tags: %w(rootA latest), with_manifest: true)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns a repository and its tags' do
|
|
|
|
subject
|
|
|
|
|
|
|
|
expect(json_response['id']).to eq(repository.id)
|
|
|
|
expect(response.body).to include('tags')
|
|
|
|
end
|
2021-10-11 18:09:46 +00:00
|
|
|
|
|
|
|
context 'with a network error' do
|
|
|
|
before do
|
|
|
|
stub_container_registry_network_error(client_method: :repository_tags)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns a connection error message' do
|
|
|
|
subject
|
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(:service_unavailable)
|
|
|
|
expect(json_response['message']).to include('We are having trouble connecting to the Container Registry')
|
|
|
|
end
|
|
|
|
end
|
2020-10-30 12:08:44 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'with tags_count param' do
|
|
|
|
let(:url) { "/registry/repositories/#{repository.id}?tags_count=true" }
|
|
|
|
|
|
|
|
before do
|
|
|
|
stub_container_registry_tags(repository: repository.path, tags: %w(rootA latest), with_manifest: true)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns a repository and its tags_count' do
|
|
|
|
subject
|
|
|
|
|
|
|
|
expect(response.body).to include('tags_count')
|
|
|
|
expect(json_response['tags_count']).to eq(2)
|
|
|
|
end
|
|
|
|
end
|
2022-02-18 12:15:31 +00:00
|
|
|
|
|
|
|
context 'with size param' do
|
|
|
|
let(:url) { "/registry/repositories/#{repository.id}?size=true" }
|
|
|
|
let(:on_com) { true }
|
|
|
|
let(:created_at) { ::ContainerRepository::MIGRATION_PHASE_1_STARTED_AT + 3.months }
|
|
|
|
|
|
|
|
before do
|
|
|
|
allow(::Gitlab).to receive(:com?).and_return(on_com)
|
|
|
|
repository.update_column(:created_at, created_at)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns a repository and its size' do
|
|
|
|
stub_container_registry_gitlab_api_support(supported: true) do |client|
|
|
|
|
stub_container_registry_gitlab_api_repository_details(client, path: repository.path, size_bytes: 12345)
|
|
|
|
end
|
|
|
|
|
|
|
|
subject
|
|
|
|
|
|
|
|
expect(json_response['size']).to eq(12345)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with a network error' do
|
|
|
|
it 'returns an error message' do
|
|
|
|
stub_container_registry_gitlab_api_network_error
|
|
|
|
|
|
|
|
subject
|
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(:service_unavailable)
|
|
|
|
expect(json_response['message']).to include('We are having trouble connecting to the Container Registry')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with not supporting the gitlab api' do
|
|
|
|
it 'returns nil' do
|
|
|
|
stub_container_registry_gitlab_api_support(supported: false)
|
|
|
|
|
|
|
|
subject
|
|
|
|
|
|
|
|
expect(json_response['size']).to eq(nil)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'not on .com' do
|
|
|
|
let(:on_com) { false }
|
|
|
|
|
|
|
|
it 'returns nil' do
|
|
|
|
subject
|
|
|
|
|
|
|
|
expect(json_response['size']).to eq(nil)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with an older container repository' do
|
|
|
|
let(:created_at) { ::ContainerRepository::MIGRATION_PHASE_1_STARTED_AT - 3.months }
|
|
|
|
|
|
|
|
it 'returns nil' do
|
|
|
|
subject
|
|
|
|
|
|
|
|
expect(json_response['size']).to eq(nil)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2020-10-30 12:08:44 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'with invalid repository id' do
|
|
|
|
let(:url) { "/registry/repositories/#{non_existing_record_id}" }
|
|
|
|
|
|
|
|
it_behaves_like 'returning response status', :not_found
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|