gitlab-org--gitlab-foss/lib/gitlab/protocol_access.rb

module Gitlab
  module ProtocolAccess
    extend Gitlab::CurrentSettings

    def self.allowed?(protocol)
      if protocol == 'web'
        true
      elsif current_application_settings.enabled_git_access_protocol.blank?
        true
      else
        protocol == current_application_settings.enabled_git_access_protocol
      end
    end
  end
end
Only allow Git Access on the allowed protocol 2016-06-21 01:40:56 +00:00			`module Gitlab`
			`module ProtocolAccess`
`current_application_settings` belongs on `Gitlab::CurrentSettings` The initializers including this were doing so at the top level, so every object loaded after them had a `current_application_settings` method. However, if someone had rack-attack enabled (which was loaded before these initializers), it would try to load the API, and fail, because `Gitlab::CurrentSettings` didn't have that method. To fix this: 1. Don't include `Gitlab::CurrentSettings` at the top level. We do not need `Object.new.current_application_settings` to work. 2. Make `Gitlab::CurrentSettings` explicitly `extend self`, as we already use it like that in several places. 3. Change the initializers to use that new form. 2017-08-31 09:47:03 +00:00			`extend Gitlab::CurrentSettings`

Only allow Git Access on the allowed protocol 2016-06-21 01:40:56 +00:00			`def self.allowed?(protocol)`
Default Git access protocol to `web` 2016-06-29 20:25:04 +00:00			`if protocol == 'web'`
Only allow Git Access on the allowed protocol 2016-06-21 01:40:56 +00:00			`true`
Rename `enabled_git_access_protocols` to singular. 2016-06-29 19:30:27 +00:00			`elsif current_application_settings.enabled_git_access_protocol.blank?`
Only allow Git Access on the allowed protocol 2016-06-21 01:40:56 +00:00			`true`
			`else`
Default Git access protocol to `web` 2016-06-29 20:25:04 +00:00			`protocol == current_application_settings.enabled_git_access_protocol`
Only allow Git Access on the allowed protocol 2016-06-21 01:40:56 +00:00			`end`
			`end`
			`end`
			`end`