2019-04-11 12:17:24 +00:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2017-04-12 11:36:35 +00:00
|
|
|
require 'spec_helper'
|
|
|
|
|
2020-06-24 06:09:01 +00:00
|
|
|
RSpec.describe Ci::PlayBuildService, '#execute' do
|
2019-04-11 15:21:18 +00:00
|
|
|
let(:user) { create(:user, developer_projects: [project]) }
|
2017-08-02 19:55:11 +00:00
|
|
|
let(:project) { create(:project) }
|
2017-04-12 11:36:35 +00:00
|
|
|
let(:pipeline) { create(:ci_pipeline, project: project) }
|
|
|
|
let(:build) { create(:ci_build, :manual, pipeline: pipeline) }
|
|
|
|
|
|
|
|
let(:service) do
|
|
|
|
described_class.new(project, user)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when project does not have repository yet' do
|
2017-08-02 19:55:11 +00:00
|
|
|
let(:project) { create(:project) }
|
2017-04-12 11:36:35 +00:00
|
|
|
|
2017-05-31 09:15:25 +00:00
|
|
|
it 'allows user to play build if protected branch rules are met' do
|
|
|
|
create(:protected_branch, :developers_can_merge,
|
|
|
|
name: build.ref, project: project)
|
2017-04-12 11:36:35 +00:00
|
|
|
|
|
|
|
service.execute(build)
|
|
|
|
|
|
|
|
expect(build.reload).to be_pending
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not allow user with developer role to play build' do
|
|
|
|
expect { service.execute(build) }
|
|
|
|
.to raise_error Gitlab::Access::AccessDeniedError
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when project has repository' do
|
2017-08-01 18:51:52 +00:00
|
|
|
let(:project) { create(:project, :repository) }
|
2017-04-12 11:36:35 +00:00
|
|
|
|
|
|
|
it 'allows user with developer role to play a build' do
|
|
|
|
service.execute(build)
|
|
|
|
|
|
|
|
expect(build.reload).to be_pending
|
|
|
|
end
|
2019-04-11 15:21:18 +00:00
|
|
|
|
|
|
|
it 'prevents a blocked developer from playing a build' do
|
|
|
|
user.block!
|
|
|
|
|
|
|
|
expect { service.execute(build) }.to raise_error(Gitlab::Access::AccessDeniedError)
|
|
|
|
end
|
2017-04-12 11:36:35 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'when build is a playable manual action' do
|
|
|
|
let(:build) { create(:ci_build, :manual, pipeline: pipeline) }
|
2019-04-11 15:21:18 +00:00
|
|
|
let!(:branch) { create(:protected_branch, :developers_can_merge, name: build.ref, project: project) }
|
2017-04-12 11:36:35 +00:00
|
|
|
|
|
|
|
it 'enqueues the build' do
|
|
|
|
expect(service.execute(build)).to eq build
|
|
|
|
expect(build.reload).to be_pending
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'reassignes build user correctly' do
|
|
|
|
service.execute(build)
|
|
|
|
|
|
|
|
expect(build.reload.user).to eq user
|
|
|
|
end
|
2019-07-29 07:43:10 +00:00
|
|
|
|
2021-04-02 15:09:19 +00:00
|
|
|
context 'when a subsequent job is skipped' do
|
|
|
|
let!(:job) { create(:ci_build, :skipped, pipeline: pipeline, stage_idx: build.stage_idx + 1) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
create(:ci_build_need, build: job, name: build.name)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'marks the subsequent job as processable' do
|
|
|
|
expect { service.execute(build) }.to change { job.reload.status }.from('skipped').to('created')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-07-29 07:43:10 +00:00
|
|
|
context 'when variables are supplied' do
|
|
|
|
let(:job_variables) do
|
|
|
|
[{ key: 'first', secret_value: 'first' },
|
|
|
|
{ key: 'second', secret_value: 'second' }]
|
|
|
|
end
|
|
|
|
|
2021-12-03 00:11:20 +00:00
|
|
|
subject { service.execute(build, job_variables) }
|
|
|
|
|
2019-07-29 07:43:10 +00:00
|
|
|
it 'assigns the variables to the build' do
|
2021-12-03 00:11:20 +00:00
|
|
|
subject
|
2019-07-29 07:43:10 +00:00
|
|
|
|
|
|
|
expect(build.reload.job_variables.map(&:key)).to contain_exactly('first', 'second')
|
|
|
|
end
|
2021-01-14 12:10:54 +00:00
|
|
|
|
2021-12-03 00:11:20 +00:00
|
|
|
context 'when variables are invalid' do
|
|
|
|
let(:job_variables) { [{}] }
|
|
|
|
|
|
|
|
it 'raises an error' do
|
|
|
|
expect { subject }.to raise_error(ActiveRecord::RecordInvalid)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2021-01-14 12:10:54 +00:00
|
|
|
context 'when user defined variables are restricted' do
|
|
|
|
before do
|
|
|
|
project.update!(restrict_user_defined_variables: true)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when user is maintainer' do
|
|
|
|
before do
|
|
|
|
project.add_maintainer(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'assigns the variables to the build' do
|
2021-12-03 00:11:20 +00:00
|
|
|
subject
|
2021-01-14 12:10:54 +00:00
|
|
|
|
|
|
|
expect(build.reload.job_variables.map(&:key)).to contain_exactly('first', 'second')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when user is developer' do
|
|
|
|
it 'raises an error' do
|
2021-12-03 00:11:20 +00:00
|
|
|
expect { subject }.to raise_error Gitlab::Access::AccessDeniedError
|
2021-01-14 12:10:54 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2019-07-29 07:43:10 +00:00
|
|
|
end
|
2017-04-12 11:36:35 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'when build is not a playable manual action' do
|
2022-01-13 09:15:32 +00:00
|
|
|
let(:build) { create(:ci_build, :success, pipeline: pipeline) }
|
2019-04-11 15:21:18 +00:00
|
|
|
let!(:branch) { create(:protected_branch, :developers_can_merge, name: build.ref, project: project) }
|
2017-04-12 11:36:35 +00:00
|
|
|
|
|
|
|
it 'duplicates the build' do
|
|
|
|
duplicate = service.execute(build)
|
|
|
|
|
|
|
|
expect(duplicate).not_to eq build
|
|
|
|
expect(duplicate).to be_pending
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'assigns users correctly' do
|
|
|
|
duplicate = service.execute(build)
|
|
|
|
|
|
|
|
expect(build.user).not_to eq user
|
|
|
|
expect(duplicate.user).to eq user
|
|
|
|
end
|
2022-01-13 09:15:32 +00:00
|
|
|
|
|
|
|
context 'and is not retryable' do
|
|
|
|
let(:build) { create(:ci_build, :deployment_rejected, pipeline: pipeline) }
|
|
|
|
|
|
|
|
it 'does not duplicate the build' do
|
|
|
|
expect { service.execute(build) }.not_to change { Ci::Build.count }
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not enqueue the build' do
|
|
|
|
expect { service.execute(build) }.not_to change { build.status }
|
|
|
|
end
|
|
|
|
end
|
2017-04-12 11:36:35 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'when build is not action' do
|
2019-04-11 15:21:18 +00:00
|
|
|
let(:user) { create(:user) }
|
2017-04-12 11:36:35 +00:00
|
|
|
let(:build) { create(:ci_build, :success, pipeline: pipeline) }
|
|
|
|
|
|
|
|
it 'raises an error' do
|
|
|
|
expect { service.execute(build) }
|
|
|
|
.to raise_error Gitlab::Access::AccessDeniedError
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when user does not have ability to trigger action' do
|
2019-04-11 15:21:18 +00:00
|
|
|
let(:user) { create(:user) }
|
|
|
|
let!(:branch) { create(:protected_branch, :developers_can_merge, name: build.ref, project: project) }
|
2017-04-12 11:36:35 +00:00
|
|
|
|
|
|
|
it 'raises an error' do
|
|
|
|
expect { service.execute(build) }
|
|
|
|
.to raise_error Gitlab::Access::AccessDeniedError
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|