2019-04-11 12:17:24 +00:00
# frozen_string_literal: true
2016-01-21 18:09:32 +00:00
require 'spec_helper'
2020-06-24 15:08:50 +00:00
RSpec . describe Projects :: ImportService do
2017-08-02 19:55:11 +00:00
let! ( :project ) { create ( :project ) }
2016-01-21 18:09:32 +00:00
let ( :user ) { project . creator }
subject { described_class . new ( project , user ) }
2018-06-06 16:42:18 +00:00
before do
allow ( project ) . to receive ( :lfs_enabled? ) . and_return ( true )
end
2017-10-13 16:50:36 +00:00
describe '#async?' do
it 'returns true for an asynchronous importer' do
importer_class = double ( :importer , async? : true )
allow ( subject ) . to receive ( :has_importer? ) . and_return ( true )
allow ( subject ) . to receive ( :importer_class ) . and_return ( importer_class )
expect ( subject ) . to be_async
end
it 'returns false for a regular importer' do
importer_class = double ( :importer , async? : false )
allow ( subject ) . to receive ( :has_importer? ) . and_return ( true )
allow ( subject ) . to receive ( :importer_class ) . and_return ( importer_class )
expect ( subject ) . not_to be_async
end
it 'returns false when the importer does not define #async?' do
importer_class = double ( :importer )
allow ( subject ) . to receive ( :has_importer? ) . and_return ( true )
allow ( subject ) . to receive ( :importer_class ) . and_return ( importer_class )
expect ( subject ) . not_to be_async
end
it 'returns false when the importer does not exist' do
allow ( subject ) . to receive ( :has_importer? ) . and_return ( false )
expect ( subject ) . not_to be_async
end
end
2016-01-21 18:09:32 +00:00
describe '#execute' do
context 'with unknown url' do
before do
project . import_url = Project :: UNKNOWN_IMPORT_URL
end
it 'succeeds if repository is created successfully' do
expect ( project ) . to receive ( :create_repository ) . and_return ( true )
result = subject . execute
expect ( result [ :status ] ) . to eq :success
end
it 'fails if repository creation fails' do
expect ( project ) . to receive ( :create_repository ) . and_return ( false )
result = subject . execute
expect ( result [ :status ] ) . to eq :error
2018-07-16 10:17:42 +00:00
expect ( result [ :message ] ) . to eq " Error importing repository #{ project . safe_import_url } into #{ project . full_path } - The repository could not be created. "
2016-01-21 18:09:32 +00:00
end
2018-06-06 16:42:18 +00:00
context 'when repository creation succeeds' do
it 'does not download lfs files' do
expect_any_instance_of ( Projects :: LfsPointers :: LfsImportService ) . not_to receive ( :execute )
subject . execute
end
end
2016-01-21 18:09:32 +00:00
end
context 'with known url' do
before do
project . import_url = 'https://github.com/vim/vim.git'
2017-04-03 18:48:09 +00:00
project . import_type = 'github'
2016-01-21 18:09:32 +00:00
end
2017-04-03 18:48:09 +00:00
context 'with a Github repository' do
2021-10-06 21:12:16 +00:00
it 'tracks the start of import' do
expect ( Gitlab :: GithubImport :: ParallelImporter ) . to receive ( :track_start_import )
subject . execute
end
2017-10-18 19:46:05 +00:00
it 'succeeds if repository import was scheduled' do
expect_any_instance_of ( Gitlab :: GithubImport :: ParallelImporter )
. to receive ( :execute )
. and_return ( true )
2016-01-21 18:09:32 +00:00
2017-04-03 18:48:09 +00:00
result = subject . execute
2016-01-21 18:09:32 +00:00
2017-04-03 18:48:09 +00:00
expect ( result [ :status ] ) . to eq :success
end
2017-10-18 19:46:05 +00:00
it 'fails if repository import was not scheduled' do
expect_any_instance_of ( Gitlab :: GithubImport :: ParallelImporter )
. to receive ( :execute )
. and_return ( false )
2017-04-03 18:48:09 +00:00
result = subject . execute
expect ( result [ :status ] ) . to eq :error
2017-04-18 00:22:33 +00:00
end
2018-06-06 16:42:18 +00:00
context 'when repository import scheduled' do
it 'does not download lfs objects' do
expect_any_instance_of ( Projects :: LfsPointers :: LfsImportService ) . not_to receive ( :execute )
subject . execute
end
end
2016-01-21 18:09:32 +00:00
end
2017-04-03 18:48:09 +00:00
context 'with a non Github repository' do
before do
project . import_url = 'https://bitbucket.org/vim/vim.git'
project . import_type = 'bitbucket'
end
2016-01-21 18:09:32 +00:00
2018-10-30 10:53:01 +00:00
it 'succeeds if repository import is successful' do
2020-03-17 21:09:16 +00:00
expect ( project . repository ) . to receive ( :import_repository ) . and_return ( true )
2020-04-03 03:07:58 +00:00
expect_next_instance_of ( Gitlab :: BitbucketImport :: Importer ) do | importer |
expect ( importer ) . to receive ( :execute ) . and_return ( true )
end
expect_next_instance_of ( Projects :: LfsPointers :: LfsImportService ) do | service |
expect ( service ) . to receive ( :execute ) . and_return ( status : :success )
end
2016-01-21 18:09:32 +00:00
2017-04-03 18:48:09 +00:00
result = subject . execute
expect ( result [ :status ] ) . to eq :success
end
it 'fails if repository import fails' do
2020-03-17 21:09:16 +00:00
expect ( project . repository )
. to receive ( :import_repository )
. and_raise ( Gitlab :: Git :: CommandError , 'Failed to import the repository /a/b/c' )
2017-04-03 18:48:09 +00:00
result = subject . execute
expect ( result [ :status ] ) . to eq :error
2018-12-05 13:31:43 +00:00
expect ( result [ :message ] ) . to eq " Error importing repository #{ project . safe_import_url } into #{ project . full_path } - Failed to import the repository [FILTERED] "
2017-04-03 18:48:09 +00:00
end
2018-06-06 16:42:18 +00:00
2019-04-30 08:21:21 +00:00
context 'when lfs import fails' do
it 'logs the error' do
error_message = 'error message'
2020-03-17 21:09:16 +00:00
expect ( project . repository ) . to receive ( :import_repository ) . and_return ( true )
2020-04-03 03:07:58 +00:00
expect_next_instance_of ( Gitlab :: BitbucketImport :: Importer ) do | importer |
expect ( importer ) . to receive ( :execute ) . and_return ( true )
end
expect_next_instance_of ( Projects :: LfsPointers :: LfsImportService ) do | service |
expect ( service ) . to receive ( :execute ) . and_return ( status : :error , message : error_message )
end
2019-04-30 08:21:21 +00:00
expect ( Gitlab :: AppLogger ) . to receive ( :error ) . with ( " The Lfs import process failed. #{ error_message } " )
subject . execute
end
end
2018-06-06 16:42:18 +00:00
context 'when repository import scheduled' do
before do
2020-03-17 21:09:16 +00:00
expect ( project . repository ) . to receive ( :import_repository ) . and_return ( true )
2018-06-06 16:42:18 +00:00
allow ( subject ) . to receive ( :import_data )
end
it 'downloads lfs objects if lfs_enabled is enabled for project' do
allow ( project ) . to receive ( :lfs_enabled? ) . and_return ( true )
2018-12-14 16:51:37 +00:00
2019-04-30 08:21:21 +00:00
expect_any_instance_of ( Projects :: LfsPointers :: LfsImportService ) . to receive ( :execute )
2018-06-06 16:42:18 +00:00
subject . execute
end
it 'does not download lfs objects if lfs_enabled is not enabled for project' do
allow ( project ) . to receive ( :lfs_enabled? ) . and_return ( false )
expect_any_instance_of ( Projects :: LfsPointers :: LfsImportService ) . not_to receive ( :execute )
subject . execute
end
end
2016-01-21 18:09:32 +00:00
end
end
context 'with valid importer' do
before do
2022-02-28 09:15:16 +00:00
provider = double ( :provider ) . as_null_object
stub_omniauth_setting ( providers : [ provider ] )
2016-01-21 18:09:32 +00:00
project . import_url = 'https://github.com/vim/vim.git'
project . import_type = 'github'
2022-02-28 09:15:16 +00:00
allow ( project ) . to receive ( :import_data ) . and_return ( double ( :import_data ) . as_null_object )
2016-01-21 18:09:32 +00:00
end
it 'succeeds if importer succeeds' do
2017-10-18 19:46:05 +00:00
allow_any_instance_of ( Gitlab :: GithubImport :: ParallelImporter )
. to receive ( :execute ) . and_return ( true )
2016-01-21 18:09:32 +00:00
result = subject . execute
expect ( result [ :status ] ) . to eq :success
end
it 'fails if importer fails' do
2017-10-18 19:46:05 +00:00
allow_any_instance_of ( Gitlab :: GithubImport :: ParallelImporter )
. to receive ( :execute )
. and_return ( false )
2016-01-21 18:09:32 +00:00
result = subject . execute
expect ( result [ :status ] ) . to eq :error
2016-09-23 07:42:07 +00:00
end
2018-06-06 16:42:18 +00:00
context 'when importer' do
it 'has a custom repository importer it does not download lfs objects' do
allow ( Gitlab :: GithubImport :: ParallelImporter ) . to receive ( :imports_repository? ) . and_return ( true )
expect_any_instance_of ( Projects :: LfsPointers :: LfsImportService ) . not_to receive ( :execute )
subject . execute
end
it 'does not have a custom repository importer downloads lfs objects' do
allow ( Gitlab :: GithubImport :: ParallelImporter ) . to receive ( :imports_repository? ) . and_return ( false )
2019-04-30 08:21:21 +00:00
expect_any_instance_of ( Projects :: LfsPointers :: LfsImportService ) . to receive ( :execute )
2018-06-06 16:42:18 +00:00
subject . execute
end
2019-04-30 08:21:21 +00:00
context 'when lfs import fails' do
it 'logs the error' do
error_message = 'error message'
allow ( Gitlab :: GithubImport :: ParallelImporter ) . to receive ( :imports_repository? ) . and_return ( false )
expect_any_instance_of ( Projects :: LfsPointers :: LfsImportService ) . to receive ( :execute ) . and_return ( status : :error , message : error_message )
expect ( Gitlab :: AppLogger ) . to receive ( :error ) . with ( " The Lfs import process failed. #{ error_message } " )
subject . execute
end
end
2018-06-06 16:42:18 +00:00
end
2016-01-21 18:09:32 +00:00
end
2017-03-15 20:09:08 +00:00
context 'with blocked import_URL' do
it 'fails with localhost' do
project . import_url = 'https://localhost:9000/vim/vim.git'
result = described_class . new ( project , user ) . execute
expect ( result [ :status ] ) . to eq :error
2018-04-02 15:13:23 +00:00
expect ( result [ :message ] ) . to include ( 'Requests to localhost are not allowed' )
2017-03-15 20:09:08 +00:00
end
it 'fails with port 25' do
project . import_url = " https://github.com:25/vim/vim.git "
2020-05-13 12:07:54 +00:00
result = subject . execute
2017-03-15 20:09:08 +00:00
expect ( result [ :status ] ) . to eq :error
2018-10-11 20:45:07 +00:00
expect ( result [ :message ] ) . to include ( 'Only allowed ports are 80, 443' )
2017-03-15 20:09:08 +00:00
end
end
2020-05-13 12:07:54 +00:00
it_behaves_like 'measurable service' do
let ( :base_log_data ) do
{
class : described_class . name ,
current_user : user . name ,
project_full_path : project . full_path ,
import_type : project . import_type ,
file_path : project . import_source
}
end
before do
project . import_type = 'github'
end
after do
subject . execute
end
end
2016-01-21 18:09:32 +00:00
end
end