2019-01-09 21:04:27 +00:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
require 'spec_helper'
|
|
|
|
|
|
|
|
describe ErrorTracking::ListIssuesService do
|
|
|
|
set(:user) { create(:user) }
|
|
|
|
set(:project) { create(:project) }
|
|
|
|
|
|
|
|
let(:sentry_url) { 'https://sentrytest.gitlab.com/api/0/projects/sentry-org/sentry-project' }
|
|
|
|
let(:token) { 'test-token' }
|
|
|
|
let(:result) { subject.execute }
|
|
|
|
|
|
|
|
let(:error_tracking_setting) do
|
|
|
|
create(:project_error_tracking_setting, api_url: sentry_url, token: token, project: project)
|
|
|
|
end
|
|
|
|
|
|
|
|
subject { described_class.new(project, user) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
expect(project).to receive(:error_tracking_setting).at_least(:once).and_return(error_tracking_setting)
|
|
|
|
|
|
|
|
project.add_reporter(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#execute' do
|
|
|
|
context 'with authorized user' do
|
|
|
|
context 'when list_sentry_issues returns issues' do
|
|
|
|
let(:issues) { [:list, :of, :issues] }
|
|
|
|
|
|
|
|
before do
|
|
|
|
expect(error_tracking_setting)
|
|
|
|
.to receive(:list_sentry_issues).and_return(issues: issues)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns the issues' do
|
|
|
|
expect(result).to eq(status: :success, issues: issues)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when list_sentry_issues returns nil' do
|
|
|
|
before do
|
|
|
|
expect(error_tracking_setting)
|
|
|
|
.to receive(:list_sentry_issues).and_return(nil)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'result is not ready' do
|
|
|
|
expect(result).to eq(
|
2019-02-21 11:19:51 +00:00
|
|
|
status: :error, http_status: :no_content, message: 'Not ready. Try again later')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when list_sentry_issues returns error' do
|
|
|
|
before do
|
|
|
|
allow(error_tracking_setting)
|
|
|
|
.to receive(:list_sentry_issues)
|
2019-03-29 14:53:40 +00:00
|
|
|
.and_return(
|
|
|
|
error: 'Sentry response status code: 401',
|
|
|
|
error_type: ErrorTracking::ProjectErrorTrackingSetting::SENTRY_API_ERROR_TYPE_NON_20X_RESPONSE
|
|
|
|
)
|
2019-02-21 11:19:51 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns the error' do
|
|
|
|
expect(result).to eq(
|
|
|
|
status: :error,
|
|
|
|
http_status: :bad_request,
|
|
|
|
message: 'Sentry response status code: 401'
|
|
|
|
)
|
2019-01-09 21:04:27 +00:00
|
|
|
end
|
2019-03-29 14:53:40 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'when list_sentry_issues returns error with http_status' do
|
|
|
|
before do
|
|
|
|
allow(error_tracking_setting)
|
|
|
|
.to receive(:list_sentry_issues)
|
|
|
|
.and_return(
|
|
|
|
error: 'Sentry API response is missing keys. key not found: "id"',
|
|
|
|
error_type: ErrorTracking::ProjectErrorTrackingSetting::SENTRY_API_ERROR_TYPE_MISSING_KEYS
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns the error with correct http_status' do
|
|
|
|
expect(result).to eq(
|
|
|
|
status: :error,
|
|
|
|
http_status: :internal_server_error,
|
|
|
|
message: 'Sentry API response is missing keys. key not found: "id"'
|
|
|
|
)
|
|
|
|
end
|
2019-01-09 21:04:27 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with unauthorized user' do
|
|
|
|
let(:unauthorized_user) { create(:user) }
|
|
|
|
|
|
|
|
subject { described_class.new(project, unauthorized_user) }
|
|
|
|
|
|
|
|
it 'returns error' do
|
|
|
|
result = subject.execute
|
|
|
|
|
2019-02-21 11:19:51 +00:00
|
|
|
expect(result).to include(
|
|
|
|
status: :error,
|
|
|
|
message: 'Access denied',
|
|
|
|
http_status: :unauthorized
|
|
|
|
)
|
2019-01-09 21:04:27 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with error tracking disabled' do
|
|
|
|
before do
|
|
|
|
error_tracking_setting.enabled = false
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'raises error' do
|
|
|
|
result = subject.execute
|
|
|
|
|
2019-02-21 11:19:51 +00:00
|
|
|
expect(result).to include(status: :error, message: 'Error Tracking is not enabled')
|
2019-01-09 21:04:27 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#sentry_external_url' do
|
|
|
|
let(:external_url) { 'https://sentrytest.gitlab.com/sentry-org/sentry-project' }
|
|
|
|
|
|
|
|
it 'calls ErrorTracking::ProjectErrorTrackingSetting' do
|
|
|
|
expect(error_tracking_setting).to receive(:sentry_external_url).and_call_original
|
|
|
|
|
|
|
|
subject.external_url
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|