2019-07-25 05:24:42 +00:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2016-04-09 00:35:43 +00:00
|
|
|
require 'spec_helper'
|
|
|
|
|
2020-06-16 18:09:01 +00:00
|
|
|
RSpec.describe 'Member autocomplete', :js do
|
2021-03-18 15:09:04 +00:00
|
|
|
let_it_be(:project) { create(:project, :public, :repository) }
|
|
|
|
let_it_be(:user) { create(:user) }
|
|
|
|
let_it_be(:author) { create(:user) }
|
2021-06-29 03:07:32 +00:00
|
|
|
|
2017-03-22 18:04:29 +00:00
|
|
|
let(:note) { create(:note, noteable: noteable, project: noteable.project) }
|
2016-04-09 00:35:43 +00:00
|
|
|
|
|
|
|
before do
|
2017-03-22 18:04:29 +00:00
|
|
|
note # actually create the note
|
2017-06-21 23:44:10 +00:00
|
|
|
sign_in(user)
|
2016-04-09 00:35:43 +00:00
|
|
|
end
|
|
|
|
|
2017-08-14 10:35:58 +00:00
|
|
|
shared_examples "open suggestions when typing @" do |resource_name|
|
2017-03-22 18:04:29 +00:00
|
|
|
before do
|
2021-03-18 15:09:04 +00:00
|
|
|
if resource_name == 'commit'
|
|
|
|
fill_in 'note[note]', with: '@'
|
|
|
|
else
|
|
|
|
fill_in 'Comment', with: '@'
|
2016-04-09 06:34:07 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-03-22 18:04:29 +00:00
|
|
|
it 'suggests noteable author and note author' do
|
2021-03-18 15:09:04 +00:00
|
|
|
expect(find_autocomplete_menu).to have_text(author.username)
|
|
|
|
expect(find_autocomplete_menu).to have_text(note.author.username)
|
2016-04-09 06:34:07 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-03-22 18:04:29 +00:00
|
|
|
context 'adding a new note on a Issue' do
|
|
|
|
let(:noteable) { create(:issue, author: author, project: project) }
|
2019-12-17 18:07:48 +00:00
|
|
|
|
2016-04-09 00:35:43 +00:00
|
|
|
before do
|
2020-06-19 12:09:07 +00:00
|
|
|
stub_feature_flags(tribute_autocomplete: false)
|
2017-07-06 16:20:50 +00:00
|
|
|
visit project_issue_path(project, noteable)
|
2016-04-09 00:35:43 +00:00
|
|
|
end
|
|
|
|
|
2017-08-14 10:35:58 +00:00
|
|
|
include_examples "open suggestions when typing @", 'issue'
|
2016-04-09 00:35:43 +00:00
|
|
|
end
|
|
|
|
|
2020-06-19 12:09:07 +00:00
|
|
|
describe 'when tribute_autocomplete feature flag is on' do
|
|
|
|
context 'adding a new note on a Issue' do
|
|
|
|
let(:noteable) { create(:issue, author: author, project: project) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
stub_feature_flags(tribute_autocomplete: true)
|
|
|
|
visit project_issue_path(project, noteable)
|
|
|
|
|
2021-03-18 15:09:04 +00:00
|
|
|
fill_in 'Comment', with: '@'
|
2020-06-19 12:09:07 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'suggests noteable author and note author' do
|
2021-03-18 15:09:04 +00:00
|
|
|
expect(find_tribute_autocomplete_menu).to have_content(author.username)
|
|
|
|
expect(find_tribute_autocomplete_menu).to have_content(note.author.username)
|
2020-06-19 12:09:07 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-03-22 18:04:29 +00:00
|
|
|
context 'adding a new note on a Merge Request' do
|
|
|
|
let(:noteable) do
|
|
|
|
create(:merge_request, source_project: project,
|
|
|
|
target_project: project, author: author)
|
|
|
|
end
|
2019-12-17 18:07:48 +00:00
|
|
|
|
2016-04-09 06:34:07 +00:00
|
|
|
before do
|
2017-07-06 16:20:50 +00:00
|
|
|
visit project_merge_request_path(project, noteable)
|
2016-04-09 06:34:07 +00:00
|
|
|
end
|
|
|
|
|
2017-08-14 10:35:58 +00:00
|
|
|
include_examples "open suggestions when typing @", 'merge_request'
|
2016-04-09 06:34:07 +00:00
|
|
|
end
|
|
|
|
|
2017-03-22 18:04:29 +00:00
|
|
|
context 'adding a new note on a Commit' do
|
|
|
|
let(:noteable) { project.commit }
|
|
|
|
let(:note) { create(:note_on_commit, project: project, commit_id: project.commit.id) }
|
2016-04-13 18:50:17 +00:00
|
|
|
|
|
|
|
before do
|
2021-03-03 06:11:13 +00:00
|
|
|
allow(User).to receive(:find_by_any_email).and_call_original
|
2017-07-17 19:26:41 +00:00
|
|
|
allow(User).to receive(:find_by_any_email)
|
2019-12-07 00:07:51 +00:00
|
|
|
.with(noteable.author_email.downcase, confirmed: true).and_return(author)
|
2016-04-13 18:50:17 +00:00
|
|
|
|
2017-07-06 16:20:50 +00:00
|
|
|
visit project_commit_path(project, noteable)
|
2016-04-09 06:34:07 +00:00
|
|
|
end
|
2016-04-13 18:50:17 +00:00
|
|
|
|
2017-08-14 10:35:58 +00:00
|
|
|
include_examples "open suggestions when typing @", 'commit'
|
2016-04-13 18:50:17 +00:00
|
|
|
end
|
2021-03-18 15:09:04 +00:00
|
|
|
|
|
|
|
private
|
|
|
|
|
|
|
|
def find_autocomplete_menu
|
|
|
|
find('.atwho-view ul', visible: true)
|
|
|
|
end
|
|
|
|
|
|
|
|
def find_tribute_autocomplete_menu
|
|
|
|
find('.tribute-container ul', visible: true)
|
|
|
|
end
|
2016-04-09 00:35:43 +00:00
|
|
|
end
|