2016-08-03 00:14:50 +00:00
|
|
|
require 'spec_helper'
|
|
|
|
|
|
|
|
describe Boards::Issues::ListService, services: true do
|
|
|
|
describe '#execute' do
|
|
|
|
let(:user) { create(:user) }
|
2016-10-06 20:14:39 +00:00
|
|
|
let(:project) { create(:empty_project) }
|
2016-10-05 17:26:28 +00:00
|
|
|
let(:board) { create(:board, project: project) }
|
2016-08-03 00:14:50 +00:00
|
|
|
|
|
|
|
let(:bug) { create(:label, project: project, name: 'Bug') }
|
|
|
|
let(:development) { create(:label, project: project, name: 'Development') }
|
|
|
|
let(:testing) { create(:label, project: project, name: 'Testing') }
|
|
|
|
let(:p1) { create(:label, title: 'P1', project: project, priority: 1) }
|
|
|
|
let(:p2) { create(:label, title: 'P2', project: project, priority: 2) }
|
|
|
|
let(:p3) { create(:label, title: 'P3', project: project, priority: 3) }
|
|
|
|
|
2016-08-03 15:09:03 +00:00
|
|
|
let!(:list1) { create(:list, board: board, label: development, position: 0) }
|
|
|
|
let!(:list2) { create(:list, board: board, label: testing, position: 1) }
|
2017-03-24 12:40:35 +00:00
|
|
|
let!(:closed) { create(:closed_list, board: board) }
|
2016-08-03 00:14:50 +00:00
|
|
|
|
2017-01-27 18:21:11 +00:00
|
|
|
let!(:opened_issue1) { create(:labeled_issue, project: project, labels: [bug]) }
|
|
|
|
let!(:opened_issue2) { create(:labeled_issue, project: project, labels: [p2]) }
|
|
|
|
let!(:reopened_issue1) { create(:issue, :reopened, project: project) }
|
|
|
|
|
2016-08-03 00:14:50 +00:00
|
|
|
let!(:list1_issue1) { create(:labeled_issue, project: project, labels: [p2, development]) }
|
|
|
|
let!(:list1_issue2) { create(:labeled_issue, project: project, labels: [development]) }
|
|
|
|
let!(:list1_issue3) { create(:labeled_issue, project: project, labels: [development, p1]) }
|
|
|
|
let!(:list2_issue1) { create(:labeled_issue, project: project, labels: [testing]) }
|
|
|
|
|
|
|
|
let!(:closed_issue1) { create(:labeled_issue, :closed, project: project, labels: [bug]) }
|
|
|
|
let!(:closed_issue2) { create(:labeled_issue, :closed, project: project, labels: [p3]) }
|
|
|
|
let!(:closed_issue3) { create(:issue, :closed, project: project) }
|
2016-10-05 14:10:03 +00:00
|
|
|
let!(:closed_issue4) { create(:labeled_issue, :closed, project: project, labels: [p1]) }
|
2017-03-23 07:22:26 +00:00
|
|
|
let!(:closed_issue5) { create(:labeled_issue, :closed, project: project, labels: [development]) }
|
2016-08-03 00:14:50 +00:00
|
|
|
|
|
|
|
before do
|
|
|
|
project.team << [user, :developer]
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'delegates search to IssuesFinder' do
|
2016-10-05 17:26:28 +00:00
|
|
|
params = { board_id: board.id, id: list1.id }
|
2016-08-03 00:14:50 +00:00
|
|
|
|
2016-08-09 19:09:30 +00:00
|
|
|
expect_any_instance_of(IssuesFinder).to receive(:execute).once.and_call_original
|
2016-08-03 00:14:50 +00:00
|
|
|
|
|
|
|
described_class.new(project, user, params).execute
|
|
|
|
end
|
|
|
|
|
2017-03-07 16:04:44 +00:00
|
|
|
context 'issues are ordered by priority' do
|
|
|
|
it 'returns opened issues when list_id is missing' do
|
|
|
|
params = { board_id: board.id }
|
|
|
|
|
|
|
|
issues = described_class.new(project, user, params).execute
|
|
|
|
|
|
|
|
expect(issues).to eq [opened_issue2, reopened_issue1, opened_issue1]
|
|
|
|
end
|
|
|
|
|
2017-03-24 12:40:35 +00:00
|
|
|
it 'returns closed issues when listing issues from Closed' do
|
|
|
|
params = { board_id: board.id, id: closed.id }
|
2017-03-07 16:04:44 +00:00
|
|
|
|
|
|
|
issues = described_class.new(project, user, params).execute
|
|
|
|
|
2017-03-23 07:22:26 +00:00
|
|
|
expect(issues).to eq [closed_issue4, closed_issue2, closed_issue5, closed_issue3, closed_issue1]
|
2017-03-07 16:04:44 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns opened issues that have label list applied when listing issues from a label list' do
|
|
|
|
params = { board_id: board.id, id: list1.id }
|
|
|
|
|
|
|
|
issues = described_class.new(project, user, params).execute
|
|
|
|
|
|
|
|
expect(issues).to eq [list1_issue3, list1_issue1, list1_issue2]
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-10-07 20:06:27 +00:00
|
|
|
context 'with list that does not belong to the board' do
|
2016-10-06 02:50:35 +00:00
|
|
|
it 'raises an error' do
|
|
|
|
list = create(:list)
|
|
|
|
service = described_class.new(project, user, board_id: board.id, id: list.id)
|
2016-10-05 17:26:28 +00:00
|
|
|
|
2016-10-06 02:50:35 +00:00
|
|
|
expect { service.execute }.to raise_error(ActiveRecord::RecordNotFound)
|
2016-10-05 17:26:28 +00:00
|
|
|
end
|
2016-10-06 02:50:35 +00:00
|
|
|
end
|
2016-10-05 17:26:28 +00:00
|
|
|
|
2016-10-06 02:50:35 +00:00
|
|
|
context 'with invalid list id' do
|
|
|
|
it 'raises an error' do
|
|
|
|
service = described_class.new(project, user, board_id: board.id, id: nil)
|
2016-10-05 17:26:28 +00:00
|
|
|
|
2016-10-06 02:50:35 +00:00
|
|
|
expect { service.execute }.to raise_error(ActiveRecord::RecordNotFound)
|
2016-10-05 17:26:28 +00:00
|
|
|
end
|
2016-10-06 02:50:35 +00:00
|
|
|
end
|
2016-08-03 00:14:50 +00:00
|
|
|
end
|
|
|
|
end
|