2016-06-22 21:04:51 +00:00
require 'spec_helper'
2016-07-18 21:28:26 +00:00
require_relative '../../config/initializers/6_validations.rb'
2016-06-22 21:04:51 +00:00
2017-07-10 14:24:02 +00:00
describe '6_validations' do
2016-07-12 01:29:13 +00:00
before :all do
FileUtils . mkdir_p ( 'tmp/tests/paths/a/b/c/d' )
FileUtils . mkdir_p ( 'tmp/tests/paths/a/b/c2' )
FileUtils . mkdir_p ( 'tmp/tests/paths/a/b/d' )
end
after :all do
FileUtils . rm_rf ( 'tmp/tests/paths' )
end
2017-03-08 16:15:05 +00:00
describe 'validate_storages_config' do
context 'with correct settings' do
before do
2018-03-14 13:42:49 +00:00
mock_storages ( 'foo' = > Gitlab :: GitalyClient :: StorageSettings . new ( 'path' = > 'tmp/tests/paths/a/b/c' ) , 'bar' = > Gitlab :: GitalyClient :: StorageSettings . new ( 'path' = > 'tmp/tests/paths/a/b/d' ) )
2017-03-08 16:15:05 +00:00
end
2016-06-22 21:04:51 +00:00
2017-03-08 16:15:05 +00:00
it 'passes through' do
expect { validate_storages_config } . not_to raise_error
end
2016-06-22 21:04:51 +00:00
end
2017-05-17 16:17:15 +00:00
context 'when one of the settings is incorrect' do
before do
2018-03-14 13:42:49 +00:00
mock_storages ( 'foo' = > Gitlab :: GitalyClient :: StorageSettings . new ( 'path' = > 'tmp/tests/paths/a/b/c' , 'failure_count_threshold' = > 'not a number' ) )
2017-05-17 16:17:15 +00:00
end
it 'throws an error' do
expect { validate_storages_config } . to raise_error ( / failure_count_threshold / )
end
end
2017-03-08 16:15:05 +00:00
context 'with invalid storage names' do
before do
2018-03-14 13:42:49 +00:00
mock_storages ( 'name with spaces' = > Gitlab :: GitalyClient :: StorageSettings . new ( 'path' = > 'tmp/tests/paths/a/b/c' ) )
2017-03-08 16:15:05 +00:00
end
2016-06-22 21:04:51 +00:00
2017-03-08 16:15:05 +00:00
it 'throws an error' do
expect { validate_storages_config } . to raise_error ( '"name with spaces" is not a valid storage name. Please fix this in your gitlab.yml before starting GitLab.' )
end
2016-06-22 21:04:51 +00:00
end
2017-03-08 16:15:05 +00:00
context 'with incomplete settings' do
before do
mock_storages ( 'foo' = > { } )
end
2016-06-22 21:04:51 +00:00
2017-03-08 16:15:05 +00:00
it 'throws an error suggesting the user to update its settings' do
expect { validate_storages_config } . to raise_error ( 'foo is not a valid storage, because it has no `path` key. Refer to gitlab.yml.example for an updated example. Please fix this in your gitlab.yml before starting GitLab.' )
end
2016-06-22 21:04:51 +00:00
end
2017-03-08 16:15:05 +00:00
context 'with deprecated settings structure' do
before do
mock_storages ( 'foo' = > 'tmp/tests/paths/a/b/c' )
end
2016-07-12 01:29:13 +00:00
2017-03-08 16:15:05 +00:00
it 'throws an error suggesting the user to update its settings' do
expect { validate_storages_config } . to raise_error ( " foo is not a valid storage, because it has no `path` key. It may be configured as: \n \n foo: \n path: tmp/tests/paths/a/b/c \n \n For source installations, update your config/gitlab.yml Refer to gitlab.yml.example for an updated example. \n \n If you're using the Gitlab Development Kit, you can update your configuration running `gdk reconfigure`. \n " )
end
2016-07-12 01:29:13 +00:00
end
end
2017-03-08 16:15:05 +00:00
describe 'validate_storages_paths' do
context 'with correct settings' do
before do
2018-03-14 13:42:49 +00:00
mock_storages ( 'foo' = > Gitlab :: GitalyClient :: StorageSettings . new ( 'path' = > 'tmp/tests/paths/a/b/c' ) , 'bar' = > Gitlab :: GitalyClient :: StorageSettings . new ( 'path' = > 'tmp/tests/paths/a/b/d' ) )
2017-03-08 16:15:05 +00:00
end
2017-02-28 21:08:40 +00:00
2017-03-08 16:15:05 +00:00
it 'passes through' do
expect { validate_storages_paths } . not_to raise_error
end
2017-02-28 21:08:40 +00:00
end
2017-03-08 16:15:05 +00:00
context 'with nested storage paths' do
before do
2018-03-14 13:42:49 +00:00
mock_storages ( 'foo' = > Gitlab :: GitalyClient :: StorageSettings . new ( 'path' = > 'tmp/tests/paths/a/b/c' ) , 'bar' = > Gitlab :: GitalyClient :: StorageSettings . new ( 'path' = > 'tmp/tests/paths/a/b/c/d' ) )
2017-03-08 16:15:05 +00:00
end
it 'throws an error' do
expect { validate_storages_paths } . to raise_error ( 'bar is a nested path of foo. Nested paths are not supported for repository storages. Please fix this in your gitlab.yml before starting GitLab.' )
end
2017-02-28 21:08:40 +00:00
end
2017-03-08 16:15:05 +00:00
context 'with similar but un-nested storage paths' do
before do
2018-03-14 13:42:49 +00:00
mock_storages ( 'foo' = > Gitlab :: GitalyClient :: StorageSettings . new ( 'path' = > 'tmp/tests/paths/a/b/c' ) , 'bar' = > Gitlab :: GitalyClient :: StorageSettings . new ( 'path' = > 'tmp/tests/paths/a/b/c2' ) )
2017-03-08 16:15:05 +00:00
end
it 'passes through' do
expect { validate_storages_paths } . not_to raise_error
end
2017-02-28 21:08:40 +00:00
end
2017-05-17 16:17:15 +00:00
describe 'inaccessible storage' do
before do
2018-03-14 13:42:49 +00:00
mock_storages ( 'foo' = > Gitlab :: GitalyClient :: StorageSettings . new ( 'path' = > 'tmp/tests/a/path/that/does/not/exist' ) )
2017-05-17 16:17:15 +00:00
end
it 'passes through with a warning' do
expect ( Rails . logger ) . to receive ( :error )
expect { validate_storages_paths } . not_to raise_error
end
end
2017-02-28 21:08:40 +00:00
end
2016-06-22 21:04:51 +00:00
def mock_storages ( storages )
allow ( Gitlab . config . repositories ) . to receive ( :storages ) . and_return ( storages )
end
end