2012-08-16 01:06:08 +00:00
|
|
|
require 'spec_helper'
|
|
|
|
|
|
|
|
describe ApplicationHelper do
|
2012-09-25 23:22:44 +00:00
|
|
|
describe 'current_controller?' do
|
|
|
|
before do
|
2015-02-12 18:17:35 +00:00
|
|
|
allow(controller).to receive(:controller_name).and_return('foo')
|
2012-09-25 23:22:44 +00:00
|
|
|
end
|
|
|
|
|
2015-01-19 20:37:20 +00:00
|
|
|
it 'returns true when controller matches argument' do
|
2015-02-12 18:17:35 +00:00
|
|
|
expect(current_controller?(:foo)).to be_truthy
|
2012-09-25 23:22:44 +00:00
|
|
|
end
|
|
|
|
|
2015-01-19 20:37:20 +00:00
|
|
|
it 'returns false when controller does not match argument' do
|
2015-02-12 18:17:35 +00:00
|
|
|
expect(current_controller?(:bar)).not_to be_truthy
|
2012-09-25 23:22:44 +00:00
|
|
|
end
|
2012-09-26 01:18:00 +00:00
|
|
|
|
2015-01-19 20:37:20 +00:00
|
|
|
it 'should take any number of arguments' do
|
2015-02-12 18:17:35 +00:00
|
|
|
expect(current_controller?(:baz, :bar)).not_to be_truthy
|
|
|
|
expect(current_controller?(:baz, :bar, :foo)).to be_truthy
|
2012-09-26 01:18:00 +00:00
|
|
|
end
|
2012-09-25 23:22:44 +00:00
|
|
|
end
|
|
|
|
|
2012-09-26 19:06:07 +00:00
|
|
|
describe 'current_action?' do
|
|
|
|
before do
|
2013-12-14 13:43:48 +00:00
|
|
|
allow(self).to receive(:action_name).and_return('foo')
|
2012-09-26 19:06:07 +00:00
|
|
|
end
|
|
|
|
|
2015-01-19 20:37:20 +00:00
|
|
|
it 'returns true when action matches argument' do
|
2015-02-12 18:17:35 +00:00
|
|
|
expect(current_action?(:foo)).to be_truthy
|
2012-09-26 19:06:07 +00:00
|
|
|
end
|
|
|
|
|
2015-01-19 20:37:20 +00:00
|
|
|
it 'returns false when action does not match argument' do
|
2015-02-12 18:17:35 +00:00
|
|
|
expect(current_action?(:bar)).not_to be_truthy
|
2012-09-26 19:06:07 +00:00
|
|
|
end
|
|
|
|
|
2015-01-19 20:37:20 +00:00
|
|
|
it 'should take any number of arguments' do
|
2015-02-12 18:17:35 +00:00
|
|
|
expect(current_action?(:baz, :bar)).not_to be_truthy
|
|
|
|
expect(current_action?(:baz, :bar, :foo)).to be_truthy
|
2012-09-26 19:06:07 +00:00
|
|
|
end
|
|
|
|
end
|
2013-12-17 09:38:30 +00:00
|
|
|
|
2014-01-25 17:15:44 +00:00
|
|
|
describe 'project_icon' do
|
|
|
|
avatar_file_path = File.join(Rails.root, 'public', 'gitlab_logo.png')
|
|
|
|
|
|
|
|
it 'should return an url for the avatar' do
|
|
|
|
project = create(:project)
|
|
|
|
project.avatar = File.open(avatar_file_path)
|
|
|
|
project.save!
|
2015-02-28 17:07:53 +00:00
|
|
|
avatar_url = "http://localhost/uploads/project/avatar/#{ project.id }/gitlab_logo.png"
|
2015-01-24 18:02:58 +00:00
|
|
|
expect(project_icon("#{project.namespace.to_param}/#{project.to_param}").to_s).to eq(
|
2015-02-28 17:07:53 +00:00
|
|
|
"<img alt=\"Gitlab logo\" src=\"#{avatar_url}\" />"
|
2015-02-12 18:17:35 +00:00
|
|
|
)
|
2014-01-25 17:15:44 +00:00
|
|
|
end
|
|
|
|
|
2015-01-19 20:37:20 +00:00
|
|
|
it 'should give uploaded icon when present' do
|
2014-01-25 17:15:44 +00:00
|
|
|
project = create(:project)
|
|
|
|
project.save!
|
|
|
|
|
2015-02-12 18:17:35 +00:00
|
|
|
allow_any_instance_of(Project).to receive(:avatar_in_git).and_return(true)
|
2014-01-25 17:15:44 +00:00
|
|
|
|
2015-02-28 17:07:53 +00:00
|
|
|
avatar_url = 'http://localhost' + namespace_project_avatar_path(project.namespace, project)
|
2015-01-24 18:02:58 +00:00
|
|
|
expect(project_icon("#{project.namespace.to_param}/#{project.to_param}").to_s).to match(
|
2015-02-28 17:07:53 +00:00
|
|
|
image_tag(avatar_url))
|
2014-01-25 17:15:44 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2015-01-19 20:37:20 +00:00
|
|
|
describe 'avatar_icon' do
|
2013-10-06 18:13:56 +00:00
|
|
|
avatar_file_path = File.join(Rails.root, 'public', 'gitlab_logo.png')
|
|
|
|
|
2015-01-19 20:37:20 +00:00
|
|
|
it 'should return an url for the avatar' do
|
2013-10-06 18:13:56 +00:00
|
|
|
user = create(:user)
|
|
|
|
user.avatar = File.open(avatar_file_path)
|
|
|
|
user.save!
|
2015-02-12 18:53:23 +00:00
|
|
|
expect(avatar_icon(user.email).to_s).
|
|
|
|
to match("/uploads/user/avatar/#{ user.id }/gitlab_logo.png")
|
2013-10-06 18:13:56 +00:00
|
|
|
end
|
|
|
|
|
2015-01-19 20:37:20 +00:00
|
|
|
it 'should return an url for the avatar with relative url' do
|
|
|
|
Gitlab.config.gitlab.stub(relative_url_root: '/gitlab')
|
2014-12-05 14:59:55 +00:00
|
|
|
Gitlab.config.gitlab.stub(url: Settings.send(:build_gitlab_url))
|
|
|
|
|
|
|
|
user = create(:user)
|
|
|
|
user.avatar = File.open(avatar_file_path)
|
|
|
|
user.save!
|
2015-02-12 18:53:23 +00:00
|
|
|
expect(avatar_icon(user.email).to_s).
|
|
|
|
to match("/gitlab/uploads/user/avatar/#{ user.id }/gitlab_logo.png")
|
2014-12-05 14:59:55 +00:00
|
|
|
end
|
|
|
|
|
2015-01-19 20:37:20 +00:00
|
|
|
it 'should call gravatar_icon when no avatar is present' do
|
2014-06-13 16:35:21 +00:00
|
|
|
user = create(:user, email: 'test@example.com')
|
2013-10-06 18:13:56 +00:00
|
|
|
user.save!
|
2015-02-12 18:17:35 +00:00
|
|
|
expect(avatar_icon(user.email).to_s).to eq('http://www.gravatar.com/avatar/55502f40dc8b7c769880b10874abc9d0?s=40&d=identicon')
|
2013-10-06 18:13:56 +00:00
|
|
|
end
|
|
|
|
end
|
2012-09-26 19:06:07 +00:00
|
|
|
|
2015-01-19 20:37:20 +00:00
|
|
|
describe 'gravatar_icon' do
|
2012-08-16 01:06:08 +00:00
|
|
|
let(:user_email) { 'user@email.com' }
|
|
|
|
|
2015-01-19 20:37:20 +00:00
|
|
|
it 'should return a generic avatar path when Gravatar is disabled' do
|
2015-01-08 21:21:00 +00:00
|
|
|
ApplicationSetting.any_instance.stub(gravatar_enabled?: false)
|
2015-02-12 18:17:35 +00:00
|
|
|
expect(gravatar_icon(user_email)).to match('no_avatar.png')
|
2012-08-16 01:06:08 +00:00
|
|
|
end
|
|
|
|
|
2015-01-19 20:37:20 +00:00
|
|
|
it 'should return a generic avatar path when email is blank' do
|
2015-02-12 18:17:35 +00:00
|
|
|
expect(gravatar_icon('')).to match('no_avatar.png')
|
2012-08-16 01:06:08 +00:00
|
|
|
end
|
|
|
|
|
2015-01-19 20:37:20 +00:00
|
|
|
it 'should return default gravatar url' do
|
2014-06-13 16:35:21 +00:00
|
|
|
Gitlab.config.gitlab.stub(https: false)
|
2015-02-12 18:53:23 +00:00
|
|
|
url = 'http://www.gravatar.com/avatar/b58c6f14d292556214bd64909bcdb118'
|
|
|
|
expect(gravatar_icon(user_email)).to match(url)
|
2012-12-06 20:44:22 +00:00
|
|
|
end
|
|
|
|
|
2015-01-19 20:37:20 +00:00
|
|
|
it 'should use SSL when appropriate' do
|
2014-06-13 16:35:21 +00:00
|
|
|
Gitlab.config.gitlab.stub(https: true)
|
2015-02-12 18:17:35 +00:00
|
|
|
expect(gravatar_icon(user_email)).to match('https://secure.gravatar.com')
|
2012-08-16 01:06:08 +00:00
|
|
|
end
|
|
|
|
|
2015-01-19 20:37:20 +00:00
|
|
|
it 'should return custom gravatar path when gravatar_url is set' do
|
2013-12-14 13:43:48 +00:00
|
|
|
allow(self).to receive(:request).and_return(double(:ssl? => false))
|
2015-02-12 18:53:23 +00:00
|
|
|
allow(Gitlab.config.gravatar).
|
|
|
|
to receive(:plain_url).
|
|
|
|
and_return('http://example.local/?s=%{size}&hash=%{hash}')
|
|
|
|
url = 'http://example.local/?s=20&hash=b58c6f14d292556214bd64909bcdb118'
|
|
|
|
expect(gravatar_icon(user_email, 20)).to eq(url)
|
2012-12-06 20:44:22 +00:00
|
|
|
end
|
|
|
|
|
2015-01-19 20:37:20 +00:00
|
|
|
it 'should accept a custom size' do
|
2013-12-14 13:43:48 +00:00
|
|
|
allow(self).to receive(:request).and_return(double(:ssl? => false))
|
2015-02-12 18:17:35 +00:00
|
|
|
expect(gravatar_icon(user_email, 64)).to match(/\?s=64/)
|
2012-08-16 01:06:08 +00:00
|
|
|
end
|
2012-12-06 20:44:22 +00:00
|
|
|
|
2015-01-19 20:37:20 +00:00
|
|
|
it 'should use default size when size is wrong' do
|
2013-12-14 13:43:48 +00:00
|
|
|
allow(self).to receive(:request).and_return(double(:ssl? => false))
|
2015-02-12 18:17:35 +00:00
|
|
|
expect(gravatar_icon(user_email, nil)).to match(/\?s=40/)
|
2012-12-06 20:44:22 +00:00
|
|
|
end
|
|
|
|
|
2015-01-19 20:37:20 +00:00
|
|
|
it 'should be case insensitive' do
|
2013-12-14 13:43:48 +00:00
|
|
|
allow(self).to receive(:request).and_return(double(:ssl? => false))
|
2015-02-12 18:53:23 +00:00
|
|
|
expect(gravatar_icon(user_email)).
|
|
|
|
to eq(gravatar_icon(user_email.upcase + ' '))
|
2012-12-06 20:44:22 +00:00
|
|
|
end
|
2014-03-09 05:00:43 +00:00
|
|
|
end
|
|
|
|
|
2015-01-19 20:37:20 +00:00
|
|
|
describe 'grouped_options_refs' do
|
2014-03-09 05:00:43 +00:00
|
|
|
# Override Rails' grouped_options_for_select helper since HTML is harder to work with
|
|
|
|
def grouped_options_for_select(options, *args)
|
|
|
|
options
|
|
|
|
end
|
|
|
|
|
|
|
|
let(:options) { grouped_options_refs }
|
|
|
|
|
|
|
|
before do
|
|
|
|
# Must be an instance variable
|
|
|
|
@project = create(:project)
|
|
|
|
end
|
|
|
|
|
2015-01-19 20:37:20 +00:00
|
|
|
it 'includes a list of branch names' do
|
2015-02-12 18:17:35 +00:00
|
|
|
expect(options[0][0]).to eq('Branches')
|
|
|
|
expect(options[0][1]).to include('master', 'feature')
|
2014-03-09 05:00:43 +00:00
|
|
|
end
|
|
|
|
|
2015-01-19 20:37:20 +00:00
|
|
|
it 'includes a list of tag names' do
|
2015-02-12 18:17:35 +00:00
|
|
|
expect(options[1][0]).to eq('Tags')
|
2015-02-12 18:53:23 +00:00
|
|
|
expect(options[1][1]).to include('v1.0.0', 'v1.1.0')
|
2014-03-09 05:00:43 +00:00
|
|
|
end
|
|
|
|
|
2015-01-19 20:37:20 +00:00
|
|
|
it 'includes a specific commit ref if defined' do
|
2014-03-09 05:00:43 +00:00
|
|
|
# Must be an instance variable
|
|
|
|
@ref = '2ed06dc41dbb5936af845b87d79e05bbf24c73b8'
|
2012-12-06 20:44:22 +00:00
|
|
|
|
2015-02-12 18:17:35 +00:00
|
|
|
expect(options[2][0]).to eq('Commit')
|
|
|
|
expect(options[2][1]).to eq([@ref])
|
2014-03-09 05:00:43 +00:00
|
|
|
end
|
|
|
|
|
2015-01-19 20:37:20 +00:00
|
|
|
it 'sorts tags in a natural order' do
|
2014-03-09 05:00:43 +00:00
|
|
|
# Stub repository.tag_names to make sure we get some valid testing data
|
2015-02-12 18:53:23 +00:00
|
|
|
expect(@project.repository).to receive(:tag_names).
|
2015-02-25 20:40:27 +00:00
|
|
|
and_return(['v1.0.9', 'v1.0.10', 'v2.0', 'v3.1.4.2', 'v2.0rc1¿',
|
|
|
|
'v1.0.9a', 'v2.0-rc1', 'v2.0rc2'])
|
2014-03-09 05:00:43 +00:00
|
|
|
|
2015-02-12 18:53:23 +00:00
|
|
|
expect(options[1][1]).
|
2015-02-25 20:40:27 +00:00
|
|
|
to eq(['v3.1.4.2', 'v2.0', 'v2.0rc2', 'v2.0rc1¿', 'v2.0-rc1', 'v1.0.10',
|
|
|
|
'v1.0.9', 'v1.0.9a'])
|
2014-03-09 05:00:43 +00:00
|
|
|
end
|
2012-08-16 01:06:08 +00:00
|
|
|
end
|
2013-06-03 15:31:35 +00:00
|
|
|
|
2015-01-19 20:37:20 +00:00
|
|
|
describe 'simple_sanitize' do
|
2013-10-20 03:57:34 +00:00
|
|
|
let(:a_tag) { '<a href="#">Foo</a>' }
|
|
|
|
|
2015-01-19 20:37:20 +00:00
|
|
|
it 'allows the a tag' do
|
2015-02-12 18:17:35 +00:00
|
|
|
expect(simple_sanitize(a_tag)).to eq(a_tag)
|
2013-10-20 03:57:34 +00:00
|
|
|
end
|
|
|
|
|
2015-01-19 20:37:20 +00:00
|
|
|
it 'allows the span tag' do
|
2013-10-20 03:57:34 +00:00
|
|
|
input = '<span class="foo">Bar</span>'
|
2015-02-12 18:17:35 +00:00
|
|
|
expect(simple_sanitize(input)).to eq(input)
|
2013-10-20 03:57:34 +00:00
|
|
|
end
|
|
|
|
|
2015-01-19 20:37:20 +00:00
|
|
|
it 'disallows other tags' do
|
2013-10-20 03:57:34 +00:00
|
|
|
input = "<strike><b>#{a_tag}</b></strike>"
|
2015-02-12 18:17:35 +00:00
|
|
|
expect(simple_sanitize(input)).to eq(a_tag)
|
2013-10-20 03:57:34 +00:00
|
|
|
end
|
|
|
|
end
|
2014-05-30 15:09:31 +00:00
|
|
|
|
2015-01-19 20:37:20 +00:00
|
|
|
describe 'link_to' do
|
|
|
|
it 'should not include rel=nofollow for internal links' do
|
2015-04-12 21:34:05 +00:00
|
|
|
expect(link_to('Home', root_path)).to eq('<a href="/">Home</a>')
|
2014-05-30 15:09:31 +00:00
|
|
|
end
|
|
|
|
|
2015-01-19 20:37:20 +00:00
|
|
|
it 'should include rel=nofollow for external links' do
|
2015-04-12 21:34:05 +00:00
|
|
|
expect(link_to('Example', 'http://www.example.com')).
|
|
|
|
to eq '<a href="http://www.example.com" rel="nofollow">Example</a>'
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'should include rel=nofollow for external links and honor existing html_options' do
|
|
|
|
expect(link_to('Example', 'http://www.example.com', class: 'toggle', data: {toggle: 'dropdown'}))
|
|
|
|
.to eq '<a class="toggle" data-toggle="dropdown" href="http://www.example.com" rel="nofollow">Example</a>'
|
2014-05-30 15:09:31 +00:00
|
|
|
end
|
|
|
|
|
2015-04-12 21:34:05 +00:00
|
|
|
it 'should include rel=nofollow for external links and preserve other rel values' do
|
|
|
|
expect(link_to('Example', 'http://www.example.com', rel: 'noreferrer'))
|
|
|
|
.to eq '<a href="http://www.example.com" rel="noreferrer nofollow">Example</a>'
|
2014-05-30 15:09:31 +00:00
|
|
|
end
|
|
|
|
|
2015-04-12 21:34:05 +00:00
|
|
|
it 'should not include rel=nofollow for external links on the same host as GitLab' do
|
|
|
|
expect(Gitlab.config.gitlab).to receive(:host).and_return('example.foo')
|
|
|
|
expect(link_to('Example', 'http://example.foo/bar')).
|
|
|
|
to eq '<a href="http://example.foo/bar">Example</a>'
|
2014-05-30 15:09:31 +00:00
|
|
|
end
|
2015-04-21 18:36:06 +00:00
|
|
|
|
|
|
|
it 'should not raise an error when given a bad URI' do
|
|
|
|
expect { link_to('default', 'if real=1 RANDOM; if real>1 IDLHS; if real>500 LHS') }.
|
|
|
|
not_to raise_error
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'should not raise an error when given a bad mailto URL' do
|
|
|
|
expect { link_to('email', 'mailto://foo.bar@example.es?subject=Subject%20Line') }.
|
|
|
|
not_to raise_error
|
|
|
|
end
|
2014-05-30 15:09:31 +00:00
|
|
|
end
|
2014-07-31 09:22:46 +00:00
|
|
|
|
2015-05-12 23:07:48 +00:00
|
|
|
describe 'render_markup' do
|
2014-07-31 09:22:46 +00:00
|
|
|
let(:content) { 'Noël' }
|
|
|
|
|
|
|
|
it 'should preserve encoding' do
|
2015-02-12 18:17:35 +00:00
|
|
|
expect(content.encoding.name).to eq('UTF-8')
|
2014-07-31 09:22:46 +00:00
|
|
|
expect(render_markup('foo.rst', content).encoding.name).to eq('UTF-8')
|
|
|
|
end
|
2015-05-12 23:07:48 +00:00
|
|
|
|
2015-05-12 23:54:13 +00:00
|
|
|
it "should delegate to #markdown when file name corresponds to Markdown" do
|
|
|
|
expect(self).to receive(:gitlab_markdown?).with('foo.md').and_return(true)
|
|
|
|
expect(self).to receive(:markdown).and_return('NOEL')
|
|
|
|
|
|
|
|
expect(render_markup('foo.md', content)).to eq('NOEL')
|
|
|
|
end
|
|
|
|
|
2015-05-12 23:07:48 +00:00
|
|
|
it "should delegate to #asciidoc when file name corresponds to AsciiDoc" do
|
|
|
|
expect(self).to receive(:asciidoc?).with('foo.adoc').and_return(true)
|
|
|
|
expect(self).to receive(:asciidoc).and_return('NOEL')
|
|
|
|
|
|
|
|
expect(render_markup('foo.adoc', content)).to eq('NOEL')
|
|
|
|
end
|
2014-07-31 09:22:46 +00:00
|
|
|
end
|
2012-08-16 01:06:08 +00:00
|
|
|
end
|