2019-07-25 01:21:37 -04:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2012-09-20 13:55:14 -04:00
|
|
|
require 'spec_helper'
|
|
|
|
|
2017-07-10 10:24:02 -04:00
|
|
|
describe ExtractsPath do
|
2017-07-25 13:09:00 -04:00
|
|
|
include described_class
|
2015-04-27 00:46:27 -04:00
|
|
|
include RepoHelpers
|
2017-07-07 11:43:37 -04:00
|
|
|
include Gitlab::Routing
|
2012-09-20 13:55:14 -04:00
|
|
|
|
|
|
|
let(:project) { double('project') }
|
2016-10-07 11:49:48 -04:00
|
|
|
let(:request) { double('request') }
|
2012-09-20 13:55:14 -04:00
|
|
|
|
|
|
|
before do
|
|
|
|
@project = project
|
2015-05-21 17:49:06 -04:00
|
|
|
|
2015-06-21 11:26:37 -04:00
|
|
|
repo = double(ref_names: ['master', 'foo/bar/baz', 'v1.0.0', 'v2.0.0',
|
|
|
|
'release/app', 'release/app/v1.0.0'])
|
2015-05-21 17:49:06 -04:00
|
|
|
allow(project).to receive(:repository).and_return(repo)
|
2017-07-20 05:34:09 -04:00
|
|
|
allow(project).to receive(:full_path)
|
2017-06-21 09:48:12 -04:00
|
|
|
.and_return('gitlab/gitlab-ci')
|
2016-10-07 11:49:48 -04:00
|
|
|
allow(request).to receive(:format=)
|
2012-09-20 13:55:14 -04:00
|
|
|
end
|
|
|
|
|
2016-10-07 11:49:48 -04:00
|
|
|
describe '#assign_ref_vars' do
|
2015-04-27 00:46:27 -04:00
|
|
|
let(:ref) { sample_commit[:id] }
|
2015-06-22 14:41:00 -04:00
|
|
|
let(:params) { { path: sample_commit[:line_code_path], ref: ref } }
|
2015-04-27 00:46:27 -04:00
|
|
|
|
|
|
|
before do
|
2017-01-24 18:42:12 -05:00
|
|
|
@project = create(:project, :repository)
|
2015-04-27 00:46:27 -04:00
|
|
|
end
|
|
|
|
|
2016-08-01 11:00:44 -04:00
|
|
|
it "log tree path has no escape sequences" do
|
2015-04-27 00:46:27 -04:00
|
|
|
assign_ref_vars
|
2020-01-27 07:08:35 -05:00
|
|
|
expect(@logs_path).to eq("/#{@project.full_path}/-/refs/#{ref}/logs_tree/files/ruby/popen.rb")
|
2015-04-27 00:46:27 -04:00
|
|
|
end
|
2015-08-02 03:07:23 -04:00
|
|
|
|
2016-08-11 07:15:46 -04:00
|
|
|
context 'ref contains %20' do
|
|
|
|
let(:ref) { 'foo%20bar' }
|
|
|
|
|
|
|
|
it 'is not converted to a space in @id' do
|
|
|
|
@project.repository.add_branch(@project.owner, 'foo%20bar', 'master')
|
|
|
|
|
|
|
|
assign_ref_vars
|
|
|
|
|
|
|
|
expect(@id).to start_with('foo%20bar/')
|
|
|
|
end
|
|
|
|
end
|
2016-08-18 16:47:16 -04:00
|
|
|
|
2018-12-26 02:34:47 -05:00
|
|
|
context 'ref contains trailing space' do
|
|
|
|
let(:ref) { 'master ' }
|
|
|
|
|
|
|
|
it 'strips surrounding space' do
|
|
|
|
assign_ref_vars
|
|
|
|
|
|
|
|
expect(@ref).to eq('master')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'ref contains leading space' do
|
|
|
|
let(:ref) { ' master ' }
|
|
|
|
|
|
|
|
it 'strips surrounding space' do
|
|
|
|
assign_ref_vars
|
|
|
|
|
|
|
|
expect(@ref).to eq('master')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'ref contains space in the middle' do
|
|
|
|
let(:ref) { 'master plan ' }
|
|
|
|
|
|
|
|
it 'returns 404' do
|
|
|
|
expect(self).to receive(:render_404)
|
|
|
|
|
|
|
|
assign_ref_vars
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-08-18 16:47:16 -04:00
|
|
|
context 'path contains space' do
|
|
|
|
let(:params) { { path: 'with space', ref: '38008cb17ce1466d8fec2dfa6f6ab8dcfe5cf49e' } }
|
|
|
|
|
|
|
|
it 'is not converted to %20 in @path' do
|
|
|
|
assign_ref_vars
|
|
|
|
|
|
|
|
expect(@path).to eq(params[:path])
|
|
|
|
end
|
|
|
|
end
|
2016-08-23 20:18:38 -04:00
|
|
|
|
|
|
|
context 'subclass overrides get_id' do
|
|
|
|
it 'uses ref returned by get_id' do
|
2019-11-20 01:06:16 -05:00
|
|
|
allow_next_instance_of(self.class) do |instance|
|
|
|
|
allow(instance).to receive(:get_id) { '38008cb17ce1466d8fec2dfa6f6ab8dcfe5cf49e' }
|
|
|
|
end
|
2016-08-23 20:18:38 -04:00
|
|
|
|
|
|
|
assign_ref_vars
|
|
|
|
|
|
|
|
expect(@id).to eq(get_id)
|
|
|
|
end
|
|
|
|
end
|
2016-10-07 11:49:48 -04:00
|
|
|
|
|
|
|
context 'ref only exists without .atom suffix' do
|
|
|
|
context 'with a path' do
|
|
|
|
let(:params) { { ref: 'v1.0.0.atom', path: 'README.md' } }
|
|
|
|
|
|
|
|
it 'renders a 404' do
|
|
|
|
expect(self).to receive(:render_404)
|
|
|
|
|
|
|
|
assign_ref_vars
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'without a path' do
|
|
|
|
let(:params) { { ref: 'v1.0.0.atom' } }
|
2017-06-14 14:18:56 -04:00
|
|
|
|
|
|
|
before do
|
|
|
|
assign_ref_vars
|
|
|
|
end
|
2016-10-07 11:49:48 -04:00
|
|
|
|
|
|
|
it 'sets the un-suffixed version as @ref' do
|
|
|
|
expect(@ref).to eq('v1.0.0')
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'sets the request format to Atom' do
|
|
|
|
expect(request).to have_received(:format=).with(:atom)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'ref exists with .atom suffix' do
|
|
|
|
context 'with a path' do
|
|
|
|
let(:params) { { ref: 'master.atom', path: 'README.md' } }
|
|
|
|
|
|
|
|
before do
|
|
|
|
repository = @project.repository
|
|
|
|
allow(repository).to receive(:commit).and_call_original
|
|
|
|
allow(repository).to receive(:commit).with('master.atom').and_return(repository.commit('master'))
|
|
|
|
|
|
|
|
assign_ref_vars
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'sets the suffixed version as @ref' do
|
|
|
|
expect(@ref).to eq('master.atom')
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not change the request format' do
|
|
|
|
expect(request).not_to have_received(:format=)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'without a path' do
|
|
|
|
let(:params) { { ref: 'master.atom' } }
|
|
|
|
|
|
|
|
before do
|
|
|
|
repository = @project.repository
|
|
|
|
allow(repository).to receive(:commit).and_call_original
|
|
|
|
allow(repository).to receive(:commit).with('master.atom').and_return(repository.commit('master'))
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'sets the suffixed version as @ref' do
|
|
|
|
assign_ref_vars
|
|
|
|
|
|
|
|
expect(@ref).to eq('master.atom')
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not change the request format' do
|
|
|
|
expect(request).not_to receive(:format=)
|
|
|
|
|
|
|
|
assign_ref_vars
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2015-04-27 00:46:27 -04:00
|
|
|
end
|
|
|
|
|
2012-09-20 13:55:14 -04:00
|
|
|
describe '#extract_ref' do
|
|
|
|
it "returns an empty pair when no @project is set" do
|
|
|
|
@project = nil
|
2015-02-12 13:17:35 -05:00
|
|
|
expect(extract_ref('master/CHANGELOG')).to eq(['', ''])
|
2012-09-20 13:55:14 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
context "without a path" do
|
|
|
|
it "extracts a valid branch" do
|
2015-02-12 13:17:35 -05:00
|
|
|
expect(extract_ref('master')).to eq(['master', ''])
|
2012-09-20 13:55:14 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it "extracts a valid tag" do
|
2015-02-12 13:17:35 -05:00
|
|
|
expect(extract_ref('v2.0.0')).to eq(['v2.0.0', ''])
|
2012-09-20 13:55:14 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it "extracts a valid commit ref without a path" do
|
2015-02-12 13:17:35 -05:00
|
|
|
expect(extract_ref('f4b14494ef6abf3d144c28e4af0c20143383e062')).to eq(
|
2012-09-20 13:55:14 -04:00
|
|
|
['f4b14494ef6abf3d144c28e4af0c20143383e062', '']
|
2015-02-12 13:17:35 -05:00
|
|
|
)
|
2012-09-20 13:55:14 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it "falls back to a primitive split for an invalid ref" do
|
2015-02-12 13:17:35 -05:00
|
|
|
expect(extract_ref('stable')).to eq(['stable', ''])
|
2012-09-20 13:55:14 -04:00
|
|
|
end
|
2015-06-21 11:26:37 -04:00
|
|
|
|
|
|
|
it "extracts the longest matching ref" do
|
|
|
|
expect(extract_ref('release/app/v1.0.0/README.md')).to eq(
|
|
|
|
['release/app/v1.0.0', 'README.md'])
|
|
|
|
end
|
2012-09-20 13:55:14 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
context "with a path" do
|
|
|
|
it "extracts a valid branch" do
|
2015-06-21 11:26:37 -04:00
|
|
|
expect(extract_ref('foo/bar/baz/CHANGELOG')).to eq(
|
|
|
|
['foo/bar/baz', 'CHANGELOG'])
|
2012-09-20 13:55:14 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it "extracts a valid tag" do
|
2015-02-12 13:17:35 -05:00
|
|
|
expect(extract_ref('v2.0.0/CHANGELOG')).to eq(['v2.0.0', 'CHANGELOG'])
|
2012-09-20 13:55:14 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it "extracts a valid commit SHA" do
|
2015-02-12 13:17:35 -05:00
|
|
|
expect(extract_ref('f4b14494ef6abf3d144c28e4af0c20143383e062/CHANGELOG')).to eq(
|
2017-02-22 12:46:57 -05:00
|
|
|
%w(f4b14494ef6abf3d144c28e4af0c20143383e062 CHANGELOG)
|
2015-02-12 13:17:35 -05:00
|
|
|
)
|
2012-09-20 13:55:14 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it "falls back to a primitive split for an invalid ref" do
|
2017-02-22 12:46:57 -05:00
|
|
|
expect(extract_ref('stable/CHANGELOG')).to eq(%w(stable CHANGELOG))
|
2012-09-20 13:55:14 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2016-10-07 11:49:48 -04:00
|
|
|
|
|
|
|
describe '#extract_ref_without_atom' do
|
|
|
|
it 'ignores any matching refs suffixed with atom' do
|
|
|
|
expect(extract_ref_without_atom('master.atom')).to eq('master')
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns the longest matching ref' do
|
|
|
|
expect(extract_ref_without_atom('release/app/v1.0.0.atom')).to eq('release/app/v1.0.0')
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns nil if there are no matching refs' do
|
|
|
|
expect(extract_ref_without_atom('foo.atom')).to eq(nil)
|
|
|
|
end
|
|
|
|
end
|
2018-07-09 09:29:46 -04:00
|
|
|
|
|
|
|
describe '#lfs_blob_ids' do
|
2018-11-20 07:29:56 -05:00
|
|
|
let(:tag) { @project.repository.add_tag(@project.owner, 'my-annotated-tag', 'master', 'test tag') }
|
|
|
|
let(:ref) { tag.target }
|
|
|
|
let(:params) { { ref: ref, path: 'README.md' } }
|
2018-07-09 09:29:46 -04:00
|
|
|
|
2018-11-20 07:29:56 -05:00
|
|
|
before do
|
|
|
|
@project = create(:project, :repository)
|
2018-07-09 09:29:46 -04:00
|
|
|
end
|
|
|
|
|
2018-11-20 07:29:56 -05:00
|
|
|
it 'handles annotated tags' do
|
|
|
|
assign_ref_vars
|
2018-07-09 09:29:46 -04:00
|
|
|
|
2018-11-20 07:29:56 -05:00
|
|
|
expect(lfs_blob_ids).to eq([])
|
2018-07-09 09:29:46 -04:00
|
|
|
end
|
|
|
|
end
|
2012-09-20 13:55:14 -04:00
|
|
|
end
|