gitlab-org--gitlab-foss/app/validators/sha_validator.rb

# frozen_string_literal: true

class ShaValidator < ActiveModel::EachValidator
  def validate_each(record, attribute, value)
    return if value.blank? || Commit.valid_hash?(value)

    record.errors.add(attribute, 'is not a valid SHA')
  end
end
Arbitrary file read via MergeRequestDiff 2019-03-04 18:36:34 +00:00			`# frozen_string_literal: true`

			`class ShaValidator < ActiveModel::EachValidator`
			`def validate_each(record, attribute, value)`
Fix Bitbucket import In https://gitlab.com/gitlab-org/gitlab-ce/commit/ebf16ada856efb85424a98848c141f21e609886a we introduced a SHA validator, to ensure that the data provided in merge request diffs, was legit. Nevertheless, the validator assumed that the SHA should be 40 chars long. When we import a project from BitBucket, the retrieved SHA is shorter (12 chars long). Therefore, this validator prevented to create a valid MergeRequestDiff for ever MergeRequest (triggering an exception). 2019-03-14 10:05:17 +00:00			`return if value.blank? \|\| Commit.valid_hash?(value)`
Arbitrary file read via MergeRequestDiff 2019-03-04 18:36:34 +00:00
			`record.errors.add(attribute, 'is not a valid SHA')`
			`end`
			`end`