gitlab-org--gitlab-foss/spec/requests/api/applications_spec.rb

153 lines
5.6 KiB
Ruby
Raw Normal View History

2017-01-04 17:07:49 -05:00
require 'spec_helper'
describe API::Applications, :api do
include ApiHelpers
let(:admin_user) { create(:user, admin: true) }
let(:user) { create(:user, admin: false) }
2018-10-11 11:25:52 -04:00
let!(:application) { create(:application, name: 'another_application', redirect_uri: 'http://other_application.url', scopes: '') }
2017-01-04 17:07:49 -05:00
describe 'POST /applications' do
context 'authenticated and authorized user' do
it 'creates and returns an OAuth application' do
expect do
post api('/applications', admin_user), params: { name: 'application_name', redirect_uri: 'http://application.url', scopes: '' }
2017-01-04 17:07:49 -05:00
end.to change { Doorkeeper::Application.count }.by 1
application = Doorkeeper::Application.find_by(name: 'application_name', redirect_uri: 'http://application.url')
expect(response).to have_gitlab_http_status(201)
2017-01-04 17:07:49 -05:00
expect(json_response).to be_a Hash
expect(json_response['application_id']).to eq application.uid
expect(json_response['secret']).to eq application.secret
expect(json_response['callback_url']).to eq application.redirect_uri
end
it 'does not allow creating an application with the wrong redirect_uri format' do
expect do
post api('/applications', admin_user), params: { name: 'application_name', redirect_uri: 'http://', scopes: '' }
2017-01-04 17:07:49 -05:00
end.not_to change { Doorkeeper::Application.count }
expect(response).to have_gitlab_http_status(400)
2017-01-04 17:07:49 -05:00
expect(json_response).to be_a Hash
expect(json_response['message']['redirect_uri'][0]).to eq('must be an absolute URI.')
end
it 'does not allow creating an application with a forbidden URI format' do
expect do
post api('/applications', admin_user), params: { name: 'application_name', redirect_uri: 'javascript://alert()', scopes: '' }
end.not_to change { Doorkeeper::Application.count }
expect(response).to have_gitlab_http_status(400)
expect(json_response).to be_a Hash
expect(json_response['message']['redirect_uri'][0]).to eq('is forbidden by the server.')
end
2017-01-04 17:07:49 -05:00
it 'does not allow creating an application without a name' do
expect do
post api('/applications', admin_user), params: { redirect_uri: 'http://application.url', scopes: '' }
2017-01-04 17:07:49 -05:00
end.not_to change { Doorkeeper::Application.count }
expect(response).to have_gitlab_http_status(400)
2017-01-04 17:07:49 -05:00
expect(json_response).to be_a Hash
expect(json_response['error']).to eq('name is missing')
end
it 'does not allow creating an application without a redirect_uri' do
expect do
post api('/applications', admin_user), params: { name: 'application_name', scopes: '' }
2017-01-04 17:07:49 -05:00
end.not_to change { Doorkeeper::Application.count }
expect(response).to have_gitlab_http_status(400)
2017-01-04 17:07:49 -05:00
expect(json_response).to be_a Hash
expect(json_response['error']).to eq('redirect_uri is missing')
end
it 'does not allow creating an application without scopes' do
expect do
post api('/applications', admin_user), params: { name: 'application_name', redirect_uri: 'http://application.url' }
2017-01-04 17:07:49 -05:00
end.not_to change { Doorkeeper::Application.count }
expect(response).to have_gitlab_http_status(400)
2017-01-04 17:07:49 -05:00
expect(json_response).to be_a Hash
expect(json_response['error']).to eq('scopes is missing')
end
end
context 'authorized user without authorization' do
it 'does not create application' do
expect do
post api('/applications', user), params: { name: 'application_name', redirect_uri: 'http://application.url', scopes: '' }
2017-01-04 17:07:49 -05:00
end.not_to change { Doorkeeper::Application.count }
expect(response).to have_gitlab_http_status(403)
2017-01-04 17:07:49 -05:00
end
end
context 'non-authenticated user' do
it 'does not create application' do
expect do
post api('/applications'), params: { name: 'application_name', redirect_uri: 'http://application.url' }
2017-01-04 17:07:49 -05:00
end.not_to change { Doorkeeper::Application.count }
expect(response).to have_gitlab_http_status(401)
2017-01-04 17:07:49 -05:00
end
end
end
describe 'GET /applications' do
context 'authenticated and authorized user' do
it 'can list application' do
2018-10-11 08:12:25 -04:00
get api('/applications', admin_user)
expect(response).to have_gitlab_http_status(200)
expect(json_response).to be_a(Array)
end
end
context 'authorized user without authorization' do
it 'cannot list application' do
get api('/applications', user)
expect(response).to have_gitlab_http_status(403)
end
end
context 'non-authenticated user' do
it 'cannot list application' do
get api('/applications')
expect(response).to have_gitlab_http_status(401)
end
end
end
describe 'DELETE /applications/:id' do
context 'authenticated and authorized user' do
it 'can delete an application' do
2018-10-11 08:12:25 -04:00
expect do
delete api("/applications/#{application.id}", admin_user)
end.to change { Doorkeeper::Application.count }.by(-1)
expect(response).to have_gitlab_http_status(204)
end
end
context 'authorized user without authorization' do
it 'cannot delete an application' do
2018-10-11 08:12:25 -04:00
delete api("/applications/#{application.id}", user)
expect(response).to have_gitlab_http_status(403)
end
end
context 'non-authenticated user' do
it 'cannot delete an application' do
delete api("/applications/#{application.id}")
expect(response).to have_gitlab_http_status(401)
end
end
end
2017-01-04 17:07:49 -05:00
end