gitlab-org--gitlab-foss/app/workers/new_note_worker.rb

class NewNoteWorker
  include Sidekiq::Worker
  include DedicatedSidekiqQueue

  # Keep extra parameter to preserve backwards compatibility with
  # old `NewNoteWorker` jobs (can remove later)
  def perform(note_id, _params = {})
    if note = Note.find_by(id: note_id)
      NotificationService.new.new_note(note)
      Notes::PostProcessService.new(note).execute
    else
      Rails.logger.error("NewNoteWorker: couldn't find note with ID=#{note_id}, skipping job")
    end
  end
end
[WIP] Background process note logic for #3948 2016-01-27 10:59:16 -05:00			`class NewNoteWorker`
			`include Sidekiq::Worker`
Re-organize queues to use for Sidekiq Dumping too many jobs in the same queue (e.g. the "default" queue) is a dangerous setup. Jobs that take a long time to process can effectively block any other work from being performed given there are enough of these jobs. Furthermore it becomes harder to monitor the jobs as a single queue could contain jobs for different workers. In such a setup the only reliable way of getting counts per job is to iterate over all jobs in a queue, which is a rather time consuming process. By using separate queues for various workers we have better control over throughput, we can add weight to queues, and we can monitor queues better. Some workers still use the same queue whenever their work is related. For example, the various CI pipeline workers use the same "pipeline" queue. This commit includes a Rails migration that moves Sidekiq jobs from the old queues to the new ones. This migration also takes care of doing the inverse if ever needed. This does require downtime as otherwise new jobs could be scheduled in the old queues after this migration completes. This commit also includes an RSpec test that blacklists the use of the "default" queue and ensures cron workers use the "cronjob" queue. Fixes gitlab-org/gitlab-ce#23370 2016-10-21 12:13:41 -04:00			`include DedicatedSidekiqQueue`
[WIP] Background process note logic for #3948 2016-01-27 10:59:16 -05:00
Preserve optional second parameter in NewNoteWorker jobs If there are any old or retries in the Sidekiq queue, NewNoteWorker will fail with the error: wrong number of arguments (given 2, expected 1) This change allows the optional second argument to be used to preserve backwards compatibility. It can be removed later. Closes #24678 2016-11-19 13:18:44 -05:00			`# Keep extra parameter to preserve backwards compatibility with`
			# old `NewNoteWorker` jobs (can remove later)
			`def perform(note_id, _params = {})`
Does not raise error when Note not found when processing NewNoteWorker - Also remove unnecessary param 2016-10-13 11:26:44 -04:00			`if note = Note.find_by(id: note_id)`
			`NotificationService.new.new_note(note)`
			`Notes::PostProcessService.new(note).execute`
			`else`
			`Rails.logger.error("NewNoteWorker: couldn't find note with ID=#{note_id}, skipping job")`
			`end`
[WIP] Background process note logic for #3948 2016-01-27 10:59:16 -05:00			`end`
			`end`