2016-05-14 20:45:48 -04:00
|
|
|
require 'spec_helper'
|
|
|
|
|
|
|
|
describe JwtController do
|
2016-05-15 01:33:06 -04:00
|
|
|
let(:service) { double(execute: {}) }
|
|
|
|
let(:service_class) { double(new: service) }
|
|
|
|
let(:service_name) { 'test' }
|
|
|
|
let(:parameters) { { service: service_name } }
|
2016-05-14 20:45:48 -04:00
|
|
|
|
2016-05-15 01:33:06 -04:00
|
|
|
before { stub_const('JwtController::SERVICES', service_name => service_class) }
|
2016-05-14 20:45:48 -04:00
|
|
|
|
|
|
|
context 'existing service' do
|
|
|
|
subject! { get '/jwt/auth', parameters }
|
|
|
|
|
2016-06-27 14:10:42 -04:00
|
|
|
it { expect(response).to have_http_status(200) }
|
2016-05-15 01:33:06 -04:00
|
|
|
|
|
|
|
context 'returning custom http code' do
|
|
|
|
let(:service) { double(execute: { http_status: 505 }) }
|
|
|
|
|
2016-06-27 14:10:42 -04:00
|
|
|
it { expect(response).to have_http_status(505) }
|
2016-05-15 01:33:06 -04:00
|
|
|
end
|
2016-05-14 20:45:48 -04:00
|
|
|
end
|
|
|
|
|
2016-11-08 13:37:15 -05:00
|
|
|
context 'when using authenticated request' do
|
2016-05-14 20:45:48 -04:00
|
|
|
context 'using CI token' do
|
2016-09-15 07:49:11 -04:00
|
|
|
let(:build) { create(:ci_build, :running) }
|
|
|
|
let(:project) { build.project }
|
|
|
|
let(:headers) { { authorization: credentials('gitlab-ci-token', build.token) } }
|
2016-05-15 01:33:06 -04:00
|
|
|
|
2016-05-14 20:45:48 -04:00
|
|
|
context 'project with enabled CI' do
|
2016-08-01 18:31:21 -04:00
|
|
|
subject! { get '/jwt/auth', parameters, headers }
|
2016-09-15 07:49:11 -04:00
|
|
|
|
2016-05-15 01:33:06 -04:00
|
|
|
it { expect(service_class).to have_received(:new).with(project, nil, parameters) }
|
2016-05-14 20:45:48 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'project with disabled CI' do
|
2016-08-01 18:31:21 -04:00
|
|
|
before do
|
|
|
|
project.project_feature.update_attribute(:builds_access_level, ProjectFeature::DISABLED)
|
|
|
|
end
|
|
|
|
|
|
|
|
subject! { get '/jwt/auth', parameters, headers }
|
2016-05-14 20:45:48 -04:00
|
|
|
|
2016-09-26 06:18:21 -04:00
|
|
|
it { expect(response).to have_http_status(401) }
|
2016-05-14 20:45:48 -04:00
|
|
|
end
|
2017-05-31 09:55:12 -04:00
|
|
|
|
|
|
|
context 'using personal access tokens' do
|
|
|
|
let(:user) { create(:user) }
|
|
|
|
let(:pat) { create(:personal_access_token, user: user, scopes: ['read_registry']) }
|
|
|
|
let(:headers) { { authorization: credentials('personal_access_token', pat.token) } }
|
|
|
|
|
|
|
|
subject! { get '/jwt/auth', parameters, headers }
|
|
|
|
|
|
|
|
it 'authenticates correctly' do
|
|
|
|
expect(response).to have_http_status(200)
|
|
|
|
expect(service_class).to have_received(:new).with(nil, user, parameters)
|
|
|
|
end
|
|
|
|
end
|
2016-05-14 20:45:48 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'using User login' do
|
|
|
|
let(:user) { create(:user) }
|
2016-09-15 17:27:01 -04:00
|
|
|
let(:headers) { { authorization: credentials(user.username, user.password) } }
|
2016-05-14 20:45:48 -04:00
|
|
|
|
2016-05-15 01:33:06 -04:00
|
|
|
subject! { get '/jwt/auth', parameters, headers }
|
2016-05-14 20:45:48 -04:00
|
|
|
|
2016-05-15 01:33:06 -04:00
|
|
|
it { expect(service_class).to have_received(:new).with(nil, user, parameters) }
|
2016-09-15 16:17:12 -04:00
|
|
|
|
|
|
|
context 'when user has 2FA enabled' do
|
|
|
|
let(:user) { create(:user, :two_factor) }
|
|
|
|
|
|
|
|
context 'without personal token' do
|
|
|
|
it 'rejects the authorization attempt' do
|
|
|
|
expect(response).to have_http_status(401)
|
2017-06-07 15:49:45 -04:00
|
|
|
expect(response.body).to include('You must use a personal access token with \'api\' scope for Git over HTTP')
|
2016-09-15 16:17:12 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with personal token' do
|
|
|
|
let(:access_token) { create(:personal_access_token, user: user) }
|
|
|
|
let(:headers) { { authorization: credentials(user.username, access_token.token) } }
|
|
|
|
|
2016-11-08 13:37:15 -05:00
|
|
|
it 'accepts the authorization attempt' do
|
2016-09-15 16:17:12 -04:00
|
|
|
expect(response).to have_http_status(200)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2016-05-14 20:45:48 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'using invalid login' do
|
2016-05-15 01:33:06 -04:00
|
|
|
let(:headers) { { authorization: credentials('invalid', 'password') } }
|
2016-05-14 20:45:48 -04:00
|
|
|
|
2017-06-07 15:49:45 -04:00
|
|
|
context 'when internal auth is enabled' do
|
|
|
|
it 'rejects the authorization attempt' do
|
|
|
|
get '/jwt/auth', parameters, headers
|
|
|
|
|
|
|
|
expect(response).to have_http_status(401)
|
|
|
|
expect(response.body).not_to include('You must use a personal access token with \'api\' scope for Git over HTTP')
|
|
|
|
end
|
|
|
|
end
|
2016-05-14 20:45:48 -04:00
|
|
|
|
2017-06-07 15:49:45 -04:00
|
|
|
context 'when internal auth is disabled' do
|
|
|
|
it 'rejects the authorization attempt with personal access token message' do
|
|
|
|
allow_any_instance_of(ApplicationSetting).to receive(:signin_enabled?) { false }
|
|
|
|
get '/jwt/auth', parameters, headers
|
|
|
|
|
|
|
|
expect(response).to have_http_status(401)
|
|
|
|
expect(response.body).to include('You must use a personal access token with \'api\' scope for Git over HTTP')
|
|
|
|
end
|
|
|
|
end
|
2016-05-14 20:45:48 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-11-08 13:37:15 -05:00
|
|
|
context 'when using unauthenticated request' do
|
|
|
|
it 'accepts the authorization attempt' do
|
|
|
|
get '/jwt/auth', parameters
|
|
|
|
|
|
|
|
expect(response).to have_http_status(200)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'allows read access' do
|
2017-06-06 07:18:01 -04:00
|
|
|
expect(service).to receive(:execute).with(authentication_abilities: Gitlab::Auth.read_authentication_abilities)
|
2016-11-08 13:37:15 -05:00
|
|
|
|
|
|
|
get '/jwt/auth', parameters
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-05-14 20:45:48 -04:00
|
|
|
context 'unknown service' do
|
|
|
|
subject! { get '/jwt/auth', service: 'unknown' }
|
|
|
|
|
2016-06-27 14:10:42 -04:00
|
|
|
it { expect(response).to have_http_status(404) }
|
2016-05-14 20:45:48 -04:00
|
|
|
end
|
|
|
|
|
2016-05-15 01:33:06 -04:00
|
|
|
def credentials(login, password)
|
2016-05-14 20:45:48 -04:00
|
|
|
ActionController::HttpAuthentication::Basic.encode_credentials(login, password)
|
|
|
|
end
|
|
|
|
end
|