2014-05-23 08:22:00 +00:00
|
|
|
require 'carrierwave/orm/activerecord'
|
|
|
|
|
2011-10-08 21:36:38 +00:00
|
|
|
class Issue < ActiveRecord::Base
|
2013-08-21 09:16:26 +00:00
|
|
|
include InternalId
|
2015-05-03 03:11:21 +00:00
|
|
|
include Issuable
|
|
|
|
include Referable
|
2015-02-06 00:49:41 +00:00
|
|
|
include Sortable
|
2016-07-21 23:11:53 +00:00
|
|
|
include Spammable
|
2016-08-08 14:18:13 +00:00
|
|
|
include FasterCacheKeys
|
2017-02-01 18:41:01 +00:00
|
|
|
include RelativePositioning
|
2012-06-07 12:44:57 +00:00
|
|
|
|
2016-04-19 11:03:28 +00:00
|
|
|
DueDateStruct = Struct.new(:title, :name).freeze
|
|
|
|
NoDueDate = DueDateStruct.new('No Due Date', '0').freeze
|
|
|
|
AnyDueDate = DueDateStruct.new('Any Due Date', '').freeze
|
|
|
|
Overdue = DueDateStruct.new('Overdue', 'overdue').freeze
|
|
|
|
DueThisWeek = DueDateStruct.new('Due This Week', 'week').freeze
|
|
|
|
DueThisMonth = DueDateStruct.new('Due This Month', 'month').freeze
|
2016-03-10 14:26:56 +00:00
|
|
|
|
2013-04-25 14:15:33 +00:00
|
|
|
belongs_to :project
|
2016-03-17 09:31:17 +00:00
|
|
|
belongs_to :moved_to, class_name: 'Issue'
|
|
|
|
|
2016-07-01 13:34:10 +00:00
|
|
|
has_many :events, as: :target, dependent: :destroy
|
|
|
|
|
2016-09-20 19:52:20 +00:00
|
|
|
has_many :merge_requests_closing_issues, class_name: 'MergeRequestsClosingIssues', dependent: :delete_all
|
Improve performance of the cycle analytics page.
1. These changes bring down page load time for 100 issues from more than
a minute to about 1.5 seconds.
2. This entire commit is composed of these types of performance
enhancements:
- Cache relevant data in `IssueMetrics` wherever possible.
- Cache relevant data in `MergeRequestMetrics` wherever possible.
- Preload metrics
3. Given these improvements, we now only need to make 4 SQL calls:
- Load all issues
- Load all merge requests
- Load all metrics for the issues
- Load all metrics for the merge requests
4. A list of all the data points that are now being pre-calculated:
a. The first time an issue is mentioned in a commit
- In `GitPushService`, find all issues mentioned by the given commit
using `ReferenceExtractor`. Set the `first_mentioned_in_commit_at`
flag for each of them.
- There seems to be a (pre-existing) bug here - files (and
therefore commits) created using the Web CI don't have
cross-references created, and issues are not closed even when
the commit title is "Fixes #xx".
b. The first time a merge request is deployed to production
When a `Deployment` is created, find all merge requests that
were merged in before the deployment, and set the
`first_deployed_to_production_at` flag for each of them.
c. The start / end time for a merge request pipeline
Hook into the `Pipeline` state machine. When the `status` moves to
`running`, find the merge requests whose tip commit matches the
pipeline, and record the `latest_build_started_at` time for each
of them. When the `status` moves to `success`, record the
`latest_build_finished_at` time.
d. The merge requests that close an issue
- This was a big cause of the performance problems we were having
with Cycle Analytics. We need to use `ReferenceExtractor` to make
this calculation, which is slow when we have to run it on a large
number of merge requests.
- When a merge request is created, updated, or refreshed, find the
issues it closes, and create an instance of
`MergeRequestsClosingIssues`, which acts as a join model between
merge requests and issues.
- If a `MergeRequestsClosingIssues` instance links a merge request
and an issue, that issue closes that merge request.
5. The `Queries` module was changed into a class, so we can cache the
results of `issues` and `merge_requests_closing_issues` across
various cycle analytics stages.
6. The code added in this commit is untested. Tests will be added in the
next commit.
2016-09-15 08:59:36 +00:00
|
|
|
|
2013-04-25 14:15:33 +00:00
|
|
|
validates :project, presence: true
|
|
|
|
|
2013-04-02 22:28:12 +00:00
|
|
|
scope :cared, ->(user) { where(assignee_id: user) }
|
2013-06-17 10:29:50 +00:00
|
|
|
scope :open_for, ->(user) { opened.assigned_to(user) }
|
2016-01-22 09:24:38 +00:00
|
|
|
scope :in_projects, ->(project_ids) { where(project_id: project_ids) }
|
2013-02-19 09:01:19 +00:00
|
|
|
|
2016-04-20 12:41:50 +00:00
|
|
|
scope :without_due_date, -> { where(due_date: nil) }
|
|
|
|
scope :due_before, ->(date) { where('issues.due_date < ?', date) }
|
|
|
|
scope :due_between, ->(from_date, to_date) { where('issues.due_date >= ?', from_date).where('issues.due_date <= ?', to_date) }
|
|
|
|
|
2016-04-19 11:10:25 +00:00
|
|
|
scope :order_due_date_asc, -> { reorder('issues.due_date IS NULL, issues.due_date ASC') }
|
|
|
|
scope :order_due_date_desc, -> { reorder('issues.due_date IS NULL, issues.due_date DESC') }
|
|
|
|
|
2016-09-20 19:17:37 +00:00
|
|
|
scope :created_after, -> (datetime) { where("created_at >= ?", datetime) }
|
|
|
|
|
2016-12-19 21:26:15 +00:00
|
|
|
scope :include_associations, -> { includes(:assignee, :labels, project: :namespace) }
|
|
|
|
|
2016-08-05 22:10:08 +00:00
|
|
|
attr_spammable :title, spam_title: true
|
|
|
|
attr_spammable :description, spam_description: true
|
2016-07-29 00:02:56 +00:00
|
|
|
|
2013-02-18 13:22:18 +00:00
|
|
|
state_machine :state, initial: :opened do
|
2013-02-18 09:10:58 +00:00
|
|
|
event :close do
|
|
|
|
transition [:reopened, :opened] => :closed
|
|
|
|
end
|
|
|
|
|
|
|
|
event :reopen do
|
2013-02-18 13:22:18 +00:00
|
|
|
transition closed: :reopened
|
2013-02-18 09:10:58 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
state :opened
|
|
|
|
state :reopened
|
|
|
|
state :closed
|
|
|
|
end
|
2013-04-09 12:04:31 +00:00
|
|
|
|
2015-05-14 20:59:39 +00:00
|
|
|
def hook_attrs
|
2017-03-14 16:56:15 +00:00
|
|
|
attrs = {
|
|
|
|
total_time_spent: total_time_spent,
|
|
|
|
human_total_time_spent: human_total_time_spent,
|
|
|
|
human_time_estimate: human_time_estimate
|
|
|
|
}
|
|
|
|
|
|
|
|
attributes.merge!(attrs)
|
2015-05-14 20:59:39 +00:00
|
|
|
end
|
|
|
|
|
2015-05-03 03:11:21 +00:00
|
|
|
def self.reference_prefix
|
|
|
|
'#'
|
|
|
|
end
|
|
|
|
|
2015-05-14 20:59:39 +00:00
|
|
|
# Pattern used to extract `#123` issue references from text
|
|
|
|
#
|
|
|
|
# This pattern supports cross-project references.
|
|
|
|
def self.reference_pattern
|
2016-03-24 15:41:48 +00:00
|
|
|
@reference_pattern ||= %r{
|
2015-12-01 14:51:27 +00:00
|
|
|
(#{Project.reference_pattern})?
|
|
|
|
#{Regexp.escape(reference_prefix)}(?<issue>\d+)
|
2015-05-14 20:59:39 +00:00
|
|
|
}x
|
2014-09-15 07:10:35 +00:00
|
|
|
end
|
|
|
|
|
2015-11-30 20:14:46 +00:00
|
|
|
def self.link_reference_pattern
|
2016-03-24 15:41:48 +00:00
|
|
|
@link_reference_pattern ||= super("issues", /(?<issue>\d+)/)
|
2015-11-30 20:14:46 +00:00
|
|
|
end
|
|
|
|
|
2016-06-18 17:55:45 +00:00
|
|
|
def self.reference_valid?(reference)
|
|
|
|
reference.to_i > 0 && reference.to_i <= Gitlab::Database::MAX_INT_VALUE
|
|
|
|
end
|
|
|
|
|
2016-10-19 13:49:07 +00:00
|
|
|
def self.project_foreign_key
|
|
|
|
'project_id'
|
|
|
|
end
|
|
|
|
|
2016-05-13 15:26:18 +00:00
|
|
|
def self.sort(method, excluded_labels: [])
|
2016-04-19 11:10:25 +00:00
|
|
|
case method.to_s
|
|
|
|
when 'due_date_asc' then order_due_date_asc
|
2016-05-13 15:26:18 +00:00
|
|
|
when 'due_date_desc' then order_due_date_desc
|
2016-04-19 11:10:25 +00:00
|
|
|
else
|
|
|
|
super
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-03-07 16:04:44 +00:00
|
|
|
def self.order_by_position_and_priority
|
|
|
|
order_labels_priority.
|
|
|
|
reorder(Gitlab::Database.nulls_last_order('relative_position', 'ASC'),
|
|
|
|
Gitlab::Database.nulls_last_order('highest_priority', 'ASC'),
|
|
|
|
"id DESC")
|
|
|
|
end
|
|
|
|
|
2017-01-11 12:44:12 +00:00
|
|
|
# `from` argument can be a Namespace or Project.
|
2017-01-10 23:52:25 +00:00
|
|
|
def to_reference(from = nil, full: false)
|
2015-05-03 03:11:21 +00:00
|
|
|
reference = "#{self.class.reference_prefix}#{iid}"
|
|
|
|
|
2017-01-10 23:52:25 +00:00
|
|
|
"#{project.to_reference(from, full: full)}#{reference}"
|
2015-05-03 03:11:21 +00:00
|
|
|
end
|
|
|
|
|
2016-01-12 17:10:06 +00:00
|
|
|
def referenced_merge_requests(current_user = nil)
|
2016-05-26 11:38:28 +00:00
|
|
|
ext = all_references(current_user)
|
|
|
|
|
|
|
|
notes_with_associations.each do |object|
|
|
|
|
object.all_references(current_user, extractor: ext)
|
2016-02-22 08:20:04 +00:00
|
|
|
end
|
2016-05-26 11:38:28 +00:00
|
|
|
|
|
|
|
ext.merge_requests.sort_by(&:iid)
|
2015-12-04 19:00:07 +00:00
|
|
|
end
|
|
|
|
|
2016-04-12 06:13:15 +00:00
|
|
|
# All branches containing the current issue's ID, except for
|
2016-04-15 04:20:53 +00:00
|
|
|
# those with a merge request open referencing the current issue.
|
2016-04-12 06:13:15 +00:00
|
|
|
def related_branches(current_user)
|
|
|
|
branches_with_iid = project.repository.branch_names.select do |branch|
|
2016-04-13 19:20:03 +00:00
|
|
|
branch =~ /\A#{iid}-(?!\d+-stable)/i
|
2016-03-18 11:47:36 +00:00
|
|
|
end
|
2016-04-12 06:13:15 +00:00
|
|
|
|
|
|
|
branches_with_merge_request = self.referenced_merge_requests(current_user).map(&:source_branch)
|
|
|
|
|
|
|
|
branches_with_iid - branches_with_merge_request
|
2016-02-12 18:42:25 +00:00
|
|
|
end
|
|
|
|
|
2014-09-20 14:06:35 +00:00
|
|
|
# To allow polymorphism with MergeRequest.
|
|
|
|
def source_project
|
|
|
|
project
|
|
|
|
end
|
2015-10-12 10:04:20 +00:00
|
|
|
|
|
|
|
# From all notes on this issue, we'll select the system notes about linked
|
|
|
|
# merge requests. Of those, the MRs closing `self` are returned.
|
2016-09-19 05:46:43 +00:00
|
|
|
def closed_by_merge_requests(current_user = nil)
|
2016-09-20 09:36:54 +00:00
|
|
|
return [] unless open?
|
2015-10-13 07:41:46 +00:00
|
|
|
|
2016-05-26 11:38:28 +00:00
|
|
|
ext = all_references(current_user)
|
|
|
|
|
|
|
|
notes.system.each do |note|
|
|
|
|
note.all_references(current_user, extractor: ext)
|
|
|
|
end
|
|
|
|
|
2016-10-19 12:30:17 +00:00
|
|
|
merge_requests = ext.merge_requests.select(&:open?)
|
|
|
|
if merge_requests.any?
|
|
|
|
ids = MergeRequestsClosingIssues.where(merge_request_id: merge_requests.map(&:id), issue_id: id).pluck(:merge_request_id)
|
|
|
|
merge_requests.select { |mr| mr.id.in?(ids) }
|
|
|
|
else
|
|
|
|
[]
|
|
|
|
end
|
2015-10-12 10:04:20 +00:00
|
|
|
end
|
2016-02-12 18:42:25 +00:00
|
|
|
|
2016-03-17 10:11:22 +00:00
|
|
|
def moved?
|
|
|
|
!moved_to.nil?
|
|
|
|
end
|
|
|
|
|
|
|
|
def can_move?(user, to_project = nil)
|
|
|
|
if to_project
|
|
|
|
return false unless user.can?(:admin_issue, to_project)
|
|
|
|
end
|
|
|
|
|
2016-03-23 08:39:37 +00:00
|
|
|
!moved? && persisted? &&
|
|
|
|
user.can?(:admin_issue, self.project)
|
2016-03-17 10:11:22 +00:00
|
|
|
end
|
2016-03-19 17:50:15 +00:00
|
|
|
|
2016-02-12 18:42:25 +00:00
|
|
|
def to_branch_name
|
2016-04-12 04:29:01 +00:00
|
|
|
if self.confidential?
|
2016-04-19 03:52:55 +00:00
|
|
|
"#{iid}-confidential-issue"
|
2016-04-12 04:29:01 +00:00
|
|
|
else
|
2016-04-15 04:20:53 +00:00
|
|
|
"#{iid}-#{title.parameterize}"
|
2016-04-12 04:29:01 +00:00
|
|
|
end
|
2016-02-12 18:42:25 +00:00
|
|
|
end
|
|
|
|
|
2016-02-17 06:11:48 +00:00
|
|
|
def can_be_worked_on?(current_user)
|
2016-02-12 18:42:25 +00:00
|
|
|
!self.closed? &&
|
2016-02-17 06:11:48 +00:00
|
|
|
!self.project.forked? &&
|
2016-04-12 06:13:15 +00:00
|
|
|
self.related_branches(current_user).empty? &&
|
2016-03-15 19:17:51 +00:00
|
|
|
self.closed_by_merge_requests(current_user).empty?
|
2016-02-12 18:42:25 +00:00
|
|
|
end
|
2016-03-18 17:59:57 +00:00
|
|
|
|
2016-07-20 18:13:02 +00:00
|
|
|
# Returns `true` if the current issue can be viewed by either a logged in User
|
|
|
|
# or an anonymous user.
|
|
|
|
def visible_to_user?(user = nil)
|
2016-11-01 20:18:51 +00:00
|
|
|
return false unless project.feature_available?(:issues, user)
|
2016-07-20 18:13:02 +00:00
|
|
|
|
2016-11-01 20:18:51 +00:00
|
|
|
user ? readable_by?(user) : publicly_visible?
|
2016-07-20 18:13:02 +00:00
|
|
|
end
|
|
|
|
|
2016-03-18 17:59:57 +00:00
|
|
|
def overdue?
|
2016-04-19 11:03:28 +00:00
|
|
|
due_date.try(:past?) || false
|
2016-03-18 17:59:57 +00:00
|
|
|
end
|
2016-07-30 04:18:32 +00:00
|
|
|
|
2016-08-05 22:10:08 +00:00
|
|
|
# Only issues on public projects should be checked for spam
|
2016-07-30 04:18:32 +00:00
|
|
|
def check_for_spam?
|
2016-08-09 17:43:47 +00:00
|
|
|
project.public?
|
2016-07-30 04:18:32 +00:00
|
|
|
end
|
2016-10-07 08:24:57 +00:00
|
|
|
|
|
|
|
def as_json(options = {})
|
|
|
|
super(options).tap do |json|
|
2016-11-04 18:19:08 +00:00
|
|
|
json[:subscribed] = subscribed?(options[:user], project) if options.has_key?(:user) && options[:user]
|
2016-10-19 21:33:34 +00:00
|
|
|
|
2016-10-14 23:51:41 +00:00
|
|
|
if options.has_key?(:labels)
|
|
|
|
json[:labels] = labels.as_json(
|
|
|
|
project: project,
|
2016-10-19 21:33:34 +00:00
|
|
|
only: [:id, :title, :description, :color, :priority],
|
2016-10-14 23:51:41 +00:00
|
|
|
methods: [:text_color]
|
|
|
|
)
|
|
|
|
end
|
2016-10-07 08:24:57 +00:00
|
|
|
end
|
|
|
|
end
|
2016-11-01 20:18:51 +00:00
|
|
|
|
|
|
|
private
|
|
|
|
|
|
|
|
# Returns `true` if the given User can read the current Issue.
|
|
|
|
#
|
|
|
|
# This method duplicates the same check of issue_policy.rb
|
|
|
|
# for performance reasons, check commit: 002ad215818450d2cbbc5fa065850a953dc7ada8
|
|
|
|
# Make sure to sync this method with issue_policy.rb
|
|
|
|
def readable_by?(user)
|
|
|
|
if user.admin?
|
|
|
|
true
|
|
|
|
elsif project.owner == user
|
|
|
|
true
|
|
|
|
elsif confidential?
|
|
|
|
author == user ||
|
|
|
|
assignee == user ||
|
|
|
|
project.team.member?(user, Gitlab::Access::REPORTER)
|
|
|
|
else
|
|
|
|
project.public? ||
|
|
|
|
project.internal? && !user.external? ||
|
|
|
|
project.team.member?(user)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
# Returns `true` if this Issue is visible to everybody.
|
|
|
|
def publicly_visible?
|
|
|
|
project.public? && !confidential?
|
|
|
|
end
|
2011-10-08 21:36:38 +00:00
|
|
|
end
|