2018-12-06 16:57:19 +00:00
|
|
|
# frozen_string_literal: true
|
|
|
|
require 'spec_helper'
|
|
|
|
|
2020-06-24 09:08:32 +00:00
|
|
|
RSpec.describe SortingHelper do
|
2018-12-06 16:57:19 +00:00
|
|
|
include ApplicationHelper
|
|
|
|
include IconsHelper
|
2019-06-17 02:08:10 +00:00
|
|
|
include ExploreHelper
|
2018-12-06 16:57:19 +00:00
|
|
|
|
2019-07-09 00:33:30 +00:00
|
|
|
def set_sorting_url(option)
|
|
|
|
allow(self).to receive(:request).and_return(double(path: 'http://test.com', query_parameters: { label_name: option }))
|
|
|
|
end
|
|
|
|
|
2018-12-06 16:57:19 +00:00
|
|
|
describe '#issuable_sort_option_title' do
|
|
|
|
it 'returns correct title for issuable_sort_option_overrides key' do
|
|
|
|
expect(issuable_sort_option_title('created_asc')).to eq('Created date')
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns correct title for a valid sort value' do
|
|
|
|
expect(issuable_sort_option_title('priority')).to eq('Priority')
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns nil for invalid sort value' do
|
|
|
|
expect(issuable_sort_option_title('invalid_key')).to eq(nil)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#issuable_sort_direction_button' do
|
|
|
|
before do
|
2019-07-09 00:33:30 +00:00
|
|
|
set_sorting_url 'test_label'
|
2018-12-11 17:11:08 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'keeps label filter param' do
|
|
|
|
expect(issuable_sort_direction_button('created_date')).to include('label_name=test_label')
|
2018-12-06 16:57:19 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns icon with sort-highest when sort is created_date' do
|
|
|
|
expect(issuable_sort_direction_button('created_date')).to include('sort-highest')
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns icon with sort-lowest when sort is asc' do
|
|
|
|
expect(issuable_sort_direction_button('created_asc')).to include('sort-lowest')
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns icon with sort-lowest when sorting by milestone' do
|
|
|
|
expect(issuable_sort_direction_button('milestone')).to include('sort-lowest')
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns icon with sort-lowest when sorting by due_date' do
|
|
|
|
expect(issuable_sort_direction_button('due_date')).to include('sort-lowest')
|
|
|
|
end
|
|
|
|
end
|
2019-06-17 02:08:10 +00:00
|
|
|
|
2020-10-26 12:08:44 +00:00
|
|
|
describe '#search_sort_direction_button' do
|
|
|
|
before do
|
|
|
|
set_sorting_url 'test_label'
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'keeps label filter param' do
|
|
|
|
expect(search_sort_direction_button('created_asc')).to include('label_name=test_label')
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns icon with sort-lowest when sort is asc' do
|
|
|
|
expect(search_sort_direction_button('created_asc')).to include('sort-lowest')
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns icon with sort-highest when sort is desc' do
|
|
|
|
expect(search_sort_direction_button('created_desc')).to include('sort-highest')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-06-17 02:08:10 +00:00
|
|
|
def stub_controller_path(value)
|
|
|
|
allow(helper.controller).to receive(:controller_path).and_return(value)
|
|
|
|
end
|
|
|
|
|
2019-07-08 06:33:42 +00:00
|
|
|
def project_common_options
|
2019-06-17 02:08:10 +00:00
|
|
|
{
|
|
|
|
sort_value_latest_activity => sort_title_latest_activity,
|
|
|
|
sort_value_recently_created => sort_title_created_date,
|
|
|
|
sort_value_name => sort_title_name,
|
2020-11-23 15:09:37 +00:00
|
|
|
sort_value_name_desc => sort_title_name_desc,
|
2019-06-17 02:08:10 +00:00
|
|
|
sort_value_stars_desc => sort_title_stars
|
|
|
|
}
|
|
|
|
end
|
|
|
|
|
2019-07-08 06:33:42 +00:00
|
|
|
describe 'with `admin/projects` controller' do
|
2019-06-17 02:08:10 +00:00
|
|
|
before do
|
2019-07-09 00:33:30 +00:00
|
|
|
stub_controller_path 'admin/projects'
|
2019-06-17 02:08:10 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
describe '#projects_sort_options_hash' do
|
|
|
|
it 'returns a hash of available sorting options' do
|
2019-07-09 00:33:30 +00:00
|
|
|
admin_options = project_common_options.merge({
|
2019-07-08 06:33:42 +00:00
|
|
|
sort_value_oldest_activity => sort_title_oldest_activity,
|
|
|
|
sort_value_oldest_created => sort_title_oldest_created,
|
|
|
|
sort_value_recently_created => sort_title_recently_created,
|
|
|
|
sort_value_stars_desc => sort_title_most_stars,
|
|
|
|
sort_value_largest_repo => sort_title_largest_repo
|
|
|
|
})
|
2019-07-09 11:31:57 +00:00
|
|
|
|
|
|
|
expect(projects_sort_options_hash).to eq(admin_options)
|
2019-06-17 02:08:10 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-07-08 06:33:42 +00:00
|
|
|
describe 'with `projects` controller' do
|
2019-06-17 02:08:10 +00:00
|
|
|
before do
|
2019-07-09 00:33:30 +00:00
|
|
|
stub_controller_path 'projects'
|
2019-06-17 02:08:10 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
describe '#projects_sort_options_hash' do
|
|
|
|
it 'returns a hash of available sorting options' do
|
2019-07-09 11:31:57 +00:00
|
|
|
expect(projects_sort_options_hash).to include(project_common_options)
|
2019-06-17 02:08:10 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-07-09 00:33:30 +00:00
|
|
|
describe '#projects_reverse_sort_options_hash' do
|
2019-07-09 11:31:57 +00:00
|
|
|
context 'returns a reversed hash of available sorting options' do
|
|
|
|
using RSpec::Parameterized::TableSyntax
|
|
|
|
|
|
|
|
where(:sort_key, :reverse_sort_title) do
|
|
|
|
sort_value_latest_activity | sort_value_oldest_activity
|
|
|
|
sort_value_recently_created | sort_value_oldest_created
|
|
|
|
sort_value_name | sort_value_name_desc
|
|
|
|
sort_value_stars_desc | sort_value_stars_asc
|
|
|
|
sort_value_oldest_activity | sort_value_latest_activity
|
|
|
|
sort_value_oldest_created | sort_value_recently_created
|
|
|
|
sort_value_name_desc | sort_value_name
|
|
|
|
sort_value_stars_asc | sort_value_stars_desc
|
|
|
|
end
|
|
|
|
|
|
|
|
with_them do
|
|
|
|
it do
|
|
|
|
reverse_hash = projects_reverse_sort_options_hash
|
|
|
|
|
|
|
|
expect(reverse_hash).to include(sort_key)
|
|
|
|
expect(reverse_hash[sort_key]).to eq(reverse_sort_title)
|
|
|
|
end
|
2019-06-17 02:08:10 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-07-08 06:33:42 +00:00
|
|
|
describe '#project_sort_direction_button' do
|
2019-07-09 11:31:57 +00:00
|
|
|
context 'returns the correct icon for each sort option' do
|
|
|
|
using RSpec::Parameterized::TableSyntax
|
|
|
|
|
2019-07-09 00:33:30 +00:00
|
|
|
sort_lowest_icon = 'sort-lowest'
|
|
|
|
sort_highest_icon = 'sort-highest'
|
|
|
|
|
2019-07-09 11:31:57 +00:00
|
|
|
where(:selected_sort, :icon) do
|
|
|
|
sort_value_latest_activity | sort_highest_icon
|
|
|
|
sort_value_recently_created | sort_highest_icon
|
|
|
|
sort_value_name_desc | sort_highest_icon
|
|
|
|
sort_value_stars_desc | sort_highest_icon
|
|
|
|
sort_value_oldest_activity | sort_lowest_icon
|
|
|
|
sort_value_oldest_created | sort_lowest_icon
|
|
|
|
sort_value_name | sort_lowest_icon
|
|
|
|
sort_value_stars_asc | sort_lowest_icon
|
|
|
|
end
|
|
|
|
|
|
|
|
with_them do
|
|
|
|
it do
|
|
|
|
set_sorting_url selected_sort
|
2019-07-09 00:33:30 +00:00
|
|
|
|
2019-07-09 11:31:57 +00:00
|
|
|
expect(project_sort_direction_button(selected_sort)).to include(icon)
|
|
|
|
end
|
2019-07-09 00:33:30 +00:00
|
|
|
end
|
|
|
|
end
|
2019-06-17 02:08:10 +00:00
|
|
|
|
2019-07-09 00:33:30 +00:00
|
|
|
it 'returns the correct link to reverse the current sort option' do
|
|
|
|
sort_options_links = projects_reverse_sort_options_hash
|
2019-06-17 02:08:10 +00:00
|
|
|
|
2019-07-09 00:33:30 +00:00
|
|
|
sort_options_links.each do |selected_sort, reverse_sort|
|
|
|
|
set_sorting_url selected_sort
|
2019-07-08 06:33:42 +00:00
|
|
|
|
2019-07-09 00:33:30 +00:00
|
|
|
expect(project_sort_direction_button(selected_sort)).to include(reverse_sort)
|
|
|
|
end
|
|
|
|
end
|
2019-06-17 02:08:10 +00:00
|
|
|
end
|
|
|
|
|
2019-07-08 06:33:42 +00:00
|
|
|
describe '#projects_sort_option_titles' do
|
|
|
|
it 'returns a hash of titles for the sorting options' do
|
2019-07-09 11:31:57 +00:00
|
|
|
options = project_common_options.merge({
|
2019-07-08 06:33:42 +00:00
|
|
|
sort_value_oldest_activity => sort_title_latest_activity,
|
|
|
|
sort_value_oldest_created => sort_title_created_date,
|
|
|
|
sort_value_name_desc => sort_title_name,
|
|
|
|
sort_value_stars_asc => sort_title_stars
|
2019-07-09 11:31:57 +00:00
|
|
|
})
|
2019-07-08 06:33:42 +00:00
|
|
|
|
2019-07-09 11:31:57 +00:00
|
|
|
expect(projects_sort_option_titles).to eq(options)
|
2019-07-08 06:33:42 +00:00
|
|
|
end
|
2019-06-17 02:08:10 +00:00
|
|
|
end
|
|
|
|
|
2019-07-08 06:33:42 +00:00
|
|
|
describe 'with project_list_filter_bar off' do
|
|
|
|
before do
|
|
|
|
stub_feature_flags(project_list_filter_bar: false)
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#projects_sort_options_hash' do
|
|
|
|
it 'returns a hash of available sorting options' do
|
|
|
|
options = project_common_options.merge({
|
|
|
|
sort_value_oldest_activity => sort_title_oldest_activity,
|
|
|
|
sort_value_oldest_created => sort_title_oldest_created,
|
|
|
|
sort_value_recently_created => sort_title_recently_created,
|
|
|
|
sort_value_stars_desc => sort_title_most_stars
|
|
|
|
})
|
|
|
|
|
2019-07-09 11:31:57 +00:00
|
|
|
expect(projects_sort_options_hash).to eq(options)
|
2019-07-08 06:33:42 +00:00
|
|
|
end
|
|
|
|
end
|
2019-06-17 02:08:10 +00:00
|
|
|
end
|
|
|
|
end
|
2018-12-06 16:57:19 +00:00
|
|
|
end
|