2019-04-11 12:17:24 +00:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2016-03-14 10:18:03 +00:00
|
|
|
require 'spec_helper'
|
|
|
|
|
2020-06-24 15:08:50 +00:00
|
|
|
RSpec.describe Users::DestroyService do
|
2020-11-11 12:09:06 +00:00
|
|
|
let!(:user) { create(:user) }
|
|
|
|
let!(:admin) { create(:admin) }
|
|
|
|
let!(:namespace) { user.namespace }
|
|
|
|
let!(:project) { create(:project, namespace: namespace) }
|
|
|
|
let(:service) { described_class.new(admin) }
|
|
|
|
let(:gitlab_shell) { Gitlab::Shell.new }
|
|
|
|
|
2022-11-08 00:10:26 +00:00
|
|
|
describe "Deletes a user and all their personal projects", :enable_admin_mode do
|
|
|
|
context 'no options are given' do
|
|
|
|
it 'creates GhostUserMigration record to handle migration in a worker' do
|
|
|
|
expect { service.execute(user) }
|
|
|
|
.to(
|
|
|
|
change do
|
|
|
|
Users::GhostUserMigration.where(user: user,
|
|
|
|
initiator_user: admin)
|
|
|
|
.exists?
|
|
|
|
end.from(false).to(true))
|
2016-03-14 10:18:03 +00:00
|
|
|
end
|
|
|
|
|
2022-11-08 00:10:26 +00:00
|
|
|
it 'will delete the personal project' do
|
|
|
|
expect_next_instance_of(Projects::DestroyService) do |destroy_service|
|
|
|
|
expect(destroy_service).to receive(:execute).once.and_return(true)
|
2022-09-14 21:13:39 +00:00
|
|
|
end
|
|
|
|
|
2022-11-08 00:10:26 +00:00
|
|
|
service.execute(user)
|
2020-01-14 15:07:55 +00:00
|
|
|
end
|
2022-11-08 00:10:26 +00:00
|
|
|
end
|
2020-01-14 15:07:55 +00:00
|
|
|
|
2022-11-08 00:10:26 +00:00
|
|
|
context 'personal projects in pending_delete' do
|
|
|
|
before do
|
|
|
|
project.pending_delete = true
|
|
|
|
project.save!
|
2016-03-14 10:18:03 +00:00
|
|
|
end
|
2020-02-28 00:09:08 +00:00
|
|
|
|
2022-11-08 00:10:26 +00:00
|
|
|
it 'destroys a personal project in pending_delete' do
|
|
|
|
expect_next_instance_of(Projects::DestroyService) do |destroy_service|
|
|
|
|
expect(destroy_service).to receive(:execute).once.and_return(true)
|
2022-09-14 21:13:39 +00:00
|
|
|
end
|
2020-02-28 00:09:08 +00:00
|
|
|
|
2022-11-08 00:10:26 +00:00
|
|
|
service.execute(user)
|
2022-09-14 21:13:39 +00:00
|
|
|
end
|
2022-11-08 00:10:26 +00:00
|
|
|
end
|
2020-02-28 00:09:08 +00:00
|
|
|
|
2022-11-08 00:10:26 +00:00
|
|
|
context "solo owned groups present" do
|
|
|
|
let(:solo_owned) { create(:group) }
|
|
|
|
let(:member) { create(:group_member) }
|
|
|
|
let(:user) { member.user }
|
2020-02-28 00:09:08 +00:00
|
|
|
|
2022-11-08 00:10:26 +00:00
|
|
|
before do
|
|
|
|
solo_owned.group_members = [member]
|
2020-02-28 00:09:08 +00:00
|
|
|
end
|
|
|
|
|
2022-11-08 00:10:26 +00:00
|
|
|
it 'returns the user with attached errors' do
|
|
|
|
expect(service.execute(user)).to be(user)
|
|
|
|
expect(user.errors.full_messages).to(
|
|
|
|
contain_exactly('You must transfer ownership or delete groups before you can remove user'))
|
2020-02-28 00:09:08 +00:00
|
|
|
end
|
2016-03-14 10:18:03 +00:00
|
|
|
|
2022-11-08 00:10:26 +00:00
|
|
|
it 'does not delete the user, nor the group' do
|
|
|
|
service.execute(user)
|
2017-03-31 23:59:46 +00:00
|
|
|
|
2022-11-08 00:10:26 +00:00
|
|
|
expect(User.find(user.id)).to eq user
|
|
|
|
expect(Group.find(solo_owned.id)).to eq solo_owned
|
2017-03-31 23:59:46 +00:00
|
|
|
end
|
|
|
|
end
|
2016-11-11 06:27:43 +00:00
|
|
|
|
2022-11-08 00:10:26 +00:00
|
|
|
context "deletions with solo owned groups" do
|
|
|
|
let(:solo_owned) { create(:group) }
|
|
|
|
let(:member) { create(:group_member) }
|
|
|
|
let(:user) { member.user }
|
2016-11-11 06:27:43 +00:00
|
|
|
|
2022-11-08 00:10:26 +00:00
|
|
|
before do
|
|
|
|
solo_owned.group_members = [member]
|
|
|
|
service.execute(user, delete_solo_owned_groups: true)
|
2016-03-14 10:18:03 +00:00
|
|
|
end
|
|
|
|
|
2022-11-08 00:10:26 +00:00
|
|
|
it 'deletes solo owned groups' do
|
|
|
|
expect { Group.find(solo_owned.id) }.to raise_error(ActiveRecord::RecordNotFound)
|
2016-03-14 10:18:03 +00:00
|
|
|
end
|
2022-11-08 00:10:26 +00:00
|
|
|
end
|
2016-03-14 10:18:03 +00:00
|
|
|
|
2022-11-08 00:10:26 +00:00
|
|
|
context 'deletions with inherited group owners' do
|
|
|
|
let(:group) { create(:group, :nested) }
|
|
|
|
let(:user) { create(:user) }
|
|
|
|
let(:inherited_owner) { create(:user) }
|
2022-05-26 15:08:29 +00:00
|
|
|
|
2022-11-08 00:10:26 +00:00
|
|
|
before do
|
|
|
|
group.parent.add_owner(inherited_owner)
|
|
|
|
group.add_owner(user)
|
2022-05-26 15:08:29 +00:00
|
|
|
|
2022-11-08 00:10:26 +00:00
|
|
|
service.execute(user, delete_solo_owned_groups: true)
|
2022-05-26 15:08:29 +00:00
|
|
|
end
|
|
|
|
|
2022-11-08 00:10:26 +00:00
|
|
|
it 'does not delete the group' do
|
|
|
|
expect(Group.exists?(id: group)).to be_truthy
|
|
|
|
end
|
|
|
|
end
|
2022-05-26 15:08:29 +00:00
|
|
|
|
2022-11-08 00:10:26 +00:00
|
|
|
describe "user personal's repository removal" do
|
|
|
|
context 'storages' do
|
2022-09-14 21:13:39 +00:00
|
|
|
before do
|
2022-11-08 00:10:26 +00:00
|
|
|
perform_enqueued_jobs { service.execute(user) }
|
2022-09-14 21:13:39 +00:00
|
|
|
end
|
2022-05-26 15:08:29 +00:00
|
|
|
|
2022-11-08 00:10:26 +00:00
|
|
|
context 'legacy storage' do
|
|
|
|
let!(:project) { create(:project, :empty_repo, :legacy_storage, namespace: user.namespace) }
|
2022-09-14 21:13:39 +00:00
|
|
|
|
2022-11-08 00:10:26 +00:00
|
|
|
it 'removes repository' do
|
|
|
|
expect(
|
|
|
|
gitlab_shell.repository_exists?(project.repository_storage,
|
|
|
|
"#{project.disk_path}.git")
|
|
|
|
).to be_falsey
|
2022-09-14 21:13:39 +00:00
|
|
|
end
|
|
|
|
end
|
2017-04-16 15:21:40 +00:00
|
|
|
|
2022-11-08 00:10:26 +00:00
|
|
|
context 'hashed storage' do
|
|
|
|
let!(:project) { create(:project, :empty_repo, namespace: user.namespace) }
|
2022-09-14 21:13:39 +00:00
|
|
|
|
2022-11-08 00:10:26 +00:00
|
|
|
it 'removes repository' do
|
|
|
|
expect(
|
|
|
|
gitlab_shell.repository_exists?(project.repository_storage,
|
|
|
|
"#{project.disk_path}.git")
|
|
|
|
).to be_falsey
|
2018-08-13 11:54:31 +00:00
|
|
|
end
|
|
|
|
end
|
2022-09-14 21:13:39 +00:00
|
|
|
end
|
2017-08-21 13:28:07 +00:00
|
|
|
|
2022-11-08 00:10:26 +00:00
|
|
|
context 'repository removal status is taken into account' do
|
|
|
|
it 'raises exception' do
|
|
|
|
expect_next_instance_of(::Projects::DestroyService) do |destroy_service|
|
|
|
|
expect(destroy_service).to receive(:execute).and_return(false)
|
|
|
|
end
|
2017-08-21 13:28:07 +00:00
|
|
|
|
2022-11-08 00:10:26 +00:00
|
|
|
expect { service.execute(user) }
|
|
|
|
.to raise_error(Users::DestroyService::DestroyError,
|
|
|
|
"Project #{project.id} can't be deleted")
|
2017-08-21 13:28:07 +00:00
|
|
|
end
|
|
|
|
end
|
2018-01-02 15:06:44 +00:00
|
|
|
end
|
2020-11-11 12:09:06 +00:00
|
|
|
|
2022-11-08 00:10:26 +00:00
|
|
|
describe "calls the before/after callbacks" do
|
|
|
|
it 'of project_members' do
|
|
|
|
expect_any_instance_of(ProjectMember).to receive(:run_callbacks).with(:find).once
|
|
|
|
expect_any_instance_of(ProjectMember).to receive(:run_callbacks).with(:initialize).once
|
|
|
|
expect_any_instance_of(ProjectMember).to receive(:run_callbacks).with(:destroy).once
|
2022-09-14 21:13:39 +00:00
|
|
|
|
2022-11-08 00:10:26 +00:00
|
|
|
service.execute(user)
|
2020-11-11 12:09:06 +00:00
|
|
|
end
|
2022-10-14 00:10:41 +00:00
|
|
|
|
2022-11-08 00:10:26 +00:00
|
|
|
it 'of group_members' do
|
|
|
|
group_member = create(:group_member)
|
|
|
|
group_member.group.group_members.create!(user: user, access_level: 40)
|
2022-10-14 00:10:41 +00:00
|
|
|
|
2022-11-08 00:10:26 +00:00
|
|
|
expect_any_instance_of(GroupMember).to receive(:run_callbacks).with(:find).once
|
|
|
|
expect_any_instance_of(GroupMember).to receive(:run_callbacks).with(:initialize).once
|
|
|
|
expect_any_instance_of(GroupMember).to receive(:run_callbacks).with(:destroy).once
|
2022-10-14 00:10:41 +00:00
|
|
|
|
2022-11-08 00:10:26 +00:00
|
|
|
service.execute(user)
|
2022-10-14 00:10:41 +00:00
|
|
|
end
|
2020-11-11 12:09:06 +00:00
|
|
|
end
|
2022-09-14 21:13:39 +00:00
|
|
|
end
|
2020-11-11 12:09:06 +00:00
|
|
|
|
2022-11-08 00:10:26 +00:00
|
|
|
describe "Deletion permission checks" do
|
|
|
|
it 'does not delete the user when user is not an admin' do
|
|
|
|
other_user = create(:user)
|
2022-04-15 00:08:23 +00:00
|
|
|
|
2022-11-08 00:10:26 +00:00
|
|
|
expect { described_class.new(other_user).execute(user) }.to raise_error(Gitlab::Access::AccessDeniedError)
|
2022-04-15 00:08:23 +00:00
|
|
|
|
2022-11-08 00:10:26 +00:00
|
|
|
expect(Users::GhostUserMigration).not_to be_exists
|
|
|
|
end
|
2022-04-15 00:08:23 +00:00
|
|
|
|
2022-11-08 00:10:26 +00:00
|
|
|
context 'when admin mode is enabled', :enable_admin_mode do
|
|
|
|
it 'allows admins to delete anyone' do
|
|
|
|
expect { described_class.new(admin).execute(user) }
|
2022-09-14 21:13:39 +00:00
|
|
|
.to(
|
|
|
|
change do
|
|
|
|
Users::GhostUserMigration.where(user: user,
|
2022-11-08 00:10:26 +00:00
|
|
|
initiator_user: admin)
|
2022-09-14 21:13:39 +00:00
|
|
|
.exists?
|
|
|
|
end.from(false).to(true))
|
|
|
|
end
|
2022-11-08 00:10:26 +00:00
|
|
|
end
|
2022-04-15 00:08:23 +00:00
|
|
|
|
2022-11-08 00:10:26 +00:00
|
|
|
context 'when admin mode is disabled' do
|
|
|
|
it 'disallows admins to delete anyone' do
|
|
|
|
expect { described_class.new(admin).execute(user) }.to raise_error(Gitlab::Access::AccessDeniedError)
|
|
|
|
|
|
|
|
expect(Users::GhostUserMigration).not_to be_exists
|
|
|
|
end
|
|
|
|
end
|
2022-05-12 18:08:38 +00:00
|
|
|
|
2022-11-08 00:10:26 +00:00
|
|
|
it 'allows users to delete their own account' do
|
|
|
|
expect { described_class.new(user).execute(user) }
|
|
|
|
.to(
|
2022-09-14 21:13:39 +00:00
|
|
|
change do
|
2022-11-08 00:10:26 +00:00
|
|
|
Users::GhostUserMigration.where(user: user,
|
2022-10-27 21:09:58 +00:00
|
|
|
initiator_user: user)
|
2022-09-14 21:13:39 +00:00
|
|
|
.exists?
|
|
|
|
end.from(false).to(true))
|
2022-11-08 00:10:26 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'allows user to be deleted if skip_authorization: true' do
|
|
|
|
other_user = create(:user)
|
|
|
|
|
|
|
|
expect do
|
|
|
|
described_class.new(user)
|
|
|
|
.execute(other_user, skip_authorization: true)
|
|
|
|
end.to(
|
|
|
|
change do
|
|
|
|
Users::GhostUserMigration.where(user: other_user,
|
|
|
|
initiator_user: user )
|
|
|
|
.exists?
|
|
|
|
end.from(false).to(true))
|
2022-04-15 00:08:23 +00:00
|
|
|
end
|
|
|
|
end
|
2016-03-14 10:18:03 +00:00
|
|
|
end
|