2019-06-07 09:55:22 -04:00
|
|
|
---
|
|
|
|
type: reference
|
|
|
|
---
|
|
|
|
|
2015-12-19 16:16:50 -05:00
|
|
|
# How we manage the TLS protocol CRIME vulnerability
|
|
|
|
|
2015-12-25 08:23:06 -05:00
|
|
|
> CRIME ("Compression Ratio Info-leak Made Easy") is a security exploit against
|
|
|
|
secret web cookies over connections using the HTTPS and SPDY protocols that also
|
|
|
|
use data compression. When used to recover the content of secret
|
|
|
|
authentication cookies, it allows an attacker to perform session hijacking on an
|
2015-12-19 16:16:50 -05:00
|
|
|
authenticated web session, allowing the launching of further attacks.
|
|
|
|
([CRIME](https://en.wikipedia.org/w/index.php?title=CRIME&oldid=692423806))
|
|
|
|
|
2019-06-07 09:55:22 -04:00
|
|
|
## Description
|
2015-12-19 16:16:50 -05:00
|
|
|
|
2019-06-07 10:33:31 -04:00
|
|
|
The TLS Protocol CRIME Vulnerability affects systems that use data compression
|
|
|
|
over HTTPS. Your system might be vulnerable to the CRIME vulnerability if you use
|
|
|
|
SSL Compression (for example, gzip) or SPDY (which optionally uses compression).
|
2015-12-19 16:16:50 -05:00
|
|
|
|
2015-12-25 08:23:06 -05:00
|
|
|
GitLab supports both gzip and [SPDY][ngx-spdy] and mitigates the CRIME
|
2019-06-07 10:33:31 -04:00
|
|
|
vulnerability by deactivating gzip when HTTPS is enabled. The sources of the
|
|
|
|
files are here:
|
2015-12-19 16:16:50 -05:00
|
|
|
|
2018-11-13 01:07:16 -05:00
|
|
|
- [Source installation NGINX file][source-nginx]
|
|
|
|
- [Omnibus installation NGINX file][omnibus-nginx]
|
2015-12-19 16:16:50 -05:00
|
|
|
|
2015-12-25 08:23:06 -05:00
|
|
|
Although SPDY is enabled in Omnibus installations, CRIME relies on compression
|
|
|
|
(the 'C') and the default compression level in NGINX's SPDY module is 0
|
|
|
|
(no compression).
|
2015-12-19 16:16:50 -05:00
|
|
|
|
2019-06-07 09:55:22 -04:00
|
|
|
## Nessus
|
2015-12-19 16:16:50 -05:00
|
|
|
|
2015-12-25 08:23:06 -05:00
|
|
|
The Nessus scanner, [reports a possible CRIME vulnerability][nessus] in GitLab
|
|
|
|
similar to the following format:
|
2015-12-19 16:16:50 -05:00
|
|
|
|
2015-12-25 08:23:06 -05:00
|
|
|
```
|
|
|
|
Description
|
2015-12-19 16:16:50 -05:00
|
|
|
|
2015-12-25 08:23:06 -05:00
|
|
|
This remote service has one of two configurations that are known to be required for the CRIME attack:
|
|
|
|
SSL/TLS compression is enabled.
|
|
|
|
TLS advertises the SPDY protocol earlier than version 4.
|
2015-12-19 16:16:50 -05:00
|
|
|
|
2015-12-25 08:23:06 -05:00
|
|
|
...
|
2015-12-19 16:16:50 -05:00
|
|
|
|
2015-12-25 08:23:06 -05:00
|
|
|
Output
|
2015-12-19 16:16:50 -05:00
|
|
|
|
2015-12-25 08:23:06 -05:00
|
|
|
The following configuration indicates that the remote service may be vulnerable to the CRIME attack:
|
|
|
|
SPDY support earlier than version 4 is advertised.
|
|
|
|
```
|
2015-12-19 16:16:50 -05:00
|
|
|
|
2015-12-25 08:23:06 -05:00
|
|
|
From the report above it is important to note that Nessus is only checking if
|
2019-06-07 10:33:31 -04:00
|
|
|
TLS advertises the SPDY protocol earlier than version 4. It does not perform an
|
|
|
|
attack nor does it check if compression is enabled. The Nessus scanner alone
|
2015-12-19 16:16:50 -05:00
|
|
|
cannot tell that SPDY's compression is disabled and not subject to the CRIME
|
2015-12-25 08:23:06 -05:00
|
|
|
vulnerability.
|
|
|
|
|
2019-06-07 09:55:22 -04:00
|
|
|
## References
|
2015-12-19 16:16:50 -05:00
|
|
|
|
2019-10-02 08:06:04 -04:00
|
|
|
- NGINX ["Module ngx_http_spdy_module"][ngx-spdy]
|
2018-11-13 01:07:16 -05:00
|
|
|
- Tenable Network Security, Inc. ["Transport Layer Security (TLS) Protocol CRIME Vulnerability"][nessus]
|
|
|
|
- Wikipedia contributors, ["CRIME"][wiki-crime] Wikipedia, The Free Encyclopedia
|
2015-12-19 16:16:50 -05:00
|
|
|
|
2019-09-18 14:06:14 -04:00
|
|
|
[source-nginx]: https://gitlab.com/gitlab-org/gitlab/blob/master/lib/support/nginx/gitlab-ssl
|
2015-12-25 08:23:06 -05:00
|
|
|
[omnibus-nginx]: https://gitlab.com/gitlab-org/omnibus-gitlab/blob/master/files/gitlab-cookbooks/gitlab/templates/default/nginx-gitlab-http.conf.erb
|
|
|
|
[ngx-spdy]: http://nginx.org/en/docs/http/ngx_http_spdy_module.html
|
|
|
|
[nessus]: https://www.tenable.com/plugins/index.php?view=single&id=62565
|
|
|
|
[wiki-crime]: https://en.wikipedia.org/wiki/CRIME
|
2019-06-07 10:33:31 -04:00
|
|
|
|
|
|
|
<!-- ## Troubleshooting
|
|
|
|
|
|
|
|
Include any troubleshooting steps that you can foresee. If you know beforehand what issues
|
|
|
|
one might have when setting this up, or when something is changed, or on upgrading, it's
|
|
|
|
important to describe those, too. Think of things that may go wrong and include them here.
|
|
|
|
This is important to minimize requests for support, and to avoid doc comments with
|
|
|
|
questions that you know someone might ask.
|
|
|
|
|
|
|
|
Each scenario can be a third-level heading, e.g. `### Getting error message X`.
|
|
|
|
If you have none to add when creating a doc, leave this section in place
|
|
|
|
but commented out to help encourage others to add to it in the future. -->
|