2019-04-15 06:17:05 -04:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2015-10-20 03:28:28 -04:00
|
|
|
require 'spec_helper'
|
|
|
|
|
2021-02-03 10:09:24 -05:00
|
|
|
RSpec.describe InvitesController do
|
2020-07-07 08:09:16 -04:00
|
|
|
let_it_be(:user) { create(:user) }
|
2021-03-30 14:10:47 -04:00
|
|
|
let_it_be(:member, reload: true) { create(:project_member, :invited, invite_email: user.email) }
|
2021-06-28 23:07:32 -04:00
|
|
|
|
2020-09-04 17:08:41 -04:00
|
|
|
let(:raw_invite_token) { member.raw_invite_token }
|
2020-07-07 08:09:16 -04:00
|
|
|
let(:project_members) { member.source.users }
|
2020-08-25 14:10:49 -04:00
|
|
|
let(:md5_member_global_id) { Digest::MD5.hexdigest(member.to_global_id.to_s) }
|
2021-04-29 17:10:03 -04:00
|
|
|
let(:extra_params) { {} }
|
|
|
|
let(:params) { { id: raw_invite_token }.merge(extra_params) }
|
2015-10-20 03:28:28 -04:00
|
|
|
|
2020-09-22 05:09:43 -04:00
|
|
|
shared_examples 'invalid token' do
|
|
|
|
context 'when invite token is not valid' do
|
2021-04-29 17:10:03 -04:00
|
|
|
let(:raw_invite_token) { '_bogus_token_' }
|
2020-09-22 05:09:43 -04:00
|
|
|
|
2021-05-04 14:10:03 -04:00
|
|
|
it 'redirects to root' do
|
2020-09-22 05:09:43 -04:00
|
|
|
request
|
|
|
|
|
2021-05-04 14:10:03 -04:00
|
|
|
expect(response).to redirect_to(root_path)
|
|
|
|
expect(controller).to set_flash[:alert].to('The invitation can not be found with the provided invite token.')
|
2020-09-22 05:09:43 -04:00
|
|
|
end
|
|
|
|
end
|
2015-10-20 03:28:28 -04:00
|
|
|
end
|
|
|
|
|
2021-08-03 17:09:39 -04:00
|
|
|
shared_examples 'invite email match enforcement' do |error_status:, flash_alert: nil|
|
|
|
|
it 'accepts user if invite email matches signed in user' do
|
|
|
|
expect do
|
|
|
|
request
|
|
|
|
end.to change { project_members.include?(user) }.from(false).to(true)
|
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(:found)
|
|
|
|
expect(flash[:notice]).to include 'You have been granted'
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'accepts invite if invite email matches confirmed secondary email' do
|
|
|
|
secondary_email = create(:email, :confirmed, user: user)
|
|
|
|
member.update!(invite_email: secondary_email.email)
|
|
|
|
|
|
|
|
expect do
|
|
|
|
request
|
|
|
|
end.to change { project_members.include?(user) }.from(false).to(true)
|
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(:found)
|
|
|
|
expect(flash[:notice]).to include 'You have been granted'
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not accept if invite email matches unconfirmed secondary email' do
|
|
|
|
secondary_email = create(:email, user: user)
|
|
|
|
member.update!(invite_email: secondary_email.email)
|
|
|
|
|
|
|
|
expect do
|
|
|
|
request
|
|
|
|
end.not_to change { project_members.include?(user) }
|
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(error_status)
|
|
|
|
expect(flash[:alert]).to eq(flash_alert)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not accept if invite email does not match signed in user' do
|
|
|
|
member.update!(invite_email: 'bogus@email.com')
|
|
|
|
|
|
|
|
expect do
|
|
|
|
request
|
|
|
|
end.not_to change { project_members.include?(user) }
|
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(error_status)
|
|
|
|
expect(flash[:alert]).to eq(flash_alert)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2021-07-29 05:08:46 -04:00
|
|
|
describe 'GET #show', :snowplow do
|
2020-08-25 14:10:49 -04:00
|
|
|
subject(:request) { get :show, params: params }
|
|
|
|
|
2021-08-03 17:09:39 -04:00
|
|
|
context 'when logged in' do
|
|
|
|
before do
|
|
|
|
sign_in(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
it_behaves_like 'invite email match enforcement', error_status: :ok
|
|
|
|
it_behaves_like 'invalid token'
|
|
|
|
end
|
|
|
|
|
2021-07-29 05:08:46 -04:00
|
|
|
context 'when it is an initial invite email' do
|
2021-04-29 17:10:03 -04:00
|
|
|
let(:extra_params) { { invite_type: 'initial_email' } }
|
|
|
|
|
2021-07-29 05:08:46 -04:00
|
|
|
it 'tracks the initial join click from email' do
|
2021-04-29 17:10:03 -04:00
|
|
|
request
|
|
|
|
|
2021-07-29 05:08:46 -04:00
|
|
|
expect_snowplow_event(
|
|
|
|
category: described_class.name,
|
|
|
|
action: 'join_clicked',
|
|
|
|
label: 'invite_email',
|
|
|
|
property: member.id.to_s
|
|
|
|
)
|
2021-04-29 17:10:03 -04:00
|
|
|
end
|
|
|
|
|
2021-08-06 14:09:57 -04:00
|
|
|
context 'when it is part of the invite_email_preview_text experiment' do
|
|
|
|
let(:extra_params) { { invite_type: 'initial_email', experiment_name: 'invite_email_preview_text' } }
|
|
|
|
|
|
|
|
it 'tracks the initial join click from email' do
|
|
|
|
experiment = double(track: true)
|
|
|
|
allow(controller).to receive(:experiment).with(:invite_email_preview_text, actor: member).and_return(experiment)
|
|
|
|
|
|
|
|
request
|
|
|
|
|
|
|
|
expect(experiment).to have_received(:track).with(:join_clicked)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when member does not exist' do
|
|
|
|
let(:raw_invite_token) { '_bogus_token_' }
|
|
|
|
|
|
|
|
it 'does not track the experiment' do
|
|
|
|
expect(controller).not_to receive(:experiment).with(:invite_email_preview_text, actor: member)
|
|
|
|
|
|
|
|
request
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2021-08-25 05:10:52 -04:00
|
|
|
context 'when it is part of the invite_email_from experiment' do
|
|
|
|
let(:extra_params) { { invite_type: 'initial_email', experiment_name: 'invite_email_from' } }
|
|
|
|
|
|
|
|
it 'tracks the initial join click from email' do
|
|
|
|
experiment = double(track: true)
|
|
|
|
allow(controller).to receive(:experiment).with(:invite_email_from, actor: member).and_return(experiment)
|
|
|
|
|
|
|
|
request
|
|
|
|
|
|
|
|
expect(experiment).to have_received(:track).with(:join_clicked)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when member does not exist' do
|
|
|
|
let(:raw_invite_token) { '_bogus_token_' }
|
|
|
|
|
|
|
|
it 'does not track the experiment' do
|
|
|
|
expect(controller).not_to receive(:experiment).with(:invite_email_from, actor: member)
|
|
|
|
|
|
|
|
request
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2021-04-29 17:10:03 -04:00
|
|
|
context 'when member does not exist' do
|
|
|
|
let(:raw_invite_token) { '_bogus_token_' }
|
|
|
|
|
2021-07-29 05:08:46 -04:00
|
|
|
it 'does not track join click' do
|
2021-04-29 17:10:03 -04:00
|
|
|
request
|
2021-07-29 05:08:46 -04:00
|
|
|
|
|
|
|
expect_no_snowplow_event(
|
|
|
|
category: described_class.name,
|
|
|
|
action: 'join_clicked',
|
|
|
|
label: 'invite_email'
|
|
|
|
)
|
2021-04-29 17:10:03 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2021-07-29 05:08:46 -04:00
|
|
|
context 'when it is not an initial email' do
|
|
|
|
it 'does not track the join click' do
|
2021-04-29 17:10:03 -04:00
|
|
|
request
|
2021-07-29 05:08:46 -04:00
|
|
|
|
|
|
|
expect_no_snowplow_event(
|
|
|
|
category: described_class.name,
|
|
|
|
action: 'join_clicked',
|
|
|
|
label: 'invite_email'
|
|
|
|
)
|
2021-04-29 17:10:03 -04:00
|
|
|
end
|
2021-08-06 14:09:57 -04:00
|
|
|
|
|
|
|
context 'when it is not part of our invite email experiment' do
|
2021-08-25 05:10:52 -04:00
|
|
|
it 'does not track via experiment', :aggregate_failures do
|
2021-08-06 14:09:57 -04:00
|
|
|
expect(controller).not_to receive(:experiment).with(:invite_email_preview_text, actor: member)
|
2021-08-25 05:10:52 -04:00
|
|
|
expect(controller).not_to receive(:experiment).with(:invite_email_from, actor: member)
|
2021-08-06 14:09:57 -04:00
|
|
|
|
|
|
|
request
|
|
|
|
end
|
|
|
|
end
|
2021-04-29 17:10:03 -04:00
|
|
|
end
|
|
|
|
|
2020-09-04 17:08:41 -04:00
|
|
|
context 'when not logged in' do
|
2021-04-29 17:10:03 -04:00
|
|
|
context 'when invite token belongs to a valid member' do
|
2021-03-30 14:10:47 -04:00
|
|
|
context 'when instance allows sign up' do
|
|
|
|
it 'indicates an account can be created in notice' do
|
|
|
|
request
|
|
|
|
|
|
|
|
expect(flash[:notice]).to include('or create an account')
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when user exists with the invited email' do
|
|
|
|
it 'is redirected to a new session with invite email param' do
|
|
|
|
request
|
|
|
|
|
|
|
|
expect(response).to redirect_to(new_user_session_path(invite_email: member.invite_email))
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when user exists with the invited email as secondary email' do
|
|
|
|
before do
|
|
|
|
secondary_email = create(:email, user: user, email: 'foo@example.com')
|
|
|
|
member.update!(invite_email: secondary_email.email)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'is redirected to a new session with invite email param' do
|
|
|
|
request
|
|
|
|
|
|
|
|
expect(response).to redirect_to(new_user_session_path(invite_email: member.invite_email))
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when user does not exist with the invited email' do
|
|
|
|
before do
|
|
|
|
member.update!(invite_email: 'bogus_email@example.com')
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'indicates an account can be created in notice' do
|
|
|
|
request
|
|
|
|
|
|
|
|
expect(flash[:notice]).to include('create an account or sign in')
|
|
|
|
end
|
|
|
|
|
2021-06-18 17:10:06 -04:00
|
|
|
it 'is redirected to a new registration with invite email param and flash message', :aggregate_failures do
|
|
|
|
request
|
2021-05-12 11:10:25 -04:00
|
|
|
|
2021-06-18 17:10:06 -04:00
|
|
|
expect(response).to redirect_to(new_user_registration_path(invite_email: member.invite_email))
|
|
|
|
expect(flash[:notice]).to eq 'To accept this invitation, create an account or sign in.'
|
2021-03-30 14:10:47 -04:00
|
|
|
end
|
2021-04-29 17:10:03 -04:00
|
|
|
|
|
|
|
it 'sets session keys for auto email confirmation on sign up' do
|
|
|
|
request
|
|
|
|
|
|
|
|
expect(session[:invite_email]).to eq(member.invite_email)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when it is part of our invite email experiment' do
|
|
|
|
let(:extra_params) { { invite_type: 'initial_email' } }
|
|
|
|
|
|
|
|
it 'sets session key for invite acceptance tracking on sign-up' do
|
|
|
|
request
|
|
|
|
|
|
|
|
expect(session[:originating_member_id]).to eq(member.id)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when it is not part of our invite email experiment' do
|
|
|
|
it 'does not set the session key for invite acceptance tracking on sign-up' do
|
|
|
|
request
|
|
|
|
|
|
|
|
expect(session[:originating_member_id]).to be_nil
|
|
|
|
end
|
|
|
|
end
|
2021-03-30 14:10:47 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when instance does not allow sign up' do
|
|
|
|
before do
|
|
|
|
stub_application_setting(allow_signup?: false)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not indicate an account can be created in notice' do
|
|
|
|
request
|
|
|
|
|
|
|
|
expect(flash[:notice]).not_to include('or create an account')
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when user exists with the invited email' do
|
|
|
|
it 'is redirected to a new session with invite email param' do
|
|
|
|
request
|
|
|
|
|
|
|
|
expect(response).to redirect_to(new_user_session_path(invite_email: member.invite_email))
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when user does not exist with the invited email' do
|
|
|
|
before do
|
|
|
|
member.update!(invite_email: 'bogus_email@example.com')
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'is redirected to a new session with invite email param' do
|
|
|
|
request
|
2020-08-25 14:10:49 -04:00
|
|
|
|
2021-03-30 14:10:47 -04:00
|
|
|
expect(response).to redirect_to(new_user_session_path(invite_email: member.invite_email))
|
|
|
|
end
|
|
|
|
end
|
2020-09-04 17:08:41 -04:00
|
|
|
end
|
|
|
|
end
|
2020-08-25 14:10:49 -04:00
|
|
|
|
2021-04-29 17:10:03 -04:00
|
|
|
context 'when invite token does not belong to a valid member' do
|
2020-09-04 17:08:41 -04:00
|
|
|
let(:params) { { id: '_bogus_token_' } }
|
|
|
|
|
|
|
|
it 'is redirected to a new session' do
|
|
|
|
request
|
|
|
|
|
|
|
|
expect(response).to redirect_to(new_user_session_path)
|
|
|
|
end
|
2020-08-25 14:10:49 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'POST #accept' do
|
2020-09-04 17:08:41 -04:00
|
|
|
before do
|
|
|
|
sign_in(user)
|
|
|
|
end
|
2020-08-25 14:10:49 -04:00
|
|
|
|
|
|
|
subject(:request) { post :accept, params: params }
|
|
|
|
|
2021-08-03 17:09:39 -04:00
|
|
|
it_behaves_like 'invite email match enforcement', error_status: :redirect, flash_alert: 'The invitation could not be accepted.'
|
2020-09-22 05:09:43 -04:00
|
|
|
it_behaves_like 'invalid token'
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'POST #decline for link in UI' do
|
|
|
|
before do
|
|
|
|
sign_in(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
subject(:request) { post :decline, params: params }
|
|
|
|
|
|
|
|
it_behaves_like 'invalid token'
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'GET #decline for link in email' do
|
|
|
|
before do
|
|
|
|
sign_in(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
subject(:request) { get :decline, params: params }
|
|
|
|
|
|
|
|
it_behaves_like 'invalid token'
|
2020-07-07 08:09:16 -04:00
|
|
|
end
|
2015-10-20 03:28:28 -04:00
|
|
|
end
|