111 lines
3.1 KiB
Ruby
111 lines
3.1 KiB
Ruby
|
# frozen_string_literal: true
|
||
|
|
|
||
|
|
require 'spec_helper'
|
||
|
|
|
||
|
|
describe Suggestions::CreateService do
|
||
|
|
let(:project_with_repo) { create(:project, :repository) }
|
||
|
|
let(:merge_request) do
|
||
|
|
create(:merge_request, source_project: project_with_repo,
|
||
|
|
target_project: project_with_repo)
|
||
|
|
end
|
||
|
|
|
||
|
|
let(:position) do
|
||
|
|
Gitlab::Diff::Position.new(old_path: "files/ruby/popen.rb",
|
||
|
|
new_path: "files/ruby/popen.rb",
|
||
|
|
old_line: nil,
|
||
|
|
new_line: 14,
|
||
|
|
diff_refs: merge_request.diff_refs)
|
||
|
|
end
|
||
|
|
|
||
|
|
let(:markdown) do
|
||
|
|
<<-MARKDOWN.strip_heredoc
|
||
|
|
```suggestion
|
||
|
|
foo
|
||
|
|
bar
|
||
|
|
```
|
||
|
|
|
||
|
|
```
|
||
|
|
nothing
|
||
|
|
```
|
||
|
|
|
||
|
|
```suggestion
|
||
|
|
xpto
|
||
|
|
baz
|
||
|
|
```
|
||
|
|
|
||
|
|
```thing
|
||
|
|
this is not a suggestion, it's a thing
|
||
|
|
```
|
||
|
|
MARKDOWN
|
||
|
|
end
|
||
|
|
|
||
|
|
subject { described_class.new(note) }
|
||
|
|
|
||
|
|
describe '#execute' do
|
||
|
|
context 'should not try to parse suggestions' do
|
||
|
|
context 'when not a diff note for merge requests' do
|
||
|
|
let(:note) do
|
||
|
|
create(:diff_note_on_commit, project: project_with_repo,
|
||
|
|
note: markdown)
|
||
|
|
end
|
||
|
|
|
||
|
|
it 'does not try to parse suggestions' do
|
||
|
|
expect(Banzai::SuggestionsParser).not_to receive(:parse)
|
||
|
|
|
||
|
|
subject.execute
|
||
|
|
end
|
||
|
|
end
|
||
|
|
|
||
|
|
context 'when diff note is not for text' do
|
||
|
|
let(:note) do
|
||
|
|
create(:diff_note_on_merge_request, project: project_with_repo,
|
||
|
|
noteable: merge_request,
|
||
|
|
position: position,
|
||
|
|
note: markdown)
|
||
|
|
end
|
||
|
|
|
||
|
|
it 'does not try to parse suggestions' do
|
||
|
|
allow(note).to receive(:on_text?) { false }
|
||
|
|
|
||
|
|
expect(Banzai::SuggestionsParser).not_to receive(:parse)
|
||
|
|
|
||
|
|
subject.execute
|
||
|
|
end
|
||
|
|
end
|
||
|
|
end
|
||
|
|
|
||
|
|
context 'should create suggestions' do
|
||
|
|
let(:note) do
|
||
|
|
create(:diff_note_on_merge_request, project: project_with_repo,
|
||
|
|
noteable: merge_request,
|
||
|
|
position: position,
|
||
|
|
note: markdown)
|
||
|
|
end
|
||
|
|
|
||
|
|
context 'single line suggestions' do
|
||
|
|
it 'persists suggestion records' do
|
||
|
|
expect { subject.execute }
|
||
|
|
.to change { note.suggestions.count }
|
||
|
|
.from(0)
|
||
|
|
.to(2)
|
||
|
|
end
|
||
|
|
|
||
|
|
it 'persists original from_content lines and suggested lines' do
|
||
|
|
subject.execute
|
||
|
|
|
||
|
|
suggestions = note.suggestions.order(:relative_order)
|
||
|
|
|
||
|
|
suggestion_1 = suggestions.first
|
||
|
|
suggestion_2 = suggestions.last
|
||
|
|
|
||
|
|
expect(suggestion_1).to have_attributes(from_content: " vars = {\n",
|
||
|
|
to_content: " foo\n bar\n")
|
||
|
|
|
||
|
|
expect(suggestion_2).to have_attributes(from_content: " vars = {\n",
|
||
|
|
to_content: " xpto\n baz\n")
|
||
|
|
end
|
||
|
|
end
|
||
|
|
end
|
||
|
|
end
|
||
|
|
end
|