gitlab-org--gitlab-foss/app/views/shared/tokens/_scopes_form.html.haml

- scopes = local_assigns.fetch(:scopes)
- prefix = local_assigns.fetch(:prefix)
- token = local_assigns.fetch(:token)

- scopes.each do |scope|
  %fieldset
    = check_box_tag "#{prefix}[scopes][]", scope, token.scopes.include?(scope), id: "#{prefix}_scopes_#{scope}"
    = label_tag "#{prefix}_scopes_#{scope}", scope
    %span= "(#{t(scope, scope: [:doorkeeper, :scopes])})"
View-related (and other minor) changes to !5951 based on @rymai's review. - The `scopes_form` partial can be used in the `admin/applications` view as well - Don't allow partials to access instance variables directly. Instead, pass in the instance variables as local variables, and use `local_assigns.fetch` to assert that the variables are passed in as expected. - Change a few instances of `render :partial` to `render` - Remove an instance of `required: false` in a view, since this is the default - Inline many instances of a local variable (`ip = 'ip'`) in `auth_spec` 2016-12-04 23:19:51 -05:00			`- scopes = local_assigns.fetch(:scopes)`
			`- prefix = local_assigns.fetch(:prefix)`
			`- token = local_assigns.fetch(:token)`

			`- scopes.each do \|scope\|`
Move the scopes form/list view into a partial. - The list of scopes that's displayed while creating a personal access token is identical to the list that's displayed while creating an OAuth application. Extract these into a partial. - The list of scopes that's displayed while in the show page for an OAuth token in the profile settings and admin settings are identical. Extract these into a partial. 2016-11-24 03:52:03 -05:00			`%fieldset`
			`= check_box_tag "#{prefix}[scopes][]", scope, token.scopes.include?(scope), id: "#{prefix}_scopes_#{scope}"`
			`= label_tag "#{prefix}_scopes_#{scope}", scope`
			`%span= "(#{t(scope, scope: [:doorkeeper, :scopes])})"`