2013-05-14 12:33:31 +00:00
|
|
|
module API
|
2012-07-24 12:19:51 +00:00
|
|
|
# Issues API
|
|
|
|
class Issues < Grape::API
|
|
|
|
before { authenticate! }
|
|
|
|
|
2016-01-09 19:30:34 +00:00
|
|
|
helpers ::Gitlab::AkismetHelper
|
|
|
|
|
2014-08-14 10:41:16 +00:00
|
|
|
helpers do
|
2014-09-04 22:01:12 +00:00
|
|
|
def filter_issues_state(issues, state)
|
2014-08-14 10:41:16 +00:00
|
|
|
case state
|
2014-09-02 12:28:27 +00:00
|
|
|
when 'opened' then issues.opened
|
|
|
|
when 'closed' then issues.closed
|
2014-09-04 14:15:08 +00:00
|
|
|
else issues
|
2014-08-14 10:41:16 +00:00
|
|
|
end
|
|
|
|
end
|
2014-08-14 14:17:19 +00:00
|
|
|
|
|
|
|
def filter_issues_labels(issues, labels)
|
2014-09-04 22:01:12 +00:00
|
|
|
issues.includes(:labels).where('labels.title' => labels.split(','))
|
|
|
|
end
|
|
|
|
|
|
|
|
def filter_issues_milestone(issues, milestone)
|
|
|
|
issues.includes(:milestone).where('milestones.title' => milestone)
|
2014-08-14 14:17:19 +00:00
|
|
|
end
|
2014-08-14 10:41:16 +00:00
|
|
|
end
|
|
|
|
|
2012-07-24 12:19:51 +00:00
|
|
|
resource :issues do
|
|
|
|
# Get currently authenticated user's issues
|
|
|
|
#
|
2014-08-14 10:41:16 +00:00
|
|
|
# Parameters:
|
|
|
|
# state (optional) - Return "opened" or "closed" issues
|
2014-08-14 14:17:19 +00:00
|
|
|
# labels (optional) - Comma-separated list of label names
|
2015-02-06 06:00:54 +00:00
|
|
|
# order_by (optional) - Return requests ordered by `created_at` or `updated_at` fields. Default is `created_at`
|
|
|
|
# sort (optional) - Return requests sorted in `asc` or `desc` order. Default is `desc`
|
|
|
|
#
|
2014-08-14 10:41:16 +00:00
|
|
|
# Example Requests:
|
2012-07-24 12:19:51 +00:00
|
|
|
# GET /issues
|
2014-08-14 10:41:16 +00:00
|
|
|
# GET /issues?state=opened
|
|
|
|
# GET /issues?state=closed
|
2014-08-14 14:17:19 +00:00
|
|
|
# GET /issues?labels=foo
|
|
|
|
# GET /issues?labels=foo,bar
|
|
|
|
# GET /issues?labels=foo,bar&state=opened
|
2012-07-24 12:19:51 +00:00
|
|
|
get do
|
2016-06-06 20:19:39 +00:00
|
|
|
issues = current_user.issues.inc_notes_with_associations
|
2014-08-14 14:17:19 +00:00
|
|
|
issues = filter_issues_state(issues, params[:state]) unless params[:state].nil?
|
|
|
|
issues = filter_issues_labels(issues, params[:labels]) unless params[:labels].nil?
|
2015-02-06 06:00:54 +00:00
|
|
|
issues.reorder(issuable_order_by => issuable_sort)
|
2016-04-08 06:41:10 +00:00
|
|
|
present paginate(issues), with: Entities::Issue, current_user: current_user
|
2012-07-24 12:19:51 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-06-07 22:01:54 +00:00
|
|
|
resource :groups do
|
|
|
|
# Get a list of group issues
|
|
|
|
#
|
|
|
|
# Parameters:
|
|
|
|
# id (required) - The ID of a group
|
|
|
|
# state (optional) - Return "opened" or "closed" issues
|
|
|
|
# labels (optional) - Comma-separated list of label names
|
|
|
|
# milestone (optional) - Milestone title
|
|
|
|
# order_by (optional) - Return requests ordered by `created_at` or `updated_at` fields. Default is `created_at`
|
|
|
|
# sort (optional) - Return requests sorted in `asc` or `desc` order. Default is `desc`
|
|
|
|
#
|
|
|
|
# Example Requests:
|
|
|
|
# GET /groups/:id/issues
|
|
|
|
# GET /groups/:id/issues?state=opened
|
|
|
|
# GET /groups/:id/issues?state=closed
|
|
|
|
# GET /groups/:id/issues?labels=foo
|
|
|
|
# GET /groups/:id/issues?labels=foo,bar
|
|
|
|
# GET /groups/:id/issues?labels=foo,bar&state=opened
|
|
|
|
# GET /groups/:id/issues?milestone=1.0.0
|
|
|
|
# GET /groups/:id/issues?milestone=1.0.0&state=closed
|
|
|
|
get ":id/issues" do
|
|
|
|
group = find_group(params[:id])
|
|
|
|
|
|
|
|
params[:state] ||= 'opened'
|
|
|
|
params[:group_id] = group.id
|
|
|
|
params[:milestone_title] = params.delete(:milestone)
|
|
|
|
params[:label_name] = params.delete(:labels)
|
|
|
|
params[:sort] = "#{params.delete(:order_by)}_#{params.delete(:sort)}" if params[:order_by] && params[:sort]
|
|
|
|
|
|
|
|
issues = IssuesFinder.new(current_user, params).execute
|
|
|
|
|
|
|
|
present paginate(issues), with: Entities::Issue, current_user: current_user
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2012-07-24 12:19:51 +00:00
|
|
|
resource :projects do
|
|
|
|
# Get a list of project issues
|
|
|
|
#
|
|
|
|
# Parameters:
|
2012-12-21 17:47:04 +00:00
|
|
|
# id (required) - The ID of a project
|
2015-01-17 22:45:39 +00:00
|
|
|
# iid (optional) - Return the project issue having the given `iid`
|
2014-08-14 10:41:16 +00:00
|
|
|
# state (optional) - Return "opened" or "closed" issues
|
2014-08-14 14:17:19 +00:00
|
|
|
# labels (optional) - Comma-separated list of label names
|
2014-09-04 22:01:12 +00:00
|
|
|
# milestone (optional) - Milestone title
|
2015-02-06 06:00:54 +00:00
|
|
|
# order_by (optional) - Return requests ordered by `created_at` or `updated_at` fields. Default is `created_at`
|
|
|
|
# sort (optional) - Return requests sorted in `asc` or `desc` order. Default is `desc`
|
2014-08-14 10:41:16 +00:00
|
|
|
#
|
|
|
|
# Example Requests:
|
2012-07-24 12:19:51 +00:00
|
|
|
# GET /projects/:id/issues
|
2014-08-14 10:41:16 +00:00
|
|
|
# GET /projects/:id/issues?state=opened
|
|
|
|
# GET /projects/:id/issues?state=closed
|
2014-08-14 14:17:19 +00:00
|
|
|
# GET /projects/:id/issues?labels=foo
|
|
|
|
# GET /projects/:id/issues?labels=foo,bar
|
|
|
|
# GET /projects/:id/issues?labels=foo,bar&state=opened
|
2014-09-04 22:01:12 +00:00
|
|
|
# GET /projects/:id/issues?milestone=1.0.0
|
|
|
|
# GET /projects/:id/issues?milestone=1.0.0&state=closed
|
2015-01-17 22:45:39 +00:00
|
|
|
# GET /issues?iid=42
|
2012-07-24 12:19:51 +00:00
|
|
|
get ":id/issues" do
|
2016-06-06 20:19:39 +00:00
|
|
|
issues = user_project.issues.inc_notes_with_associations.visible_to_user(current_user)
|
2014-08-14 14:17:19 +00:00
|
|
|
issues = filter_issues_state(issues, params[:state]) unless params[:state].nil?
|
|
|
|
issues = filter_issues_labels(issues, params[:labels]) unless params[:labels].nil?
|
2015-01-17 22:45:39 +00:00
|
|
|
issues = filter_by_iid(issues, params[:iid]) unless params[:iid].nil?
|
2015-02-06 06:00:54 +00:00
|
|
|
|
2014-09-04 22:01:12 +00:00
|
|
|
unless params[:milestone].nil?
|
|
|
|
issues = filter_issues_milestone(issues, params[:milestone])
|
|
|
|
end
|
2014-08-14 14:17:19 +00:00
|
|
|
|
2015-02-06 06:00:54 +00:00
|
|
|
issues.reorder(issuable_order_by => issuable_sort)
|
2016-04-08 06:41:10 +00:00
|
|
|
present paginate(issues), with: Entities::Issue, current_user: current_user
|
2012-07-24 12:19:51 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
# Get a single project issue
|
|
|
|
#
|
|
|
|
# Parameters:
|
2012-12-21 17:47:04 +00:00
|
|
|
# id (required) - The ID of a project
|
2012-07-24 12:19:51 +00:00
|
|
|
# issue_id (required) - The ID of a project issue
|
|
|
|
# Example Request:
|
|
|
|
# GET /projects/:id/issues/:issue_id
|
|
|
|
get ":id/issues/:issue_id" do
|
2016-05-12 20:48:09 +00:00
|
|
|
@issue = find_project_issue(params[:issue_id])
|
2016-04-08 06:41:10 +00:00
|
|
|
present @issue, with: Entities::Issue, current_user: current_user
|
2012-07-24 12:19:51 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
# Create a new project issue
|
|
|
|
#
|
|
|
|
# Parameters:
|
2016-03-25 21:21:50 +00:00
|
|
|
# id (required) - The ID of a project
|
|
|
|
# title (required) - The title of an issue
|
|
|
|
# description (optional) - The description of an issue
|
|
|
|
# assignee_id (optional) - The ID of a user to assign issue
|
2012-07-24 12:19:51 +00:00
|
|
|
# milestone_id (optional) - The ID of a milestone to assign issue
|
2016-03-25 21:21:50 +00:00
|
|
|
# labels (optional) - The labels of an issue
|
2016-04-05 17:05:55 +00:00
|
|
|
# created_at (optional) - Date time string, ISO 8601 formatted
|
2016-07-12 15:59:21 +00:00
|
|
|
# due_date (optional) - Date time string in the format YEAR-MONTH-DAY
|
2012-07-24 12:19:51 +00:00
|
|
|
# Example Request:
|
|
|
|
# POST /projects/:id/issues
|
2016-07-12 15:59:21 +00:00
|
|
|
post ':id/issues' do
|
2014-04-02 10:38:35 +00:00
|
|
|
required_attributes! [:title]
|
2016-03-25 21:21:50 +00:00
|
|
|
|
2016-07-12 15:59:21 +00:00
|
|
|
keys = [:title, :description, :assignee_id, :milestone_id, :due_date]
|
2016-03-25 21:21:50 +00:00
|
|
|
keys << :created_at if current_user.admin? || user_project.owner == current_user
|
|
|
|
attrs = attributes_for_keys(keys)
|
2014-07-30 14:17:29 +00:00
|
|
|
|
2014-08-14 08:17:52 +00:00
|
|
|
# Validate label names in advance
|
2014-08-17 20:22:01 +00:00
|
|
|
if (errors = validate_label_params(params)).any?
|
|
|
|
render_api_error!({ labels: errors }, 400)
|
2014-08-14 08:17:52 +00:00
|
|
|
end
|
|
|
|
|
2016-01-09 19:30:34 +00:00
|
|
|
project = user_project
|
2016-01-26 20:08:20 +00:00
|
|
|
text = [attrs[:title], attrs[:description]].reject(&:blank?).join("\n")
|
2016-01-09 19:30:34 +00:00
|
|
|
|
|
|
|
if check_for_spam?(project, current_user) && is_spam?(env, current_user, text)
|
2016-07-16 16:42:44 +00:00
|
|
|
create_spam_log(project, current_user, attrs, env)
|
2016-01-09 19:30:34 +00:00
|
|
|
render_api_error!({ error: 'Spam detected' }, 400)
|
|
|
|
end
|
|
|
|
|
|
|
|
issue = ::Issues::CreateService.new(project, current_user, attrs).execute
|
2014-04-02 10:38:35 +00:00
|
|
|
|
|
|
|
if issue.valid?
|
2014-08-14 08:17:52 +00:00
|
|
|
# Find or create labels and attach to issue. Labels are valid because
|
|
|
|
# we already checked its name, so there can't be an error here
|
2014-07-30 14:17:29 +00:00
|
|
|
if params[:labels].present?
|
2014-08-14 08:17:52 +00:00
|
|
|
issue.add_labels_by_names(params[:labels].split(','))
|
2014-07-30 14:17:29 +00:00
|
|
|
end
|
|
|
|
|
2016-04-08 06:41:10 +00:00
|
|
|
present issue, with: Entities::Issue, current_user: current_user
|
2014-04-02 10:38:35 +00:00
|
|
|
else
|
2014-08-18 18:09:09 +00:00
|
|
|
render_validation_error!(issue)
|
2012-07-24 12:19:51 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
# Update an existing issue
|
|
|
|
#
|
|
|
|
# Parameters:
|
2012-12-21 17:47:04 +00:00
|
|
|
# id (required) - The ID of a project
|
2012-07-24 12:19:51 +00:00
|
|
|
# issue_id (required) - The ID of a project issue
|
|
|
|
# title (optional) - The title of an issue
|
|
|
|
# description (optional) - The description of an issue
|
|
|
|
# assignee_id (optional) - The ID of a user to assign issue
|
|
|
|
# milestone_id (optional) - The ID of a milestone to assign issue
|
|
|
|
# labels (optional) - The labels of an issue
|
2013-06-06 08:31:40 +00:00
|
|
|
# state_event (optional) - The state event of an issue (close|reopen)
|
2016-04-05 17:05:55 +00:00
|
|
|
# updated_at (optional) - Date time string, ISO 8601 formatted
|
2016-07-12 15:59:21 +00:00
|
|
|
# due_date (optional) - Date time string in the format YEAR-MONTH-DAY
|
2012-07-24 12:19:51 +00:00
|
|
|
# Example Request:
|
|
|
|
# PUT /projects/:id/issues/:issue_id
|
2016-07-12 15:59:21 +00:00
|
|
|
put ':id/issues/:issue_id' do
|
2014-04-02 10:54:41 +00:00
|
|
|
issue = user_project.issues.find(params[:issue_id])
|
2015-06-26 13:55:56 +00:00
|
|
|
authorize! :update_issue, issue
|
2016-07-12 15:59:21 +00:00
|
|
|
keys = [:title, :description, :assignee_id, :milestone_id, :state_event, :due_date]
|
2016-04-05 17:05:55 +00:00
|
|
|
keys << :updated_at if current_user.admin? || user_project.owner == current_user
|
|
|
|
attrs = attributes_for_keys(keys)
|
2014-04-02 10:54:41 +00:00
|
|
|
|
2014-08-14 08:17:52 +00:00
|
|
|
# Validate label names in advance
|
2014-08-17 20:22:01 +00:00
|
|
|
if (errors = validate_label_params(params)).any?
|
|
|
|
render_api_error!({ labels: errors }, 400)
|
2014-08-14 08:17:52 +00:00
|
|
|
end
|
|
|
|
|
2014-04-02 10:54:41 +00:00
|
|
|
issue = ::Issues::UpdateService.new(user_project, current_user, attrs).execute(issue)
|
2013-06-11 15:15:18 +00:00
|
|
|
|
2014-04-02 10:54:41 +00:00
|
|
|
if issue.valid?
|
2014-08-14 08:17:52 +00:00
|
|
|
# Find or create labels and attach to issue. Labels are valid because
|
|
|
|
# we already checked its name, so there can't be an error here
|
2015-06-26 14:02:57 +00:00
|
|
|
if params[:labels] && can?(current_user, :admin_issue, user_project)
|
2014-08-17 20:22:01 +00:00
|
|
|
issue.remove_labels
|
2014-08-14 08:17:52 +00:00
|
|
|
# Create and add labels to the new created issue
|
|
|
|
issue.add_labels_by_names(params[:labels].split(','))
|
2014-07-30 14:17:29 +00:00
|
|
|
end
|
|
|
|
|
2016-04-08 06:41:10 +00:00
|
|
|
present issue, with: Entities::Issue, current_user: current_user
|
2014-04-02 10:54:41 +00:00
|
|
|
else
|
2014-08-18 18:09:09 +00:00
|
|
|
render_validation_error!(issue)
|
2012-07-24 12:19:51 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-04-07 12:07:17 +00:00
|
|
|
# Move an existing issue
|
|
|
|
#
|
|
|
|
# Parameters:
|
2016-04-12 16:38:18 +00:00
|
|
|
# id (required) - The ID of a project
|
|
|
|
# issue_id (required) - The ID of a project issue
|
|
|
|
# to_project_id (required) - The ID of the new project
|
2016-04-07 12:07:17 +00:00
|
|
|
# Example Request:
|
|
|
|
# POST /projects/:id/issues/:issue_id/move
|
2016-04-12 16:38:18 +00:00
|
|
|
post ':id/issues/:issue_id/move' do
|
|
|
|
required_attributes! [:to_project_id]
|
2016-04-07 12:07:17 +00:00
|
|
|
|
|
|
|
issue = user_project.issues.find(params[:issue_id])
|
2016-04-12 16:38:18 +00:00
|
|
|
new_project = Project.find(params[:to_project_id])
|
2016-04-07 12:07:17 +00:00
|
|
|
|
|
|
|
begin
|
|
|
|
issue = ::Issues::MoveService.new(user_project, current_user).execute(issue, new_project)
|
2016-04-12 16:38:18 +00:00
|
|
|
present issue, with: Entities::Issue, current_user: current_user
|
2016-04-07 12:07:17 +00:00
|
|
|
rescue ::Issues::MoveService::MoveError => error
|
|
|
|
render_api_error!(error.message, 400)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
#
|
2016-02-26 08:55:43 +00:00
|
|
|
# Delete a project issue
|
2012-07-24 12:19:51 +00:00
|
|
|
#
|
|
|
|
# Parameters:
|
2012-12-21 17:47:04 +00:00
|
|
|
# id (required) - The ID of a project
|
2012-07-24 12:19:51 +00:00
|
|
|
# issue_id (required) - The ID of a project issue
|
|
|
|
# Example Request:
|
|
|
|
# DELETE /projects/:id/issues/:issue_id
|
|
|
|
delete ":id/issues/:issue_id" do
|
2016-03-21 13:12:52 +00:00
|
|
|
issue = user_project.issues.find_by(id: params[:issue_id])
|
2016-02-26 08:55:43 +00:00
|
|
|
|
2016-03-21 13:12:52 +00:00
|
|
|
authorize!(:destroy_issue, issue)
|
2016-02-26 08:55:43 +00:00
|
|
|
issue.destroy
|
2012-07-24 12:19:51 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|