gitlab-org--gitlab-foss/changelogs/unreleased/59257-find-new-branches-har...

---
title: Look for new branches more carefully
merge_request: 29761
author:
type: fixed
Look for new branches more carefully In certain cases, GitLab can miss a PostReceive invocation the first time a branch is pushed. When this happens, the "branch created" hooks are not run, which means various features don't work until the branch is deleted and pushed again. This MR changes the `Git::BranchPushService` so it checks the cache of existing branches in addition to the `oldrev` reported for the branch. If the branch name isn't in the cache, chances are we haven't run the service yet (it's what refreshes the cache), so we can go ahead and run it, even through `oldrev` is set. If the cache has been cleared by some other means in the meantime, then we'll still fail to run the hooks when we should. Fixing that in the general case is a larger problem, and we'd need to devote significant engineering effort to it. There's a chance that we'll run the relevant hooks multiple times with this change, if there's a race between the branch being created, and the `PostReceive` worker being run multiple times, but this can already happen, since Sidekiq is "at-least-once" execution of jobs. So, this should be safe. 2019-06-17 15:12:05 +00:00			`---`
			`title: Look for new branches more carefully`
			`merge_request: 29761`
			`author:`
			`type: fixed`