2019-04-15 06:17:05 -04:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2015-04-15 12:45:31 -04:00
|
|
|
require 'spec_helper'
|
|
|
|
|
2020-06-03 23:08:05 -04:00
|
|
|
RSpec.describe HelpController do
|
2020-10-07 20:08:30 -04:00
|
|
|
include StubVersion
|
|
|
|
|
2015-04-15 12:45:31 -04:00
|
|
|
let(:user) { create(:user) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
sign_in(user)
|
|
|
|
end
|
|
|
|
|
2016-11-10 00:57:46 -05:00
|
|
|
describe 'GET #index' do
|
2016-12-01 06:07:52 -05:00
|
|
|
context 'with absolute url' do
|
|
|
|
it 'keeps the URL absolute' do
|
|
|
|
stub_readme("[API](/api/README.md)")
|
|
|
|
|
2016-11-10 00:57:46 -05:00
|
|
|
get :index
|
2016-12-01 06:07:52 -05:00
|
|
|
|
|
|
|
expect(assigns[:help_index]).to eq '[API](/api/README.md)'
|
2016-11-10 00:57:46 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-12-01 06:07:52 -05:00
|
|
|
context 'with relative url' do
|
|
|
|
it 'prefixes it with /help/' do
|
|
|
|
stub_readme("[API](api/README.md)")
|
|
|
|
|
2016-11-10 00:57:46 -05:00
|
|
|
get :index
|
2016-12-01 06:07:52 -05:00
|
|
|
|
|
|
|
expect(assigns[:help_index]).to eq '[API](/help/api/README.md)'
|
2016-11-10 00:57:46 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-11-18 06:57:25 -05:00
|
|
|
context 'when url is an external link' do
|
2016-12-01 06:07:52 -05:00
|
|
|
it 'does not change it' do
|
2016-11-18 06:57:25 -05:00
|
|
|
stub_readme("[external](https://some.external.link)")
|
2016-12-01 06:07:52 -05:00
|
|
|
|
2016-11-10 00:57:46 -05:00
|
|
|
get :index
|
2016-12-01 06:07:52 -05:00
|
|
|
|
2016-11-18 06:57:25 -05:00
|
|
|
expect(assigns[:help_index]).to eq '[external](https://some.external.link)'
|
2016-11-10 00:57:46 -05:00
|
|
|
end
|
|
|
|
end
|
2019-02-11 16:20:39 -05:00
|
|
|
|
|
|
|
context 'when relative url with external on same line' do
|
|
|
|
it 'prefix it with /help/' do
|
|
|
|
stub_readme("[API](api/README.md) [external](https://some.external.link)")
|
|
|
|
|
|
|
|
get :index
|
|
|
|
|
|
|
|
expect(assigns[:help_index]).to eq '[API](/help/api/README.md) [external](https://some.external.link)'
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when relative url with http:// in query' do
|
|
|
|
it 'prefix it with /help/' do
|
|
|
|
stub_readme("[API](api/README.md?go=https://example.com/)")
|
|
|
|
|
|
|
|
get :index
|
|
|
|
|
|
|
|
expect(assigns[:help_index]).to eq '[API](/help/api/README.md?go=https://example.com/)'
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when mailto URL' do
|
|
|
|
it 'do not change it' do
|
|
|
|
stub_readme("[report bug](mailto:bugs@example.com)")
|
|
|
|
|
|
|
|
get :index
|
|
|
|
|
|
|
|
expect(assigns[:help_index]).to eq '[report bug](mailto:bugs@example.com)'
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when protocol-relative link' do
|
|
|
|
it 'do not change it' do
|
|
|
|
stub_readme("[protocol-relative](//example.com)")
|
|
|
|
|
|
|
|
get :index
|
|
|
|
|
|
|
|
expect(assigns[:help_index]).to eq '[protocol-relative](//example.com)'
|
|
|
|
end
|
|
|
|
end
|
2020-04-15 11:09:17 -04:00
|
|
|
|
|
|
|
context 'restricted visibility set to public' do
|
|
|
|
before do
|
|
|
|
sign_out(user)
|
|
|
|
|
|
|
|
stub_application_setting(restricted_visibility_levels: [Gitlab::VisibilityLevel::PUBLIC])
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'redirects to sign_in path' do
|
|
|
|
get :index
|
|
|
|
|
|
|
|
expect(response).to redirect_to(new_user_session_path)
|
|
|
|
end
|
|
|
|
end
|
2016-11-10 00:57:46 -05:00
|
|
|
end
|
|
|
|
|
2015-04-15 12:45:31 -04:00
|
|
|
describe 'GET #show' do
|
|
|
|
context 'for Markdown formats' do
|
|
|
|
context 'when requested file exists' do
|
|
|
|
before do
|
2020-11-19 16:09:07 -05:00
|
|
|
expect_file_read(File.join(Rails.root, 'doc/ssh/README.md'), content: fixture_file('blockquote_fence_after.md'))
|
|
|
|
|
2018-12-17 17:52:17 -05:00
|
|
|
get :show, params: { path: 'ssh/README' }, format: :md
|
2015-04-15 12:45:31 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'assigns to @markdown' do
|
|
|
|
expect(assigns[:markdown]).not_to be_empty
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'renders HTML' do
|
2020-10-07 20:08:30 -04:00
|
|
|
aggregate_failures do
|
|
|
|
expect(response).to render_template('show.html.haml')
|
|
|
|
expect(response.media_type).to eq 'text/html'
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when a custom help_page_documentation_url is set' do
|
|
|
|
before do
|
|
|
|
stub_application_setting(help_page_documentation_base_url: documentation_base_url)
|
|
|
|
stub_version(gitlab_version, 'deadbeaf')
|
|
|
|
end
|
|
|
|
|
|
|
|
subject { get :show, params: { path: path }, format: 'html' }
|
|
|
|
|
|
|
|
let(:gitlab_version) { '13.4.0-ee' }
|
|
|
|
let(:documentation_base_url) { 'https://docs.gitlab.com' }
|
|
|
|
let(:path) { 'ssh/README' }
|
|
|
|
|
|
|
|
it 'redirects user to custom documentation url with a specified version' do
|
|
|
|
is_expected.to redirect_to("#{documentation_base_url}/13.4/ee/#{path}.html")
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when documentation url ends with a slash' do
|
|
|
|
let(:documentation_base_url) { 'https://docs.gitlab.com/' }
|
|
|
|
|
|
|
|
it 'redirects user to custom documentation url without slash duplicates' do
|
|
|
|
is_expected.to redirect_to("https://docs.gitlab.com/13.4/ee/#{path}.html")
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when it is a pre-release' do
|
|
|
|
let(:gitlab_version) { '13.4.0-pre' }
|
|
|
|
|
|
|
|
it 'redirects user to custom documentation url without a version' do
|
|
|
|
is_expected.to redirect_to("#{documentation_base_url}/ee/#{path}.html")
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when feature flag is disabled' do
|
|
|
|
before do
|
|
|
|
stub_feature_flags(help_page_documentation_redirect: false)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'renders HTML' do
|
|
|
|
aggregate_failures do
|
|
|
|
is_expected.to render_template('show.html.haml')
|
|
|
|
expect(response.media_type).to eq 'text/html'
|
|
|
|
end
|
|
|
|
end
|
2015-04-15 12:45:31 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when requested file is missing' do
|
|
|
|
it 'renders not found' do
|
2018-12-17 17:52:17 -05:00
|
|
|
get :show, params: { path: 'foo/bar' }, format: :md
|
2015-04-15 12:45:31 -04:00
|
|
|
expect(response).to be_not_found
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'for image formats' do
|
|
|
|
context 'when requested file exists' do
|
|
|
|
it 'renders the raw file' do
|
2015-06-23 01:24:39 -04:00
|
|
|
get :show,
|
2018-12-17 17:52:17 -05:00
|
|
|
params: {
|
2020-02-03 10:08:45 -05:00
|
|
|
path: 'user/img/markdown_logo'
|
2018-12-17 17:52:17 -05:00
|
|
|
},
|
2015-06-23 01:24:39 -04:00
|
|
|
format: :png
|
2020-10-07 20:08:30 -04:00
|
|
|
|
|
|
|
aggregate_failures do
|
|
|
|
expect(response).to be_successful
|
|
|
|
expect(response.media_type).to eq 'image/png'
|
|
|
|
expect(response.headers['Content-Disposition']).to match(/^inline;/)
|
|
|
|
end
|
2015-04-15 12:45:31 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when requested file is missing' do
|
|
|
|
it 'renders not found' do
|
2015-06-23 01:24:39 -04:00
|
|
|
get :show,
|
2018-12-17 17:52:17 -05:00
|
|
|
params: {
|
|
|
|
path: 'foo/bar'
|
|
|
|
},
|
2015-06-23 01:24:39 -04:00
|
|
|
format: :png
|
2015-04-15 12:45:31 -04:00
|
|
|
expect(response).to be_not_found
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'for other formats' do
|
|
|
|
it 'always renders not found' do
|
2015-06-23 01:24:39 -04:00
|
|
|
get :show,
|
2018-12-17 17:52:17 -05:00
|
|
|
params: {
|
|
|
|
path: 'ssh/README'
|
|
|
|
},
|
2015-06-23 01:24:39 -04:00
|
|
|
format: :foo
|
2015-04-15 12:45:31 -04:00
|
|
|
expect(response).to be_not_found
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2016-07-19 13:17:14 -04:00
|
|
|
|
2016-11-10 00:57:46 -05:00
|
|
|
def stub_readme(content)
|
2020-11-19 16:09:07 -05:00
|
|
|
expect_file_read(Rails.root.join('doc', 'README.md'), content: content)
|
2016-11-10 00:57:46 -05:00
|
|
|
end
|
2015-04-15 12:45:31 -04:00
|
|
|
end
|