2014-10-07 10:09:28 -04:00
|
|
|
class IssuableBaseService < BaseService
|
|
|
|
private
|
|
|
|
|
|
|
|
def create_milestone_note(issuable)
|
2015-05-09 18:18:50 -04:00
|
|
|
SystemNoteService.change_milestone(
|
2017-08-03 13:37:32 -04:00
|
|
|
issuable, issuable.project, current_user, issuable.milestone)
|
2014-10-07 10:09:28 -04:00
|
|
|
end
|
2015-02-07 06:14:55 -05:00
|
|
|
|
2016-03-01 11:33:13 -05:00
|
|
|
def create_labels_note(issuable, old_labels)
|
|
|
|
added_labels = issuable.labels - old_labels
|
|
|
|
removed_labels = old_labels - issuable.labels
|
|
|
|
|
2015-05-09 18:18:50 -04:00
|
|
|
SystemNoteService.change_label(
|
2015-02-07 06:14:55 -05:00
|
|
|
issuable, issuable.project, current_user, added_labels, removed_labels)
|
|
|
|
end
|
2015-05-26 21:49:04 -04:00
|
|
|
|
|
|
|
def create_title_change_note(issuable, old_title)
|
|
|
|
SystemNoteService.change_title(
|
|
|
|
issuable, issuable.project, current_user, old_title)
|
|
|
|
end
|
2015-05-28 21:00:37 -04:00
|
|
|
|
2017-04-28 19:54:37 -04:00
|
|
|
def create_description_change_note(issuable)
|
|
|
|
SystemNoteService.change_description(issuable, issuable.project, current_user)
|
|
|
|
end
|
|
|
|
|
2015-05-28 21:00:37 -04:00
|
|
|
def create_branch_change_note(issuable, branch_type, old_branch, new_branch)
|
|
|
|
SystemNoteService.change_branch(
|
|
|
|
issuable, issuable.project, current_user, branch_type,
|
|
|
|
old_branch, new_branch)
|
|
|
|
end
|
2015-06-25 10:17:48 -04:00
|
|
|
|
2015-10-22 11:18:59 -04:00
|
|
|
def create_task_status_note(issuable)
|
|
|
|
issuable.updated_tasks.each do |task|
|
|
|
|
SystemNoteService.change_task_status(issuable, issuable.project, current_user, task)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-12-23 00:44:02 -05:00
|
|
|
def create_time_estimate_note(issuable)
|
|
|
|
SystemNoteService.change_time_estimate(issuable, issuable.project, current_user)
|
|
|
|
end
|
|
|
|
|
|
|
|
def create_time_spent_note(issuable)
|
|
|
|
SystemNoteService.change_time_spent(issuable, issuable.project, current_user)
|
|
|
|
end
|
|
|
|
|
2016-12-14 16:39:53 -05:00
|
|
|
def filter_params(issuable)
|
|
|
|
ability_name = :"admin_#{issuable.to_ability_name}"
|
2015-11-17 06:42:43 -05:00
|
|
|
|
2016-12-14 16:39:53 -05:00
|
|
|
unless can?(current_user, ability_name, project)
|
2015-06-25 10:17:48 -04:00
|
|
|
params.delete(:milestone_id)
|
2016-08-18 06:24:44 -04:00
|
|
|
params.delete(:labels)
|
2016-04-29 12:38:07 -04:00
|
|
|
params.delete(:add_label_ids)
|
|
|
|
params.delete(:remove_label_ids)
|
2015-06-25 10:17:48 -04:00
|
|
|
params.delete(:label_ids)
|
2017-05-04 08:11:15 -04:00
|
|
|
params.delete(:assignee_ids)
|
2015-06-25 10:17:48 -04:00
|
|
|
params.delete(:assignee_id)
|
2016-09-27 05:29:06 -04:00
|
|
|
params.delete(:due_date)
|
2017-07-20 10:42:33 -04:00
|
|
|
params.delete(:canonical_issue_id)
|
2015-06-25 10:17:48 -04:00
|
|
|
end
|
2016-12-14 16:39:53 -05:00
|
|
|
|
|
|
|
filter_assignee(issuable)
|
|
|
|
filter_milestone
|
|
|
|
filter_labels
|
2015-06-25 10:17:48 -04:00
|
|
|
end
|
2015-11-17 06:42:43 -05:00
|
|
|
|
2016-12-14 16:39:53 -05:00
|
|
|
def filter_assignee(issuable)
|
|
|
|
return unless params[:assignee_id].present?
|
|
|
|
|
|
|
|
assignee_id = params[:assignee_id]
|
|
|
|
|
|
|
|
if assignee_id.to_s == IssuableFinder::NONE
|
|
|
|
params[:assignee_id] = ""
|
|
|
|
else
|
|
|
|
params.delete(:assignee_id) unless assignee_can_read?(issuable, assignee_id)
|
2016-04-21 06:20:05 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-12-14 16:39:53 -05:00
|
|
|
def assignee_can_read?(issuable, assignee_id)
|
|
|
|
new_assignee = User.find_by_id(assignee_id)
|
|
|
|
|
2017-05-04 08:11:15 -04:00
|
|
|
return false unless new_assignee
|
2016-12-14 16:39:53 -05:00
|
|
|
|
|
|
|
ability_name = :"read_#{issuable.to_ability_name}"
|
|
|
|
resource = issuable.persisted? ? issuable : project
|
|
|
|
|
|
|
|
can?(new_assignee, ability_name, resource)
|
|
|
|
end
|
|
|
|
|
2016-04-21 06:20:05 -04:00
|
|
|
def filter_milestone
|
2016-04-21 07:40:52 -04:00
|
|
|
milestone_id = params[:milestone_id]
|
|
|
|
return unless milestone_id
|
2016-04-21 06:20:05 -04:00
|
|
|
|
2017-07-07 11:08:49 -04:00
|
|
|
params[:milestone_id] = '' if milestone_id == IssuableFinder::NONE
|
|
|
|
|
|
|
|
milestone =
|
|
|
|
Milestone.for_projects_and_groups([project.id], [project.group&.id]).find_by_id(milestone_id)
|
|
|
|
|
|
|
|
params[:milestone_id] = '' unless milestone
|
2016-04-21 06:20:05 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
def filter_labels
|
2016-06-30 11:34:19 -04:00
|
|
|
filter_labels_in_param(:add_label_ids)
|
|
|
|
filter_labels_in_param(:remove_label_ids)
|
|
|
|
filter_labels_in_param(:label_ids)
|
2016-08-18 06:24:44 -04:00
|
|
|
find_or_create_label_ids
|
2016-04-29 12:38:07 -04:00
|
|
|
end
|
|
|
|
|
2016-05-31 07:45:55 -04:00
|
|
|
def filter_labels_in_param(key)
|
|
|
|
return if params[key].to_a.empty?
|
2016-04-29 12:38:07 -04:00
|
|
|
|
2016-09-19 16:21:39 -04:00
|
|
|
params[key] = available_labels.where(id: params[key]).pluck(:id)
|
2016-04-29 12:38:07 -04:00
|
|
|
end
|
|
|
|
|
2016-08-18 06:24:44 -04:00
|
|
|
def find_or_create_label_ids
|
|
|
|
labels = params.delete(:labels)
|
2016-11-10 05:23:44 -05:00
|
|
|
|
2016-08-18 06:24:44 -04:00
|
|
|
return unless labels
|
|
|
|
|
2016-11-10 05:23:44 -05:00
|
|
|
params[:label_ids] = labels.split(",").map do |label_name|
|
2016-10-19 09:53:31 -04:00
|
|
|
service = Labels::FindOrCreateService.new(current_user, project, title: label_name.strip)
|
2016-10-17 22:27:10 -04:00
|
|
|
label = service.execute
|
2016-09-19 16:21:39 -04:00
|
|
|
|
2016-11-10 05:23:44 -05:00
|
|
|
label.try(:id)
|
|
|
|
end.compact
|
2016-08-18 06:24:44 -04:00
|
|
|
end
|
|
|
|
|
2016-08-18 15:19:13 -04:00
|
|
|
def process_label_ids(attributes, existing_label_ids: nil)
|
2016-08-09 13:26:45 -04:00
|
|
|
label_ids = attributes.delete(:label_ids)
|
|
|
|
add_label_ids = attributes.delete(:add_label_ids)
|
|
|
|
remove_label_ids = attributes.delete(:remove_label_ids)
|
2016-06-30 11:34:19 -04:00
|
|
|
|
2016-08-18 15:19:13 -04:00
|
|
|
new_label_ids = existing_label_ids || label_ids || []
|
2016-08-16 20:59:55 -04:00
|
|
|
|
2016-08-18 15:19:13 -04:00
|
|
|
if add_label_ids.blank? && remove_label_ids.blank?
|
|
|
|
new_label_ids = label_ids if label_ids
|
|
|
|
else
|
|
|
|
new_label_ids |= add_label_ids if add_label_ids
|
|
|
|
new_label_ids -= remove_label_ids if remove_label_ids
|
|
|
|
end
|
2016-06-30 11:34:19 -04:00
|
|
|
|
|
|
|
new_label_ids
|
|
|
|
end
|
|
|
|
|
2016-09-19 16:21:39 -04:00
|
|
|
def available_labels
|
|
|
|
LabelsFinder.new(current_user, project_id: @project.id).execute
|
|
|
|
end
|
|
|
|
|
2017-05-31 01:50:53 -04:00
|
|
|
def merge_quick_actions_into_params!(issuable)
|
2016-08-12 21:17:18 -04:00
|
|
|
description, command_params =
|
2017-06-21 09:48:12 -04:00
|
|
|
QuickActions::InterpretService.new(project, current_user)
|
|
|
|
.execute(params[:description], issuable)
|
2016-06-30 11:34:19 -04:00
|
|
|
|
2016-10-26 17:21:50 -04:00
|
|
|
# Avoid a description already set on an issuable to be overwritten by a nil
|
2017-06-02 13:11:26 -04:00
|
|
|
params[:description] = description if params.key?(:description)
|
2016-08-12 21:17:18 -04:00
|
|
|
|
|
|
|
params.merge!(command_params)
|
2016-06-30 11:34:19 -04:00
|
|
|
end
|
|
|
|
|
2016-08-16 20:59:55 -04:00
|
|
|
def create_issuable(issuable, attributes, label_ids:)
|
2016-04-29 12:38:07 -04:00
|
|
|
issuable.with_transaction_returning_status do
|
2016-06-30 11:34:19 -04:00
|
|
|
if issuable.save
|
|
|
|
issuable.update_attributes(label_ids: label_ids)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2016-04-21 06:20:05 -04:00
|
|
|
|
2016-06-30 11:34:19 -04:00
|
|
|
def create(issuable)
|
2017-05-31 01:50:53 -04:00
|
|
|
merge_quick_actions_into_params!(issuable)
|
2016-12-14 16:39:53 -05:00
|
|
|
filter_params(issuable)
|
2016-04-29 12:38:07 -04:00
|
|
|
|
2016-08-16 20:59:55 -04:00
|
|
|
params.delete(:state_event)
|
|
|
|
params[:author] ||= current_user
|
2016-11-10 05:23:44 -05:00
|
|
|
|
2016-08-16 20:59:55 -04:00
|
|
|
label_ids = process_label_ids(params)
|
|
|
|
|
|
|
|
issuable.assign_attributes(params)
|
|
|
|
|
|
|
|
before_create(issuable)
|
|
|
|
|
|
|
|
if params.present? && create_issuable(issuable, params, label_ids: label_ids)
|
|
|
|
after_create(issuable)
|
2016-06-30 11:34:19 -04:00
|
|
|
execute_hooks(issuable)
|
2017-07-11 12:12:33 -04:00
|
|
|
invalidate_cache_counts(issuable, users: issuable.assignees)
|
2016-06-30 11:34:19 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
issuable
|
|
|
|
end
|
2016-04-29 12:38:07 -04:00
|
|
|
|
2016-08-16 20:59:55 -04:00
|
|
|
def before_create(issuable)
|
|
|
|
# To be overridden by subclasses
|
|
|
|
end
|
|
|
|
|
|
|
|
def after_create(issuable)
|
|
|
|
# To be overridden by subclasses
|
|
|
|
end
|
2016-04-29 12:38:07 -04:00
|
|
|
|
2017-02-14 14:07:11 -05:00
|
|
|
def before_update(issuable)
|
2016-09-20 15:52:20 -04:00
|
|
|
# To be overridden by subclasses
|
|
|
|
end
|
|
|
|
|
2017-02-14 14:07:11 -05:00
|
|
|
def after_update(issuable)
|
|
|
|
# To be overridden by subclasses
|
2016-04-21 06:20:05 -04:00
|
|
|
end
|
|
|
|
|
2015-11-17 06:42:43 -05:00
|
|
|
def update(issuable)
|
|
|
|
change_state(issuable)
|
2016-07-12 19:18:13 -04:00
|
|
|
change_subscription(issuable)
|
2016-06-30 11:34:19 -04:00
|
|
|
change_todo(issuable)
|
2017-02-28 15:38:19 -05:00
|
|
|
toggle_award(issuable)
|
2016-12-14 16:39:53 -05:00
|
|
|
filter_params(issuable)
|
2015-11-17 06:42:43 -05:00
|
|
|
old_labels = issuable.labels.to_a
|
2016-08-12 17:54:32 -04:00
|
|
|
old_mentioned_users = issuable.mentioned_users.to_a
|
2017-05-04 08:11:15 -04:00
|
|
|
old_assignees = issuable.assignees.to_a
|
2015-11-17 06:42:43 -05:00
|
|
|
|
2016-12-14 15:45:39 -05:00
|
|
|
label_ids = process_label_ids(params, existing_label_ids: issuable.label_ids)
|
|
|
|
params[:label_ids] = label_ids if labels_changing?(issuable.label_ids, label_ids)
|
2016-08-16 20:59:55 -04:00
|
|
|
|
2017-02-24 09:32:35 -05:00
|
|
|
if issuable.changed? || params.present?
|
2017-02-14 14:07:11 -05:00
|
|
|
issuable.assign_attributes(params.merge(updated_by: current_user))
|
|
|
|
|
2017-05-03 01:32:21 -04:00
|
|
|
if has_title_or_description_changed?(issuable)
|
2017-05-03 01:47:14 -04:00
|
|
|
issuable.assign_attributes(last_edited_at: Time.now, last_edited_by: current_user)
|
2017-05-03 01:32:21 -04:00
|
|
|
end
|
|
|
|
|
2017-02-14 14:07:11 -05:00
|
|
|
before_update(issuable)
|
2016-08-15 12:50:41 -04:00
|
|
|
|
2017-02-14 14:07:11 -05:00
|
|
|
if issuable.with_transaction_returning_status { issuable.save }
|
|
|
|
# We do not touch as it will affect a update on updated_at field
|
|
|
|
ActiveRecord::Base.no_touching do
|
|
|
|
handle_common_system_notes(issuable, old_labels: old_labels)
|
|
|
|
end
|
|
|
|
|
2017-05-04 08:11:15 -04:00
|
|
|
handle_changes(
|
|
|
|
issuable,
|
|
|
|
old_labels: old_labels,
|
|
|
|
old_mentioned_users: old_mentioned_users,
|
|
|
|
old_assignees: old_assignees
|
|
|
|
)
|
|
|
|
|
2017-07-11 12:12:33 -04:00
|
|
|
new_assignees = issuable.assignees.to_a
|
|
|
|
affected_assignees = (old_assignees + new_assignees) - (old_assignees & new_assignees)
|
2017-05-10 16:54:10 -04:00
|
|
|
|
2017-07-11 12:12:33 -04:00
|
|
|
# Don't clear the project cache, because it will be handled by the
|
|
|
|
# appropriate service (close / reopen / merge / etc.).
|
|
|
|
invalidate_cache_counts(issuable, users: affected_assignees.compact, skip_project_cache: true)
|
2017-02-14 14:07:11 -05:00
|
|
|
after_update(issuable)
|
|
|
|
issuable.create_new_cross_references!(current_user)
|
|
|
|
execute_hooks(issuable, 'update')
|
|
|
|
end
|
2015-11-17 06:42:43 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
issuable
|
|
|
|
end
|
|
|
|
|
2016-12-14 15:45:39 -05:00
|
|
|
def labels_changing?(old_label_ids, new_label_ids)
|
|
|
|
old_label_ids.sort != new_label_ids.sort
|
|
|
|
end
|
|
|
|
|
2017-05-03 01:32:21 -04:00
|
|
|
def has_title_or_description_changed?(issuable)
|
|
|
|
issuable.title_changed? || issuable.description_changed?
|
|
|
|
end
|
|
|
|
|
2015-11-17 06:42:43 -05:00
|
|
|
def change_state(issuable)
|
|
|
|
case params.delete(:state_event)
|
|
|
|
when 'reopen'
|
|
|
|
reopen_service.new(project, current_user, {}).execute(issuable)
|
|
|
|
when 'close'
|
|
|
|
close_service.new(project, current_user, {}).execute(issuable)
|
|
|
|
end
|
|
|
|
end
|
2015-10-22 11:18:59 -04:00
|
|
|
|
2016-07-12 19:18:13 -04:00
|
|
|
def change_subscription(issuable)
|
|
|
|
case params.delete(:subscription_event)
|
|
|
|
when 'subscribe'
|
2016-11-04 14:19:08 -04:00
|
|
|
issuable.subscribe(current_user, project)
|
2016-07-12 19:18:13 -04:00
|
|
|
when 'unsubscribe'
|
2016-11-04 14:19:08 -04:00
|
|
|
issuable.unsubscribe(current_user, project)
|
2016-07-12 19:18:13 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-06-30 11:34:19 -04:00
|
|
|
def change_todo(issuable)
|
|
|
|
case params.delete(:todo_event)
|
2016-08-09 16:47:29 -04:00
|
|
|
when 'add'
|
2016-06-30 11:34:19 -04:00
|
|
|
todo_service.mark_todo(issuable, current_user)
|
|
|
|
when 'done'
|
|
|
|
todo = TodosFinder.new(current_user).execute.find_by(target: issuable)
|
2017-04-21 05:36:34 -04:00
|
|
|
todo_service.mark_todos_as_done_by_ids(todo, current_user) if todo
|
2016-06-30 11:34:19 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-02-28 15:38:19 -05:00
|
|
|
def toggle_award(issuable)
|
|
|
|
award = params.delete(:emoji_award)
|
|
|
|
if award
|
|
|
|
todo_service.new_award_emoji(issuable, current_user)
|
|
|
|
issuable.toggle_award_emoji(award, current_user)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-05-04 08:11:15 -04:00
|
|
|
def has_changes?(issuable, old_labels: [], old_assignees: [])
|
2016-02-17 11:33:30 -05:00
|
|
|
valid_attrs = [:title, :description, :assignee_id, :milestone_id, :target_branch]
|
|
|
|
|
|
|
|
attrs_changed = valid_attrs.any? do |attr|
|
|
|
|
issuable.previous_changes.include?(attr.to_s)
|
|
|
|
end
|
|
|
|
|
2016-03-01 11:33:13 -05:00
|
|
|
labels_changed = issuable.labels != old_labels
|
2016-02-17 11:33:30 -05:00
|
|
|
|
2017-05-04 08:11:15 -04:00
|
|
|
assignees_changed = issuable.assignees != old_assignees
|
|
|
|
|
|
|
|
attrs_changed || labels_changed || assignees_changed
|
2016-02-17 11:33:30 -05:00
|
|
|
end
|
|
|
|
|
2016-03-01 11:33:13 -05:00
|
|
|
def handle_common_system_notes(issuable, old_labels: [])
|
2015-10-22 11:18:59 -04:00
|
|
|
if issuable.previous_changes.include?('title')
|
|
|
|
create_title_change_note(issuable, issuable.previous_changes['title'].first)
|
|
|
|
end
|
|
|
|
|
2017-04-28 19:54:37 -04:00
|
|
|
if issuable.previous_changes.include?('description')
|
2017-06-08 13:56:41 -04:00
|
|
|
if issuable.tasks? && issuable.updated_tasks.any?
|
|
|
|
create_task_status_note(issuable)
|
|
|
|
else
|
|
|
|
# TODO: Show this note if non-task content was modified.
|
|
|
|
# https://gitlab.com/gitlab-org/gitlab-ce/issues/33577
|
|
|
|
create_description_change_note(issuable)
|
|
|
|
end
|
2015-10-22 11:18:59 -04:00
|
|
|
end
|
2015-11-20 10:36:12 -05:00
|
|
|
|
2016-12-23 00:44:02 -05:00
|
|
|
if issuable.previous_changes.include?('time_estimate')
|
|
|
|
create_time_estimate_note(issuable)
|
|
|
|
end
|
|
|
|
|
|
|
|
if issuable.time_spent?
|
|
|
|
create_time_spent_note(issuable)
|
|
|
|
end
|
|
|
|
|
2016-03-01 11:33:13 -05:00
|
|
|
create_labels_note(issuable, old_labels) if issuable.labels != old_labels
|
2015-10-22 11:18:59 -04:00
|
|
|
end
|
2017-05-15 08:04:09 -04:00
|
|
|
|
2017-07-11 12:12:33 -04:00
|
|
|
def invalidate_cache_counts(issuable, users: [], skip_project_cache: false)
|
2017-05-15 08:04:09 -04:00
|
|
|
users.each do |user|
|
|
|
|
user.public_send("invalidate_#{issuable.model_name.singular}_cache_counts")
|
|
|
|
end
|
2017-07-11 12:12:33 -04:00
|
|
|
|
|
|
|
unless skip_project_cache
|
|
|
|
case issuable
|
|
|
|
when Issue
|
|
|
|
IssuesFinder.new(nil, project_id: issuable.project_id).clear_caches!
|
|
|
|
when MergeRequest
|
|
|
|
MergeRequestsFinder.new(nil, project_id: issuable.target_project_id).clear_caches!
|
|
|
|
end
|
|
|
|
end
|
2017-05-15 08:04:09 -04:00
|
|
|
end
|
2014-10-07 10:09:28 -04:00
|
|
|
end
|