2021-10-28 12:10:22 +00:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
require 'spec_helper'
|
|
|
|
|
2021-11-17 00:12:37 +00:00
|
|
|
RSpec.describe MergeRequests::ToggleAttentionRequestedService do
|
2021-10-28 12:10:22 +00:00
|
|
|
let(:current_user) { create(:user) }
|
|
|
|
let(:user) { create(:user) }
|
|
|
|
let(:assignee_user) { create(:user) }
|
|
|
|
let(:merge_request) { create(:merge_request, reviewers: [user], assignees: [assignee_user]) }
|
|
|
|
let(:reviewer) { merge_request.find_reviewer(user) }
|
|
|
|
let(:assignee) { merge_request.find_assignee(assignee_user) }
|
|
|
|
let(:project) { merge_request.project }
|
|
|
|
let(:service) { described_class.new(project: project, current_user: current_user, merge_request: merge_request, user: user) }
|
|
|
|
let(:result) { service.execute }
|
|
|
|
let(:todo_service) { spy('todo service') }
|
2021-11-30 15:14:19 +00:00
|
|
|
let(:notification_service) { spy('notification service') }
|
2021-10-28 12:10:22 +00:00
|
|
|
|
|
|
|
before do
|
2021-11-30 15:14:19 +00:00
|
|
|
allow(NotificationService).to receive(:new) { notification_service }
|
2021-10-28 12:10:22 +00:00
|
|
|
allow(service).to receive(:todo_service).and_return(todo_service)
|
2021-11-30 15:14:19 +00:00
|
|
|
allow(service).to receive(:notification_service).and_return(notification_service)
|
2021-12-02 09:10:59 +00:00
|
|
|
allow(SystemNoteService).to receive(:request_attention)
|
|
|
|
allow(SystemNoteService).to receive(:remove_attention_request)
|
2021-10-28 12:10:22 +00:00
|
|
|
|
|
|
|
project.add_developer(current_user)
|
|
|
|
project.add_developer(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#execute' do
|
|
|
|
context 'invalid permissions' do
|
|
|
|
let(:service) { described_class.new(project: project, current_user: create(:user), merge_request: merge_request, user: user) }
|
|
|
|
|
|
|
|
it 'returns an error' do
|
|
|
|
expect(result[:status]).to eq :error
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'reviewer does not exist' do
|
|
|
|
let(:service) { described_class.new(project: project, current_user: current_user, merge_request: merge_request, user: create(:user)) }
|
|
|
|
|
|
|
|
it 'returns an error' do
|
|
|
|
expect(result[:status]).to eq :error
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'reviewer exists' do
|
2021-11-17 00:12:37 +00:00
|
|
|
before do
|
|
|
|
reviewer.update!(state: :reviewed)
|
|
|
|
end
|
|
|
|
|
2021-10-28 12:10:22 +00:00
|
|
|
it 'returns success' do
|
|
|
|
expect(result[:status]).to eq :success
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'updates reviewers state' do
|
|
|
|
service.execute
|
|
|
|
reviewer.reload
|
|
|
|
|
2021-11-17 00:12:37 +00:00
|
|
|
expect(reviewer.state).to eq 'attention_requested'
|
2021-10-28 12:10:22 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'creates a new todo for the reviewer' do
|
2021-11-17 00:12:37 +00:00
|
|
|
expect(todo_service).to receive(:create_attention_requested_todo).with(merge_request, current_user, user)
|
2021-10-28 12:10:22 +00:00
|
|
|
|
|
|
|
service.execute
|
|
|
|
end
|
2021-11-30 15:14:19 +00:00
|
|
|
|
|
|
|
it 'sends email to reviewer' do
|
|
|
|
expect(notification_service).to receive_message_chain(:async, :attention_requested_of_merge_request).with(merge_request, current_user, user)
|
|
|
|
|
|
|
|
service.execute
|
|
|
|
end
|
2021-12-08 12:13:04 +00:00
|
|
|
|
|
|
|
it 'removes attention requested state' do
|
|
|
|
expect(MergeRequests::RemoveAttentionRequestedService).to receive(:new)
|
|
|
|
.with(project: project, current_user: current_user, merge_request: merge_request, user: current_user)
|
|
|
|
.and_call_original
|
|
|
|
|
|
|
|
service.execute
|
|
|
|
end
|
2021-10-28 12:10:22 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'assignee exists' do
|
|
|
|
let(:service) { described_class.new(project: project, current_user: current_user, merge_request: merge_request, user: assignee_user) }
|
|
|
|
|
2021-11-17 00:12:37 +00:00
|
|
|
before do
|
|
|
|
assignee.update!(state: :reviewed)
|
|
|
|
end
|
|
|
|
|
2021-10-28 12:10:22 +00:00
|
|
|
it 'returns success' do
|
|
|
|
expect(result[:status]).to eq :success
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'updates assignees state' do
|
|
|
|
service.execute
|
|
|
|
assignee.reload
|
|
|
|
|
2021-11-17 00:12:37 +00:00
|
|
|
expect(assignee.state).to eq 'attention_requested'
|
2021-10-28 12:10:22 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'creates a new todo for the reviewer' do
|
2021-11-17 00:12:37 +00:00
|
|
|
expect(todo_service).to receive(:create_attention_requested_todo).with(merge_request, current_user, assignee_user)
|
2021-10-28 12:10:22 +00:00
|
|
|
|
|
|
|
service.execute
|
|
|
|
end
|
2021-12-02 09:10:59 +00:00
|
|
|
|
|
|
|
it 'creates a request attention system note' do
|
|
|
|
expect(SystemNoteService).to receive(:request_attention).with(merge_request, merge_request.project, current_user, assignee_user)
|
|
|
|
|
|
|
|
service.execute
|
|
|
|
end
|
2021-12-08 12:13:04 +00:00
|
|
|
|
|
|
|
it 'removes attention requested state' do
|
|
|
|
expect(MergeRequests::RemoveAttentionRequestedService).to receive(:new)
|
|
|
|
.with(project: project, current_user: current_user, merge_request: merge_request, user: current_user)
|
|
|
|
.and_call_original
|
|
|
|
|
|
|
|
service.execute
|
|
|
|
end
|
2021-10-28 12:10:22 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'assignee is the same as reviewer' do
|
|
|
|
let(:merge_request) { create(:merge_request, reviewers: [user], assignees: [user]) }
|
|
|
|
let(:service) { described_class.new(project: project, current_user: current_user, merge_request: merge_request, user: user) }
|
|
|
|
let(:assignee) { merge_request.find_assignee(user) }
|
|
|
|
|
2021-11-17 00:12:37 +00:00
|
|
|
before do
|
|
|
|
reviewer.update!(state: :reviewed)
|
|
|
|
assignee.update!(state: :reviewed)
|
|
|
|
end
|
|
|
|
|
2021-10-28 12:10:22 +00:00
|
|
|
it 'updates reviewers and assignees state' do
|
|
|
|
service.execute
|
|
|
|
reviewer.reload
|
|
|
|
assignee.reload
|
|
|
|
|
2021-11-17 00:12:37 +00:00
|
|
|
expect(reviewer.state).to eq 'attention_requested'
|
|
|
|
expect(assignee.state).to eq 'attention_requested'
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'state is attention_requested' do
|
|
|
|
before do
|
|
|
|
reviewer.update!(state: :attention_requested)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'toggles state to reviewed' do
|
|
|
|
service.execute
|
|
|
|
reviewer.reload
|
|
|
|
|
|
|
|
expect(reviewer.state).to eq "reviewed"
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not create a new todo for the reviewer' do
|
|
|
|
expect(todo_service).not_to receive(:create_attention_requested_todo).with(merge_request, current_user, assignee_user)
|
|
|
|
|
|
|
|
service.execute
|
2021-10-28 12:10:22 +00:00
|
|
|
end
|
2021-12-02 09:10:59 +00:00
|
|
|
|
|
|
|
it 'creates a remove attention request system note' do
|
|
|
|
expect(SystemNoteService).to receive(:remove_attention_request).with(merge_request, merge_request.project, current_user, user)
|
|
|
|
|
|
|
|
service.execute
|
|
|
|
end
|
2021-10-28 12:10:22 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|