2013-05-15 13:59:15 +00:00
|
|
|
require 'spec_helper'
|
|
|
|
|
2015-12-09 10:55:49 +00:00
|
|
|
describe Issues::BulkUpdateService, services: true do
|
2015-06-22 20:00:54 +00:00
|
|
|
let(:issue) { create(:issue, project: @project) }
|
2013-05-16 10:32:16 +00:00
|
|
|
|
|
|
|
before do
|
|
|
|
@user = create :user
|
|
|
|
opts = {
|
2013-09-17 13:12:10 +00:00
|
|
|
name: "GitLab",
|
|
|
|
namespace: @user.namespace
|
2013-05-16 10:32:16 +00:00
|
|
|
}
|
2014-01-16 18:29:18 +00:00
|
|
|
@project = Projects::CreateService.new(@user, opts).execute
|
2013-05-16 10:32:16 +00:00
|
|
|
end
|
|
|
|
|
2013-05-15 13:59:15 +00:00
|
|
|
describe :close_issue do
|
|
|
|
|
|
|
|
before do
|
2016-05-30 12:21:26 +00:00
|
|
|
@issues = create_list(:issue, 5, project: @project)
|
2014-06-17 19:51:43 +00:00
|
|
|
@params = {
|
2015-03-06 14:01:13 +00:00
|
|
|
state_event: 'close',
|
2016-06-02 16:25:44 +00:00
|
|
|
issues_ids: @issues.map(&:id).join(",")
|
2013-05-15 13:59:15 +00:00
|
|
|
}
|
|
|
|
end
|
|
|
|
|
2015-06-22 20:00:54 +00:00
|
|
|
it do
|
2014-01-16 18:29:18 +00:00
|
|
|
result = Issues::BulkUpdateService.new(@project, @user, @params).execute
|
2015-02-12 18:17:35 +00:00
|
|
|
expect(result[:success]).to be_truthy
|
|
|
|
expect(result[:count]).to eq(@issues.count)
|
2013-05-16 10:32:16 +00:00
|
|
|
|
2015-02-12 18:17:35 +00:00
|
|
|
expect(@project.issues.opened).to be_empty
|
|
|
|
expect(@project.issues.closed).not_to be_empty
|
2015-06-22 20:00:54 +00:00
|
|
|
end
|
2013-05-15 13:59:15 +00:00
|
|
|
|
|
|
|
end
|
|
|
|
|
|
|
|
describe :reopen_issues do
|
|
|
|
before do
|
2016-05-30 12:21:26 +00:00
|
|
|
@issues = create_list(:closed_issue, 5, project: @project)
|
2014-06-17 19:51:43 +00:00
|
|
|
@params = {
|
2015-03-06 14:01:13 +00:00
|
|
|
state_event: 'reopen',
|
2016-06-02 16:25:44 +00:00
|
|
|
issues_ids: @issues.map(&:id).join(",")
|
2013-05-15 13:59:15 +00:00
|
|
|
}
|
|
|
|
end
|
|
|
|
|
2015-06-22 20:00:54 +00:00
|
|
|
it do
|
2014-01-16 18:29:18 +00:00
|
|
|
result = Issues::BulkUpdateService.new(@project, @user, @params).execute
|
2015-02-12 18:17:35 +00:00
|
|
|
expect(result[:success]).to be_truthy
|
|
|
|
expect(result[:count]).to eq(@issues.count)
|
2013-05-16 10:32:16 +00:00
|
|
|
|
2015-02-12 18:17:35 +00:00
|
|
|
expect(@project.issues.closed).to be_empty
|
|
|
|
expect(@project.issues.opened).not_to be_empty
|
2015-06-22 20:00:54 +00:00
|
|
|
end
|
2013-05-16 10:32:16 +00:00
|
|
|
|
|
|
|
end
|
|
|
|
|
|
|
|
describe :update_assignee do
|
|
|
|
|
|
|
|
before do
|
|
|
|
@new_assignee = create :user
|
2014-06-17 19:51:43 +00:00
|
|
|
@params = {
|
2016-06-02 16:25:44 +00:00
|
|
|
issues_ids: issue.id.to_s,
|
2015-03-06 14:01:13 +00:00
|
|
|
assignee_id: @new_assignee.id
|
2013-05-16 10:32:16 +00:00
|
|
|
}
|
2013-05-15 13:59:15 +00:00
|
|
|
end
|
|
|
|
|
2015-06-22 20:00:54 +00:00
|
|
|
it do
|
2014-01-16 18:29:18 +00:00
|
|
|
result = Issues::BulkUpdateService.new(@project, @user, @params).execute
|
2015-02-12 18:17:35 +00:00
|
|
|
expect(result[:success]).to be_truthy
|
|
|
|
expect(result[:count]).to eq(1)
|
2013-05-16 10:32:16 +00:00
|
|
|
|
2015-02-12 18:17:35 +00:00
|
|
|
expect(@project.issues.first.assignee).to eq(@new_assignee)
|
2015-06-22 20:00:54 +00:00
|
|
|
end
|
2013-05-15 13:59:15 +00:00
|
|
|
|
2015-02-25 09:29:33 +00:00
|
|
|
it 'allows mass-unassigning' do
|
|
|
|
@project.issues.first.update_attribute(:assignee, @new_assignee)
|
|
|
|
expect(@project.issues.first.assignee).not_to be_nil
|
|
|
|
|
2015-03-06 14:01:13 +00:00
|
|
|
@params[:assignee_id] = -1
|
2015-02-25 09:29:33 +00:00
|
|
|
|
|
|
|
Issues::BulkUpdateService.new(@project, @user, @params).execute
|
|
|
|
expect(@project.issues.first.assignee).to be_nil
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not unassign when assignee_id is not present' do
|
|
|
|
@project.issues.first.update_attribute(:assignee, @new_assignee)
|
|
|
|
expect(@project.issues.first.assignee).not_to be_nil
|
|
|
|
|
2015-03-06 14:01:13 +00:00
|
|
|
@params[:assignee_id] = ''
|
2015-02-25 09:29:33 +00:00
|
|
|
|
|
|
|
Issues::BulkUpdateService.new(@project, @user, @params).execute
|
|
|
|
expect(@project.issues.first.assignee).not_to be_nil
|
|
|
|
end
|
2013-05-15 13:59:15 +00:00
|
|
|
end
|
|
|
|
|
2013-05-16 10:32:16 +00:00
|
|
|
describe :update_milestone do
|
|
|
|
|
|
|
|
before do
|
2016-04-21 10:25:21 +00:00
|
|
|
@milestone = create(:milestone, project: @project)
|
2014-06-17 19:51:43 +00:00
|
|
|
@params = {
|
2016-06-02 16:25:44 +00:00
|
|
|
issues_ids: issue.id.to_s,
|
2015-03-06 14:01:13 +00:00
|
|
|
milestone_id: @milestone.id
|
2013-05-16 10:32:16 +00:00
|
|
|
}
|
|
|
|
end
|
|
|
|
|
2015-06-22 20:00:54 +00:00
|
|
|
it do
|
2014-01-16 18:29:18 +00:00
|
|
|
result = Issues::BulkUpdateService.new(@project, @user, @params).execute
|
2015-02-12 18:17:35 +00:00
|
|
|
expect(result[:success]).to be_truthy
|
|
|
|
expect(result[:count]).to eq(1)
|
2013-05-16 10:32:16 +00:00
|
|
|
|
2015-02-12 18:17:35 +00:00
|
|
|
expect(@project.issues.first.milestone).to eq(@milestone)
|
2015-06-22 20:00:54 +00:00
|
|
|
end
|
2013-05-15 13:59:15 +00:00
|
|
|
end
|
|
|
|
|
2016-05-02 15:25:21 +00:00
|
|
|
describe 'updating labels' do
|
|
|
|
def create_issue_with_labels(labels)
|
|
|
|
create(:issue, project: project) { |issue| issue.labels = labels }
|
|
|
|
end
|
|
|
|
|
|
|
|
let(:user) { create(:user) }
|
|
|
|
let(:project) { Projects::CreateService.new(user, namespace: user.namespace, name: 'test').execute }
|
|
|
|
let(:label_1) { create(:label, project: project) }
|
|
|
|
let(:label_2) { create(:label, project: project) }
|
|
|
|
let(:label_3) { create(:label, project: project) }
|
|
|
|
|
|
|
|
let(:issue_all_labels) { create_issue_with_labels([label_1, label_2, label_3]) }
|
|
|
|
let(:issue_labels_1_and_2) { create_issue_with_labels([label_1, label_2]) }
|
|
|
|
let(:issue_labels_1_and_3) { create_issue_with_labels([label_1, label_3]) }
|
|
|
|
let(:issue_no_labels) { create(:issue, project: project) }
|
|
|
|
let(:issues) { [issue_all_labels, issue_labels_1_and_2, issue_labels_1_and_3, issue_no_labels] }
|
|
|
|
|
|
|
|
let(:labels) { [] }
|
|
|
|
let(:add_labels) { [] }
|
|
|
|
let(:remove_labels) { [] }
|
|
|
|
|
|
|
|
let(:params) do
|
|
|
|
{
|
|
|
|
label_ids: labels.map(&:id),
|
|
|
|
add_label_ids: add_labels.map(&:id),
|
|
|
|
remove_label_ids: remove_labels.map(&:id),
|
|
|
|
issues_ids: issues.map(&:id).join(',')
|
|
|
|
}
|
|
|
|
end
|
|
|
|
|
|
|
|
before { Issues::BulkUpdateService.new(project, user, params).execute }
|
|
|
|
|
|
|
|
context 'when label_ids are passed' do
|
|
|
|
let(:issues) { [issue_all_labels, issue_no_labels] }
|
|
|
|
let(:labels) { [label_1, label_2] }
|
|
|
|
|
|
|
|
it 'updates the labels of all issues passed to the labels passed' do
|
|
|
|
expect(issues.map(&:reload).map(&:label_ids)).to all(eq(labels.map(&:id)))
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not update issues not passed in' do
|
|
|
|
expect(issue_labels_1_and_2.label_ids).to contain_exactly(label_1.id, label_2.id)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when add_label_ids are passed' do
|
|
|
|
let(:issues) { [issue_all_labels, issue_labels_1_and_3, issue_no_labels] }
|
|
|
|
let(:add_labels) { [label_1, label_2, label_3] }
|
|
|
|
|
|
|
|
it 'adds those label IDs to all issues passed' do
|
|
|
|
expect(issues.map(&:reload).map(&:label_ids)).to all(include(*add_labels.map(&:id)))
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not update issues not passed in' do
|
|
|
|
expect(issue_labels_1_and_2.label_ids).to contain_exactly(label_1.id, label_2.id)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when remove_label_ids are passed' do
|
|
|
|
let(:issues) { [issue_all_labels, issue_labels_1_and_3, issue_no_labels] }
|
|
|
|
let(:remove_labels) { [label_1, label_2, label_3] }
|
|
|
|
|
|
|
|
it 'removes those label IDs from all issues passed' do
|
|
|
|
expect(issues.map(&:reload).map(&:label_ids)).to all(be_empty)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not update issues not passed in' do
|
|
|
|
expect(issue_labels_1_and_2.label_ids).to contain_exactly(label_1.id, label_2.id)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when add_label_ids and remove_label_ids are passed' do
|
|
|
|
let(:issues) { [issue_all_labels, issue_labels_1_and_3, issue_no_labels] }
|
|
|
|
let(:add_labels) { [label_1] }
|
|
|
|
let(:remove_labels) { [label_3] }
|
|
|
|
|
|
|
|
it 'adds the label IDs to all issues passed' do
|
|
|
|
expect(issues.map(&:reload).map(&:label_ids)).to all(include(label_1.id))
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'removes the label IDs from all issues passed' do
|
|
|
|
expect(issues.map(&:reload).map(&:label_ids).flatten).not_to include(label_3.id)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not update issues not passed in' do
|
|
|
|
expect(issue_labels_1_and_2.label_ids).to contain_exactly(label_1.id, label_2.id)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when add_label_ids and label_ids are passed' do
|
|
|
|
let(:issues) { [issue_all_labels, issue_labels_1_and_2, issue_labels_1_and_3] }
|
|
|
|
let(:labels) { [label_3] }
|
|
|
|
let(:add_labels) { [label_2] }
|
|
|
|
|
|
|
|
it 'adds the label IDs to all issues passed' do
|
|
|
|
expect(issues.map(&:reload).map(&:label_ids)).to all(include(label_2.id))
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'ignores the label IDs parameter' do
|
|
|
|
expect(issues.map(&:reload).map(&:label_ids)).to all(include(label_1.id))
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not update issues not passed in' do
|
|
|
|
expect(issue_no_labels.label_ids).to be_empty
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when remove_label_ids and label_ids are passed' do
|
|
|
|
let(:issues) { [issue_no_labels, issue_labels_1_and_2] }
|
|
|
|
let(:labels) { [label_3] }
|
|
|
|
let(:remove_labels) { [label_2] }
|
|
|
|
|
|
|
|
it 'remove the label IDs from all issues passed' do
|
|
|
|
expect(issues.map(&:reload).map(&:label_ids).flatten).not_to include(label_2.id)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'ignores the label IDs parameter' do
|
|
|
|
expect(issues.map(&:reload).map(&:label_ids).flatten).not_to include(label_3.id)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not update issues not passed in' do
|
|
|
|
expect(issue_all_labels.label_ids).to contain_exactly(label_1.id, label_2.id, label_3.id)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when add_label_ids, remove_label_ids, and label_ids are passed' do
|
|
|
|
let(:issues) { [issue_labels_1_and_3, issue_no_labels] }
|
|
|
|
let(:labels) { [label_2] }
|
|
|
|
let(:add_labels) { [label_1] }
|
|
|
|
let(:remove_labels) { [label_3] }
|
|
|
|
|
|
|
|
it 'adds the label IDs to all issues passed' do
|
|
|
|
expect(issues.map(&:reload).map(&:label_ids)).to all(include(label_1.id))
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'removes the label IDs from all issues passed' do
|
|
|
|
expect(issues.map(&:reload).map(&:label_ids).flatten).not_to include(label_3.id)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'ignores the label IDs parameter' do
|
|
|
|
expect(issues.map(&:reload).map(&:label_ids).flatten).not_to include(label_2.id)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not update issues not passed in' do
|
|
|
|
expect(issue_labels_1_and_2.label_ids).to contain_exactly(label_1.id, label_2.id)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2013-05-16 10:32:16 +00:00
|
|
|
end
|