2019-07-25 05:24:42 +00:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2016-06-17 08:49:02 +00:00
|
|
|
require 'spec_helper'
|
|
|
|
|
2018-07-05 06:32:05 +00:00
|
|
|
describe 'Protected Branches', :js do
|
2019-04-24 18:17:46 +00:00
|
|
|
include ProtectedBranchHelpers
|
|
|
|
|
2017-09-15 11:25:12 +00:00
|
|
|
let(:user) { create(:user) }
|
|
|
|
let(:admin) { create(:admin) }
|
2017-03-28 21:13:16 +00:00
|
|
|
let(:project) { create(:project, :repository) }
|
2016-06-17 08:49:02 +00:00
|
|
|
|
2017-09-15 11:25:12 +00:00
|
|
|
context 'logged in as developer' do
|
|
|
|
before do
|
|
|
|
project.add_developer(user)
|
|
|
|
sign_in(user)
|
|
|
|
end
|
2016-06-17 08:49:02 +00:00
|
|
|
|
2017-09-15 11:25:12 +00:00
|
|
|
describe 'Delete protected branch' do
|
|
|
|
before do
|
|
|
|
create(:protected_branch, project: project, name: 'fix')
|
|
|
|
expect(ProtectedBranch.count).to eq(1)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not allow developer to removes protected branch' do
|
|
|
|
visit project_branches_path(project)
|
|
|
|
|
|
|
|
fill_in 'branch-search', with: 'fix'
|
|
|
|
find('#branch-search').native.send_keys(:enter)
|
2016-06-17 08:49:02 +00:00
|
|
|
|
2017-09-15 11:25:12 +00:00
|
|
|
expect(page).to have_css('.btn-remove.disabled')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2016-06-17 08:49:02 +00:00
|
|
|
|
2018-07-11 14:36:08 +00:00
|
|
|
context 'logged in as maintainer' do
|
2017-09-15 11:25:12 +00:00
|
|
|
before do
|
2018-07-11 14:36:08 +00:00
|
|
|
project.add_maintainer(user)
|
2017-09-15 11:25:12 +00:00
|
|
|
sign_in(user)
|
2016-06-17 08:49:02 +00:00
|
|
|
end
|
|
|
|
|
2017-09-15 11:25:12 +00:00
|
|
|
describe 'Delete protected branch' do
|
|
|
|
before do
|
|
|
|
create(:protected_branch, project: project, name: 'fix')
|
|
|
|
expect(ProtectedBranch.count).to eq(1)
|
|
|
|
end
|
2016-06-17 08:49:02 +00:00
|
|
|
|
2017-09-15 11:25:12 +00:00
|
|
|
it 'removes branch after modal confirmation' do
|
|
|
|
visit project_branches_path(project)
|
2016-06-17 08:49:02 +00:00
|
|
|
|
2017-09-15 11:25:12 +00:00
|
|
|
fill_in 'branch-search', with: 'fix'
|
|
|
|
find('#branch-search').native.send_keys(:enter)
|
2016-06-17 08:49:02 +00:00
|
|
|
|
2017-09-15 11:25:12 +00:00
|
|
|
expect(page).to have_content('fix')
|
|
|
|
expect(find('.all-branches')).to have_selector('li', count: 1)
|
2017-10-11 21:54:05 +00:00
|
|
|
page.find('[data-target="#modal-delete-branch"]').click
|
2016-06-17 08:49:02 +00:00
|
|
|
|
2017-09-15 11:25:12 +00:00
|
|
|
expect(page).to have_css('.js-delete-branch[disabled]')
|
|
|
|
fill_in 'delete_branch_input', with: 'fix'
|
|
|
|
click_link 'Delete protected branch'
|
|
|
|
|
|
|
|
fill_in 'branch-search', with: 'fix'
|
|
|
|
find('#branch-search').native.send_keys(:enter)
|
|
|
|
|
|
|
|
expect(page).to have_content('No branches to show')
|
|
|
|
end
|
2016-06-17 08:49:02 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-09-15 11:25:12 +00:00
|
|
|
context 'logged in as admin' do
|
|
|
|
before do
|
|
|
|
sign_in(admin)
|
2016-06-17 08:49:02 +00:00
|
|
|
end
|
|
|
|
|
2017-09-15 11:25:12 +00:00
|
|
|
describe "explicit protected branches" do
|
|
|
|
it "allows creating explicit protected branches" do
|
|
|
|
visit project_protected_branches_path(project)
|
2018-06-27 11:41:16 +00:00
|
|
|
set_defaults
|
2017-09-15 11:25:12 +00:00
|
|
|
set_protected_branch_name('some-branch')
|
|
|
|
click_on "Protect"
|
2016-06-17 08:49:02 +00:00
|
|
|
|
2017-09-15 11:25:12 +00:00
|
|
|
within(".protected-branches-list") { expect(page).to have_content('some-branch') }
|
|
|
|
expect(ProtectedBranch.count).to eq(1)
|
|
|
|
expect(ProtectedBranch.last.name).to eq('some-branch')
|
|
|
|
end
|
2016-06-17 08:49:02 +00:00
|
|
|
|
2017-09-15 11:25:12 +00:00
|
|
|
it "displays the last commit on the matching branch if it exists" do
|
|
|
|
commit = create(:commit, project: project)
|
|
|
|
project.repository.add_branch(admin, 'some-branch', commit.id)
|
|
|
|
|
|
|
|
visit project_protected_branches_path(project)
|
2018-06-27 11:41:16 +00:00
|
|
|
set_defaults
|
2017-09-15 11:25:12 +00:00
|
|
|
set_protected_branch_name('some-branch')
|
|
|
|
click_on "Protect"
|
|
|
|
|
2019-10-15 21:06:25 +00:00
|
|
|
within(".protected-branches-list") do
|
|
|
|
expect(page).not_to have_content("matching")
|
|
|
|
expect(page).not_to have_content("was deleted")
|
|
|
|
end
|
2017-09-15 11:25:12 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it "displays an error message if the named branch does not exist" do
|
|
|
|
visit project_protected_branches_path(project)
|
2018-06-27 11:41:16 +00:00
|
|
|
set_defaults
|
2017-09-15 11:25:12 +00:00
|
|
|
set_protected_branch_name('some-branch')
|
|
|
|
click_on "Protect"
|
|
|
|
|
2019-10-15 21:06:25 +00:00
|
|
|
within(".protected-branches-list") { expect(page).to have_content('Branch was deleted') }
|
2017-09-15 11:25:12 +00:00
|
|
|
end
|
2016-06-17 08:49:02 +00:00
|
|
|
end
|
|
|
|
|
2017-09-15 11:25:12 +00:00
|
|
|
describe "wildcard protected branches" do
|
|
|
|
it "allows creating protected branches with a wildcard" do
|
|
|
|
visit project_protected_branches_path(project)
|
2018-06-27 11:41:16 +00:00
|
|
|
set_defaults
|
2017-09-15 11:25:12 +00:00
|
|
|
set_protected_branch_name('*-stable')
|
|
|
|
click_on "Protect"
|
|
|
|
|
|
|
|
within(".protected-branches-list") { expect(page).to have_content('*-stable') }
|
|
|
|
expect(ProtectedBranch.count).to eq(1)
|
|
|
|
expect(ProtectedBranch.last.name).to eq('*-stable')
|
|
|
|
end
|
2016-08-16 05:09:13 +00:00
|
|
|
|
2017-09-15 11:25:12 +00:00
|
|
|
it "displays the number of matching branches" do
|
|
|
|
project.repository.add_branch(admin, 'production-stable', 'master')
|
|
|
|
project.repository.add_branch(admin, 'staging-stable', 'master')
|
2016-06-17 08:49:02 +00:00
|
|
|
|
2017-09-15 11:25:12 +00:00
|
|
|
visit project_protected_branches_path(project)
|
2018-06-27 11:41:16 +00:00
|
|
|
set_defaults
|
2017-09-15 11:25:12 +00:00
|
|
|
set_protected_branch_name('*-stable')
|
|
|
|
click_on "Protect"
|
2016-06-17 08:49:02 +00:00
|
|
|
|
2018-04-04 10:37:44 +00:00
|
|
|
within(".protected-branches-list") do
|
|
|
|
expect(page).to have_content("2 matching branches")
|
|
|
|
end
|
2016-06-17 08:49:02 +00:00
|
|
|
end
|
2017-09-15 11:25:12 +00:00
|
|
|
|
|
|
|
it "displays all the branches matching the wildcard" do
|
|
|
|
project.repository.add_branch(admin, 'production-stable', 'master')
|
|
|
|
project.repository.add_branch(admin, 'staging-stable', 'master')
|
|
|
|
project.repository.add_branch(admin, 'development', 'master')
|
|
|
|
|
|
|
|
visit project_protected_branches_path(project)
|
|
|
|
set_protected_branch_name('*-stable')
|
2018-06-27 11:41:16 +00:00
|
|
|
set_defaults
|
2017-09-15 11:25:12 +00:00
|
|
|
click_on "Protect"
|
|
|
|
|
|
|
|
visit project_protected_branches_path(project)
|
|
|
|
click_on "2 matching branches"
|
|
|
|
|
|
|
|
within(".protected-branches-list") do
|
|
|
|
expect(page).to have_content("production-stable")
|
|
|
|
expect(page).to have_content("staging-stable")
|
|
|
|
expect(page).not_to have_content("development")
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe "access control" do
|
2019-04-24 18:17:46 +00:00
|
|
|
before do
|
|
|
|
stub_licensed_features(protected_refs_for_users: false)
|
|
|
|
end
|
2018-06-27 11:41:16 +00:00
|
|
|
|
2019-04-24 18:17:46 +00:00
|
|
|
include_examples "protected branches > access control > CE"
|
2018-06-27 11:41:16 +00:00
|
|
|
end
|
|
|
|
end
|
2016-06-17 08:49:02 +00:00
|
|
|
end
|