2019-07-25 05:24:42 +00:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2015-05-05 03:06:57 +00:00
|
|
|
require 'spec_helper'
|
|
|
|
|
2018-07-05 06:32:05 +00:00
|
|
|
describe 'Task Lists' do
|
2015-05-05 03:06:57 +00:00
|
|
|
include Warden::Test::Helpers
|
|
|
|
|
2020-01-31 18:09:11 +00:00
|
|
|
let(:project) { create(:project, :public, :repository) }
|
2015-05-05 03:06:57 +00:00
|
|
|
let(:user) { create(:user) }
|
|
|
|
let(:user2) { create(:user) }
|
|
|
|
|
|
|
|
let(:markdown) do
|
|
|
|
<<-MARKDOWN.strip_heredoc
|
|
|
|
This is a task list:
|
|
|
|
|
|
|
|
- [ ] Incomplete entry 1
|
|
|
|
- [x] Complete entry 1
|
|
|
|
- [ ] Incomplete entry 2
|
|
|
|
- [x] Complete entry 2
|
|
|
|
- [ ] Incomplete entry 3
|
|
|
|
- [ ] Incomplete entry 4
|
|
|
|
MARKDOWN
|
|
|
|
end
|
|
|
|
|
2016-08-27 17:36:08 +00:00
|
|
|
let(:singleIncompleteMarkdown) do
|
|
|
|
<<-MARKDOWN.strip_heredoc
|
|
|
|
This is a task list:
|
|
|
|
|
|
|
|
- [ ] Incomplete entry 1
|
|
|
|
MARKDOWN
|
|
|
|
end
|
|
|
|
|
|
|
|
let(:singleCompleteMarkdown) do
|
|
|
|
<<-MARKDOWN.strip_heredoc
|
|
|
|
This is a task list:
|
|
|
|
|
|
|
|
- [x] Incomplete entry 1
|
|
|
|
MARKDOWN
|
|
|
|
end
|
|
|
|
|
2018-06-14 08:30:16 +00:00
|
|
|
let(:nested_tasks_markdown) do
|
|
|
|
<<-EOT.strip_heredoc
|
|
|
|
- [ ] Task a
|
|
|
|
- [x] Task a.1
|
|
|
|
- [ ] Task a.2
|
|
|
|
- [ ] Task b
|
|
|
|
|
|
|
|
1. [ ] Task 1
|
|
|
|
1. [ ] Task 1.1
|
|
|
|
1. [x] Task 1.2
|
|
|
|
EOT
|
|
|
|
end
|
|
|
|
|
2019-12-21 15:07:56 +00:00
|
|
|
let(:commented_tasks_markdown) do
|
|
|
|
<<-EOT.strip_heredoc
|
|
|
|
<!--
|
|
|
|
- [ ] a
|
|
|
|
-->
|
|
|
|
|
|
|
|
- [ ] b
|
|
|
|
EOT
|
|
|
|
end
|
|
|
|
|
|
|
|
let(:summary_no_blank_line_markdown) do
|
|
|
|
<<-EOT.strip_heredoc
|
|
|
|
<details>
|
|
|
|
<summary>No blank line after summary element breaks task list</summary>
|
|
|
|
1. [ ] People Ops: do such and such
|
|
|
|
</details>
|
|
|
|
|
|
|
|
* [ ] Task 1
|
|
|
|
EOT
|
|
|
|
end
|
|
|
|
|
2015-05-05 03:06:57 +00:00
|
|
|
before do
|
|
|
|
Warden.test_mode!
|
|
|
|
|
2018-07-11 14:36:08 +00:00
|
|
|
project.add_maintainer(user)
|
2017-08-09 11:30:07 +00:00
|
|
|
project.add_guest(user2)
|
2015-05-05 03:06:57 +00:00
|
|
|
|
|
|
|
login_as(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
def visit_issue(project, issue)
|
2017-06-29 17:06:35 +00:00
|
|
|
visit project_issue_path(project, issue)
|
2015-05-05 03:06:57 +00:00
|
|
|
end
|
|
|
|
|
2017-06-29 04:13:10 +00:00
|
|
|
describe 'for Issues' do
|
2017-10-03 08:35:01 +00:00
|
|
|
describe 'multiple tasks', :js do
|
2016-08-27 17:36:08 +00:00
|
|
|
let!(:issue) { create(:issue, description: markdown, author: user, project: project) }
|
2015-05-05 03:06:57 +00:00
|
|
|
|
2016-08-27 17:36:08 +00:00
|
|
|
it 'renders' do
|
|
|
|
visit_issue(project, issue)
|
2017-05-17 18:25:13 +00:00
|
|
|
wait_for_requests
|
2017-04-24 21:03:58 +00:00
|
|
|
|
2016-08-27 17:36:08 +00:00
|
|
|
expect(page).to have_selector('ul.task-list', count: 1)
|
|
|
|
expect(page).to have_selector('li.task-list-item', count: 6)
|
|
|
|
expect(page).to have_selector('ul input[checked]', count: 2)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'contains the required selectors' do
|
|
|
|
visit_issue(project, issue)
|
2017-05-17 18:25:13 +00:00
|
|
|
wait_for_requests
|
2016-08-27 17:36:08 +00:00
|
|
|
|
2019-03-23 13:09:14 +00:00
|
|
|
expect(page).to have_selector(".md .task-list .task-list-item .task-list-item-checkbox")
|
2016-08-27 17:36:08 +00:00
|
|
|
expect(page).to have_selector('a.btn-close')
|
|
|
|
end
|
2015-05-05 03:06:57 +00:00
|
|
|
|
2016-08-27 17:36:08 +00:00
|
|
|
it 'is only editable by author' do
|
|
|
|
visit_issue(project, issue)
|
2017-05-17 18:25:13 +00:00
|
|
|
wait_for_requests
|
2017-04-24 21:03:58 +00:00
|
|
|
|
2019-03-23 13:09:14 +00:00
|
|
|
expect(page).to have_selector(".md .task-list .task-list-item .task-list-item-checkbox")
|
2015-05-05 03:06:57 +00:00
|
|
|
|
2016-08-27 17:36:08 +00:00
|
|
|
logout(:user)
|
|
|
|
login_as(user2)
|
|
|
|
visit current_path
|
2017-05-17 18:25:13 +00:00
|
|
|
wait_for_requests
|
2017-05-03 20:35:54 +00:00
|
|
|
|
2019-03-23 13:09:14 +00:00
|
|
|
expect(page).to have_selector(".md .task-list .task-list-item .task-list-item-checkbox")
|
2016-08-27 17:36:08 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'provides a summary on Issues#index' do
|
2017-06-29 17:06:35 +00:00
|
|
|
visit project_issues_path(project)
|
2020-01-31 18:09:11 +00:00
|
|
|
|
2016-08-27 17:36:08 +00:00
|
|
|
expect(page).to have_content("2 of 6 tasks completed")
|
|
|
|
end
|
2015-05-05 03:06:57 +00:00
|
|
|
end
|
|
|
|
|
2017-10-03 08:35:01 +00:00
|
|
|
describe 'single incomplete task', :js do
|
2016-08-27 17:36:08 +00:00
|
|
|
let!(:issue) { create(:issue, description: singleIncompleteMarkdown, author: user, project: project) }
|
2015-05-05 03:06:57 +00:00
|
|
|
|
2016-08-27 17:36:08 +00:00
|
|
|
it 'renders' do
|
|
|
|
visit_issue(project, issue)
|
2017-05-17 18:25:13 +00:00
|
|
|
wait_for_requests
|
2017-04-24 21:03:58 +00:00
|
|
|
|
2016-08-27 17:36:08 +00:00
|
|
|
expect(page).to have_selector('ul.task-list', count: 1)
|
|
|
|
expect(page).to have_selector('li.task-list-item', count: 1)
|
|
|
|
expect(page).to have_selector('ul input[checked]', count: 0)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'provides a summary on Issues#index' do
|
2017-06-29 17:06:35 +00:00
|
|
|
visit project_issues_path(project)
|
2017-05-03 20:35:54 +00:00
|
|
|
|
2016-08-27 17:36:08 +00:00
|
|
|
expect(page).to have_content("0 of 1 task completed")
|
|
|
|
end
|
2015-05-05 03:06:57 +00:00
|
|
|
end
|
|
|
|
|
2017-10-03 08:35:01 +00:00
|
|
|
describe 'single complete task', :js do
|
2016-08-27 17:36:08 +00:00
|
|
|
let!(:issue) { create(:issue, description: singleCompleteMarkdown, author: user, project: project) }
|
|
|
|
|
|
|
|
it 'renders' do
|
|
|
|
visit_issue(project, issue)
|
2017-05-17 18:25:13 +00:00
|
|
|
wait_for_requests
|
2017-04-24 21:03:58 +00:00
|
|
|
|
2016-08-27 17:36:08 +00:00
|
|
|
expect(page).to have_selector('ul.task-list', count: 1)
|
|
|
|
expect(page).to have_selector('li.task-list-item', count: 1)
|
|
|
|
expect(page).to have_selector('ul input[checked]', count: 1)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'provides a summary on Issues#index' do
|
2017-06-29 17:06:35 +00:00
|
|
|
visit project_issues_path(project)
|
2017-05-03 20:35:54 +00:00
|
|
|
|
2016-08-27 17:36:08 +00:00
|
|
|
expect(page).to have_content("1 of 1 task completed")
|
|
|
|
end
|
2015-05-05 03:06:57 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'for Notes' do
|
|
|
|
let!(:issue) { create(:issue, author: user, project: project) }
|
2019-12-17 18:07:48 +00:00
|
|
|
|
2016-08-27 17:36:08 +00:00
|
|
|
describe 'multiple tasks' do
|
|
|
|
let!(:note) do
|
|
|
|
create(:note, note: markdown, noteable: issue,
|
|
|
|
project: project, author: user)
|
|
|
|
end
|
|
|
|
|
2017-08-13 00:00:22 +00:00
|
|
|
it 'renders for note body', :js do
|
2016-08-27 17:36:08 +00:00
|
|
|
visit_issue(project, issue)
|
|
|
|
|
|
|
|
expect(page).to have_selector('.note ul.task-list', count: 1)
|
|
|
|
expect(page).to have_selector('.note li.task-list-item', count: 6)
|
|
|
|
expect(page).to have_selector('.note ul input[checked]', count: 2)
|
|
|
|
end
|
|
|
|
|
2017-08-13 00:00:22 +00:00
|
|
|
it 'contains the required selectors', :js do
|
2016-08-27 17:36:08 +00:00
|
|
|
visit_issue(project, issue)
|
|
|
|
|
|
|
|
expect(page).to have_selector('.note .js-task-list-container')
|
|
|
|
expect(page).to have_selector('.note .js-task-list-container .task-list .task-list-item .task-list-item-checkbox')
|
|
|
|
end
|
|
|
|
|
2017-08-13 00:00:22 +00:00
|
|
|
it 'is only editable by author', :js do
|
2016-08-27 17:36:08 +00:00
|
|
|
visit_issue(project, issue)
|
2020-01-31 18:09:11 +00:00
|
|
|
|
2016-08-27 17:36:08 +00:00
|
|
|
expect(page).to have_selector('.js-task-list-container')
|
|
|
|
|
2017-09-04 05:47:56 +00:00
|
|
|
gitlab_sign_out
|
2016-08-27 17:36:08 +00:00
|
|
|
|
2017-09-04 05:47:56 +00:00
|
|
|
gitlab_sign_in(user2)
|
2016-08-27 17:36:08 +00:00
|
|
|
visit current_path
|
|
|
|
expect(page).not_to have_selector('.js-task-list-container')
|
|
|
|
end
|
2016-04-26 11:52:18 +00:00
|
|
|
end
|
2015-05-05 03:06:57 +00:00
|
|
|
|
2016-08-27 17:36:08 +00:00
|
|
|
describe 'single incomplete task' do
|
|
|
|
let!(:note) do
|
|
|
|
create(:note, note: singleIncompleteMarkdown, noteable: issue,
|
|
|
|
project: project, author: user)
|
|
|
|
end
|
2015-05-05 03:06:57 +00:00
|
|
|
|
2017-08-13 00:00:22 +00:00
|
|
|
it 'renders for note body', :js do
|
2016-08-27 17:36:08 +00:00
|
|
|
visit_issue(project, issue)
|
2015-05-05 03:06:57 +00:00
|
|
|
|
2016-08-27 17:36:08 +00:00
|
|
|
expect(page).to have_selector('.note ul.task-list', count: 1)
|
|
|
|
expect(page).to have_selector('.note li.task-list-item', count: 1)
|
|
|
|
expect(page).to have_selector('.note ul input[checked]', count: 0)
|
|
|
|
end
|
2015-05-05 03:06:57 +00:00
|
|
|
end
|
|
|
|
|
2016-08-27 17:36:08 +00:00
|
|
|
describe 'single complete task' do
|
|
|
|
let!(:note) do
|
|
|
|
create(:note, note: singleCompleteMarkdown, noteable: issue,
|
|
|
|
project: project, author: user)
|
|
|
|
end
|
2015-05-05 03:06:57 +00:00
|
|
|
|
2017-08-13 00:00:22 +00:00
|
|
|
it 'renders for note body', :js do
|
2016-08-27 17:36:08 +00:00
|
|
|
visit_issue(project, issue)
|
2015-05-05 03:06:57 +00:00
|
|
|
|
2016-08-27 17:36:08 +00:00
|
|
|
expect(page).to have_selector('.note ul.task-list', count: 1)
|
|
|
|
expect(page).to have_selector('.note li.task-list-item', count: 1)
|
|
|
|
expect(page).to have_selector('.note ul input[checked]', count: 1)
|
|
|
|
end
|
2015-05-05 03:06:57 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'for Merge Requests' do
|
|
|
|
def visit_merge_request(project, merge)
|
2017-06-29 17:06:35 +00:00
|
|
|
visit project_merge_request_path(project, merge)
|
2015-05-05 03:06:57 +00:00
|
|
|
end
|
|
|
|
|
2020-01-31 18:09:11 +00:00
|
|
|
shared_examples 'multiple tasks' do
|
2020-02-04 00:09:04 +00:00
|
|
|
it 'renders for description', :js do
|
2016-08-27 17:36:08 +00:00
|
|
|
visit_merge_request(project, merge)
|
2020-02-04 00:09:04 +00:00
|
|
|
wait_for_requests
|
2015-05-05 03:06:57 +00:00
|
|
|
|
2016-08-27 17:36:08 +00:00
|
|
|
expect(page).to have_selector('ul.task-list', count: 1)
|
|
|
|
expect(page).to have_selector('li.task-list-item', count: 6)
|
|
|
|
expect(page).to have_selector('ul input[checked]', count: 2)
|
|
|
|
end
|
2015-05-05 03:06:57 +00:00
|
|
|
|
2020-02-04 00:09:04 +00:00
|
|
|
it 'contains the required selectors', :js do
|
2016-08-27 17:36:08 +00:00
|
|
|
visit_merge_request(project, merge)
|
2020-02-04 00:09:04 +00:00
|
|
|
wait_for_requests
|
2015-05-05 03:06:57 +00:00
|
|
|
|
2016-08-27 17:36:08 +00:00
|
|
|
container = '.detail-page-description .description.js-task-list-container'
|
2015-05-05 03:06:57 +00:00
|
|
|
|
2016-08-27 17:36:08 +00:00
|
|
|
expect(page).to have_selector(container)
|
2019-03-23 13:09:14 +00:00
|
|
|
expect(page).to have_selector("#{container} .md .task-list .task-list-item .task-list-item-checkbox")
|
2020-02-04 00:09:04 +00:00
|
|
|
expect(page).to have_selector("#{container} .js-task-list-field", visible: false)
|
2016-08-27 17:36:08 +00:00
|
|
|
expect(page).to have_selector('form.js-issuable-update')
|
|
|
|
end
|
2015-05-05 03:06:57 +00:00
|
|
|
|
2020-01-31 18:09:11 +00:00
|
|
|
it 'is only editable by author', :js do
|
2016-08-27 17:36:08 +00:00
|
|
|
visit_merge_request(project, merge)
|
2020-02-04 00:09:04 +00:00
|
|
|
wait_for_requests
|
2020-01-31 18:09:11 +00:00
|
|
|
|
2016-08-27 17:36:08 +00:00
|
|
|
expect(page).to have_selector('.js-task-list-container')
|
2020-01-31 18:09:11 +00:00
|
|
|
expect(page).to have_selector('li.task-list-item.enabled', count: 6)
|
2015-05-05 03:06:57 +00:00
|
|
|
|
2016-08-27 17:36:08 +00:00
|
|
|
logout(:user)
|
|
|
|
login_as(user2)
|
|
|
|
visit current_path
|
2020-02-04 00:09:04 +00:00
|
|
|
wait_for_requests
|
2020-01-31 18:09:11 +00:00
|
|
|
|
2016-08-27 17:36:08 +00:00
|
|
|
expect(page).not_to have_selector('.js-task-list-container')
|
2020-01-31 18:09:11 +00:00
|
|
|
expect(page).to have_selector('li.task-list-item.enabled', count: 0)
|
|
|
|
expect(page).to have_selector('li.task-list-item input[disabled]', count: 6)
|
2016-08-27 17:36:08 +00:00
|
|
|
end
|
2020-01-31 18:09:11 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'when merge request is open' do
|
|
|
|
let!(:merge) { create(:merge_request, :simple, description: markdown, author: user, source_project: project) }
|
|
|
|
|
|
|
|
it_behaves_like 'multiple tasks'
|
2016-08-27 17:36:08 +00:00
|
|
|
|
|
|
|
it 'provides a summary on MergeRequests#index' do
|
2017-06-29 17:06:35 +00:00
|
|
|
visit project_merge_requests_path(project)
|
2020-01-31 18:09:11 +00:00
|
|
|
|
2016-08-27 17:36:08 +00:00
|
|
|
expect(page).to have_content("2 of 6 tasks completed")
|
|
|
|
end
|
|
|
|
end
|
2017-01-18 13:33:13 +00:00
|
|
|
|
2020-01-31 18:09:11 +00:00
|
|
|
context 'when merge request is closed' do
|
|
|
|
let!(:merge) { create(:merge_request, :closed, :simple, description: markdown, author: user, source_project: project) }
|
|
|
|
|
|
|
|
it_behaves_like 'multiple tasks'
|
|
|
|
end
|
|
|
|
|
2016-08-27 17:36:08 +00:00
|
|
|
describe 'single incomplete task' do
|
|
|
|
let!(:merge) { create(:merge_request, :simple, description: singleIncompleteMarkdown, author: user, source_project: project) }
|
|
|
|
|
2020-02-04 00:09:04 +00:00
|
|
|
it 'renders for description', :js do
|
2016-08-27 17:36:08 +00:00
|
|
|
visit_merge_request(project, merge)
|
2020-02-04 00:09:04 +00:00
|
|
|
wait_for_requests
|
2016-08-27 17:36:08 +00:00
|
|
|
|
|
|
|
expect(page).to have_selector('ul.task-list', count: 1)
|
|
|
|
expect(page).to have_selector('li.task-list-item', count: 1)
|
|
|
|
expect(page).to have_selector('ul input[checked]', count: 0)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'provides a summary on MergeRequests#index' do
|
2017-06-29 17:06:35 +00:00
|
|
|
visit project_merge_requests_path(project)
|
2020-01-31 18:09:11 +00:00
|
|
|
|
2016-08-27 17:36:08 +00:00
|
|
|
expect(page).to have_content("0 of 1 task completed")
|
|
|
|
end
|
2015-05-05 03:06:57 +00:00
|
|
|
end
|
|
|
|
|
2016-08-27 17:36:08 +00:00
|
|
|
describe 'single complete task' do
|
|
|
|
let!(:merge) { create(:merge_request, :simple, description: singleCompleteMarkdown, author: user, source_project: project) }
|
|
|
|
|
2020-02-04 00:09:04 +00:00
|
|
|
it 'renders for description', :js do
|
2016-08-27 17:36:08 +00:00
|
|
|
visit_merge_request(project, merge)
|
2020-02-04 00:09:04 +00:00
|
|
|
wait_for_requests
|
2016-08-27 17:36:08 +00:00
|
|
|
|
|
|
|
expect(page).to have_selector('ul.task-list', count: 1)
|
|
|
|
expect(page).to have_selector('li.task-list-item', count: 1)
|
|
|
|
expect(page).to have_selector('ul input[checked]', count: 1)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'provides a summary on MergeRequests#index' do
|
2017-06-29 17:06:35 +00:00
|
|
|
visit project_merge_requests_path(project)
|
2020-02-04 00:09:04 +00:00
|
|
|
|
2016-08-27 17:36:08 +00:00
|
|
|
expect(page).to have_content("1 of 1 task completed")
|
|
|
|
end
|
2015-05-05 03:06:57 +00:00
|
|
|
end
|
|
|
|
end
|
2019-12-21 15:07:56 +00:00
|
|
|
|
|
|
|
describe 'markdown task edge cases' do
|
|
|
|
describe 'commented tasks', :js do
|
|
|
|
let!(:issue) { create(:issue, description: commented_tasks_markdown, author: user, project: project) }
|
|
|
|
|
|
|
|
it 'renders' do
|
|
|
|
visit_issue(project, issue)
|
|
|
|
wait_for_requests
|
|
|
|
|
|
|
|
expect(page).to have_selector('ul.task-list', count: 1)
|
|
|
|
expect(page).to have_selector('li.task-list-item', count: 1)
|
|
|
|
expect(page).to have_selector('ul input[checked]', count: 0)
|
|
|
|
|
|
|
|
find('.task-list-item-checkbox').click
|
|
|
|
wait_for_requests
|
|
|
|
|
|
|
|
visit_issue(project, issue)
|
|
|
|
wait_for_requests
|
|
|
|
|
|
|
|
expect(page).to have_selector('ul.task-list', count: 1)
|
|
|
|
expect(page).to have_selector('li.task-list-item', count: 1)
|
|
|
|
expect(page).to have_selector('ul input[checked]', count: 1)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'summary with no blank line', :js do
|
|
|
|
let!(:issue) { create(:issue, description: summary_no_blank_line_markdown, author: user, project: project) }
|
|
|
|
|
|
|
|
it 'renders' do
|
|
|
|
visit_issue(project, issue)
|
|
|
|
wait_for_requests
|
|
|
|
|
|
|
|
expect(page).to have_selector('ul.task-list', count: 1)
|
|
|
|
expect(page).to have_selector('li.task-list-item', count: 1)
|
|
|
|
expect(page).to have_selector('ul input[checked]', count: 0)
|
|
|
|
|
|
|
|
find('.task-list-item-checkbox').click
|
|
|
|
wait_for_requests
|
|
|
|
|
|
|
|
visit_issue(project, issue)
|
|
|
|
wait_for_requests
|
|
|
|
|
|
|
|
expect(page).to have_selector('ul.task-list', count: 1)
|
|
|
|
expect(page).to have_selector('li.task-list-item', count: 1)
|
|
|
|
expect(page).to have_selector('ul input[checked]', count: 1)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2015-05-05 03:06:57 +00:00
|
|
|
end
|