2019-10-15 03:06:19 +00:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2019-08-29 07:56:52 +00:00
|
|
|
require 'spec_helper'
|
2017-02-15 18:11:44 +00:00
|
|
|
|
|
|
|
describe RecordsUploads do
|
2017-05-29 07:54:35 +00:00
|
|
|
let!(:uploader) do
|
2017-02-28 18:34:43 +00:00
|
|
|
class RecordsUploadsExampleUploader < GitlabUploader
|
2018-01-29 17:57:34 +00:00
|
|
|
include RecordsUploads::Concern
|
2017-02-15 18:11:44 +00:00
|
|
|
|
|
|
|
storage :file
|
|
|
|
|
2018-01-29 17:57:34 +00:00
|
|
|
def dynamic_segment
|
|
|
|
'co/fe/ee'
|
2017-02-15 18:11:44 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-01-29 17:57:34 +00:00
|
|
|
RecordsUploadsExampleUploader.new(build_stubbed(:user))
|
2017-02-15 18:11:44 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
def upload_fixture(filename)
|
2018-06-05 21:18:06 +00:00
|
|
|
fixture_file_upload(File.join('spec', 'fixtures', filename))
|
2017-02-15 18:11:44 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
describe 'callbacks' do
|
2018-01-29 17:57:34 +00:00
|
|
|
let(:upload) { create(:upload) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
uploader.upload = upload
|
|
|
|
end
|
|
|
|
|
|
|
|
it '#record_upload after `store`' do
|
2017-02-15 18:11:44 +00:00
|
|
|
expect(uploader).to receive(:record_upload).once
|
|
|
|
|
|
|
|
uploader.store!(upload_fixture('doc_sample.txt'))
|
|
|
|
end
|
|
|
|
|
2018-01-29 17:57:34 +00:00
|
|
|
it '#destroy_upload after `remove`' do
|
2017-02-15 18:11:44 +00:00
|
|
|
uploader.store!(upload_fixture('doc_sample.txt'))
|
|
|
|
|
2018-01-29 17:57:34 +00:00
|
|
|
expect(uploader).to receive(:destroy_upload).once
|
2017-02-15 18:11:44 +00:00
|
|
|
uploader.remove!
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#record_upload callback' do
|
2018-01-29 17:57:34 +00:00
|
|
|
it 'creates an Upload record after store' do
|
|
|
|
expect { uploader.store!(upload_fixture('rails_sample.jpg')) }.to change { Upload.count }.by(1)
|
2017-02-15 18:11:44 +00:00
|
|
|
end
|
|
|
|
|
2018-01-29 17:57:34 +00:00
|
|
|
it 'creates a new record and assigns size, path, model, and uploader' do
|
2017-02-15 18:11:44 +00:00
|
|
|
uploader.store!(upload_fixture('rails_sample.jpg'))
|
2018-01-29 17:57:34 +00:00
|
|
|
|
|
|
|
upload = uploader.upload
|
|
|
|
aggregate_failures do
|
|
|
|
expect(upload).to be_persisted
|
|
|
|
expect(upload.size).to eq uploader.file.size
|
|
|
|
expect(upload.path).to eq uploader.upload_path
|
|
|
|
expect(upload.model_id).to eq uploader.model.id
|
|
|
|
expect(upload.model_type).to eq uploader.model.class.to_s
|
|
|
|
expect(upload.uploader).to eq uploader.class.to_s
|
|
|
|
end
|
2017-02-15 18:11:44 +00:00
|
|
|
end
|
|
|
|
|
2018-01-29 17:57:34 +00:00
|
|
|
it "does not create an Upload record when the file doesn't exist" do
|
|
|
|
allow(uploader).to receive(:file).and_return(double(exists?: false))
|
2017-02-15 18:11:44 +00:00
|
|
|
|
2018-01-29 17:57:34 +00:00
|
|
|
expect { uploader.store!(upload_fixture('rails_sample.jpg')) }.not_to change { Upload.count }
|
2017-02-15 18:11:44 +00:00
|
|
|
end
|
|
|
|
|
2017-05-29 07:54:35 +00:00
|
|
|
it 'does not create an Upload record if model is missing' do
|
2018-01-29 17:57:34 +00:00
|
|
|
allow_any_instance_of(RecordsUploadsExampleUploader).to receive(:model).and_return(nil)
|
2017-05-29 07:54:35 +00:00
|
|
|
|
2018-01-29 17:57:34 +00:00
|
|
|
expect { uploader.store!(upload_fixture('rails_sample.jpg')) }.not_to change { Upload.count }
|
2017-05-29 07:54:35 +00:00
|
|
|
end
|
|
|
|
|
2019-04-05 08:43:27 +00:00
|
|
|
it 'destroys Upload records at the same path before recording' do
|
2017-02-15 18:11:44 +00:00
|
|
|
existing = Upload.create!(
|
2017-02-28 18:34:43 +00:00
|
|
|
path: File.join('uploads', 'rails_sample.jpg'),
|
2017-02-15 18:11:44 +00:00
|
|
|
size: 512.kilobytes,
|
|
|
|
model: build_stubbed(:user),
|
2020-04-15 18:09:36 +00:00
|
|
|
uploader: uploader.class.to_s
|
2017-02-15 18:11:44 +00:00
|
|
|
)
|
|
|
|
|
2018-01-29 17:57:34 +00:00
|
|
|
uploader.upload = existing
|
2017-02-15 18:11:44 +00:00
|
|
|
uploader.store!(upload_fixture('rails_sample.jpg'))
|
|
|
|
|
|
|
|
expect { existing.reload }.to raise_error(ActiveRecord::RecordNotFound)
|
2018-01-29 17:57:34 +00:00
|
|
|
expect(Upload.count).to eq(1)
|
2017-02-15 18:11:44 +00:00
|
|
|
end
|
2019-07-11 04:48:50 +00:00
|
|
|
|
|
|
|
it 'does not affect other uploads with different model but the same path' do
|
|
|
|
project = create(:project)
|
|
|
|
other_project = create(:project)
|
|
|
|
|
|
|
|
uploader = RecordsUploadsExampleUploader.new(other_project)
|
|
|
|
|
|
|
|
upload_for_project = Upload.create!(
|
|
|
|
path: File.join('uploads', 'rails_sample.jpg'),
|
|
|
|
size: 512.kilobytes,
|
|
|
|
model: project,
|
2020-04-15 18:09:36 +00:00
|
|
|
uploader: uploader.class.to_s
|
2019-07-11 04:48:50 +00:00
|
|
|
)
|
|
|
|
|
|
|
|
uploader.store!(upload_fixture('rails_sample.jpg'))
|
|
|
|
|
|
|
|
upload_for_project_fresh = Upload.find(upload_for_project.id)
|
|
|
|
|
|
|
|
expect(upload_for_project).to eq(upload_for_project_fresh)
|
|
|
|
expect(Upload.count).to eq(2)
|
|
|
|
end
|
2017-02-15 18:11:44 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
describe '#destroy_upload callback' do
|
2019-04-05 08:43:27 +00:00
|
|
|
it 'destroys Upload records at the same path after removal' do
|
2017-02-15 18:11:44 +00:00
|
|
|
uploader.store!(upload_fixture('rails_sample.jpg'))
|
|
|
|
|
|
|
|
expect { uploader.remove! }.to change { Upload.count }.from(1).to(0)
|
|
|
|
end
|
|
|
|
end
|
Speed up avatar URLs with object storage
With object storage enabled, calling `#filename` on an upload does this:
1. Call the `#filename` method on the CarrierWave object.
2. Generate the URL for that object.
3. If the uploader isn't public, do so by generating an authenticated
URL, including signing that request.
That's all correct behaviour, but for the case where we use `#filename`,
it's typically to generate a GitLab URL. That URL doesn't need to be
signed because we do our own auth.
Signing the URLs can be very expensive, especially in batch (say, we
need to get the avatar URLs for 150 users in one request). It's all
unnecessary work. If we used the `RecordsUploads` concern, we have
already recorded a `path` in the database. That `path` is actually
generated from CarrierWave's `#filename` at upload time, so we don't
need to recompute it - we can just use it and strip off the prefix if
it's available.
On a sample users autocomplete URL, at least 10% of the time before this
change went to signing URLs. After this change, we spend no time in URL
signing, and still get the correct results.
2019-04-02 11:52:28 +00:00
|
|
|
|
|
|
|
describe '#filename' do
|
|
|
|
it 'gets the filename from the path recorded in the database, not CarrierWave' do
|
|
|
|
uploader.store!(upload_fixture('rails_sample.jpg'))
|
|
|
|
expect_any_instance_of(GitlabUploader).not_to receive(:filename)
|
|
|
|
|
|
|
|
expect(uploader.filename).to eq('rails_sample.jpg')
|
|
|
|
end
|
|
|
|
end
|
2017-02-15 18:11:44 +00:00
|
|
|
end
|