2015-10-09 10:20:38 +00:00
|
|
|
require 'spec_helper'
|
|
|
|
|
2017-07-10 14:24:02 +00:00
|
|
|
describe TeamcityService, :use_clean_rails_memory_store_caching do
|
2017-01-12 22:31:02 +00:00
|
|
|
include ReactiveCachingHelpers
|
|
|
|
|
|
|
|
let(:teamcity_url) { 'http://gitlab.com/teamcity' }
|
|
|
|
|
|
|
|
subject(:service) do
|
|
|
|
described_class.create(
|
2017-08-02 19:55:11 +00:00
|
|
|
project: create(:project),
|
2017-01-12 22:31:02 +00:00
|
|
|
properties: {
|
|
|
|
teamcity_url: teamcity_url,
|
|
|
|
username: 'mic',
|
|
|
|
password: 'password',
|
|
|
|
build_type: 'foo'
|
|
|
|
}
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
2016-04-05 13:11:31 +00:00
|
|
|
describe 'Associations' do
|
2015-10-09 10:20:38 +00:00
|
|
|
it { is_expected.to belong_to :project }
|
|
|
|
it { is_expected.to have_one :service_hook }
|
|
|
|
end
|
|
|
|
|
2016-04-05 13:11:31 +00:00
|
|
|
describe 'Validations' do
|
2016-04-21 15:13:14 +00:00
|
|
|
context 'when service is active' do
|
2017-06-14 18:18:56 +00:00
|
|
|
before do
|
|
|
|
subject.active = true
|
|
|
|
end
|
2016-04-05 13:11:31 +00:00
|
|
|
|
2016-04-21 15:13:14 +00:00
|
|
|
it { is_expected.to validate_presence_of(:build_type) }
|
|
|
|
it { is_expected.to validate_presence_of(:teamcity_url) }
|
|
|
|
it_behaves_like 'issue tracker service URL attribute', :teamcity_url
|
2016-04-05 13:11:31 +00:00
|
|
|
|
2016-04-21 15:13:14 +00:00
|
|
|
describe '#username' do
|
|
|
|
it 'does not validate the presence of username if password is nil' do
|
|
|
|
subject.password = nil
|
2016-04-05 13:11:31 +00:00
|
|
|
|
2016-04-21 15:13:14 +00:00
|
|
|
expect(subject).not_to validate_presence_of(:username)
|
|
|
|
end
|
2016-04-05 13:11:31 +00:00
|
|
|
|
2016-04-21 15:13:14 +00:00
|
|
|
it 'validates the presence of username if password is present' do
|
|
|
|
subject.password = 'secret'
|
2016-04-05 13:11:31 +00:00
|
|
|
|
2016-04-21 15:13:14 +00:00
|
|
|
expect(subject).to validate_presence_of(:username)
|
|
|
|
end
|
2015-10-15 07:09:01 +00:00
|
|
|
end
|
2016-04-05 13:11:31 +00:00
|
|
|
|
2016-04-21 15:13:14 +00:00
|
|
|
describe '#password' do
|
|
|
|
it 'does not validate the presence of password if username is nil' do
|
|
|
|
subject.username = nil
|
2016-04-05 13:11:31 +00:00
|
|
|
|
2016-04-21 15:13:14 +00:00
|
|
|
expect(subject).not_to validate_presence_of(:password)
|
|
|
|
end
|
2015-10-15 07:09:01 +00:00
|
|
|
|
2016-04-21 15:13:14 +00:00
|
|
|
it 'validates the presence of password if username is present' do
|
|
|
|
subject.username = 'john'
|
2016-04-05 13:11:31 +00:00
|
|
|
|
2016-04-21 15:13:14 +00:00
|
|
|
expect(subject).to validate_presence_of(:password)
|
|
|
|
end
|
2015-10-15 07:09:01 +00:00
|
|
|
end
|
2015-10-09 10:20:38 +00:00
|
|
|
end
|
2016-04-05 13:11:31 +00:00
|
|
|
|
2016-04-21 15:13:14 +00:00
|
|
|
context 'when service is inactive' do
|
2017-06-14 18:18:56 +00:00
|
|
|
before do
|
|
|
|
subject.active = false
|
|
|
|
end
|
2016-04-05 13:11:31 +00:00
|
|
|
|
2016-04-21 15:13:14 +00:00
|
|
|
it { is_expected.not_to validate_presence_of(:build_type) }
|
|
|
|
it { is_expected.not_to validate_presence_of(:teamcity_url) }
|
|
|
|
it { is_expected.not_to validate_presence_of(:username) }
|
|
|
|
it { is_expected.not_to validate_presence_of(:password) }
|
2015-10-09 10:20:38 +00:00
|
|
|
end
|
|
|
|
end
|
2016-04-05 13:11:31 +00:00
|
|
|
|
|
|
|
describe 'Callbacks' do
|
|
|
|
describe 'before_update :reset_password' do
|
|
|
|
context 'when a password was previously set' do
|
|
|
|
it 'resets password if url changed' do
|
|
|
|
teamcity_service = service
|
|
|
|
|
|
|
|
teamcity_service.teamcity_url = 'http://gitlab1.com'
|
|
|
|
teamcity_service.save
|
|
|
|
|
|
|
|
expect(teamcity_service.password).to be_nil
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not reset password if username changed' do
|
|
|
|
teamcity_service = service
|
|
|
|
|
|
|
|
teamcity_service.username = 'some_name'
|
|
|
|
teamcity_service.save
|
|
|
|
|
|
|
|
expect(teamcity_service.password).to eq('password')
|
|
|
|
end
|
|
|
|
|
|
|
|
it "does not reset password if new url is set together with password, even if it's the same password" do
|
|
|
|
teamcity_service = service
|
|
|
|
|
|
|
|
teamcity_service.teamcity_url = 'http://gitlab_edited.com'
|
|
|
|
teamcity_service.password = 'password'
|
|
|
|
teamcity_service.save
|
|
|
|
|
|
|
|
expect(teamcity_service.password).to eq('password')
|
|
|
|
expect(teamcity_service.teamcity_url).to eq('http://gitlab_edited.com')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'saves password if new url is set together with password when no password was previously set' do
|
|
|
|
teamcity_service = service
|
|
|
|
teamcity_service.password = nil
|
|
|
|
|
|
|
|
teamcity_service.teamcity_url = 'http://gitlab_edited.com'
|
|
|
|
teamcity_service.password = 'password'
|
|
|
|
teamcity_service.save
|
|
|
|
|
|
|
|
expect(teamcity_service.password).to eq('password')
|
|
|
|
expect(teamcity_service.teamcity_url).to eq('http://gitlab_edited.com')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#build_page' do
|
2017-01-12 22:31:02 +00:00
|
|
|
it 'returns the contents of the reactive cache' do
|
|
|
|
stub_reactive_cache(service, { build_page: 'foo' }, 'sha', 'ref')
|
2016-04-05 13:11:31 +00:00
|
|
|
|
2017-01-12 22:31:02 +00:00
|
|
|
expect(service.build_page('sha', 'ref')).to eq('foo')
|
2016-04-05 13:11:31 +00:00
|
|
|
end
|
2017-01-12 22:31:02 +00:00
|
|
|
end
|
2016-04-05 13:11:31 +00:00
|
|
|
|
2017-01-12 22:31:02 +00:00
|
|
|
describe '#commit_status' do
|
|
|
|
it 'returns the contents of the reactive cache' do
|
|
|
|
stub_reactive_cache(service, { commit_status: 'foo' }, 'sha', 'ref')
|
2016-04-05 13:11:31 +00:00
|
|
|
|
2017-01-12 22:31:02 +00:00
|
|
|
expect(service.commit_status('sha', 'ref')).to eq('foo')
|
2016-04-05 13:11:31 +00:00
|
|
|
end
|
2017-01-12 22:31:02 +00:00
|
|
|
end
|
2016-04-05 13:11:31 +00:00
|
|
|
|
2017-01-12 22:31:02 +00:00
|
|
|
describe '#calculate_reactive_cache' do
|
|
|
|
context 'build_page' do
|
|
|
|
subject { service.calculate_reactive_cache('123', 'unused')[:build_page] }
|
2016-04-05 13:11:31 +00:00
|
|
|
|
2017-01-12 22:31:02 +00:00
|
|
|
it 'returns a specific URL when status is 500' do
|
|
|
|
stub_request(status: 500)
|
2016-04-05 13:11:31 +00:00
|
|
|
|
2017-01-12 22:31:02 +00:00
|
|
|
is_expected.to eq('http://gitlab.com/teamcity/viewLog.html?buildTypeId=foo')
|
|
|
|
end
|
2016-04-05 13:11:31 +00:00
|
|
|
|
2017-01-12 22:31:02 +00:00
|
|
|
it 'returns a build URL when teamcity_url has no trailing slash' do
|
2017-02-22 22:39:43 +00:00
|
|
|
stub_request(body: %q({"build":{"id":"666"}}))
|
2016-04-05 13:11:31 +00:00
|
|
|
|
2017-01-12 22:31:02 +00:00
|
|
|
is_expected.to eq('http://gitlab.com/teamcity/viewLog.html?buildId=666&buildTypeId=foo')
|
|
|
|
end
|
2016-04-05 13:11:31 +00:00
|
|
|
|
2017-01-12 22:31:02 +00:00
|
|
|
context 'teamcity_url has trailing slash' do
|
|
|
|
let(:teamcity_url) { 'http://gitlab.com/teamcity/' }
|
2016-04-05 13:11:31 +00:00
|
|
|
|
2017-01-12 22:31:02 +00:00
|
|
|
it 'returns a build URL' do
|
2017-02-22 22:39:43 +00:00
|
|
|
stub_request(body: %q({"build":{"id":"666"}}))
|
2016-04-05 13:11:31 +00:00
|
|
|
|
2017-01-12 22:31:02 +00:00
|
|
|
is_expected.to eq('http://gitlab.com/teamcity/viewLog.html?buildId=666&buildTypeId=foo')
|
|
|
|
end
|
|
|
|
end
|
2016-04-05 13:11:31 +00:00
|
|
|
end
|
|
|
|
|
2017-01-12 22:31:02 +00:00
|
|
|
context 'commit_status' do
|
|
|
|
subject { service.calculate_reactive_cache('123', 'unused')[:commit_status] }
|
2016-04-05 13:11:31 +00:00
|
|
|
|
2017-01-12 22:31:02 +00:00
|
|
|
it 'sets commit status to :error when status is 500' do
|
|
|
|
stub_request(status: 500)
|
2016-04-05 13:11:31 +00:00
|
|
|
|
2017-01-12 22:31:02 +00:00
|
|
|
is_expected.to eq(:error)
|
|
|
|
end
|
2016-04-05 13:11:31 +00:00
|
|
|
|
2017-01-12 22:31:02 +00:00
|
|
|
it 'sets commit status to "pending" when status is 404' do
|
|
|
|
stub_request(status: 404)
|
2016-04-05 13:11:31 +00:00
|
|
|
|
2017-01-12 22:31:02 +00:00
|
|
|
is_expected.to eq('pending')
|
|
|
|
end
|
2016-04-05 13:11:31 +00:00
|
|
|
|
2017-01-12 22:31:02 +00:00
|
|
|
it 'sets commit status to "success" when build status contains SUCCESS' do
|
|
|
|
stub_request(build_status: 'YAY SUCCESS!')
|
2016-04-05 13:11:31 +00:00
|
|
|
|
2017-01-12 22:31:02 +00:00
|
|
|
is_expected.to eq('success')
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'sets commit status to "failed" when build status contains FAILURE' do
|
|
|
|
stub_request(build_status: 'NO FAILURE!')
|
|
|
|
|
|
|
|
is_expected.to eq('failed')
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'sets commit status to "pending" when build status contains Pending' do
|
|
|
|
stub_request(build_status: 'NO Pending!')
|
|
|
|
|
|
|
|
is_expected.to eq('pending')
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'sets commit status to :error when build status is unknown' do
|
|
|
|
stub_request(build_status: 'FOO BAR!')
|
|
|
|
|
|
|
|
is_expected.to eq(:error)
|
|
|
|
end
|
|
|
|
end
|
2016-04-05 13:11:31 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
def stub_request(status: 200, body: nil, build_status: 'success')
|
2019-01-10 16:34:49 +00:00
|
|
|
teamcity_full_url = 'http://gitlab.com/teamcity/httpAuth/app/rest/builds/branch:unspecified:any,revision:123'
|
2017-06-27 00:59:45 +00:00
|
|
|
auth = %w(mic password)
|
|
|
|
|
2017-02-22 22:39:43 +00:00
|
|
|
body ||= %Q({"build":{"status":"#{build_status}","id":"666"}})
|
2016-04-05 13:11:31 +00:00
|
|
|
|
2017-06-27 00:59:45 +00:00
|
|
|
WebMock.stub_request(:get, teamcity_full_url).with(basic_auth: auth).to_return(
|
2016-04-05 13:11:31 +00:00
|
|
|
status: status,
|
|
|
|
headers: { 'Content-Type' => 'application/json' },
|
|
|
|
body: body
|
|
|
|
)
|
|
|
|
end
|
2015-10-09 10:20:38 +00:00
|
|
|
end
|