2017-08-24 16:17:04 +00:00
|
|
|
require 'spec_helper'
|
|
|
|
|
|
|
|
describe IssuableCollections do
|
|
|
|
let(:user) { create(:user) }
|
|
|
|
|
|
|
|
let(:controller) do
|
|
|
|
klass = Class.new do
|
|
|
|
def self.helper_method(name); end
|
|
|
|
|
|
|
|
include IssuableCollections
|
2018-02-20 12:33:49 +00:00
|
|
|
|
|
|
|
def finder_type
|
|
|
|
IssuesFinder
|
|
|
|
end
|
2017-08-24 16:17:04 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
controller = klass.new
|
|
|
|
|
2017-11-13 04:14:18 +00:00
|
|
|
allow(controller).to receive(:params).and_return(ActionController::Parameters.new(params))
|
2019-01-07 00:00:48 +00:00
|
|
|
allow(controller).to receive(:current_user).and_return(user)
|
2017-08-24 16:17:04 +00:00
|
|
|
|
|
|
|
controller
|
|
|
|
end
|
|
|
|
|
2019-01-07 00:00:48 +00:00
|
|
|
describe '#set_sort_order_from_user_preference' do
|
|
|
|
describe 'when sort param given' do
|
|
|
|
let(:params) { { sort: 'updated_desc' } }
|
|
|
|
|
|
|
|
context 'when issuable_sorting_field is defined' do
|
|
|
|
before do
|
|
|
|
controller.class.define_method(:issuable_sorting_field) { :issues_sort}
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'sets user_preference with the right value' do
|
|
|
|
controller.send(:set_sort_order_from_user_preference)
|
|
|
|
|
|
|
|
expect(user.user_preference.reload.issues_sort).to eq('updated_desc')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when no issuable_sorting_field is defined on the controller' do
|
|
|
|
it 'does not touch user_preference' do
|
|
|
|
allow(user).to receive(:user_preference)
|
|
|
|
|
|
|
|
controller.send(:set_sort_order_from_user_preference)
|
|
|
|
|
|
|
|
expect(user).not_to have_received(:user_preference)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when a user sorting preference exists' do
|
|
|
|
let(:params) { {} }
|
|
|
|
|
|
|
|
before do
|
|
|
|
controller.class.define_method(:issuable_sorting_field) { :issues_sort }
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns the set preference' do
|
|
|
|
user.user_preference.update(issues_sort: 'updated_asc')
|
|
|
|
|
|
|
|
sort_preference = controller.send(:set_sort_order_from_user_preference)
|
|
|
|
|
|
|
|
expect(sort_preference).to eq('updated_asc')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-08-30 20:39:56 +00:00
|
|
|
describe '#set_set_order_from_cookie' do
|
|
|
|
describe 'when sort param given' do
|
|
|
|
let(:cookies) { {} }
|
|
|
|
let(:params) { { sort: 'downvotes_asc' } }
|
|
|
|
|
|
|
|
it 'sets the cookie with the right values and flags' do
|
|
|
|
allow(controller).to receive(:cookies).and_return(cookies)
|
|
|
|
|
|
|
|
controller.send(:set_sort_order_from_cookie)
|
|
|
|
|
|
|
|
expect(cookies['issue_sort']).to eq({ value: 'popularity', secure: false, httponly: false })
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'when cookie exists' do
|
|
|
|
let(:cookies) { { 'issue_sort' => 'id_asc' } }
|
|
|
|
let(:params) { {} }
|
|
|
|
|
|
|
|
it 'sets the cookie with the right values and flags' do
|
|
|
|
allow(controller).to receive(:cookies).and_return(cookies)
|
|
|
|
|
|
|
|
controller.send(:set_sort_order_from_cookie)
|
|
|
|
|
|
|
|
expect(cookies['issue_sort']).to eq({ value: 'created_asc', secure: false, httponly: false })
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-08-24 16:17:04 +00:00
|
|
|
describe '#page_count_for_relation' do
|
2017-11-13 04:14:18 +00:00
|
|
|
let(:params) { { state: 'opened' } }
|
|
|
|
|
2017-08-24 16:17:04 +00:00
|
|
|
it 'returns the number of pages' do
|
|
|
|
relation = double(:relation, limit_value: 20)
|
|
|
|
pages = controller.send(:page_count_for_relation, relation, 28)
|
|
|
|
|
|
|
|
expect(pages).to eq(2)
|
|
|
|
end
|
|
|
|
end
|
2017-11-13 04:14:18 +00:00
|
|
|
|
2018-11-09 14:29:45 +00:00
|
|
|
describe '#finder_options' do
|
2017-11-13 04:14:18 +00:00
|
|
|
let(:params) do
|
|
|
|
{
|
|
|
|
assignee_id: '1',
|
|
|
|
assignee_username: 'user1',
|
|
|
|
author_id: '2',
|
|
|
|
author_username: 'user2',
|
2019-02-25 20:42:34 +00:00
|
|
|
authorized_only: 'true',
|
2017-11-13 04:14:18 +00:00
|
|
|
due_date: '2017-01-01',
|
|
|
|
group_id: '3',
|
|
|
|
iids: '4',
|
|
|
|
label_name: 'foo',
|
|
|
|
milestone_title: 'bar',
|
|
|
|
my_reaction_emoji: 'thumbsup',
|
|
|
|
non_archived: 'true',
|
|
|
|
project_id: '5',
|
|
|
|
scope: 'all',
|
|
|
|
search: 'baz',
|
|
|
|
sort: 'priority',
|
|
|
|
state: 'opened',
|
|
|
|
invalid_param: 'invalid_param'
|
|
|
|
}
|
|
|
|
end
|
|
|
|
|
2018-11-09 14:29:45 +00:00
|
|
|
it 'only allows whitelisted params' do
|
2017-11-13 04:14:18 +00:00
|
|
|
allow(controller).to receive(:cookies).and_return({})
|
2018-12-03 12:46:47 +00:00
|
|
|
allow(controller).to receive(:current_user).and_return(nil)
|
2017-11-13 04:14:18 +00:00
|
|
|
|
2018-11-09 14:29:45 +00:00
|
|
|
finder_options = controller.send(:finder_options)
|
2017-11-13 04:14:18 +00:00
|
|
|
|
2018-12-16 12:01:11 +00:00
|
|
|
expect(finder_options).to eq(ActionController::Parameters.new({
|
2017-11-13 04:14:18 +00:00
|
|
|
'assignee_id' => '1',
|
|
|
|
'assignee_username' => 'user1',
|
|
|
|
'author_id' => '2',
|
|
|
|
'author_username' => 'user2',
|
|
|
|
'label_name' => 'foo',
|
|
|
|
'milestone_title' => 'bar',
|
|
|
|
'my_reaction_emoji' => 'thumbsup',
|
2018-11-09 14:29:45 +00:00
|
|
|
'due_date' => '2017-01-01',
|
2017-11-13 04:14:18 +00:00
|
|
|
'scope' => 'all',
|
|
|
|
'search' => 'baz',
|
|
|
|
'sort' => 'priority',
|
|
|
|
'state' => 'opened'
|
2018-12-16 12:01:11 +00:00
|
|
|
}).permit!)
|
2017-11-13 04:14:18 +00:00
|
|
|
end
|
|
|
|
end
|
2017-08-24 16:17:04 +00:00
|
|
|
end
|