2018-07-16 12:31:01 -04:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2014-04-02 06:54:41 -04:00
|
|
|
module Issues
|
2014-04-02 12:55:23 -04:00
|
|
|
class UpdateService < Issues::BaseService
|
2020-10-01 14:10:20 -04:00
|
|
|
extend ::Gitlab::Utils::Override
|
2017-02-14 14:07:11 -05:00
|
|
|
|
2014-04-02 06:54:41 -04:00
|
|
|
def execute(issue)
|
2017-08-28 17:56:49 -04:00
|
|
|
handle_move_between_ids(issue)
|
2021-01-27 04:09:01 -05:00
|
|
|
|
|
|
|
@request = params.delete(:request)
|
|
|
|
@spam_params = Spam::SpamActionService.filter_spam_params!(params)
|
|
|
|
|
2017-07-20 10:42:33 -04:00
|
|
|
change_issue_duplicate(issue)
|
2020-12-03 16:09:35 -05:00
|
|
|
move_issue_to_new_project(issue) || clone_issue(issue) || update_task_event(issue) || update(issue)
|
2014-04-02 06:54:41 -04:00
|
|
|
end
|
2015-11-12 18:13:45 -05:00
|
|
|
|
2018-10-19 03:16:58 -04:00
|
|
|
def update(issue)
|
|
|
|
create_merge_request_from_quick_action
|
|
|
|
|
|
|
|
super
|
|
|
|
end
|
|
|
|
|
2020-10-01 14:10:20 -04:00
|
|
|
override :filter_params
|
|
|
|
def filter_params(issue)
|
|
|
|
super
|
|
|
|
|
|
|
|
# filter confidential in `Issues::UpdateService` and not in `IssuableBaseService#filtr_params`
|
|
|
|
# because we do allow users that cannot admin issues to set confidential flag when creating an issue
|
|
|
|
unless can_admin_issuable?(issue)
|
|
|
|
params.delete(:confidential)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-07-09 11:21:10 -04:00
|
|
|
def before_update(issue, skip_spam_check: false)
|
2021-01-27 04:09:01 -05:00
|
|
|
return if skip_spam_check
|
|
|
|
|
|
|
|
Spam::SpamActionService.new(
|
|
|
|
spammable: issue,
|
|
|
|
request: request,
|
|
|
|
user: current_user,
|
|
|
|
action: :update
|
|
|
|
).execute(spam_params: spam_params)
|
2017-02-14 14:07:11 -05:00
|
|
|
end
|
|
|
|
|
2020-04-30 08:09:45 -04:00
|
|
|
def after_update(issue)
|
2020-08-05 08:09:45 -04:00
|
|
|
IssuesChannel.broadcast_to(issue, event: 'updated') if Gitlab::ActionCable::Config.in_app? || Feature.enabled?(:broadcast_issue_updates, issue.project)
|
2020-04-30 08:09:45 -04:00
|
|
|
end
|
|
|
|
|
2017-05-04 08:11:15 -04:00
|
|
|
def handle_changes(issue, options)
|
2017-11-21 12:13:07 -05:00
|
|
|
old_associations = options.fetch(:old_associations, {})
|
|
|
|
old_labels = old_associations.fetch(:labels, [])
|
|
|
|
old_mentioned_users = old_associations.fetch(:mentioned_users, [])
|
|
|
|
old_assignees = old_associations.fetch(:assignees, [])
|
2017-05-04 08:11:15 -04:00
|
|
|
|
|
|
|
if has_changes?(issue, old_labels: old_labels, old_assignees: old_assignees)
|
2020-05-28 14:08:37 -04:00
|
|
|
todo_service.resolve_todos_for_target(issue, current_user)
|
2016-02-18 16:12:52 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
if issue.previous_changes.include?('title') ||
|
2016-12-15 17:14:20 -05:00
|
|
|
issue.previous_changes.include?('description')
|
2017-03-28 02:25:43 -04:00
|
|
|
todo_service.update_issue(issue, current_user, old_mentioned_users)
|
2016-02-15 21:26:33 -05:00
|
|
|
end
|
|
|
|
|
2017-05-04 08:11:15 -04:00
|
|
|
if issue.assignees != old_assignees
|
|
|
|
create_assignee_note(issue, old_assignees)
|
2018-04-20 13:37:38 -04:00
|
|
|
notification_service.async.reassigned_issue(issue, current_user, old_assignees)
|
2020-08-17 05:10:08 -04:00
|
|
|
todo_service.reassigned_assignable(issue, current_user, old_assignees)
|
2020-09-10 17:08:28 -04:00
|
|
|
track_incident_action(current_user, issue, :incident_assigned)
|
2015-11-12 18:13:45 -05:00
|
|
|
end
|
2016-02-12 09:58:39 -05:00
|
|
|
|
2016-04-20 18:41:11 -04:00
|
|
|
if issue.previous_changes.include?('confidential')
|
2018-07-16 14:30:17 -04:00
|
|
|
# don't enqueue immediately to prevent todos removal in case of a mistake
|
2018-12-11 13:15:10 -05:00
|
|
|
TodosDestroyer::ConfidentialIssueWorker.perform_in(Todo::WAIT_FOR_DELETE, issue.id) if issue.confidential?
|
2016-04-20 18:41:11 -04:00
|
|
|
create_confidentiality_note(issue)
|
2020-09-17 23:09:28 -04:00
|
|
|
track_usage_event(:incident_management_incident_change_confidential, current_user.id)
|
2016-04-20 18:41:11 -04:00
|
|
|
end
|
|
|
|
|
2016-03-01 11:33:13 -05:00
|
|
|
added_labels = issue.labels - old_labels
|
2017-03-02 11:09:48 -05:00
|
|
|
|
2016-03-01 11:33:13 -05:00
|
|
|
if added_labels.present?
|
2018-04-20 13:37:38 -04:00
|
|
|
notification_service.async.relabeled_issue(issue, added_labels, current_user)
|
2016-02-12 09:58:39 -05:00
|
|
|
end
|
2016-08-12 17:54:32 -04:00
|
|
|
|
2018-11-02 12:29:32 -04:00
|
|
|
handle_milestone_change(issue)
|
|
|
|
|
2019-10-11 14:06:15 -04:00
|
|
|
added_mentions = issue.mentioned_users(current_user) - old_mentioned_users
|
2017-03-02 11:09:48 -05:00
|
|
|
|
2016-08-12 17:54:32 -04:00
|
|
|
if added_mentions.present?
|
2018-04-20 13:37:38 -04:00
|
|
|
notification_service.async.new_mentions_in_issue(issue, added_mentions, current_user)
|
2016-08-12 17:54:32 -04:00
|
|
|
end
|
2015-11-12 18:13:45 -05:00
|
|
|
end
|
2015-11-17 06:42:43 -05:00
|
|
|
|
2019-01-22 19:05:38 -05:00
|
|
|
def handle_task_changes(issuable)
|
2020-05-28 14:08:37 -04:00
|
|
|
todo_service.resolve_todos_for_target(issuable, current_user)
|
2019-01-22 19:05:38 -05:00
|
|
|
todo_service.update_issue(issuable, current_user)
|
|
|
|
end
|
|
|
|
|
2017-08-31 15:34:57 -04:00
|
|
|
def handle_move_between_ids(issue)
|
2017-08-28 17:56:49 -04:00
|
|
|
return unless params[:move_between_ids]
|
2017-03-02 11:09:48 -05:00
|
|
|
|
2017-08-28 17:56:49 -04:00
|
|
|
after_id, before_id = params.delete(:move_between_ids)
|
2018-03-28 15:12:56 -04:00
|
|
|
board_group_id = params.delete(:board_group_id)
|
2017-03-02 11:09:48 -05:00
|
|
|
|
2018-03-28 15:12:56 -04:00
|
|
|
issue_before = get_issue_if_allowed(before_id, board_group_id)
|
|
|
|
issue_after = get_issue_if_allowed(after_id, board_group_id)
|
2019-05-31 21:19:08 -04:00
|
|
|
raise ActiveRecord::RecordNotFound unless issue_before || issue_after
|
2017-03-02 11:09:48 -05:00
|
|
|
|
|
|
|
issue.move_between(issue_before, issue_after)
|
2020-08-26 20:10:33 -04:00
|
|
|
rebalance_if_needed(issue)
|
2017-02-01 13:41:01 -05:00
|
|
|
end
|
|
|
|
|
2018-08-27 11:31:01 -04:00
|
|
|
# rubocop: disable CodeReuse/ActiveRecord
|
2017-07-20 10:42:33 -04:00
|
|
|
def change_issue_duplicate(issue)
|
|
|
|
canonical_issue_id = params.delete(:canonical_issue_id)
|
2019-01-22 19:05:38 -05:00
|
|
|
return unless canonical_issue_id
|
|
|
|
|
2017-07-20 10:42:33 -04:00
|
|
|
canonical_issue = IssuesFinder.new(current_user).find_by(id: canonical_issue_id)
|
|
|
|
|
|
|
|
if canonical_issue
|
|
|
|
Issues::DuplicateService.new(project, current_user).execute(issue, canonical_issue)
|
|
|
|
end
|
|
|
|
end
|
2018-08-27 11:31:01 -04:00
|
|
|
# rubocop: enable CodeReuse/ActiveRecord
|
2017-07-20 10:42:33 -04:00
|
|
|
|
2017-08-09 11:37:06 -04:00
|
|
|
def move_issue_to_new_project(issue)
|
|
|
|
target_project = params.delete(:target_project)
|
|
|
|
|
|
|
|
return unless target_project &&
|
|
|
|
issue.can_move?(current_user, target_project) &&
|
|
|
|
target_project != issue.project
|
|
|
|
|
|
|
|
update(issue)
|
|
|
|
Issues::MoveService.new(project, current_user).execute(issue, target_project)
|
|
|
|
end
|
|
|
|
|
2016-05-18 13:56:13 -04:00
|
|
|
private
|
|
|
|
|
2021-01-27 04:09:01 -05:00
|
|
|
attr_reader :request, :spam_params
|
|
|
|
|
2020-12-03 16:09:35 -05:00
|
|
|
def clone_issue(issue)
|
|
|
|
target_project = params.delete(:target_clone_project)
|
2020-12-07 19:09:45 -05:00
|
|
|
with_notes = params.delete(:clone_with_notes)
|
2020-12-03 16:09:35 -05:00
|
|
|
|
|
|
|
return unless target_project &&
|
|
|
|
issue.can_clone?(current_user, target_project)
|
|
|
|
|
|
|
|
# we've pre-empted this from running in #execute, so let's go ahead and update the Issue now.
|
|
|
|
update(issue)
|
2020-12-07 19:09:45 -05:00
|
|
|
Issues::CloneService.new(project, current_user).execute(issue, target_project, with_notes: with_notes)
|
2020-12-03 16:09:35 -05:00
|
|
|
end
|
|
|
|
|
2018-10-19 03:16:58 -04:00
|
|
|
def create_merge_request_from_quick_action
|
|
|
|
create_merge_request_params = params.delete(:create_merge_request)
|
|
|
|
return unless create_merge_request_params
|
|
|
|
|
|
|
|
MergeRequests::CreateFromIssueService.new(project, current_user, create_merge_request_params).execute
|
|
|
|
end
|
|
|
|
|
2018-11-02 12:29:32 -04:00
|
|
|
def handle_milestone_change(issue)
|
|
|
|
return unless issue.previous_changes.include?('milestone_id')
|
|
|
|
|
2020-03-04 19:07:49 -05:00
|
|
|
invalidate_milestone_issue_counters(issue)
|
|
|
|
send_milestone_change_notification(issue)
|
|
|
|
end
|
|
|
|
|
|
|
|
def invalidate_milestone_issue_counters(issue)
|
|
|
|
issue.previous_changes['milestone_id'].each do |milestone_id|
|
|
|
|
next unless milestone_id
|
|
|
|
|
|
|
|
milestone = Milestone.find_by_id(milestone_id)
|
|
|
|
|
|
|
|
delete_milestone_closed_issue_counter_cache(milestone)
|
|
|
|
delete_milestone_total_issue_counter_cache(milestone)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def send_milestone_change_notification(issue)
|
|
|
|
return if skip_milestone_email
|
|
|
|
|
2018-11-02 12:29:32 -04:00
|
|
|
if issue.milestone.nil?
|
|
|
|
notification_service.async.removed_milestone_issue(issue, current_user)
|
|
|
|
else
|
|
|
|
notification_service.async.changed_milestone_issue(issue, issue.milestone, current_user)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-08-27 11:31:01 -04:00
|
|
|
# rubocop: disable CodeReuse/ActiveRecord
|
2018-03-28 15:12:56 -04:00
|
|
|
def get_issue_if_allowed(id, board_group_id = nil)
|
|
|
|
return unless id
|
|
|
|
|
|
|
|
issue =
|
|
|
|
if board_group_id
|
2018-04-05 14:14:04 -04:00
|
|
|
IssuesFinder.new(current_user, group_id: board_group_id, include_subgroups: true).find_by(id: id)
|
2018-03-28 15:12:56 -04:00
|
|
|
else
|
|
|
|
project.issues.find(id)
|
|
|
|
end
|
|
|
|
|
2017-03-02 11:09:48 -05:00
|
|
|
issue if can?(current_user, :update_issue, issue)
|
|
|
|
end
|
2018-08-27 11:31:01 -04:00
|
|
|
# rubocop: enable CodeReuse/ActiveRecord
|
2017-03-02 11:09:48 -05:00
|
|
|
|
2016-05-18 13:56:13 -04:00
|
|
|
def create_confidentiality_note(issue)
|
|
|
|
SystemNoteService.change_issue_confidentiality(issue, issue.project, current_user)
|
|
|
|
end
|
2014-04-02 06:54:41 -04:00
|
|
|
end
|
|
|
|
end
|
2019-09-13 09:26:31 -04:00
|
|
|
|
|
|
|
Issues::UpdateService.prepend_if_ee('EE::Issues::UpdateService')
|