gitlab-org--gitlab-foss/danger/duplicate_yarn_dependencies/Dangerfile

# frozen_string_literal: true

return unless helper.all_changed_files.include?('yarn.lock')

duplicate = `node_modules/.bin/yarn-deduplicate --list --strategy fewer yarn.lock`
             .split(/$/)
             .map(&:strip)
             .reject(&:empty?)

return if duplicate.empty?

warn 'This merge request has introduced duplicated yarn dependencies.'

if GitlabDanger.new(helper.gitlab_helper).ci?
  markdown(<<~MARKDOWN)
    ## Duplicate yarn dependencies

    The following dependencies should be de-duplicated:

    * #{duplicate.map { |path| "`#{path}`" }.join("\n* ")}

    Please run the following command and commit the changes to `yarn.lock`:

    ```
    node_modules/.bin/yarn-deduplicate --strategy fewer yarn.lock \\
      && yarn install
    ```
  MARKDOWN
end
Add danger check for duplicate yarn dependencies This danger check utilises `yarn-deduplicate` in order to show duplicate dependencies in the yarn.lock dependency tree. Often when introducing new dependencies or updating existing ones, yarn does not seem to build the most optimal dependency tree. In order to prevent those unnecessary dependency updates we are nudging developers and maintainers to resolve these issues in MRs. Automating this with danger especially helps, as yarn.lock files are not that easy to review. 2018-09-07 07:20:06 -04:00			`# frozen_string_literal: true`

Add new GitlabDanger class This class encapsulates our use of the Danger gem. 2019-09-06 07:21:53 -04:00			`return unless helper.all_changed_files.include?('yarn.lock')`
Add danger check for duplicate yarn dependencies This danger check utilises `yarn-deduplicate` in order to show duplicate dependencies in the yarn.lock dependency tree. Often when introducing new dependencies or updating existing ones, yarn does not seem to build the most optimal dependency tree. In order to prevent those unnecessary dependency updates we are nudging developers and maintainers to resolve these issues in MRs. Automating this with danger especially helps, as yarn.lock files are not that easy to review. 2018-09-07 07:20:06 -04:00
			duplicate = `node_modules/.bin/yarn-deduplicate --list --strategy fewer yarn.lock`
			`.split(/$/)`
			`.map(&:strip)`
			`.reject(&:empty?)`

			`return if duplicate.empty?`

			`warn 'This merge request has introduced duplicated yarn dependencies.'`

Add new GitlabDanger class This class encapsulates our use of the Danger gem. 2019-09-06 07:21:53 -04:00			`if GitlabDanger.new(helper.gitlab_helper).ci?`
			`markdown(<<~MARKDOWN)`
			`## Duplicate yarn dependencies`
Add danger check for duplicate yarn dependencies This danger check utilises `yarn-deduplicate` in order to show duplicate dependencies in the yarn.lock dependency tree. Often when introducing new dependencies or updating existing ones, yarn does not seem to build the most optimal dependency tree. In order to prevent those unnecessary dependency updates we are nudging developers and maintainers to resolve these issues in MRs. Automating this with danger especially helps, as yarn.lock files are not that easy to review. 2018-09-07 07:20:06 -04:00
Add new GitlabDanger class This class encapsulates our use of the Danger gem. 2019-09-06 07:21:53 -04:00			`The following dependencies should be de-duplicated:`
Add danger check for duplicate yarn dependencies This danger check utilises `yarn-deduplicate` in order to show duplicate dependencies in the yarn.lock dependency tree. Often when introducing new dependencies or updating existing ones, yarn does not seem to build the most optimal dependency tree. In order to prevent those unnecessary dependency updates we are nudging developers and maintainers to resolve these issues in MRs. Automating this with danger especially helps, as yarn.lock files are not that easy to review. 2018-09-07 07:20:06 -04:00
Add new GitlabDanger class This class encapsulates our use of the Danger gem. 2019-09-06 07:21:53 -04:00			* #{duplicate.map { \|path\| "`#{path}`" }.join("\n* ")}
Add danger check for duplicate yarn dependencies This danger check utilises `yarn-deduplicate` in order to show duplicate dependencies in the yarn.lock dependency tree. Often when introducing new dependencies or updating existing ones, yarn does not seem to build the most optimal dependency tree. In order to prevent those unnecessary dependency updates we are nudging developers and maintainers to resolve these issues in MRs. Automating this with danger especially helps, as yarn.lock files are not that easy to review. 2018-09-07 07:20:06 -04:00
Add new GitlabDanger class This class encapsulates our use of the Danger gem. 2019-09-06 07:21:53 -04:00			Please run the following command and commit the changes to `yarn.lock`:
Add danger check for duplicate yarn dependencies This danger check utilises `yarn-deduplicate` in order to show duplicate dependencies in the yarn.lock dependency tree. Often when introducing new dependencies or updating existing ones, yarn does not seem to build the most optimal dependency tree. In order to prevent those unnecessary dependency updates we are nudging developers and maintainers to resolve these issues in MRs. Automating this with danger especially helps, as yarn.lock files are not that easy to review. 2018-09-07 07:20:06 -04:00
Add new GitlabDanger class This class encapsulates our use of the Danger gem. 2019-09-06 07:21:53 -04:00			```
			`node_modules/.bin/yarn-deduplicate --strategy fewer yarn.lock \\`
			`&& yarn install`
			```
			`MARKDOWN`
			`end`