2019-04-15 06:17:05 -04:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2016-12-22 13:56:33 -05:00
|
|
|
require 'spec_helper'
|
|
|
|
|
2020-06-03 14:08:28 -04:00
|
|
|
RSpec.describe Projects::PagesDomainsController do
|
2017-04-06 23:27:35 -04:00
|
|
|
let(:user) { create(:user) }
|
2017-08-02 15:55:11 -04:00
|
|
|
let(:project) { create(:project) }
|
2017-04-06 23:27:35 -04:00
|
|
|
let!(:pages_domain) { create(:pages_domain, project: project) }
|
2016-12-22 13:56:33 -05:00
|
|
|
|
|
|
|
let(:request_params) do
|
|
|
|
{
|
|
|
|
namespace_id: project.namespace,
|
|
|
|
project_id: project
|
|
|
|
}
|
|
|
|
end
|
|
|
|
|
2017-04-06 23:27:35 -04:00
|
|
|
let(:pages_domain_params) do
|
2019-06-21 08:06:12 -04:00
|
|
|
attributes_for(:pages_domain, domain: 'my.otherdomain.com').slice(:key, :certificate, :domain).tap do |params|
|
|
|
|
params[:user_provided_key] = params.delete(:key)
|
|
|
|
params[:user_provided_certificate] = params.delete(:certificate)
|
|
|
|
end
|
2017-04-06 23:27:35 -04:00
|
|
|
end
|
|
|
|
|
2016-12-22 13:56:33 -05:00
|
|
|
before do
|
2017-04-06 23:27:35 -04:00
|
|
|
allow(Gitlab.config.pages).to receive(:enabled).and_return(true)
|
2016-12-22 13:56:33 -05:00
|
|
|
sign_in(user)
|
2018-07-11 10:36:08 -04:00
|
|
|
project.add_maintainer(user)
|
2016-12-22 13:56:33 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
describe 'GET show' do
|
2019-02-12 07:18:17 -05:00
|
|
|
def make_request
|
2018-12-17 17:52:17 -05:00
|
|
|
get(:show, params: request_params.merge(id: pages_domain.domain))
|
2019-02-12 07:18:17 -05:00
|
|
|
end
|
2016-12-22 13:56:33 -05:00
|
|
|
|
2019-12-10 02:53:40 -05:00
|
|
|
it "displays to the 'show' page" do
|
2019-02-12 07:18:17 -05:00
|
|
|
make_request
|
2019-11-15 13:06:24 -05:00
|
|
|
|
2020-01-28 07:08:44 -05:00
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
2019-12-10 02:53:40 -05:00
|
|
|
expect(response).to render_template('show')
|
2016-12-22 13:56:33 -05:00
|
|
|
end
|
2019-02-12 07:18:17 -05:00
|
|
|
|
|
|
|
context 'when user is developer' do
|
|
|
|
before do
|
|
|
|
project.add_developer(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'renders 404 page' do
|
|
|
|
make_request
|
|
|
|
|
2020-01-28 07:08:44 -05:00
|
|
|
expect(response).to have_gitlab_http_status(:not_found)
|
2019-02-12 07:18:17 -05:00
|
|
|
end
|
|
|
|
end
|
2016-12-22 13:56:33 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
describe 'GET new' do
|
|
|
|
it "displays the 'new' page" do
|
2018-12-17 17:52:17 -05:00
|
|
|
get(:new, params: request_params)
|
2016-12-22 13:56:33 -05:00
|
|
|
|
2020-01-28 07:08:44 -05:00
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
2016-12-22 13:56:33 -05:00
|
|
|
expect(response).to render_template('new')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'POST create' do
|
|
|
|
it "creates a new pages domain" do
|
|
|
|
expect do
|
2018-12-17 17:52:17 -05:00
|
|
|
post(:create, params: request_params.merge(pages_domain: pages_domain_params))
|
2016-12-22 13:56:33 -05:00
|
|
|
end.to change { PagesDomain.count }.by(1)
|
|
|
|
|
2018-02-06 08:25:46 -05:00
|
|
|
created_domain = PagesDomain.reorder(:id).last
|
|
|
|
|
|
|
|
expect(created_domain).to be_present
|
2019-12-10 02:53:40 -05:00
|
|
|
expect(response).to redirect_to(project_pages_domain_path(project, created_domain))
|
2018-02-06 08:25:46 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-12-10 02:53:40 -05:00
|
|
|
describe 'GET show' do
|
|
|
|
it "displays the 'show' page" do
|
|
|
|
get(:show, params: request_params.merge(id: pages_domain.domain))
|
2018-02-25 08:06:09 -05:00
|
|
|
|
2020-01-28 07:08:44 -05:00
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
2019-12-10 02:53:40 -05:00
|
|
|
expect(response).to render_template('show')
|
2018-02-25 08:06:09 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'PATCH update' do
|
|
|
|
before do
|
|
|
|
controller.instance_variable_set(:@domain, pages_domain)
|
|
|
|
end
|
|
|
|
|
|
|
|
let(:params) do
|
|
|
|
request_params.merge(id: pages_domain.domain, pages_domain: pages_domain_params)
|
|
|
|
end
|
|
|
|
|
2019-06-21 08:06:12 -04:00
|
|
|
context 'with valid params' do
|
|
|
|
let(:pages_domain_params) do
|
|
|
|
attributes_for(:pages_domain, :with_trusted_chain).slice(:key, :certificate).tap do |params|
|
|
|
|
params[:user_provided_key] = params.delete(:key)
|
|
|
|
params[:user_provided_certificate] = params.delete(:certificate)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'updates the domain' do
|
|
|
|
expect do
|
|
|
|
patch(:update, params: params)
|
|
|
|
end.to change { pages_domain.reload.certificate }.to(pages_domain_params[:user_provided_certificate])
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'redirects to the project page' do
|
|
|
|
patch(:update, params: params)
|
2018-02-25 08:06:09 -05:00
|
|
|
|
2019-06-21 08:06:12 -04:00
|
|
|
expect(flash[:notice]).to eq 'Domain was updated'
|
|
|
|
expect(response).to redirect_to(project_pages_path(project))
|
|
|
|
end
|
2018-02-25 08:06:09 -05:00
|
|
|
end
|
|
|
|
|
2019-06-21 08:06:12 -04:00
|
|
|
context 'with key parameter' do
|
|
|
|
before do
|
|
|
|
pages_domain.update!(key: nil, certificate: nil, certificate_source: 'gitlab_provided')
|
|
|
|
end
|
2018-02-25 08:06:09 -05:00
|
|
|
|
2019-06-21 08:06:12 -04:00
|
|
|
it 'marks certificate as provided by user' do
|
|
|
|
expect do
|
|
|
|
patch(:update, params: params)
|
|
|
|
end.to change { pages_domain.reload.certificate_source }.from('gitlab_provided').to('user_provided')
|
|
|
|
end
|
2018-02-25 08:06:09 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'the domain is invalid' do
|
2019-06-21 08:06:12 -04:00
|
|
|
let(:pages_domain_params) { { user_provided_certificate: 'blabla' } }
|
2018-02-25 08:06:09 -05:00
|
|
|
|
2019-12-10 02:53:40 -05:00
|
|
|
it 'renders the show action' do
|
2018-12-17 17:52:17 -05:00
|
|
|
patch(:update, params: params)
|
2018-02-25 08:06:09 -05:00
|
|
|
|
2019-12-10 02:53:40 -05:00
|
|
|
expect(response).to render_template('show')
|
2018-02-25 08:06:09 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-06-21 08:06:12 -04:00
|
|
|
context 'when parameters include the domain' do
|
|
|
|
it 'does not update domain' do
|
|
|
|
expect do
|
|
|
|
patch(:update, params: params.deep_merge(pages_domain: { domain: 'abc' }))
|
|
|
|
end.not_to change { pages_domain.reload.domain }
|
2018-02-25 08:06:09 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-02-06 08:25:46 -05:00
|
|
|
describe 'POST verify' do
|
|
|
|
let(:params) { request_params.merge(id: pages_domain.domain) }
|
|
|
|
|
|
|
|
it 'handles verification success' do
|
2020-05-08 02:09:40 -04:00
|
|
|
expect_next_instance_of(VerifyPagesDomainService, pages_domain) do |service|
|
|
|
|
expect(service).to receive(:execute).and_return(status: :success)
|
|
|
|
end
|
2018-02-06 08:25:46 -05:00
|
|
|
|
2018-12-17 17:52:17 -05:00
|
|
|
post :verify, params: params
|
2018-02-06 08:25:46 -05:00
|
|
|
|
2019-12-10 02:53:40 -05:00
|
|
|
expect(response).to redirect_to project_pages_domain_path(project, pages_domain)
|
2018-02-06 08:25:46 -05:00
|
|
|
expect(flash[:notice]).to eq('Successfully verified domain ownership')
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'handles verification failure' do
|
2020-05-08 02:09:40 -04:00
|
|
|
expect_next_instance_of(VerifyPagesDomainService, pages_domain) do |service|
|
|
|
|
expect(service).to receive(:execute).and_return(status: :failed)
|
|
|
|
end
|
2018-02-06 08:25:46 -05:00
|
|
|
|
2018-12-17 17:52:17 -05:00
|
|
|
post :verify, params: params
|
2018-02-06 08:25:46 -05:00
|
|
|
|
2019-12-10 02:53:40 -05:00
|
|
|
expect(response).to redirect_to project_pages_domain_path(project, pages_domain)
|
2018-02-06 08:25:46 -05:00
|
|
|
expect(flash[:alert]).to eq('Failed to verify domain ownership')
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns a 404 response for an unknown domain' do
|
2018-12-17 17:52:17 -05:00
|
|
|
post :verify, params: request_params.merge(id: 'unknown-domain')
|
2018-02-06 08:25:46 -05:00
|
|
|
|
2020-01-28 07:08:44 -05:00
|
|
|
expect(response).to have_gitlab_http_status(:not_found)
|
2016-12-22 13:56:33 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2020-04-14 17:09:52 -04:00
|
|
|
describe 'POST retry_auto_ssl' do
|
|
|
|
before do
|
|
|
|
pages_domain.update!(auto_ssl_enabled: true, auto_ssl_failed: true)
|
|
|
|
end
|
|
|
|
|
|
|
|
let(:params) { request_params.merge(id: pages_domain.domain) }
|
|
|
|
|
|
|
|
it 'calls retry service and redirects' do
|
|
|
|
expect_next_instance_of(PagesDomains::RetryAcmeOrderService, pages_domain) do |service|
|
|
|
|
expect(service).to receive(:execute)
|
|
|
|
end
|
|
|
|
|
|
|
|
post :retry_auto_ssl, params: params
|
|
|
|
|
|
|
|
expect(response).to redirect_to project_pages_domain_path(project, pages_domain)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-12-22 13:56:33 -05:00
|
|
|
describe 'DELETE destroy' do
|
|
|
|
it "deletes the pages domain" do
|
|
|
|
expect do
|
2018-12-17 17:52:17 -05:00
|
|
|
delete(:destroy, params: request_params.merge(id: pages_domain.domain))
|
2016-12-22 13:56:33 -05:00
|
|
|
end.to change { PagesDomain.count }.by(-1)
|
|
|
|
|
2017-06-29 13:06:35 -04:00
|
|
|
expect(response).to redirect_to(project_pages_path(project))
|
2016-12-22 13:56:33 -05:00
|
|
|
end
|
|
|
|
end
|
2017-04-06 23:27:35 -04:00
|
|
|
|
2019-10-28 20:06:10 -04:00
|
|
|
describe 'DELETE #clean_certificate' do
|
|
|
|
subject do
|
|
|
|
delete(:clean_certificate, params: request_params.merge(id: pages_domain.domain))
|
|
|
|
end
|
|
|
|
|
2019-12-10 02:53:40 -05:00
|
|
|
it 'redirects to show page' do
|
2019-10-28 20:06:10 -04:00
|
|
|
subject
|
|
|
|
|
2019-12-10 02:53:40 -05:00
|
|
|
expect(response).to redirect_to(project_pages_domain_path(project, pages_domain))
|
2019-10-28 20:06:10 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'removes certificate' do
|
|
|
|
expect do
|
|
|
|
subject
|
|
|
|
end.to change { pages_domain.reload.certificate }.to(nil)
|
|
|
|
.and change { pages_domain.reload.key }.to(nil)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'sets certificate source to user_provided' do
|
|
|
|
pages_domain.update!(certificate_source: :gitlab_provided)
|
|
|
|
|
|
|
|
expect do
|
|
|
|
subject
|
|
|
|
end.to change { pages_domain.reload.certificate_source }.from("gitlab_provided").to("user_provided")
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when pages_https_only is set' do
|
|
|
|
before do
|
|
|
|
project.update!(pages_https_only: true)
|
|
|
|
stub_pages_setting(external_https: '127.0.0.1')
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not remove certificate' do
|
|
|
|
subject
|
|
|
|
|
|
|
|
pages_domain.reload
|
|
|
|
expect(pages_domain.certificate).to be_present
|
|
|
|
expect(pages_domain.key).to be_present
|
|
|
|
end
|
|
|
|
|
2019-12-10 02:53:40 -05:00
|
|
|
it 'redirects to show page with a flash message' do
|
2019-10-28 20:06:10 -04:00
|
|
|
subject
|
|
|
|
|
|
|
|
expect(flash[:alert]).to include('Certificate')
|
|
|
|
expect(flash[:alert]).to include('Key')
|
2019-12-10 02:53:40 -05:00
|
|
|
expect(response).to redirect_to(project_pages_domain_path(project, pages_domain))
|
2019-10-28 20:06:10 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-04-06 23:27:35 -04:00
|
|
|
context 'pages disabled' do
|
|
|
|
before do
|
|
|
|
allow(Gitlab.config.pages).to receive(:enabled).and_return(false)
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'GET show' do
|
|
|
|
it 'returns 404 status' do
|
2018-12-17 17:52:17 -05:00
|
|
|
get(:show, params: request_params.merge(id: pages_domain.domain))
|
2017-04-06 23:27:35 -04:00
|
|
|
|
2020-01-28 07:08:44 -05:00
|
|
|
expect(response).to have_gitlab_http_status(:not_found)
|
2017-04-06 23:27:35 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'GET new' do
|
|
|
|
it 'returns 404 status' do
|
2018-12-17 17:52:17 -05:00
|
|
|
get :new, params: request_params
|
2017-04-06 23:27:35 -04:00
|
|
|
|
2020-01-28 07:08:44 -05:00
|
|
|
expect(response).to have_gitlab_http_status(:not_found)
|
2017-04-06 23:27:35 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'POST create' do
|
|
|
|
it "returns 404 status" do
|
2018-12-17 17:52:17 -05:00
|
|
|
post(:create, params: request_params.merge(pages_domain: pages_domain_params))
|
2017-04-06 23:27:35 -04:00
|
|
|
|
2020-01-28 07:08:44 -05:00
|
|
|
expect(response).to have_gitlab_http_status(:not_found)
|
2017-04-06 23:27:35 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'DELETE destroy' do
|
|
|
|
it "deletes the pages domain" do
|
2018-12-17 17:52:17 -05:00
|
|
|
delete(:destroy, params: request_params.merge(id: pages_domain.domain))
|
2017-04-06 23:27:35 -04:00
|
|
|
|
2020-01-28 07:08:44 -05:00
|
|
|
expect(response).to have_gitlab_http_status(:not_found)
|
2017-04-06 23:27:35 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2016-12-22 13:56:33 -05:00
|
|
|
end
|