2019-08-22 06:14:30 -04:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2019-08-22 05:42:16 -04:00
|
|
|
require 'spec_helper'
|
|
|
|
|
|
|
|
require 'rubocop'
|
|
|
|
require 'rubocop/rspec/support'
|
|
|
|
|
|
|
|
require_relative '../../../../rubocop/cop/rspec/be_success_matcher'
|
|
|
|
|
|
|
|
describe RuboCop::Cop::RSpec::BeSuccessMatcher do
|
|
|
|
include CopHelper
|
|
|
|
|
2019-08-23 04:57:46 -04:00
|
|
|
CODE_EXAMPLES = [
|
|
|
|
{
|
|
|
|
bad: %(expect(response).to be_success).freeze,
|
|
|
|
good: %(expect(response).to be_successful).freeze
|
|
|
|
},
|
2019-08-23 05:05:50 -04:00
|
|
|
{
|
|
|
|
bad: %(expect(response).to_not be_success).freeze,
|
|
|
|
good: %(expect(response).to_not be_successful).freeze
|
|
|
|
},
|
|
|
|
{
|
|
|
|
bad: %(expect(response).not_to be_success).freeze,
|
|
|
|
good: %(expect(response).not_to be_successful).freeze
|
|
|
|
},
|
2019-08-23 04:57:46 -04:00
|
|
|
{
|
|
|
|
bad: %(is_expected.to be_success).freeze,
|
|
|
|
good: %(is_expected.to be_successful).freeze
|
2019-08-23 05:05:50 -04:00
|
|
|
},
|
|
|
|
{
|
|
|
|
bad: %(is_expected.to_not be_success).freeze,
|
|
|
|
good: %(is_expected.to_not be_successful).freeze
|
|
|
|
},
|
|
|
|
{
|
|
|
|
bad: %(is_expected.not_to be_success).freeze,
|
|
|
|
good: %(is_expected.not_to be_successful).freeze
|
2019-08-23 04:57:46 -04:00
|
|
|
}
|
2019-08-23 05:05:50 -04:00
|
|
|
].freeze
|
2019-08-22 05:42:16 -04:00
|
|
|
|
|
|
|
let(:source_file) { 'spec/foo_spec.rb' }
|
|
|
|
|
|
|
|
subject(:cop) { described_class.new }
|
|
|
|
|
|
|
|
shared_examples 'an offensive be_success call' do |content|
|
|
|
|
it "registers an offense for `#{content}`" do
|
|
|
|
inspect_source(content, source_file)
|
|
|
|
|
|
|
|
expect(cop.offenses.size).to eq(1)
|
|
|
|
expect(cop.offenses.map(&:line)).to eq([1])
|
|
|
|
expect(cop.highlights).to eq([content])
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-08-22 05:57:33 -04:00
|
|
|
shared_examples 'an autocorrected be_success call' do |content, autocorrected_content|
|
|
|
|
it "registers an offense for `#{content}` and autocorrects it to `#{autocorrected_content}`" do
|
|
|
|
autocorrected = autocorrect_source(content, source_file)
|
|
|
|
|
|
|
|
expect(autocorrected).to eql(autocorrected_content)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-08-22 05:42:16 -04:00
|
|
|
context 'in a controller spec file' do
|
|
|
|
before do
|
|
|
|
allow(cop).to receive(:in_controller_spec?).and_return(true)
|
|
|
|
end
|
|
|
|
|
2019-08-23 04:57:46 -04:00
|
|
|
CODE_EXAMPLES.each do |code_example|
|
|
|
|
context "using #{code_example[:bad]} call" do
|
|
|
|
it_behaves_like 'an offensive be_success call', code_example[:bad]
|
|
|
|
it_behaves_like 'an autocorrected be_success call', code_example[:bad], code_example[:good]
|
2019-08-22 05:42:16 -04:00
|
|
|
end
|
|
|
|
|
2019-08-23 04:57:46 -04:00
|
|
|
context "using #{code_example[:good]} call" do
|
2019-08-23 05:05:50 -04:00
|
|
|
it 'does not register an offense' do
|
2019-08-23 04:57:46 -04:00
|
|
|
inspect_source(code_example[:good])
|
2019-08-22 05:42:16 -04:00
|
|
|
|
2019-08-23 04:57:46 -04:00
|
|
|
expect(cop.offenses.size).to eq(0)
|
|
|
|
end
|
2019-08-22 05:42:16 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'outside of a controller spec file' do
|
2019-08-23 04:57:46 -04:00
|
|
|
CODE_EXAMPLES.each do |code_example|
|
|
|
|
context "using #{code_example[:bad]} call" do
|
|
|
|
it 'does not register an offense' do
|
|
|
|
inspect_source(code_example[:bad])
|
2019-08-22 05:42:16 -04:00
|
|
|
|
2019-08-23 04:57:46 -04:00
|
|
|
expect(cop.offenses.size).to eq(0)
|
|
|
|
end
|
2019-08-22 05:42:16 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|