2013-01-04 21:35:31 +00:00
|
|
|
require "spec_helper"
|
|
|
|
|
2015-12-09 09:50:51 +00:00
|
|
|
describe ProjectTeam, models: true do
|
2014-06-04 08:52:17 +00:00
|
|
|
let(:master) { create(:user) }
|
|
|
|
let(:reporter) { create(:user) }
|
|
|
|
let(:guest) { create(:user) }
|
|
|
|
let(:nonmember) { create(:user) }
|
2013-01-04 21:35:31 +00:00
|
|
|
|
2014-06-20 09:54:03 +00:00
|
|
|
context 'personal project' do
|
|
|
|
let(:project) { create(:empty_project) }
|
2014-06-04 08:52:17 +00:00
|
|
|
|
2014-06-20 09:54:03 +00:00
|
|
|
before do
|
|
|
|
project.team << [master, :master]
|
|
|
|
project.team << [reporter, :reporter]
|
|
|
|
project.team << [guest, :guest]
|
|
|
|
end
|
2014-06-04 08:52:17 +00:00
|
|
|
|
2014-06-20 09:54:03 +00:00
|
|
|
describe 'members collection' do
|
2015-02-12 18:17:35 +00:00
|
|
|
it { expect(project.team.masters).to include(master) }
|
|
|
|
it { expect(project.team.masters).not_to include(guest) }
|
|
|
|
it { expect(project.team.masters).not_to include(reporter) }
|
|
|
|
it { expect(project.team.masters).not_to include(nonmember) }
|
2014-06-20 09:54:03 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
describe 'access methods' do
|
2015-02-12 18:17:35 +00:00
|
|
|
it { expect(project.team.master?(master)).to be_truthy }
|
|
|
|
it { expect(project.team.master?(guest)).to be_falsey }
|
|
|
|
it { expect(project.team.master?(reporter)).to be_falsey }
|
|
|
|
it { expect(project.team.master?(nonmember)).to be_falsey }
|
|
|
|
it { expect(project.team.member?(nonmember)).to be_falsey }
|
|
|
|
it { expect(project.team.member?(guest)).to be_truthy }
|
2016-06-06 19:13:31 +00:00
|
|
|
it { expect(project.team.member?(reporter, Gitlab::Access::REPORTER)).to be_truthy }
|
|
|
|
it { expect(project.team.member?(guest, Gitlab::Access::REPORTER)).to be_falsey }
|
|
|
|
it { expect(project.team.member?(nonmember, Gitlab::Access::GUEST)).to be_falsey }
|
2014-06-20 09:54:03 +00:00
|
|
|
end
|
2014-06-04 08:52:17 +00:00
|
|
|
end
|
|
|
|
|
2014-06-20 09:54:03 +00:00
|
|
|
context 'group project' do
|
|
|
|
let(:group) { create(:group) }
|
|
|
|
let(:project) { create(:empty_project, group: group) }
|
|
|
|
|
|
|
|
before do
|
2015-08-07 04:20:02 +00:00
|
|
|
group.add_master(master)
|
|
|
|
group.add_reporter(reporter)
|
|
|
|
group.add_guest(guest)
|
2014-06-20 09:54:03 +00:00
|
|
|
|
|
|
|
# If user is a group and a project member - GitLab uses highest permission
|
|
|
|
# So we add group guest as master and add group master as guest
|
|
|
|
# to this project to test highest access
|
|
|
|
project.team << [guest, :master]
|
|
|
|
project.team << [master, :guest]
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'members collection' do
|
2015-02-12 18:17:35 +00:00
|
|
|
it { expect(project.team.reporters).to include(reporter) }
|
|
|
|
it { expect(project.team.masters).to include(master) }
|
|
|
|
it { expect(project.team.masters).to include(guest) }
|
|
|
|
it { expect(project.team.masters).not_to include(reporter) }
|
|
|
|
it { expect(project.team.masters).not_to include(nonmember) }
|
2014-06-20 09:54:03 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
describe 'access methods' do
|
2015-02-12 18:17:35 +00:00
|
|
|
it { expect(project.team.reporter?(reporter)).to be_truthy }
|
|
|
|
it { expect(project.team.master?(master)).to be_truthy }
|
|
|
|
it { expect(project.team.master?(guest)).to be_truthy }
|
|
|
|
it { expect(project.team.master?(reporter)).to be_falsey }
|
|
|
|
it { expect(project.team.master?(nonmember)).to be_falsey }
|
|
|
|
it { expect(project.team.member?(nonmember)).to be_falsey }
|
|
|
|
it { expect(project.team.member?(guest)).to be_truthy }
|
2016-06-06 19:13:31 +00:00
|
|
|
it { expect(project.team.member?(guest, Gitlab::Access::MASTER)).to be_truthy }
|
|
|
|
it { expect(project.team.member?(reporter, Gitlab::Access::MASTER)).to be_falsey }
|
|
|
|
it { expect(project.team.member?(nonmember, Gitlab::Access::GUEST)).to be_falsey }
|
2014-06-20 09:54:03 +00:00
|
|
|
end
|
2013-01-04 06:43:25 +00:00
|
|
|
end
|
2015-10-02 12:10:33 +00:00
|
|
|
|
2016-09-20 12:18:11 +00:00
|
|
|
describe '#fetch_members' do
|
|
|
|
context 'personal project' do
|
|
|
|
let(:project) { create(:empty_project) }
|
|
|
|
|
|
|
|
it 'returns project members' do
|
|
|
|
user = create(:user)
|
|
|
|
project.team << [user, :guest]
|
|
|
|
|
|
|
|
expect(project.team.members).to contain_exactly(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns project members of a specified level' do
|
|
|
|
user = create(:user)
|
|
|
|
project.team << [user, :reporter]
|
|
|
|
|
|
|
|
expect(project.team.guests).to be_empty
|
|
|
|
expect(project.team.reporters).to contain_exactly(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns invited members of a group' do
|
|
|
|
group_member = create(:group_member)
|
|
|
|
|
|
|
|
project.project_group_links.create!(
|
|
|
|
group: group_member.group,
|
|
|
|
group_access: Gitlab::Access::GUEST
|
|
|
|
)
|
|
|
|
|
|
|
|
expect(project.team.members).to contain_exactly(group_member.user)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns invited members of a group of a specified level' do
|
|
|
|
group_member = create(:group_member)
|
|
|
|
|
|
|
|
project.project_group_links.create!(
|
|
|
|
group: group_member.group,
|
|
|
|
group_access: Gitlab::Access::REPORTER
|
|
|
|
)
|
|
|
|
|
|
|
|
expect(project.team.reporters).to contain_exactly(group_member.user)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'group project' do
|
|
|
|
let(:group) { create(:group) }
|
|
|
|
let(:project) { create(:empty_project, group: group) }
|
|
|
|
|
|
|
|
it 'returns project members' do
|
|
|
|
group_member = create(:group_member, group: group)
|
|
|
|
|
|
|
|
expect(project.team.members).to contain_exactly(group_member.user)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns project members of a specified level' do
|
|
|
|
group_member = create(:group_member, :reporter, group: group)
|
|
|
|
|
|
|
|
expect(project.team.guests).to be_empty
|
|
|
|
expect(project.team.reporters).to contain_exactly(group_member.user)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-04-18 16:53:32 +00:00
|
|
|
describe '#find_member' do
|
|
|
|
context 'personal project' do
|
|
|
|
let(:project) { create(:empty_project) }
|
|
|
|
let(:requester) { create(:user) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
project.team << [master, :master]
|
|
|
|
project.team << [reporter, :reporter]
|
|
|
|
project.team << [guest, :guest]
|
|
|
|
project.request_access(requester)
|
|
|
|
end
|
|
|
|
|
|
|
|
it { expect(project.team.find_member(master.id)).to be_a(ProjectMember) }
|
|
|
|
it { expect(project.team.find_member(reporter.id)).to be_a(ProjectMember) }
|
|
|
|
it { expect(project.team.find_member(guest.id)).to be_a(ProjectMember) }
|
|
|
|
it { expect(project.team.find_member(nonmember.id)).to be_nil }
|
|
|
|
it { expect(project.team.find_member(requester.id)).to be_nil }
|
2016-03-12 13:45:14 +00:00
|
|
|
end
|
|
|
|
|
2016-04-18 16:53:32 +00:00
|
|
|
context 'group project' do
|
|
|
|
let(:group) { create(:group) }
|
|
|
|
let(:project) { create(:empty_project, group: group) }
|
|
|
|
let(:requester) { create(:user) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
group.add_master(master)
|
|
|
|
group.add_reporter(reporter)
|
|
|
|
group.add_guest(guest)
|
|
|
|
group.request_access(requester)
|
|
|
|
end
|
|
|
|
|
|
|
|
it { expect(project.team.find_member(master.id)).to be_a(GroupMember) }
|
|
|
|
it { expect(project.team.find_member(reporter.id)).to be_a(GroupMember) }
|
|
|
|
it { expect(project.team.find_member(guest.id)).to be_a(GroupMember) }
|
|
|
|
it { expect(project.team.find_member(nonmember.id)).to be_nil }
|
|
|
|
it { expect(project.team.find_member(requester.id)).to be_nil }
|
2016-03-12 13:45:14 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-06-02 16:05:06 +00:00
|
|
|
describe "#human_max_access" do
|
|
|
|
it 'returns Master role' do
|
|
|
|
user = create(:user)
|
|
|
|
group = create(:group)
|
|
|
|
group.add_master(user)
|
|
|
|
|
|
|
|
project = build_stubbed(:empty_project, namespace: group)
|
|
|
|
|
|
|
|
expect(project.team.human_max_access(user.id)).to eq 'Master'
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns Owner role' do
|
|
|
|
user = create(:user)
|
|
|
|
group = create(:group)
|
|
|
|
group.add_owner(user)
|
|
|
|
|
|
|
|
project = build_stubbed(:empty_project, namespace: group)
|
|
|
|
|
|
|
|
expect(project.team.human_max_access(user.id)).to eq 'Owner'
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-04-18 16:53:32 +00:00
|
|
|
describe '#max_member_access' do
|
|
|
|
let(:requester) { create(:user) }
|
|
|
|
|
|
|
|
context 'personal project' do
|
|
|
|
let(:project) { create(:empty_project) }
|
|
|
|
|
|
|
|
context 'when project is not shared with group' do
|
|
|
|
before do
|
|
|
|
project.team << [master, :master]
|
|
|
|
project.team << [reporter, :reporter]
|
|
|
|
project.team << [guest, :guest]
|
|
|
|
project.request_access(requester)
|
|
|
|
end
|
|
|
|
|
|
|
|
it { expect(project.team.max_member_access(master.id)).to eq(Gitlab::Access::MASTER) }
|
|
|
|
it { expect(project.team.max_member_access(reporter.id)).to eq(Gitlab::Access::REPORTER) }
|
|
|
|
it { expect(project.team.max_member_access(guest.id)).to eq(Gitlab::Access::GUEST) }
|
2016-07-20 04:52:31 +00:00
|
|
|
it { expect(project.team.max_member_access(nonmember.id)).to eq(Gitlab::Access::NO_ACCESS) }
|
|
|
|
it { expect(project.team.max_member_access(requester.id)).to eq(Gitlab::Access::NO_ACCESS) }
|
2016-04-18 16:53:32 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'when project is shared with group' do
|
|
|
|
before do
|
|
|
|
group = create(:group)
|
|
|
|
project.project_group_links.create(
|
|
|
|
group: group,
|
|
|
|
group_access: Gitlab::Access::DEVELOPER)
|
|
|
|
|
|
|
|
group.add_master(master)
|
|
|
|
group.add_reporter(reporter)
|
|
|
|
end
|
|
|
|
|
|
|
|
it { expect(project.team.max_member_access(master.id)).to eq(Gitlab::Access::DEVELOPER) }
|
|
|
|
it { expect(project.team.max_member_access(reporter.id)).to eq(Gitlab::Access::REPORTER) }
|
2016-07-20 04:52:31 +00:00
|
|
|
it { expect(project.team.max_member_access(nonmember.id)).to eq(Gitlab::Access::NO_ACCESS) }
|
|
|
|
it { expect(project.team.max_member_access(requester.id)).to eq(Gitlab::Access::NO_ACCESS) }
|
2016-04-18 16:53:32 +00:00
|
|
|
|
|
|
|
context 'but share_with_group_lock is true' do
|
|
|
|
before { project.namespace.update(share_with_group_lock: true) }
|
|
|
|
|
2016-07-20 04:52:31 +00:00
|
|
|
it { expect(project.team.max_member_access(master.id)).to eq(Gitlab::Access::NO_ACCESS) }
|
|
|
|
it { expect(project.team.max_member_access(reporter.id)).to eq(Gitlab::Access::NO_ACCESS) }
|
2016-04-18 16:53:32 +00:00
|
|
|
end
|
|
|
|
end
|
2016-02-18 21:39:59 +00:00
|
|
|
end
|
|
|
|
|
2016-04-18 16:53:32 +00:00
|
|
|
context 'group project' do
|
|
|
|
let(:group) { create(:group) }
|
|
|
|
let(:project) { create(:empty_project, group: group) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
group.add_master(master)
|
|
|
|
group.add_reporter(reporter)
|
|
|
|
group.add_guest(guest)
|
|
|
|
group.request_access(requester)
|
|
|
|
end
|
|
|
|
|
|
|
|
it { expect(project.team.max_member_access(master.id)).to eq(Gitlab::Access::MASTER) }
|
|
|
|
it { expect(project.team.max_member_access(reporter.id)).to eq(Gitlab::Access::REPORTER) }
|
|
|
|
it { expect(project.team.max_member_access(guest.id)).to eq(Gitlab::Access::GUEST) }
|
2016-07-20 04:52:31 +00:00
|
|
|
it { expect(project.team.max_member_access(nonmember.id)).to eq(Gitlab::Access::NO_ACCESS) }
|
|
|
|
it { expect(project.team.max_member_access(requester.id)).to eq(Gitlab::Access::NO_ACCESS) }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-08-01 20:11:45 +00:00
|
|
|
shared_examples_for "#max_member_access_for_users" do |enable_request_store|
|
|
|
|
describe "#max_member_access_for_users" do
|
|
|
|
before do
|
|
|
|
RequestStore.begin! if enable_request_store
|
|
|
|
end
|
2016-07-20 04:52:31 +00:00
|
|
|
|
2016-08-01 20:11:45 +00:00
|
|
|
after do
|
|
|
|
if enable_request_store
|
|
|
|
RequestStore.end!
|
|
|
|
RequestStore.clear!
|
|
|
|
end
|
|
|
|
end
|
2016-07-20 04:52:31 +00:00
|
|
|
|
2016-08-01 20:11:45 +00:00
|
|
|
it 'returns correct roles for different users' do
|
|
|
|
master = create(:user)
|
|
|
|
reporter = create(:user)
|
|
|
|
promoted_guest = create(:user)
|
|
|
|
guest = create(:user)
|
|
|
|
project = create(:project)
|
|
|
|
|
|
|
|
project.team << [master, :master]
|
|
|
|
project.team << [reporter, :reporter]
|
|
|
|
project.team << [promoted_guest, :guest]
|
|
|
|
project.team << [guest, :guest]
|
|
|
|
|
|
|
|
group = create(:group)
|
|
|
|
group_developer = create(:user)
|
|
|
|
second_developer = create(:user)
|
|
|
|
project.project_group_links.create(
|
|
|
|
group: group,
|
|
|
|
group_access: Gitlab::Access::DEVELOPER)
|
|
|
|
|
|
|
|
group.add_master(promoted_guest)
|
|
|
|
group.add_developer(group_developer)
|
|
|
|
group.add_developer(second_developer)
|
|
|
|
|
|
|
|
second_group = create(:group)
|
|
|
|
project.project_group_links.create(
|
|
|
|
group: second_group,
|
|
|
|
group_access: Gitlab::Access::MASTER)
|
|
|
|
second_group.add_master(second_developer)
|
|
|
|
|
|
|
|
users = [master, reporter, promoted_guest, guest, group_developer, second_developer].map(&:id)
|
|
|
|
|
|
|
|
expected = {
|
|
|
|
master.id => Gitlab::Access::MASTER,
|
|
|
|
reporter.id => Gitlab::Access::REPORTER,
|
|
|
|
promoted_guest.id => Gitlab::Access::DEVELOPER,
|
|
|
|
guest.id => Gitlab::Access::GUEST,
|
|
|
|
group_developer.id => Gitlab::Access::DEVELOPER,
|
|
|
|
second_developer.id => Gitlab::Access::MASTER
|
|
|
|
}
|
|
|
|
|
|
|
|
expect(project.team.max_member_access_for_user_ids(users)).to eq(expected)
|
|
|
|
end
|
2015-10-02 12:10:33 +00:00
|
|
|
end
|
|
|
|
end
|
2016-08-01 20:11:45 +00:00
|
|
|
|
|
|
|
describe '#max_member_access_for_users with RequestStore' do
|
|
|
|
it_behaves_like "#max_member_access_for_users", true
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#max_member_access_for_users without RequestStore' do
|
|
|
|
it_behaves_like "#max_member_access_for_users", false
|
|
|
|
end
|
2013-01-04 06:43:25 +00:00
|
|
|
end
|