gitlab-org--gitlab-foss/spec/services/merge_requests/merge_when_build_succeeds_s...

164 lines
5.5 KiB
Ruby
Raw Normal View History

2015-11-24 13:59:02 +00:00
require 'spec_helper'
describe MergeRequests::MergeWhenBuildSucceedsService do
let(:user) { create(:user) }
let(:project) { create(:project) }
2015-12-03 09:27:34 +00:00
let(:mr_merge_if_green_enabled) do
create(:merge_request, merge_when_build_succeeds: true, merge_user: user,
2016-01-20 19:38:34 +00:00
source_branch: "master", target_branch: 'feature',
2015-12-03 09:27:34 +00:00
source_project: project, target_project: project, state: "opened")
end
let(:pipeline) { create(:ci_pipeline_with_one_job, ref: mr_merge_if_green_enabled.source_branch, project: project) }
2015-11-24 13:59:02 +00:00
let(:service) { MergeRequests::MergeWhenBuildSucceedsService.new(project, user, commit_message: 'Awesome message') }
describe "#execute" do
let(:merge_request) do
create(:merge_request, target_project: project, source_project: project,
source_branch: "feature", target_branch: 'master')
end
2015-11-24 13:59:02 +00:00
context 'first time enabling' do
before do
allow(merge_request).to receive(:pipeline).and_return(pipeline)
2015-12-03 09:27:34 +00:00
service.execute(merge_request)
2015-11-24 13:59:02 +00:00
end
it 'sets the params, merge_user, and flag' do
expect(merge_request).to be_valid
expect(merge_request.merge_when_build_succeeds).to be_truthy
expect(merge_request.merge_params).to eq commit_message: 'Awesome message'
expect(merge_request.merge_user).to be user
2015-12-03 09:27:34 +00:00
end
2015-11-24 13:59:02 +00:00
2015-12-03 09:27:34 +00:00
it 'creates a system note' do
2015-11-24 13:59:02 +00:00
note = merge_request.notes.last
expect(note.note).to match /enabled an automatic merge when the build for (\w+\/\w+@)?\h{8}/
2015-11-24 13:59:02 +00:00
end
end
2015-12-03 09:27:34 +00:00
context 'already approved' do
2015-11-24 13:59:02 +00:00
let(:service) { MergeRequests::MergeWhenBuildSucceedsService.new(project, user, new_key: true) }
let(:build) { create(:ci_build, ref: mr_merge_if_green_enabled.source_branch) }
before do
allow(mr_merge_if_green_enabled).to receive(:pipeline).and_return(pipeline)
2015-11-24 13:59:02 +00:00
allow(mr_merge_if_green_enabled).to receive(:mergeable?).and_return(true)
allow(pipeline).to receive(:success?).and_return(true)
2015-11-24 13:59:02 +00:00
end
it 'updates the merge params' do
expect(SystemNoteService).not_to receive(:merge_when_build_succeeds)
service.execute(mr_merge_if_green_enabled)
expect(mr_merge_if_green_enabled.merge_params).to have_key(:new_key)
end
end
end
describe "#trigger" do
let(:merge_request_ref) { mr_merge_if_green_enabled.source_branch }
let(:merge_request_head) do
project.commit(mr_merge_if_green_enabled.source_branch).id
end
2015-11-24 13:59:02 +00:00
context 'when triggered by pipeline with valid ref and sha' do
let(:triggering_pipeline) do
create(:ci_pipeline, project: project, ref: merge_request_ref,
sha: merge_request_head, status: 'success')
end
it "merges all merge requests with merge when build succeeds enabled" do
expect(MergeWorker).to receive(:perform_async)
service.trigger(triggering_pipeline)
end
end
context 'when triggered by an old pipeline' do
let(:old_pipeline) do
create(:ci_pipeline, project: project, ref: merge_request_ref,
sha: '1234abcdef', status: 'success')
end
it 'it does not merge merge request' do
expect(MergeWorker).not_to receive(:perform_async)
service.trigger(old_pipeline)
end
end
context 'when triggered by pipeline from a different branch' do
let(:unrelated_pipeline) do
create(:ci_pipeline, project: project, ref: 'feature',
sha: merge_request_head, status: 'success')
end
2015-11-24 13:59:02 +00:00
it 'does not merge request' do
expect(MergeWorker).not_to receive(:perform_async)
service.trigger(unrelated_pipeline)
end
2015-11-24 13:59:02 +00:00
end
end
describe "#cancel" do
before do
service.cancel(mr_merge_if_green_enabled)
end
it "resets all the merge_when_build_succeeds params" do
expect(mr_merge_if_green_enabled.merge_when_build_succeeds).to be_falsey
expect(mr_merge_if_green_enabled.merge_params).to eq({})
expect(mr_merge_if_green_enabled.merge_user).to be nil
end
it 'Posts a system note' do
note = mr_merge_if_green_enabled.notes.last
expect(note.note).to include 'canceled the automatic merge'
end
end
describe 'pipeline integration' do
context 'when there are multiple stages in the pipeline' do
let(:ref) { mr_merge_if_green_enabled.source_branch }
let(:sha) { project.commit(ref).id }
let(:pipeline) do
create(:ci_empty_pipeline, ref: ref, sha: sha, project: project)
end
let!(:build) do
create(:ci_build, :created, pipeline: pipeline, ref: ref,
name: 'build', stage: 'build')
end
let!(:test) do
create(:ci_build, :created, pipeline: pipeline, ref: ref,
name: 'test', stage: 'test')
end
before do
# This behavior of MergeRequest: we instantiate a new object
allow_any_instance_of(MergeRequest).to receive(:pipeline).and_wrap_original do
Ci::Pipeline.find(pipeline.id)
end
end
it "doesn't merge if any of stages failed" do
expect(MergeWorker).not_to receive(:perform_async)
build.success
2016-10-26 09:34:40 +00:00
test.reload
test.drop
end
it 'merges when all stages succeeded' do
expect(MergeWorker).to receive(:perform_async)
build.success
2016-10-26 09:34:40 +00:00
test.reload
test.success
end
end
2015-11-24 13:59:02 +00:00
end
end