2019-11-24 07:06:34 -05:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2017-09-19 13:23:15 -04:00
|
|
|
require 'spec_helper'
|
|
|
|
|
|
|
|
describe Gitlab::HookData::IssuableBuilder do
|
|
|
|
set(:user) { create(:user) }
|
|
|
|
|
|
|
|
# This shared example requires a `builder` and `user` variable
|
|
|
|
shared_examples 'issuable hook data' do |kind|
|
|
|
|
let(:data) { builder.build(user: user) }
|
|
|
|
|
|
|
|
include_examples 'project hook data' do
|
|
|
|
let(:project) { builder.issuable.project }
|
|
|
|
end
|
|
|
|
include_examples 'deprecated repository hook data'
|
|
|
|
|
|
|
|
context "with a #{kind}" do
|
|
|
|
it 'contains issuable data' do
|
|
|
|
expect(data[:object_kind]).to eq(kind)
|
|
|
|
expect(data[:user]).to eq(user.hook_attrs)
|
|
|
|
expect(data[:project]).to eq(builder.issuable.project.hook_attrs)
|
|
|
|
expect(data[:object_attributes]).to eq(builder.issuable.hook_attrs)
|
|
|
|
expect(data[:changes]).to eq({})
|
|
|
|
expect(data[:repository]).to eq(builder.issuable.project.hook_attrs.slice(:name, :url, :description, :homepage))
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not contain certain keys' do
|
|
|
|
expect(data).not_to have_key(:assignees)
|
|
|
|
expect(data).not_to have_key(:assignee)
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'changes are given' do
|
|
|
|
let(:changes) do
|
|
|
|
{
|
|
|
|
cached_markdown_version: %w[foo bar],
|
|
|
|
description: ['A description', 'A cool description'],
|
|
|
|
description_html: %w[foo bar],
|
|
|
|
in_progress_merge_commit_sha: %w[foo bar],
|
|
|
|
lock_version: %w[foo bar],
|
|
|
|
merge_jid: %w[foo bar],
|
|
|
|
title: ['A title', 'Hello World'],
|
2017-10-05 13:02:50 -04:00
|
|
|
title_html: %w[foo bar],
|
|
|
|
labels: [
|
|
|
|
[{ id: 1, title: 'foo' }],
|
|
|
|
[{ id: 1, title: 'foo' }, { id: 2, title: 'bar' }]
|
2017-11-14 12:55:00 -05:00
|
|
|
],
|
2019-09-16 14:06:05 -04:00
|
|
|
total_time_spent: [1, 2],
|
|
|
|
assignees: [
|
|
|
|
[],
|
|
|
|
[{
|
|
|
|
name: "Foo Bar",
|
|
|
|
username: "foobar",
|
|
|
|
avatar_url: "http://www.example.com/my-avatar.jpg"
|
|
|
|
}]
|
|
|
|
]
|
2017-09-19 13:23:15 -04:00
|
|
|
}
|
|
|
|
end
|
|
|
|
let(:data) { builder.build(user: user, changes: changes) }
|
|
|
|
|
|
|
|
it 'populates the :changes hash' do
|
|
|
|
expect(data[:changes]).to match(hash_including({
|
2017-10-05 13:02:50 -04:00
|
|
|
title: { previous: 'A title', current: 'Hello World' },
|
|
|
|
description: { previous: 'A description', current: 'A cool description' },
|
|
|
|
labels: {
|
|
|
|
previous: [{ id: 1, title: 'foo' }],
|
|
|
|
current: [{ id: 1, title: 'foo' }, { id: 2, title: 'bar' }]
|
2017-11-14 12:55:00 -05:00
|
|
|
},
|
|
|
|
total_time_spent: {
|
|
|
|
previous: 1,
|
|
|
|
current: 2
|
2019-09-16 14:06:05 -04:00
|
|
|
},
|
|
|
|
assignees: {
|
|
|
|
previous: [],
|
|
|
|
current: [{
|
|
|
|
name: "Foo Bar",
|
|
|
|
username: "foobar",
|
|
|
|
avatar_url: "http://www.example.com/my-avatar.jpg"
|
|
|
|
}]
|
2017-10-05 13:02:50 -04:00
|
|
|
}
|
2017-09-19 13:23:15 -04:00
|
|
|
}))
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not contain certain keys' do
|
|
|
|
expect(data[:changes]).not_to have_key('cached_markdown_version')
|
|
|
|
expect(data[:changes]).not_to have_key('description_html')
|
|
|
|
expect(data[:changes]).not_to have_key('lock_version')
|
|
|
|
expect(data[:changes]).not_to have_key('title_html')
|
|
|
|
expect(data[:changes]).not_to have_key('in_progress_merge_commit_sha')
|
|
|
|
expect(data[:changes]).not_to have_key('merge_jid')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#build' do
|
|
|
|
it_behaves_like 'issuable hook data', 'issue' do
|
|
|
|
let(:issuable) { create(:issue, description: 'A description') }
|
|
|
|
let(:builder) { described_class.new(issuable) }
|
|
|
|
end
|
|
|
|
|
|
|
|
it_behaves_like 'issuable hook data', 'merge_request' do
|
|
|
|
let(:issuable) { create(:merge_request, description: 'A description') }
|
|
|
|
let(:builder) { described_class.new(issuable) }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'issue is assigned' do
|
2017-10-05 13:02:50 -04:00
|
|
|
let(:issue) { create(:issue, assignees: [user]) }
|
2017-09-19 13:23:15 -04:00
|
|
|
let(:data) { described_class.new(issue).build(user: user) }
|
|
|
|
|
|
|
|
it 'returns correct hook data' do
|
|
|
|
expect(data[:object_attributes]['assignee_id']).to eq(user.id)
|
|
|
|
expect(data[:assignees].first).to eq(user.hook_attrs)
|
|
|
|
expect(data).not_to have_key(:assignee)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'merge_request is assigned' do
|
2019-04-07 14:35:16 -04:00
|
|
|
let(:merge_request) { create(:merge_request, assignees: [user]) }
|
2017-09-19 13:23:15 -04:00
|
|
|
let(:data) { described_class.new(merge_request).build(user: user) }
|
|
|
|
|
|
|
|
it 'returns correct hook data' do
|
|
|
|
expect(data[:object_attributes]['assignee_id']).to eq(user.id)
|
2019-04-07 14:35:16 -04:00
|
|
|
expect(data[:assignees].first).to eq(user.hook_attrs)
|
|
|
|
expect(data).not_to have_key(:assignee)
|
2017-09-19 13:23:15 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|