gitlab-org--gitlab-foss/spec/services/spam_service_spec.rb

112 lines
3.2 KiB
Ruby
Raw Normal View History

# frozen_string_literal: true
require 'spec_helper'
describe SpamService do
2017-02-14 14:07:11 -05:00
describe '#when_recaptcha_verified' do
def check_spam(issue, request, recaptcha_verified)
described_class.new(issue, request).when_recaptcha_verified(recaptcha_verified) do
'yielded'
end
end
it 'yields block when recaptcha was already verified' do
issue = build_stubbed(:issue)
2017-02-14 14:07:11 -05:00
expect(check_spam(issue, nil, true)).to eql('yielded')
end
2017-02-14 14:07:11 -05:00
context 'when recaptcha was not verified' do
let(:project) { create(:project, :public) }
2017-02-14 14:07:11 -05:00
let(:issue) { create(:issue, project: project) }
let(:request) { double(:request, env: {}) }
context 'when spammable attributes have not changed' do
before do
issue.closed_at = Time.zone.now
2017-08-24 13:05:02 -04:00
allow(AkismetService).to receive(:new).and_return(double(spam?: true))
2017-02-14 14:07:11 -05:00
end
it 'returns false' do
expect(check_spam(issue, request, false)).to be_falsey
2017-02-14 14:07:11 -05:00
end
it 'does not create a spam log' do
2017-02-14 14:07:11 -05:00
expect { check_spam(issue, request, false) }
.not_to change { SpamLog.count }
2017-02-14 14:07:11 -05:00
end
end
context 'when spammable attributes have changed' do
before do
issue.description = 'SPAM!'
2017-02-14 14:07:11 -05:00
end
context 'when indicated as spam by akismet' do
shared_examples 'akismet spam' do
it 'doesnt check as spam when request is missing' do
check_spam(issue, nil, false)
expect(issue).not_to be_spam
end
it 'creates a spam log' do
expect { check_spam(issue, request, false) }
.to log_spam(title: issue.title, description: issue.description, noteable_type: 'Issue')
end
it 'does not yield to the block' do
expect(check_spam(issue, request, false))
.to eql(SpamLog.last)
end
end
before do
2017-08-24 13:05:02 -04:00
allow(AkismetService).to receive(:new).and_return(double(spam?: true))
end
2017-02-14 14:07:11 -05:00
context 'when allow_possible_spam feature flag is false' do
before do
stub_feature_flags(allow_possible_spam: false)
end
it_behaves_like 'akismet spam'
it 'checks as spam' do
check_spam(issue, request, false)
expect(issue.spam).to be_truthy
end
end
context 'when allow_possible_spam feature flag is true' do
it_behaves_like 'akismet spam'
it 'does not check as spam' do
check_spam(issue, request, false)
expect(issue.spam).to be_nil
end
end
2017-02-14 14:07:11 -05:00
end
context 'when not indicated as spam by akismet' do
before do
2017-08-24 13:05:02 -04:00
allow(AkismetService).to receive(:new).and_return(double(spam?: false))
end
it 'returns false' do
expect(check_spam(issue, request, false)).to be_falsey
end
it 'does not create a spam log' do
expect { check_spam(issue, request, false) }
.not_to change { SpamLog.count }
end
2017-02-14 14:07:11 -05:00
end
end
end
end
end