2017-01-04 22:07:49 +00:00
|
|
|
require 'spec_helper'
|
|
|
|
|
|
|
|
describe API::Applications, :api do
|
|
|
|
include ApiHelpers
|
|
|
|
|
|
|
|
let(:admin_user) { create(:user, admin: true) }
|
|
|
|
let(:user) { create(:user, admin: false) }
|
2018-10-11 15:25:52 +00:00
|
|
|
let!(:application) { create(:application, name: 'another_application', redirect_uri: 'http://other_application.url', scopes: '') }
|
2017-01-04 22:07:49 +00:00
|
|
|
|
|
|
|
describe 'POST /applications' do
|
|
|
|
context 'authenticated and authorized user' do
|
|
|
|
it 'creates and returns an OAuth application' do
|
|
|
|
expect do
|
2018-12-17 22:52:17 +00:00
|
|
|
post api('/applications', admin_user), params: { name: 'application_name', redirect_uri: 'http://application.url', scopes: '' }
|
2017-01-04 22:07:49 +00:00
|
|
|
end.to change { Doorkeeper::Application.count }.by 1
|
|
|
|
|
|
|
|
application = Doorkeeper::Application.find_by(name: 'application_name', redirect_uri: 'http://application.url')
|
|
|
|
|
2018-10-15 11:07:56 +00:00
|
|
|
expect(response).to have_gitlab_http_status(201)
|
2017-01-04 22:07:49 +00:00
|
|
|
expect(json_response).to be_a Hash
|
|
|
|
expect(json_response['application_id']).to eq application.uid
|
|
|
|
expect(json_response['secret']).to eq application.secret
|
|
|
|
expect(json_response['callback_url']).to eq application.redirect_uri
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not allow creating an application with the wrong redirect_uri format' do
|
|
|
|
expect do
|
2018-12-17 22:52:17 +00:00
|
|
|
post api('/applications', admin_user), params: { name: 'application_name', redirect_uri: 'http://', scopes: '' }
|
2017-01-04 22:07:49 +00:00
|
|
|
end.not_to change { Doorkeeper::Application.count }
|
|
|
|
|
2018-10-15 11:07:56 +00:00
|
|
|
expect(response).to have_gitlab_http_status(400)
|
2017-01-04 22:07:49 +00:00
|
|
|
expect(json_response).to be_a Hash
|
|
|
|
expect(json_response['message']['redirect_uri'][0]).to eq('must be an absolute URI.')
|
|
|
|
end
|
|
|
|
|
2018-11-28 22:53:48 +00:00
|
|
|
it 'does not allow creating an application with a forbidden URI format' do
|
|
|
|
expect do
|
2018-12-17 22:52:17 +00:00
|
|
|
post api('/applications', admin_user), params: { name: 'application_name', redirect_uri: 'javascript://alert()', scopes: '' }
|
2018-11-28 22:53:48 +00:00
|
|
|
end.not_to change { Doorkeeper::Application.count }
|
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(400)
|
|
|
|
expect(json_response).to be_a Hash
|
|
|
|
expect(json_response['message']['redirect_uri'][0]).to eq('is forbidden by the server.')
|
|
|
|
end
|
|
|
|
|
2017-01-04 22:07:49 +00:00
|
|
|
it 'does not allow creating an application without a name' do
|
|
|
|
expect do
|
2018-12-17 22:52:17 +00:00
|
|
|
post api('/applications', admin_user), params: { redirect_uri: 'http://application.url', scopes: '' }
|
2017-01-04 22:07:49 +00:00
|
|
|
end.not_to change { Doorkeeper::Application.count }
|
|
|
|
|
2018-10-15 11:07:56 +00:00
|
|
|
expect(response).to have_gitlab_http_status(400)
|
2017-01-04 22:07:49 +00:00
|
|
|
expect(json_response).to be_a Hash
|
|
|
|
expect(json_response['error']).to eq('name is missing')
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not allow creating an application without a redirect_uri' do
|
|
|
|
expect do
|
2018-12-17 22:52:17 +00:00
|
|
|
post api('/applications', admin_user), params: { name: 'application_name', scopes: '' }
|
2017-01-04 22:07:49 +00:00
|
|
|
end.not_to change { Doorkeeper::Application.count }
|
|
|
|
|
2018-10-15 11:07:56 +00:00
|
|
|
expect(response).to have_gitlab_http_status(400)
|
2017-01-04 22:07:49 +00:00
|
|
|
expect(json_response).to be_a Hash
|
|
|
|
expect(json_response['error']).to eq('redirect_uri is missing')
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not allow creating an application without scopes' do
|
|
|
|
expect do
|
2018-12-17 22:52:17 +00:00
|
|
|
post api('/applications', admin_user), params: { name: 'application_name', redirect_uri: 'http://application.url' }
|
2017-01-04 22:07:49 +00:00
|
|
|
end.not_to change { Doorkeeper::Application.count }
|
|
|
|
|
2018-10-15 11:07:56 +00:00
|
|
|
expect(response).to have_gitlab_http_status(400)
|
2017-01-04 22:07:49 +00:00
|
|
|
expect(json_response).to be_a Hash
|
|
|
|
expect(json_response['error']).to eq('scopes is missing')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'authorized user without authorization' do
|
|
|
|
it 'does not create application' do
|
|
|
|
expect do
|
2018-12-17 22:52:17 +00:00
|
|
|
post api('/applications', user), params: { name: 'application_name', redirect_uri: 'http://application.url', scopes: '' }
|
2017-01-04 22:07:49 +00:00
|
|
|
end.not_to change { Doorkeeper::Application.count }
|
|
|
|
|
2018-10-15 11:07:56 +00:00
|
|
|
expect(response).to have_gitlab_http_status(403)
|
2017-01-04 22:07:49 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'non-authenticated user' do
|
|
|
|
it 'does not create application' do
|
|
|
|
expect do
|
2018-12-17 22:52:17 +00:00
|
|
|
post api('/applications'), params: { name: 'application_name', redirect_uri: 'http://application.url' }
|
2017-01-04 22:07:49 +00:00
|
|
|
end.not_to change { Doorkeeper::Application.count }
|
|
|
|
|
2018-10-15 11:07:56 +00:00
|
|
|
expect(response).to have_gitlab_http_status(401)
|
2017-01-04 22:07:49 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2018-10-11 10:54:15 +00:00
|
|
|
|
|
|
|
describe 'GET /applications' do
|
|
|
|
context 'authenticated and authorized user' do
|
|
|
|
it 'can list application' do
|
2018-10-11 12:12:25 +00:00
|
|
|
get api('/applications', admin_user)
|
2018-10-11 10:54:15 +00:00
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(200)
|
|
|
|
expect(json_response).to be_a(Array)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-10-11 13:35:17 +00:00
|
|
|
context 'authorized user without authorization' do
|
|
|
|
it 'cannot list application' do
|
|
|
|
get api('/applications', user)
|
|
|
|
|
2018-10-15 11:07:56 +00:00
|
|
|
expect(response).to have_gitlab_http_status(403)
|
2018-10-11 13:35:17 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-10-11 10:54:15 +00:00
|
|
|
context 'non-authenticated user' do
|
|
|
|
it 'cannot list application' do
|
2018-10-12 00:28:40 +00:00
|
|
|
get api('/applications')
|
2018-10-11 10:54:15 +00:00
|
|
|
|
2018-10-15 11:07:56 +00:00
|
|
|
expect(response).to have_gitlab_http_status(401)
|
2018-10-11 10:54:15 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'DELETE /applications/:id' do
|
|
|
|
context 'authenticated and authorized user' do
|
|
|
|
it 'can delete an application' do
|
2018-10-11 12:12:25 +00:00
|
|
|
expect do
|
|
|
|
delete api("/applications/#{application.id}", admin_user)
|
2018-10-11 13:35:17 +00:00
|
|
|
end.to change { Doorkeeper::Application.count }.by(-1)
|
|
|
|
|
2018-10-11 10:54:15 +00:00
|
|
|
expect(response).to have_gitlab_http_status(204)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-10-11 13:35:17 +00:00
|
|
|
context 'authorized user without authorization' do
|
2018-10-11 10:54:15 +00:00
|
|
|
it 'cannot delete an application' do
|
2018-10-11 12:12:25 +00:00
|
|
|
delete api("/applications/#{application.id}", user)
|
2018-10-11 10:54:15 +00:00
|
|
|
|
2018-10-15 11:07:56 +00:00
|
|
|
expect(response).to have_gitlab_http_status(403)
|
2018-10-11 13:35:17 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'non-authenticated user' do
|
|
|
|
it 'cannot delete an application' do
|
|
|
|
delete api("/applications/#{application.id}")
|
|
|
|
|
2018-10-15 11:07:56 +00:00
|
|
|
expect(response).to have_gitlab_http_status(401)
|
2018-10-11 10:54:15 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2017-01-04 22:07:49 +00:00
|
|
|
end
|