2013-10-29 14:39:46 +00:00
|
|
|
require "spec_helper"
|
|
|
|
|
2017-04-21 20:32:02 +00:00
|
|
|
describe API::Services do
|
2017-09-05 08:04:40 +00:00
|
|
|
set(:user) { create(:user) }
|
|
|
|
set(:admin) { create(:admin) }
|
|
|
|
set(:user2) { create(:user) }
|
|
|
|
|
|
|
|
set(:project) do
|
|
|
|
create(:project, creator_id: user.id, namespace: user.namespace)
|
|
|
|
end
|
2013-10-29 14:39:46 +00:00
|
|
|
|
2015-08-26 23:58:49 +00:00
|
|
|
Service.available_services_names.each do |service|
|
2019-08-01 06:20:35 +00:00
|
|
|
describe "PUT /projects/:id/services/#{service.dasherize}" do
|
2015-08-26 23:58:49 +00:00
|
|
|
include_context service
|
|
|
|
|
2016-08-01 15:00:44 +00:00
|
|
|
it "updates #{service} settings" do
|
2018-12-17 22:52:17 +00:00
|
|
|
put api("/projects/#{project.id}/services/#{dashed_service}", user), params: service_attrs
|
2015-08-26 23:58:49 +00:00
|
|
|
|
2017-10-19 18:28:19 +00:00
|
|
|
expect(response).to have_gitlab_http_status(200)
|
2016-12-27 12:44:24 +00:00
|
|
|
|
|
|
|
current_service = project.services.first
|
2019-06-16 15:57:38 +00:00
|
|
|
events = current_service.event_names.empty? ? ["foo"].freeze : current_service.event_names
|
|
|
|
query_strings = []
|
|
|
|
events.each do |event|
|
|
|
|
query_strings << "#{event}=#{!current_service[event]}"
|
|
|
|
end
|
|
|
|
query_strings = query_strings.join('&')
|
2016-12-27 12:44:24 +00:00
|
|
|
|
2019-06-16 15:57:38 +00:00
|
|
|
put api("/projects/#{project.id}/services/#{dashed_service}?#{query_strings}", user), params: service_attrs
|
2016-12-27 12:44:24 +00:00
|
|
|
|
2017-10-19 18:28:19 +00:00
|
|
|
expect(response).to have_gitlab_http_status(200)
|
2019-06-16 15:57:38 +00:00
|
|
|
events.each do |event|
|
|
|
|
next if event == "foo"
|
|
|
|
|
|
|
|
expect(project.services.first[event]).not_to eq(current_service[event]),
|
|
|
|
"expected #{!current_service[event]} for event #{event} for service #{current_service.title}, got #{current_service[event]}"
|
|
|
|
end
|
2015-08-26 23:58:49 +00:00
|
|
|
end
|
|
|
|
|
2016-08-01 15:00:44 +00:00
|
|
|
it "returns if required fields missing" do
|
2015-08-26 23:58:49 +00:00
|
|
|
attrs = service_attrs
|
2015-09-16 09:43:16 +00:00
|
|
|
|
2015-08-26 23:58:49 +00:00
|
|
|
required_attributes = service_attrs_list.select do |attr|
|
2015-09-16 09:43:16 +00:00
|
|
|
service_klass.validators_on(attr).any? do |v|
|
2015-08-26 23:58:49 +00:00
|
|
|
v.class == ActiveRecord::Validations::PresenceValidator
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
if required_attributes.empty?
|
|
|
|
expected_code = 200
|
|
|
|
else
|
2015-12-15 02:53:52 +00:00
|
|
|
attrs.delete(required_attributes.sample)
|
2015-08-26 23:58:49 +00:00
|
|
|
expected_code = 400
|
|
|
|
end
|
2016-08-01 15:00:44 +00:00
|
|
|
|
2018-12-17 22:52:17 +00:00
|
|
|
put api("/projects/#{project.id}/services/#{dashed_service}", user), params: attrs
|
2015-08-26 23:58:49 +00:00
|
|
|
|
|
|
|
expect(response.status).to eq(expected_code)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-08-01 06:20:35 +00:00
|
|
|
describe "DELETE /projects/:id/services/#{service.dasherize}" do
|
2015-08-26 23:58:49 +00:00
|
|
|
include_context service
|
|
|
|
|
2018-01-04 09:33:51 +00:00
|
|
|
before do
|
|
|
|
initialize_service(service)
|
|
|
|
end
|
|
|
|
|
2016-08-01 15:00:44 +00:00
|
|
|
it "deletes #{service}" do
|
2015-08-26 23:58:49 +00:00
|
|
|
delete api("/projects/#{project.id}/services/#{dashed_service}", user)
|
|
|
|
|
2017-10-19 18:28:19 +00:00
|
|
|
expect(response).to have_gitlab_http_status(204)
|
2015-11-09 15:48:03 +00:00
|
|
|
project.send(service_method).reload
|
2015-08-26 23:58:49 +00:00
|
|
|
expect(project.send(service_method).activated?).to be_falsey
|
|
|
|
end
|
2014-10-14 17:07:34 +00:00
|
|
|
end
|
2015-09-03 13:38:54 +00:00
|
|
|
|
|
|
|
describe "GET /projects/:id/services/#{service.dasherize}" do
|
|
|
|
include_context service
|
|
|
|
|
2015-10-12 13:24:00 +00:00
|
|
|
# inject some properties into the service
|
2019-07-11 09:53:08 +00:00
|
|
|
let!(:initialized_service) { initialize_service(service) }
|
2015-10-12 13:24:00 +00:00
|
|
|
|
2016-08-01 15:00:44 +00:00
|
|
|
it 'returns authentication error when unauthenticated' do
|
2015-10-12 13:24:00 +00:00
|
|
|
get api("/projects/#{project.id}/services/#{dashed_service}")
|
2017-10-19 18:28:19 +00:00
|
|
|
expect(response).to have_gitlab_http_status(401)
|
2015-10-12 13:24:00 +00:00
|
|
|
end
|
2016-08-01 15:00:44 +00:00
|
|
|
|
|
|
|
it "returns all properties of service #{service} when authenticated as admin" do
|
2015-10-12 13:24:00 +00:00
|
|
|
get api("/projects/#{project.id}/services/#{dashed_service}", admin)
|
2016-08-01 15:00:44 +00:00
|
|
|
|
2017-10-19 18:28:19 +00:00
|
|
|
expect(response).to have_gitlab_http_status(200)
|
2018-01-06 06:18:13 +00:00
|
|
|
expect(json_response['properties'].keys).to match_array(service_instance.api_field_names)
|
2015-10-12 13:24:00 +00:00
|
|
|
end
|
|
|
|
|
2016-08-01 15:00:44 +00:00
|
|
|
it "returns properties of service #{service} other than passwords when authenticated as project owner" do
|
2015-09-03 13:38:54 +00:00
|
|
|
get api("/projects/#{project.id}/services/#{dashed_service}", user)
|
|
|
|
|
2017-10-19 18:28:19 +00:00
|
|
|
expect(response).to have_gitlab_http_status(200)
|
2018-01-06 06:18:13 +00:00
|
|
|
expect(json_response['properties'].keys).to match_array(service_instance.api_field_names)
|
2015-09-03 13:38:54 +00:00
|
|
|
end
|
2015-10-12 13:24:00 +00:00
|
|
|
|
2019-07-11 09:53:08 +00:00
|
|
|
it "returns empty hash if properties are empty" do
|
|
|
|
# deprecated services are not valid for update
|
|
|
|
initialized_service.update_attribute(:properties, {})
|
|
|
|
get api("/projects/#{project.id}/services/#{dashed_service}", user)
|
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(200)
|
|
|
|
expect(json_response['properties'].keys).to be_empty
|
|
|
|
end
|
|
|
|
|
2016-08-01 15:00:44 +00:00
|
|
|
it "returns error when authenticated but not a project owner" do
|
2017-12-22 08:18:28 +00:00
|
|
|
project.add_developer(user2)
|
2015-10-12 13:24:00 +00:00
|
|
|
get api("/projects/#{project.id}/services/#{dashed_service}", user2)
|
2016-08-01 15:00:44 +00:00
|
|
|
|
2017-10-19 18:28:19 +00:00
|
|
|
expect(response).to have_gitlab_http_status(403)
|
2015-10-12 13:24:00 +00:00
|
|
|
end
|
2015-09-03 13:38:54 +00:00
|
|
|
end
|
2014-10-14 17:07:34 +00:00
|
|
|
end
|
2016-11-18 09:00:40 +00:00
|
|
|
|
|
|
|
describe 'POST /projects/:id/services/:slug/trigger' do
|
2016-12-29 09:48:18 +00:00
|
|
|
describe 'Mattermost Service' do
|
|
|
|
let(:service_name) { 'mattermost_slash_commands' }
|
2016-11-18 09:00:40 +00:00
|
|
|
|
2016-12-29 09:48:18 +00:00
|
|
|
context 'no service is available' do
|
|
|
|
it 'returns a not found message' do
|
|
|
|
post api("/projects/#{project.id}/services/idonotexist/trigger")
|
|
|
|
|
2017-10-19 18:28:19 +00:00
|
|
|
expect(response).to have_gitlab_http_status(404)
|
2016-12-29 09:48:18 +00:00
|
|
|
expect(json_response["error"]).to eq("404 Not Found")
|
|
|
|
end
|
2016-11-18 09:00:40 +00:00
|
|
|
end
|
|
|
|
|
2016-12-29 09:48:18 +00:00
|
|
|
context 'the service exists' do
|
|
|
|
let(:params) { { token: 'token' } }
|
2016-11-18 10:38:54 +00:00
|
|
|
|
2016-12-29 09:48:18 +00:00
|
|
|
context 'the service is not active' do
|
|
|
|
before do
|
|
|
|
project.create_mattermost_slash_commands_service(
|
|
|
|
active: false,
|
|
|
|
properties: params
|
|
|
|
)
|
|
|
|
end
|
2016-11-18 09:00:40 +00:00
|
|
|
|
2016-12-29 09:48:18 +00:00
|
|
|
it 'when the service is inactive' do
|
2018-12-17 22:52:17 +00:00
|
|
|
post api("/projects/#{project.id}/services/#{service_name}/trigger"), params: params
|
2016-11-18 09:00:40 +00:00
|
|
|
|
2017-10-19 18:28:19 +00:00
|
|
|
expect(response).to have_gitlab_http_status(404)
|
2016-12-29 09:48:18 +00:00
|
|
|
end
|
2016-11-18 09:00:40 +00:00
|
|
|
end
|
|
|
|
|
2016-12-29 09:48:18 +00:00
|
|
|
context 'the service is active' do
|
|
|
|
before do
|
|
|
|
project.create_mattermost_slash_commands_service(
|
|
|
|
active: true,
|
|
|
|
properties: params
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns status 200' do
|
2018-12-17 22:52:17 +00:00
|
|
|
post api("/projects/#{project.id}/services/#{service_name}/trigger"), params: params
|
2016-12-29 09:48:18 +00:00
|
|
|
|
2017-10-19 18:28:19 +00:00
|
|
|
expect(response).to have_gitlab_http_status(200)
|
2016-12-29 09:48:18 +00:00
|
|
|
end
|
2016-11-18 09:00:40 +00:00
|
|
|
end
|
|
|
|
|
2016-12-29 09:48:18 +00:00
|
|
|
context 'when the project can not be found' do
|
|
|
|
it 'returns a generic 404' do
|
2018-12-17 22:52:17 +00:00
|
|
|
post api("/projects/404/services/#{service_name}/trigger"), params: params
|
2016-11-18 09:00:40 +00:00
|
|
|
|
2017-10-19 18:28:19 +00:00
|
|
|
expect(response).to have_gitlab_http_status(404)
|
2016-12-29 09:48:18 +00:00
|
|
|
expect(json_response["message"]).to eq("404 Service Not Found")
|
|
|
|
end
|
2016-11-18 09:00:40 +00:00
|
|
|
end
|
|
|
|
end
|
2016-12-29 09:48:18 +00:00
|
|
|
end
|
2016-11-18 10:38:54 +00:00
|
|
|
|
2016-12-29 09:48:18 +00:00
|
|
|
describe 'Slack Service' do
|
|
|
|
let(:service_name) { 'slack_slash_commands' }
|
2016-11-18 10:38:54 +00:00
|
|
|
|
2016-12-29 09:48:18 +00:00
|
|
|
before do
|
|
|
|
project.create_slack_slash_commands_service(
|
|
|
|
active: true,
|
|
|
|
properties: { token: 'token' }
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns status 200' do
|
2018-12-17 22:52:17 +00:00
|
|
|
post api("/projects/#{project.id}/services/#{service_name}/trigger"), params: { token: 'token', text: 'help' }
|
2016-12-29 09:48:18 +00:00
|
|
|
|
2017-10-19 18:28:19 +00:00
|
|
|
expect(response).to have_gitlab_http_status(200)
|
2016-12-29 09:48:18 +00:00
|
|
|
expect(json_response['response_type']).to eq("ephemeral")
|
2016-11-18 10:38:54 +00:00
|
|
|
end
|
2016-11-18 09:00:40 +00:00
|
|
|
end
|
|
|
|
end
|
2017-11-08 10:22:24 +00:00
|
|
|
|
|
|
|
describe 'Mattermost service' do
|
|
|
|
let(:service_name) { 'mattermost' }
|
|
|
|
let(:params) do
|
|
|
|
{ webhook: 'https://hook.example.com', username: 'username' }
|
|
|
|
end
|
|
|
|
|
|
|
|
before do
|
|
|
|
project.create_mattermost_service(
|
|
|
|
active: true,
|
|
|
|
properties: params
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'accepts a username for update' do
|
2018-12-17 22:52:17 +00:00
|
|
|
put api("/projects/#{project.id}/services/mattermost", user), params: params.merge(username: 'new_username')
|
2017-11-08 10:22:24 +00:00
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(200)
|
|
|
|
expect(json_response['properties']['username']).to eq('new_username')
|
|
|
|
end
|
|
|
|
end
|
2013-10-29 14:39:46 +00:00
|
|
|
end
|