gitlab-org--gitlab-foss/app/services/issues/reopen_service.rb

# frozen_string_literal: true

module Issues
  class ReopenService < Issues::BaseService
    def execute(issue)
      return issue unless can?(current_user, :update_issue, issue)

      if issue.reopen
        event_service.reopen_issue(issue, current_user)
        create_note(issue, 'reopened')
        notification_service.async.reopen_issue(issue, current_user)
        execute_hooks(issue, 'reopen')
        invalidate_cache_counts(issue, users: issue.assignees)
        issue.update_project_counter_caches
      end

      issue
    end

    private

    def create_note(issue, state = issue.state)
      SystemNoteService.change_status(issue, issue.project, current_user, state, nil)
    end
  end
end
Enable frozen string in apps/services/*/.rb For directories application_settings --> labels. Partially addresses #47424. 2018-07-16 12:31:01 -04:00			`# frozen_string_literal: true`

Create services for issue close and reopen Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> 2014-04-02 08:38:24 -04:00			`module Issues`
Fix tests Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> 2014-04-02 12:55:23 -04:00			`class ReopenService < Issues::BaseService`
Create services for issue close and reopen Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> 2014-04-02 08:38:24 -04:00			`def execute(issue)`
Enforce permissions in `{Issues,MergeRequests}::{Close,Reopen}Service` Signed-off-by: Rémy Coutable <remy@rymai.me> 2016-08-09 11:51:40 -04:00			`return issue unless can?(current_user, :update_issue, issue)`

Create services for issue close and reopen Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> 2014-04-02 08:38:24 -04:00			`if issue.reopen`
			`event_service.reopen_issue(issue, current_user)`
Merge issuable "reopened" state into "opened" Having two states that essentially mean the same thing is very much like having a boolean "true" and boolean "mostly-true": it's rather silly. This commit merges the "reopened" state into the "opened" state while taking care of system notes still showing messages along the lines of "Alice reopened this issue". A big benefit from having only two states (opened and closed) is that indexing and querying becomes simpler and more performant. For example, to get all the opened queries we no longer have to query both states: SELECT * FROM issues WHERE project_id = 2 AND state IN ('opened', 'reopened'); Instead we can query a single state directly, which can be much faster: SELECT * FROM issues WHERE project_id = 2 AND state = 'opened'; Further, only having two states makes indexing easier as we will only ever filter (and thus scan an index) using a single value. Partial indexes could help but aren't supported on MySQL, complicating the development process and not being helpful for MySQL. 2017-07-19 10:03:50 -04:00			`create_note(issue, 'reopened')`
Move NotificationService calls to Sidekiq The NotificationService has to do quite a lot of work to calculate the recipients for an email. Where possible, we should try to avoid doing this in an HTTP request, because the mail are sent by Sidekiq anyway, so there's no need to schedule those emails immediately. This commit creates a generic Sidekiq worker that uses Global ID to serialise and deserialise its arguments, then forwards them to the NotificationService. The NotificationService gains an `#async` method, so you can replace: notification_service.new_issue(issue, current_user) With: notification_service.async.new_issue(issue, current_user) And have everything else work as normal, except that calculating the recipients will be done by Sidekiq, which will then schedule further Sidekiq jobs to send each email. 2018-04-20 13:37:38 -04:00			`notification_service.async.reopen_issue(issue, current_user)`
Return a little more information in Issue webhook When a webhook for issues is triggered, it should also return the resource URL, and the action that was performed (ie: Was it reopened, updated, opened or closed) 2014-05-23 09:16:03 -04:00			`execute_hooks(issue, 'reopen')`
Clear issuable counter caches on update When an issuable's state changes, or one is created, we should clear the cache counts for a user's assigned issuables, and also the project-wide caches for this user type. 2017-07-11 12:12:33 -04:00			`invalidate_cache_counts(issue, users: issue.assignees)`
Refresh open Issue and Merge Request project counter caches when re-opening 2017-10-30 12:20:29 -04:00			`issue.update_project_counter_caches`
Create services for issue close and reopen Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> 2014-04-02 08:38:24 -04:00			`end`

			`issue`
			`end`

			`private`

Merge issuable "reopened" state into "opened" Having two states that essentially mean the same thing is very much like having a boolean "true" and boolean "mostly-true": it's rather silly. This commit merges the "reopened" state into the "opened" state while taking care of system notes still showing messages along the lines of "Alice reopened this issue". A big benefit from having only two states (opened and closed) is that indexing and querying becomes simpler and more performant. For example, to get all the opened queries we no longer have to query both states: SELECT * FROM issues WHERE project_id = 2 AND state IN ('opened', 'reopened'); Instead we can query a single state directly, which can be much faster: SELECT * FROM issues WHERE project_id = 2 AND state = 'opened'; Further, only having two states makes indexing easier as we will only ever filter (and thus scan an index) using a single value. Partial indexes could help but aren't supported on MySQL, complicating the development process and not being helpful for MySQL. 2017-07-19 10:03:50 -04:00			`def create_note(issue, state = issue.state)`
			`SystemNoteService.change_status(issue, issue.project, current_user, state, nil)`
Create services for issue close and reopen Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> 2014-04-02 08:38:24 -04:00			`end`
			`end`
			`end`