gitlab-org--gitlab-foss/spec/controllers/groups/boards_controller_spec.rb

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

188 lines
5.9 KiB
Ruby
Raw Normal View History

# frozen_string_literal: true
2018-02-19 14:06:16 -05:00
require 'spec_helper'
RSpec.describe Groups::BoardsController do
2018-02-19 14:06:16 -05:00
let(:group) { create(:group) }
let(:user) { create(:user) }
2018-02-19 14:06:16 -05:00
before do
group.add_maintainer(user)
2018-02-19 14:06:16 -05:00
sign_in(user)
end
describe 'GET index' do
it 'creates a new board when group does not have one' do
expect { list_boards }.to change(group.boards, :count).by(1)
end
context 'when format is HTML' do
it 'renders template' do
list_boards
expect(response).to render_template :index
expect(response.media_type).to eq 'text/html'
2018-02-19 14:06:16 -05:00
end
context 'with unauthorized user' do
before do
expect(Ability).to receive(:allowed?).with(user, :log_in, :global).and_call_original
2018-02-19 14:06:16 -05:00
allow(Ability).to receive(:allowed?).with(user, :read_cross_project, :global).and_return(true)
allow(Ability).to receive(:allowed?).with(user, :read_group, group).and_return(true)
allow(Ability).to receive(:allowed?).with(user, :read_issue_board, group).and_return(false)
2018-02-19 14:06:16 -05:00
end
it 'returns a not found 404 response' do
list_boards
expect(response).to have_gitlab_http_status(:not_found)
expect(response.media_type).to eq 'text/html'
2018-02-19 14:06:16 -05:00
end
end
context 'when user is signed out' do
let(:group) { create(:group, :public) }
it 'renders template' do
sign_out(user)
board = create(:board, group: group)
create(:board_group_recent_visit, group: board.group, board: board, user: user)
list_boards
expect(response).to render_template :index
expect(response.media_type).to eq 'text/html'
end
end
2018-02-19 14:06:16 -05:00
end
context 'when format is JSON' do
it 'return an array with one group board' do
create(:board, group: group)
expect(Boards::VisitsFinder).not_to receive(:new)
2018-02-19 14:06:16 -05:00
list_boards format: :json
expect(response).to match_response_schema('boards')
expect(json_response.length).to eq 1
2018-02-19 14:06:16 -05:00
end
context 'with unauthorized user' do
before do
expect(Ability).to receive(:allowed?).with(user, :log_in, :global).and_call_original
2018-02-19 14:06:16 -05:00
allow(Ability).to receive(:allowed?).with(user, :read_cross_project, :global).and_return(true)
allow(Ability).to receive(:allowed?).with(user, :read_group, group).and_return(true)
allow(Ability).to receive(:allowed?).with(user, :read_issue_board, group).and_return(false)
2018-02-19 14:06:16 -05:00
end
it 'returns a not found 404 response' do
list_boards format: :json
expect(response).to have_gitlab_http_status(:not_found)
expect(response.media_type).to eq 'application/json'
2018-02-19 14:06:16 -05:00
end
end
end
it_behaves_like 'disabled when using an external authorization service' do
subject { list_boards }
end
2018-02-19 14:06:16 -05:00
def list_boards(format: :html)
get :index, params: { group_id: group }, format: format
2018-02-19 14:06:16 -05:00
end
end
describe 'GET show' do
let!(:board) { create(:board, group: group) }
context 'when format is HTML' do
it 'renders template' do
expect { read_board board: board }.to change(BoardGroupRecentVisit, :count).by(1)
2018-02-19 14:06:16 -05:00
expect(response).to render_template :show
expect(response.media_type).to eq 'text/html'
2018-02-19 14:06:16 -05:00
end
context 'with unauthorized user' do
before do
expect(Ability).to receive(:allowed?).with(user, :log_in, :global).and_call_original
2018-02-19 14:06:16 -05:00
allow(Ability).to receive(:allowed?).with(user, :read_cross_project, :global).and_return(true)
allow(Ability).to receive(:allowed?).with(user, :read_group, group).and_return(true)
allow(Ability).to receive(:allowed?).with(user, :read_issue_board, group).and_return(false)
2018-02-19 14:06:16 -05:00
end
it 'returns a not found 404 response' do
read_board board: board
expect(response).to have_gitlab_http_status(:not_found)
expect(response.media_type).to eq 'text/html'
2018-02-19 14:06:16 -05:00
end
end
context 'when user is signed out' do
let(:group) { create(:group, :public) }
it 'does not save visit' do
sign_out(user)
expect { read_board board: board }.to change(BoardGroupRecentVisit, :count).by(0)
expect(response).to render_template :show
expect(response.media_type).to eq 'text/html'
end
end
2018-02-19 14:06:16 -05:00
end
context 'when format is JSON' do
it 'returns project board' do
expect(Boards::Visits::CreateService).not_to receive(:new)
2018-02-19 14:06:16 -05:00
read_board board: board, format: :json
expect(response).to match_response_schema('board')
end
context 'with unauthorized user' do
before do
expect(Ability).to receive(:allowed?).with(user, :log_in, :global).and_call_original
2018-02-19 14:06:16 -05:00
allow(Ability).to receive(:allowed?).with(user, :read_cross_project, :global).and_return(true)
allow(Ability).to receive(:allowed?).with(user, :read_group, group).and_return(true)
2018-02-19 14:06:16 -05:00
allow(Ability).to receive(:allowed?).with(user, :read_group, group).and_return(false)
end
it 'returns a not found 404 response' do
read_board board: board, format: :json
expect(response).to have_gitlab_http_status(:not_found)
expect(response.media_type).to eq 'application/json'
2018-02-19 14:06:16 -05:00
end
end
end
context 'when board does not belong to group' do
it 'returns a not found 404 response' do
another_board = create(:board)
read_board board: another_board
expect(response).to have_gitlab_http_status(:not_found)
2018-02-19 14:06:16 -05:00
end
end
it_behaves_like 'disabled when using an external authorization service' do
subject { read_board board: board }
end
2018-02-19 14:06:16 -05:00
def read_board(board:, format: :html)
get :show, params: {
group_id: group,
id: board.to_param
},
2018-02-19 14:06:16 -05:00
format: format
end
end
end