2013-02-11 08:32:29 -05:00
|
|
|
require "spec_helper"
|
|
|
|
|
|
|
|
describe IssuesHelper do
|
2013-02-19 08:21:59 -05:00
|
|
|
let(:project) { create :project }
|
|
|
|
let(:issue) { create :issue, project: project }
|
|
|
|
let(:ext_project) { create :redmine_project }
|
2013-02-11 08:32:29 -05:00
|
|
|
|
2015-02-12 10:48:53 -05:00
|
|
|
describe "url_for_project_issues" do
|
2015-01-26 18:59:40 -05:00
|
|
|
let(:project_url) { ext_project.external_issue_tracker.project_url }
|
2013-02-19 08:21:59 -05:00
|
|
|
let(:ext_expected) do
|
|
|
|
project_url.gsub(':project_id', ext_project.id.to_s)
|
|
|
|
.gsub(':issues_tracker_id', ext_project.issues_tracker_id.to_s)
|
|
|
|
end
|
2015-01-24 13:02:58 -05:00
|
|
|
let(:int_expected) { polymorphic_path([@project.namespace, project]) }
|
2013-02-19 08:21:59 -05:00
|
|
|
|
|
|
|
it "should return internal path if used internal tracker" do
|
|
|
|
@project = project
|
2015-02-12 13:17:35 -05:00
|
|
|
expect(url_for_project_issues).to match(int_expected)
|
2013-02-19 08:21:59 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
it "should return path to external tracker" do
|
|
|
|
@project = ext_project
|
|
|
|
|
2015-02-12 13:17:35 -05:00
|
|
|
expect(url_for_project_issues).to match(ext_expected)
|
2013-02-19 08:21:59 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
it "should return empty string if project nil" do
|
|
|
|
@project = nil
|
|
|
|
|
2015-02-12 13:17:35 -05:00
|
|
|
expect(url_for_project_issues).to eq ""
|
2013-02-19 08:21:59 -05:00
|
|
|
end
|
2013-10-17 04:42:39 -04:00
|
|
|
|
2016-04-21 11:13:14 -04:00
|
|
|
it 'returns an empty string if project_url is invalid' do
|
|
|
|
expect(project).to receive_message_chain('issues_tracker.project_url') { 'javascript:alert("foo");' }
|
|
|
|
|
|
|
|
expect(url_for_project_issues(project)).to eq ''
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns an empty string if project_path is invalid' do
|
|
|
|
expect(project).to receive_message_chain('issues_tracker.project_path') { 'javascript:alert("foo");' }
|
|
|
|
|
|
|
|
expect(url_for_project_issues(project, only_path: true)).to eq ''
|
|
|
|
end
|
|
|
|
|
2013-10-17 04:42:39 -04:00
|
|
|
describe "when external tracker was enabled and then config removed" do
|
|
|
|
before do
|
|
|
|
@project = ext_project
|
2015-02-12 13:17:35 -05:00
|
|
|
allow(Gitlab.config).to receive(:issues_tracker).and_return(nil)
|
2013-10-17 04:42:39 -04:00
|
|
|
end
|
|
|
|
|
2015-01-26 18:59:40 -05:00
|
|
|
it "should return path to external tracker" do
|
2015-02-12 13:17:35 -05:00
|
|
|
expect(url_for_project_issues).to match(ext_expected)
|
2013-10-17 04:42:39 -04:00
|
|
|
end
|
|
|
|
end
|
2013-02-19 08:21:59 -05:00
|
|
|
end
|
|
|
|
|
2015-02-12 10:48:53 -05:00
|
|
|
describe "url_for_issue" do
|
2015-01-26 18:59:40 -05:00
|
|
|
let(:issues_url) { ext_project.external_issue_tracker.issues_url}
|
2013-02-11 08:32:29 -05:00
|
|
|
let(:ext_expected) do
|
2015-01-26 18:59:40 -05:00
|
|
|
issues_url.gsub(':id', issue.iid.to_s)
|
2013-02-11 08:32:29 -05:00
|
|
|
.gsub(':project_id', ext_project.id.to_s)
|
|
|
|
.gsub(':issues_tracker_id', ext_project.issues_tracker_id.to_s)
|
|
|
|
end
|
2015-01-24 13:02:58 -05:00
|
|
|
let(:int_expected) { polymorphic_path([@project.namespace, project, issue]) }
|
2013-02-11 08:32:29 -05:00
|
|
|
|
|
|
|
it "should return internal path if used internal tracker" do
|
|
|
|
@project = project
|
2015-02-12 13:17:35 -05:00
|
|
|
expect(url_for_issue(issue.iid)).to match(int_expected)
|
2013-02-11 08:32:29 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
it "should return path to external tracker" do
|
|
|
|
@project = ext_project
|
|
|
|
|
2015-02-12 13:17:35 -05:00
|
|
|
expect(url_for_issue(issue.iid)).to match(ext_expected)
|
2013-02-11 08:32:29 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
it "should return empty string if project nil" do
|
|
|
|
@project = nil
|
|
|
|
|
2015-02-12 13:17:35 -05:00
|
|
|
expect(url_for_issue(issue.iid)).to eq ""
|
2013-02-11 08:32:29 -05:00
|
|
|
end
|
2013-10-17 04:42:39 -04:00
|
|
|
|
2016-04-21 11:13:14 -04:00
|
|
|
it 'returns an empty string if issue_url is invalid' do
|
|
|
|
expect(project).to receive_message_chain('issues_tracker.issue_url') { 'javascript:alert("foo");' }
|
|
|
|
|
|
|
|
expect(url_for_issue(issue.iid, project)).to eq ''
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns an empty string if issue_path is invalid' do
|
|
|
|
expect(project).to receive_message_chain('issues_tracker.issue_path') { 'javascript:alert("foo");' }
|
|
|
|
|
|
|
|
expect(url_for_issue(issue.iid, project, only_path: true)).to eq ''
|
|
|
|
end
|
|
|
|
|
2013-10-17 04:42:39 -04:00
|
|
|
describe "when external tracker was enabled and then config removed" do
|
|
|
|
before do
|
|
|
|
@project = ext_project
|
2015-02-12 13:17:35 -05:00
|
|
|
allow(Gitlab.config).to receive(:issues_tracker).and_return(nil)
|
2013-10-17 04:42:39 -04:00
|
|
|
end
|
|
|
|
|
2015-01-26 18:59:40 -05:00
|
|
|
it "should return external path" do
|
2015-02-12 13:17:35 -05:00
|
|
|
expect(url_for_issue(issue.iid)).to match(ext_expected)
|
2013-10-17 04:42:39 -04:00
|
|
|
end
|
|
|
|
end
|
2013-02-11 08:32:29 -05:00
|
|
|
end
|
2013-03-26 04:27:34 -04:00
|
|
|
|
2016-04-07 16:04:09 -04:00
|
|
|
describe 'url_for_new_issue' do
|
2015-01-26 18:59:40 -05:00
|
|
|
let(:issues_url) { ext_project.external_issue_tracker.new_issue_url }
|
2013-03-26 04:27:34 -04:00
|
|
|
let(:ext_expected) do
|
|
|
|
issues_url.gsub(':project_id', ext_project.id.to_s)
|
|
|
|
.gsub(':issues_tracker_id', ext_project.issues_tracker_id.to_s)
|
|
|
|
end
|
2015-01-24 13:02:58 -05:00
|
|
|
let(:int_expected) { new_namespace_project_issue_path(project.namespace, project) }
|
2013-03-26 04:27:34 -04:00
|
|
|
|
|
|
|
it "should return internal path if used internal tracker" do
|
|
|
|
@project = project
|
2015-02-12 13:17:35 -05:00
|
|
|
expect(url_for_new_issue).to match(int_expected)
|
2013-03-26 04:27:34 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it "should return path to external tracker" do
|
|
|
|
@project = ext_project
|
|
|
|
|
2015-02-12 13:17:35 -05:00
|
|
|
expect(url_for_new_issue).to match(ext_expected)
|
2013-03-26 04:27:34 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it "should return empty string if project nil" do
|
|
|
|
@project = nil
|
|
|
|
|
2015-02-12 13:17:35 -05:00
|
|
|
expect(url_for_new_issue).to eq ""
|
2013-03-26 04:27:34 -04:00
|
|
|
end
|
2013-10-17 04:42:39 -04:00
|
|
|
|
2016-04-21 11:13:14 -04:00
|
|
|
it 'returns an empty string if issue_url is invalid' do
|
|
|
|
expect(project).to receive_message_chain('issues_tracker.new_issue_url') { 'javascript:alert("foo");' }
|
|
|
|
|
|
|
|
expect(url_for_new_issue(project)).to eq ''
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns an empty string if issue_path is invalid' do
|
|
|
|
expect(project).to receive_message_chain('issues_tracker.new_issue_path') { 'javascript:alert("foo");' }
|
|
|
|
|
|
|
|
expect(url_for_new_issue(project, only_path: true)).to eq ''
|
|
|
|
end
|
|
|
|
|
2013-10-17 04:42:39 -04:00
|
|
|
describe "when external tracker was enabled and then config removed" do
|
|
|
|
before do
|
|
|
|
@project = ext_project
|
2015-02-12 13:17:35 -05:00
|
|
|
allow(Gitlab.config).to receive(:issues_tracker).and_return(nil)
|
2013-10-17 04:42:39 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it "should return internal path" do
|
2015-02-12 13:17:35 -05:00
|
|
|
expect(url_for_new_issue).to match(ext_expected)
|
2013-10-17 04:42:39 -04:00
|
|
|
end
|
|
|
|
end
|
2013-03-26 04:27:34 -04:00
|
|
|
end
|
|
|
|
|
2016-04-07 16:04:09 -04:00
|
|
|
describe "merge_requests_sentence" do
|
2015-10-13 03:41:46 -04:00
|
|
|
subject { merge_requests_sentence(merge_requests)}
|
|
|
|
let(:merge_requests) do
|
|
|
|
[ build(:merge_request, iid: 1), build(:merge_request, iid: 2),
|
|
|
|
build(:merge_request, iid: 3)]
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to eq("!1, !2, or !3") }
|
|
|
|
end
|
|
|
|
|
2016-04-07 16:04:09 -04:00
|
|
|
describe "note_active_class" do
|
2015-11-19 07:41:05 -05:00
|
|
|
before do
|
|
|
|
@note = create :note
|
|
|
|
@note1 = create :note
|
|
|
|
end
|
|
|
|
|
|
|
|
it "returns empty string for unauthenticated user" do
|
|
|
|
expect(note_active_class(Note.all, nil)).to eq("")
|
|
|
|
end
|
|
|
|
|
|
|
|
it "returns active string for author" do
|
|
|
|
expect(note_active_class(Note.all, @note.author)).to eq("active")
|
|
|
|
end
|
|
|
|
end
|
2015-12-25 05:08:53 -05:00
|
|
|
|
2016-04-07 16:04:09 -04:00
|
|
|
describe "awards_sort" do
|
2015-12-25 05:08:53 -05:00
|
|
|
it "sorts a hash so thumbsup and thumbsdown are always on top" do
|
2015-12-25 08:46:01 -05:00
|
|
|
data = { "thumbsdown" => "some value", "lifter" => "some value", "thumbsup" => "some value" }
|
2015-12-25 05:08:53 -05:00
|
|
|
expect(awards_sort(data).keys).to eq(["thumbsup", "thumbsdown", "lifter"])
|
|
|
|
end
|
|
|
|
end
|
2016-04-06 10:02:22 -04:00
|
|
|
|
2016-04-07 16:04:09 -04:00
|
|
|
describe "milestone_options" do
|
2016-04-06 10:02:22 -04:00
|
|
|
it "gets closed milestone from current issue" do
|
2016-04-07 16:04:09 -04:00
|
|
|
closed_milestone = create(:closed_milestone, project: project)
|
|
|
|
milestone1 = create(:milestone, project: project)
|
|
|
|
milestone2 = create(:milestone, project: project)
|
|
|
|
issue.update_attributes(milestone_id: closed_milestone.id)
|
|
|
|
|
2016-04-06 10:02:22 -04:00
|
|
|
options = milestone_options(issue)
|
2016-04-07 16:04:09 -04:00
|
|
|
|
2016-04-06 10:02:22 -04:00
|
|
|
expect(options).to have_selector('option[selected]', text: closed_milestone.title)
|
|
|
|
expect(options).to have_selector('option', text: milestone1.title)
|
|
|
|
expect(options).to have_selector('option', text: milestone2.title)
|
|
|
|
end
|
|
|
|
end
|
2013-02-11 08:32:29 -05:00
|
|
|
end
|