2016-10-05 10:41:32 -04:00
|
|
|
require 'spec_helper'
|
|
|
|
|
2017-07-10 10:24:02 -04:00
|
|
|
describe Users::ActivityService do
|
2018-07-12 07:21:08 -04:00
|
|
|
include ExclusiveLeaseHelpers
|
2016-11-25 11:10:25 -05:00
|
|
|
|
2018-07-12 07:21:08 -04:00
|
|
|
let(:user) { create(:user, last_activity_on: last_activity_on) }
|
2016-11-25 11:10:25 -05:00
|
|
|
|
2018-07-12 07:21:08 -04:00
|
|
|
subject { described_class.new(user, 'type') }
|
2016-10-05 10:41:32 -04:00
|
|
|
|
2017-07-10 23:35:47 -04:00
|
|
|
describe '#execute', :clean_gitlab_redis_shared_state do
|
2016-10-05 10:41:32 -04:00
|
|
|
context 'when last activity is nil' do
|
2018-07-12 07:21:08 -04:00
|
|
|
let(:last_activity_on) { nil }
|
2016-10-05 10:41:32 -04:00
|
|
|
|
2018-07-12 07:21:08 -04:00
|
|
|
it 'updates last_activity_on for the user' do
|
|
|
|
expect { subject.execute }
|
|
|
|
.to change(user, :last_activity_on).from(last_activity_on).to(Date.today)
|
2016-11-25 11:10:25 -05:00
|
|
|
end
|
2018-07-12 07:21:08 -04:00
|
|
|
end
|
2016-11-25 11:10:25 -05:00
|
|
|
|
2018-07-12 07:21:08 -04:00
|
|
|
context 'when last activity is in the past' do
|
|
|
|
let(:last_activity_on) { Date.today - 1.week }
|
2016-11-25 11:10:25 -05:00
|
|
|
|
2018-07-12 07:21:08 -04:00
|
|
|
it 'updates last_activity_on for the user' do
|
|
|
|
expect { subject.execute }
|
|
|
|
.to change(user, :last_activity_on)
|
|
|
|
.from(last_activity_on)
|
|
|
|
.to(Date.today)
|
2016-10-05 10:41:32 -04:00
|
|
|
end
|
2018-07-12 07:21:08 -04:00
|
|
|
end
|
2016-10-05 10:41:32 -04:00
|
|
|
|
2018-08-02 14:17:00 -04:00
|
|
|
context 'when a bad object is passed' do
|
|
|
|
let(:fake_object) { double(username: 'hello') }
|
|
|
|
|
|
|
|
it 'does not record activity' do
|
|
|
|
service = described_class.new(fake_object, 'pull')
|
|
|
|
|
|
|
|
expect(service).not_to receive(:record_activity)
|
|
|
|
|
|
|
|
service.execute
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-07-12 07:21:08 -04:00
|
|
|
context 'when last activity is today' do
|
|
|
|
let(:last_activity_on) { Date.today }
|
2016-10-05 10:41:32 -04:00
|
|
|
|
2018-07-12 07:21:08 -04:00
|
|
|
it 'does not update last_activity_on' do
|
|
|
|
expect { subject.execute }.not_to change(user, :last_activity_on)
|
2016-10-05 10:41:32 -04:00
|
|
|
end
|
|
|
|
end
|
2017-09-19 03:44:58 -04:00
|
|
|
|
|
|
|
context 'when in GitLab read-only instance' do
|
2018-07-12 07:21:08 -04:00
|
|
|
let(:last_activity_on) { nil }
|
|
|
|
|
2017-09-19 03:44:58 -04:00
|
|
|
before do
|
|
|
|
allow(Gitlab::Database).to receive(:read_only?).and_return(true)
|
|
|
|
end
|
|
|
|
|
2018-07-12 07:21:08 -04:00
|
|
|
it 'does not update last_activity_on' do
|
|
|
|
expect { subject.execute }.not_to change(user, :last_activity_on)
|
2017-09-19 03:44:58 -04:00
|
|
|
end
|
|
|
|
end
|
2017-03-07 13:34:43 -05:00
|
|
|
|
2018-07-12 07:21:08 -04:00
|
|
|
context 'when a lease could not be obtained' do
|
|
|
|
let(:last_activity_on) { nil }
|
|
|
|
|
|
|
|
it 'does not update last_activity_on' do
|
|
|
|
stub_exclusive_lease_taken("acitvity_service:#{user.id}", timeout: 1.minute.to_i)
|
|
|
|
|
|
|
|
expect { subject.execute }.not_to change(user, :last_activity_on)
|
|
|
|
end
|
|
|
|
end
|
2017-03-07 13:34:43 -05:00
|
|
|
end
|
2016-10-05 10:41:32 -04:00
|
|
|
end
|